From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 138C9C3ABC9 for ; Fri, 16 May 2025 14:08:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 744836B0186; Fri, 16 May 2025 10:08:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6F2826B0188; Fri, 16 May 2025 10:08:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5945D6B0189; Fri, 16 May 2025 10:08:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 3C5AD6B0186 for ; Fri, 16 May 2025 10:08:03 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id B842EBB2C4 for ; Fri, 16 May 2025 14:08:04 +0000 (UTC) X-FDA: 83448950088.09.A241CA4 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf14.hostedemail.com (Postfix) with ESMTP id 33463100015 for ; Fri, 16 May 2025 14:08:02 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cXJlWpHQ; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747404482; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Uq6KURHAsdiUcEMvv/uoqzWtUBzSDdD1xyqnhIAzcWM=; b=E78UqKwX3Qe/P+OA8mn1aVPwbhXvhdJuR9hlnOJ0hj2w8aoF/+Y2pUPgHoI5B+3WXqNEG3 ZgLb4fpkq7fwQVpHZYuQRoLlurCPwoPAFghs8KRSA2TlPSgPMnmZhQ+Ib32ALn6oY3CKxz BUwPiutfE0RWiVLp8ERawYS15bC6wz4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747404482; a=rsa-sha256; cv=none; b=lcTNppu9YPeC36YdGnht0sWjC9ucGYboCfjDe19A/GQw+94Sbz3BsC4l8F2hobWXK45cOl V9jBqnP4jqcVchHsZALDS2RXYsDG7yHu2oN8o7vwmNMr1x1Qm8kEQfpbjLz/5HVsRDjHO2 foWPQ0fWxpTWZxTQVHfCErZ8lmO4Nx8= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cXJlWpHQ; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747404481; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Uq6KURHAsdiUcEMvv/uoqzWtUBzSDdD1xyqnhIAzcWM=; b=cXJlWpHQD6bfkBoiCBPZgP0/hYZT37putnGQJI+/X7fB7qVWOOjwRBp1FJZSjZdmHqNQ9c /Pcm+PNO9B2mcrtN0VlgjzIdqgXSD8gVSauf4NrBEtWAP7LolIRbDUHObP7p6uJtr70lJv lKZRps1MxmYidML3ZDaNFGfvf2NKsbA= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-185-W3mrvtxzPiiVQYTGecRPpQ-1; Fri, 16 May 2025 10:08:00 -0400 X-MC-Unique: W3mrvtxzPiiVQYTGecRPpQ-1 X-Mimecast-MFC-AGG-ID: W3mrvtxzPiiVQYTGecRPpQ_1747404479 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-442f90418b0so8831265e9.2 for ; Fri, 16 May 2025 07:08:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747404479; x=1748009279; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=Uq6KURHAsdiUcEMvv/uoqzWtUBzSDdD1xyqnhIAzcWM=; b=oD7u3gTup3Tcy1F0JKoeySQsSMSbWPw7oVidWZnIXSOgSh8YdDnslrQNyxSzr9o1fH IsJoiVrnDb9kn2z7o/uysBxxrudFeyh4iTMfQYMQ1MCiHb62z/p4ni0V0TK3ux/ns5GW SLzhE+nhqsuNpS6uTVtNtREQQFBWB2XczpoJ2UxbxJ/Oz8fFTwL4vT9hIoE/w+s31OZx YQ4kWgOEHEOdw7lIfgKu1J7/h6N+cjCM66pwQ2i4czPRVFLFB7S2UKP7eMv1UpqOMUxk NIEKUDnb4p8gBjmZyjeiLDhu5BOFSoQ+vxDgTl/QRW5Q/ElzVV/bFDVCZ+vHCIqRWpxj iaDA== X-Forwarded-Encrypted: i=1; AJvYcCXYalf1X7V/UujVBd3ZppktxzFfKc7YlZQVscj/KgYNCI0yN/1rhDgnjXGU3HVrw6JIBTj5aQXIoA==@kvack.org X-Gm-Message-State: AOJu0YyzKinF1uvFXBaOkZYqC8hqDHpCyimHx7otjzndOPoM9Mab/+P8 EEHTEGICcolqTW3sKVU+zzhQfKLuexUxht4AZe/BvcthBFm3j2wmAHJgjMXvxhm5nl1g5s2gKtM OkMEUD55JUBM0MtCBcsCGABZBEsVetzyLJ7UH60ljm1mwxiPuP6mY X-Gm-Gg: ASbGncs+/w3Fn7PlnISD1RgjrlunYnatnFXQh2vjvmgAb18s2QKEyf1LtzkhGkVYLKZ SJuzrk0DswgoITuqLJ0Nmd6L+ooxJ+x7tDWMVPjbWWDK1E712CCKNdg5ld6A2bk5pex96dZ7e4t vm2U2h9L7Mn+PgX2Q/sHd+H2ghJJQvATAsx0EiOTYJTyVnXhYOVwKy2T4AmDdEZ6ocHJ5D3t9wI V7C3dlZziOI5SDrQK6uU+PoskLJ1Ewr2B8+M2jt6CENLwc0x9MhHVp8c68bRjyMXzVDM4HN+4x5 02ftffrRLdKoJ/5JuQJ8pOdS1UihI8pUbRqySjELqdPObFv/loM6sRejh4XcQ1grDoGmbSNZi0g 3nhprORd1GnFBB/jAz3k8tg5QSnZ8QaPvNf1lL+c= X-Received: by 2002:a05:600c:3f07:b0:43d:77c5:9c1a with SMTP id 5b1f17b1804b1-442fd60b516mr39862115e9.4.1747404479445; Fri, 16 May 2025 07:07:59 -0700 (PDT) X-Google-Smtp-Source: AGHT+IErUF+kUAa2DUbbfcj03racps/O2R2c/jJuyRwdI2xUqjpHejuSvMBsI2MJ8NaMr9Z5ueg8yA== X-Received: by 2002:a05:600c:3f07:b0:43d:77c5:9c1a with SMTP id 5b1f17b1804b1-442fd60b516mr39861295e9.4.1747404479012; Fri, 16 May 2025 07:07:59 -0700 (PDT) Received: from ?IPV6:2003:d8:2f47:4700:e6f9:f453:9ece:7602? (p200300d82f474700e6f9f4539ece7602.dip0.t-ipconnect.de. [2003:d8:2f47:4700:e6f9:f453:9ece:7602]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-442f39e851bsm111513665e9.28.2025.05.16.07.07.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 May 2025 07:07:57 -0700 (PDT) Message-ID: Date: Fri, 16 May 2025 16:07:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/3] s390/uv: don't return 0 from make_hva_secure() if the operation was not successful To: linux-kernel@vger.kernel.org Cc: linux-s390@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, Christian Borntraeger , Janosch Frank , Claudio Imbrenda , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Sven Schnelle , Thomas Huth , Matthew Wilcox , Zi Yan , Sebastian Mitterle , stable@vger.kernel.org References: <20250516123946.1648026-1-david@redhat.com> <20250516123946.1648026-2-david@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250516123946.1648026-2-david@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Q2y4XZOCjqDPpwBNJkslBIXPDEut79ZwjOCbsfwtKq0_1747404479 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: p9ceukeapubexgu4dam86bduncnpegis X-Rspam-User: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 33463100015 X-HE-Tag: 1747404482-573149 X-HE-Meta: U2FsdGVkX19l9OW7xK0/RveM+eD7YRgl1j/x5LpDu8dm+XbOPQak0wHQGsCW0gWM/Hwyv1ZlTIZa6c2QsQatBp96goNT0oRP7vdvdZQYvN7SQrifODnUjwnTjX6fVO/hovAVHWYUfsWckQdp9C6uI3vxL3wQgywp9c+bJonBqdFI+kHURH1hs9g1J2Q1TG212K44LMD6vk5NJD0zUPf8YGLnSs8lSC5hqN12U9fYvsSCDHX8TTBFJm0PQliRHsWTB562tjyu+I+6Wx1lx9+rUWhQ9zVf4F38zyrTS9Edl4138SSx4nM7JnLzFVJr+B+MfAJNKXkJ2eeJRNBYxWk2cL8KHDN2cTqmjQHf3o6Wnb7MHDZIpv9jF+fvBu81+WXVhYldyEtf/k3StOnmmQbHLg9x+knVWHQHZJa1Fwj0xosJlRVChAKr2y6sEbqu4a53/1nQsrYZx9abdPPqfAJXT3R2DPPyLY5QjmxqNkyKCpHCVdTeSyhm7SnV5tvz67/H1kdoQzrfY9/Bkvpku+WD7PywtEcaLfT+9ZesdKeHN5A6V2TSTSE6HLnYIkc5Gzs6SAmMUCvlZ+r6ml+2r2D1NIn4zptE5K3NTrY0qATk3lxXjHCPoheN7FhZO8Yxrnvqdxezj8450fwX4orQduegQlrSNQpSQQUihV4sCka9HdvJj7DyYhVmKxtzhWUFSWlgbdO4YZaeqYb6p05zICo9P5Ni2I2VgCOJ8BJIKCIE7ulmRKHYzLDxRRWdfpvB5NU7OH+u4CtuQS3O3K3t/ibNRSWT+pPWtsEBBj+Lt6unduwLfPmSi/KaEY3RdJSiNtUMUqWxLD4iFzwmh4m1pNQ81fIAXPMdWVjWYldkrDxUaf+99zqPJorc/G1fToKBKxXubXR+Z5JC8ylQHpd5n6p1m8ruEK+qgY52h1a6SDVgRhTiylWIun7tWuLMLOEoasm4yUgKtrFpdcqtl65L9GC 888HVecg nZ7cBRwS2P+FznR6HJyxITrbiJWaHs9e3tO0I1N3c+JFwM0khM1umyx6cOP0OyzSUBXp4tjP3kLfsqeUCnEYe87QnCJXqyJB4Pf4ttNgxiVrDqV8zRYyDS88QWYIHUpDcQGA1TOGhSLn8B3IkBJRNhi7qYNk6/tN5Ay2KLDnK7tElscPOUE+35h9Oh02MmKKh/SK9FV5aWVjYuLZWCXmzBNyBbH6BNZ5FiNFrETcA7tywwp/eVzkTZBFZXBwa1aueiPVbmu3p0uxUng3beuyEXPu5oGZu1SC6wOdcl+U63HHqRM7ywkMc6Ht/s9lVEIki0fPb3A+Chp01f4BG0mITDPbpHPgLuwGRcUaT+dei1IpdWhU/un50x0xlwBCKlyKHRFE84gczCJnYJQh9bQPCaemOWUsPoixrjLDmcCC74aHKbI5Z713NDdAMqMgAbNpHra1DS7z4t/zmanleVq9yJdV2VcoB1v02dmBe X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 16.05.25 14:39, David Hildenbrand wrote: > If s390_wiggle_split_folio() returns 0 because splitting a large folio > succeeded, we will return 0 from make_hva_secure() even though a retry > is required. Return -EAGAIN in that case. > > Otherwise, we'll return 0 from gmap_make_secure(), and consequently from > unpack_one(). In kvm_s390_pv_unpack(), we assume that unpacking > succeeded and skip unpacking this page. Later on, we run into issues > and fail booting the VM. > > So far, this issue was only observed with follow-up patches where we > split large pagecache XFS folios. Maybe it can also be triggered with > shmem? Yes! I can reproduce it when allocating pages outside of the qemu process. $ echo force > /sys/kernel/mm/transparent_hugepage/shmem_enabled $ rm /dev/shm/vm-ram $ fallocate -l 4G /dev/shm/vm-ram $ /usr/libexec/qemu-kvm ... -object memory-backend-file,id=mem0,size=4g,share=on,mem-path=/dev/shm/vm-ram -M memory-backend=mem0 LOADPARM=[ ] Using virtio-blk. Using SCSI scheme. ......................................................................................................................... qemu-kvm: KVM PV command 4 (KVM_PV_VERIFY) failed: header rc 102 rrc 1a IOCTL rc: -22 Protected boot has failed: 0xa02 Guest crashed on cpu 0: disabled-wait PSW: 0x0002000080000000 0x0000000000004608 -- Cheers, David / dhildenb