From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9D14C25B77 for ; Wed, 22 May 2024 07:54:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 71F2F6B00A3; Wed, 22 May 2024 03:54:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6CF736B00A4; Wed, 22 May 2024 03:54:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 596E56B00A5; Wed, 22 May 2024 03:54:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 3AE426B00A3 for ; Wed, 22 May 2024 03:54:09 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id DF071A2D86 for ; Wed, 22 May 2024 07:54:08 +0000 (UTC) X-FDA: 82145268576.27.8B806E7 Received: from out30-101.freemail.mail.aliyun.com (out30-101.freemail.mail.aliyun.com [115.124.30.101]) by imf14.hostedemail.com (Postfix) with ESMTP id 1704C100010 for ; Wed, 22 May 2024 07:54:05 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=CSSJhg07; spf=pass (imf14.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.101 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716364447; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BTRCthf3MwxjqRJvuhMBtVbgzw2jNBN2hGAw2Hd/zn4=; b=u75v6gsvH6oWMp8w4o5Sq9Hziix7DKU9yuT9PF+Y+eKl2HYrMLMQ7kBNWfqAP+0A3Zoj4u A+AM1Y2ntR+a9c493SEL8jWwHxkm/4LcVvgNPvsEbY6omQGNjJDmAvn3ErDhIU5ahR3QF4 XcrtgiCUDkzaLwcBloezAA78TbQs1GY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716364447; a=rsa-sha256; cv=none; b=VB3DKwb4wFePvZad7o6rVrgLc3yUGm4AuCfhjC4mA5p911Dc9JPOXINBJrBsISbSyb6ve4 A/OI+Q3PNMPSxJHYKFuK70UAUnsRU++ywUfaNBSX5alFTPGRtWmsPbkJt1sgCHzYxqMBkL LzbFF1b4kP26y4+/CIzuBbuuYb5KKqQ= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=CSSJhg07; spf=pass (imf14.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.101 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1716364442; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=BTRCthf3MwxjqRJvuhMBtVbgzw2jNBN2hGAw2Hd/zn4=; b=CSSJhg07//Q1RWk/buMSESJ3+P41btkyH+ulWlFb6aitpF4EO3xaGx7gany+6N8Y9/Q9FzdqRxkI5GOQqhLEtgnJbvLnF4Ky3fAyspobTlaSsSpsMHdflBMaYkWm5RimUwtYrg0z9ROmarGXfhpJDdDWmjSyvthyYyuBs1gSIK8= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R211e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=maildocker-contentspam033037067113;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=16;SR=0;TI=SMTPD_---0W7-a1va_1716364440; Received: from 30.97.56.54(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0W7-a1va_1716364440) by smtp.aliyun-inc.com; Wed, 22 May 2024 15:54:01 +0800 Message-ID: Date: Wed, 22 May 2024 15:54:00 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 1/8] mm: fix shmem swapout statistic To: "Huang, Ying" Cc: akpm@linux-foundation.org, hughd@google.com, willy@infradead.org, david@redhat.com, ioworker0@gmail.com, hrisl@kernel.org, p.raghav@samsung.com, da.gomez@samsung.com, wangkefeng.wang@huawei.com, 21cnbao@gmail.com, ryan.roberts@arm.com, shy828301@gmail.com, ziy@nvidia.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <87le42b9l6.fsf@yhuang6-desk2.ccr.corp.intel.com> From: Baolin Wang In-Reply-To: <87le42b9l6.fsf@yhuang6-desk2.ccr.corp.intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: 74b77s6chhagzimc377ifdi4c545mabk X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 1704C100010 X-HE-Tag: 1716364445-543179 X-HE-Meta: U2FsdGVkX1922ixwnZrYxpYfZO5B9iXo7fUNuPEDaaQdfb5cxV4sd2LRS1e5D2dm0f7/UQ9V+NqeJyiLjxKJlfusLTcQ0Cb37RSpUx+RsS53X9jbolYQQZesi3iNqr2Ufa15XksWlvtxgMWZUF++z4D2UIUn4guiiyug6mZJ0UN1xU+bwNzZG9v5Ebml9V1SePvenkLnkBFnILkYMkVXe9Bvg6UwNA6tYsI+EoRsium28xuPQidj3tvTcLmB2XSRcDrWV5t7NlWgayiGwXBwZLYVOub/g7POyeBTfF0H+G0RPx/9CvkzjzGovzEBuIqNzX5qyJ8k7IWGqsqzSQuJZ9ym4MI8vXdWM7BVab4D+8732U4lRIsNDqYi7ZbluIhHIScC/kicaaoCpZRiC9H8YbYrSoL6ksiNzJKvdHFQxpkLhGKQPj8XO9qY/XgedM05Ucv5XBxLZO1xjiKxguKaf4EkM8ZhyMjocoZdqIFuYN0GK6/fjrr837zJz5ligMrBab+jQMCzzG2uUWYTywo9Gg1u6l/pEfHbuM0iCIMcxJFo5x/sdaP9rfnYAf0dqOo3WBP0qrQWcQGg15v7QhlBFsHiw7kRIrIzyymg3gT7MmhS99nTFbpudhn/Iq3GM5qH6D+P0e/afWIIjqURka5Fy6c8/56+kd3SmT/66NPCd9HDbLf5O0WcgFahnIZt2Lx28epNRU/Erz+b+0Lm03V0QMpf60YQZQAPUxXTXQrWfg3ngoQReCVnIZjqx7WBxK9SP0cvj15y2dOHQtUWdPtwciO4Qy4s6WOJPvpUpkycSOX9Oo8rjG/5GFlJk85nT//iHW/cxv/ArpakDJLGhpZ51ZeZmdEl1hJHXS79nVvEij9htADt/WyHBMzz6RGA9ItAA8IqkKtW3x6Hrb5TALcIH6DNWeCt9wIG X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/5/22 15:16, Huang, Ying wrote: > Baolin Wang writes: > >> As we know, shmem not only supports the sharing of anonymous pages, but also >> the RAM-based temporary filesystem. Therefore, shmem swapouts should not be >> marked as anonymous swapout statistics. Fix it by adding folio_test_anon(). >> >> Fixes: d0f048ac39f6 ("mm: add per-order mTHP anon_swpout and anon_swpout_fallback counters") >> Signed-off-by: Baolin Wang >> --- >> mm/page_io.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/mm/page_io.c b/mm/page_io.c >> index 46c603dddf04..b181b81f39e3 100644 >> --- a/mm/page_io.c >> +++ b/mm/page_io.c >> @@ -217,7 +217,9 @@ static inline void count_swpout_vm_event(struct folio *folio) >> count_memcg_folio_events(folio, THP_SWPOUT, 1); >> count_vm_event(THP_SWPOUT); >> } >> - count_mthp_stat(folio_order(folio), MTHP_STAT_ANON_SWPOUT); >> + >> + if (folio_test_anon(folio)) >> + count_mthp_stat(folio_order(folio), MTHP_STAT_ANON_SWPOUT); > > Do we need to distinguish anonymous swapout and non-anonymous swapout? > IMHO, we don't. Just like we have done for small folio and THP. Yes, old counters did not add 'anon_' prefix. > If so, how about fix this in another direction? That is, remove "ANON" > from mTHP swapout statistics? This sounds good to me. And I will separate out an individual patch with your suggestion. Thanks.