From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E923EE77188 for ; Mon, 6 Jan 2025 03:53:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 62BF96B0082; Sun, 5 Jan 2025 22:53:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5B5196B0088; Sun, 5 Jan 2025 22:53:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 42F536B0089; Sun, 5 Jan 2025 22:53:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 24D7E6B0082 for ; Sun, 5 Jan 2025 22:53:54 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id CE52545342 for ; Mon, 6 Jan 2025 03:53:53 +0000 (UTC) X-FDA: 82975658346.18.87E595D Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) by imf03.hostedemail.com (Postfix) with ESMTP id CF39620008 for ; Mon, 6 Jan 2025 03:53:51 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b="MQ/IIEWk"; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf03.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.216.43 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736135631; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/q466ctbH84kLf48L1cXJtHFTRzDl7be/n0cI3LGmOM=; b=c+BYEuy146ynst0MTXrsCGWhtIQhH51xA4aQR6nr9huQLeGYFRN5K09Y2r6xpvgyf9cToI GzybWbWzyexQlDzo/2BDtSgUzHm/B7kvRw7K6SGUFu4UVouZKiohr/p2htRLr6ihrHZJKx XsZy+8Q7tsUjFoepZIj9YkYLZp9h+gU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736135631; a=rsa-sha256; cv=none; b=pxy7bgjWv+/Akp+PN1kRF115N5dUbEtQlBfyC6kq0rh58tFE7T51Mn7ha1awJ9cN7q1r4I +t2bxjppI9y1uItN5qD9rmRr4wboy68T2SfBUjZv/ZL+fT74GzVrlOc231sqJFcAHFaXKi mzoZjpsHPdCNeWkfD6E82WXerem1Y9g= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b="MQ/IIEWk"; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf03.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.216.43 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com Received: by mail-pj1-f43.google.com with SMTP id 98e67ed59e1d1-2f43d17b0e3so20375866a91.0 for ; Sun, 05 Jan 2025 19:53:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1736135630; x=1736740430; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/q466ctbH84kLf48L1cXJtHFTRzDl7be/n0cI3LGmOM=; b=MQ/IIEWkDDTdoJC/9zx5rlKEc6UxKb8Qxa06Pp++7uYFqONBTVNqiMdZ5SEISXz/A7 s1yijCkX0SoFH74EFtAekcDjkca0fX+jfhRfdgsNZnR1QlOIG2nAgk7XLb0Bl27q6fpo Iav0QIPapT/mehRC1IFGMP9XY3j+pyW6lmux5y/ZO4HG8057x4gpf+zVC+uXXL6+YmF2 Uuf3l/Yy956JaTmeyWHqXmwvu+On05w8uJpq3XW89HFKtBmL92G8/2DQFanuOutjY75d zxUvlaEm3FI8uLBR/tcU2Tejun8V1LILauFxgAVhFJoR5tt1NhNv9VgIw0sq/UQRbAuT /TTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736135630; x=1736740430; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/q466ctbH84kLf48L1cXJtHFTRzDl7be/n0cI3LGmOM=; b=GMiAkL5c8TJnMA8tSek7rU/FAbXDbtzJu3xE++wsISSmHvFO24FZKo0bHRgHMFK1Nj 0REMElu6jR35AtmOMhON41rIDM+sm/zN2FOLpjfhskobFK1CRB+lfcQmdFNWmC8bUpWL GzJXWRUveHnP0epMomMTmyvbGoSO6ADRx9SeSkEOL7tgeTzRfPPAQ7uLzDFkNj0QvJ5h dzAJZo/WZXCw8orqfpdx7CA5YgRs6N0oNMu3gmCDM+7EoNqmDcqJZJrEbM7qIOY0SzSF HINZ1l6YVIDG3AI/n/Me0af4xx0jDAP7cnaljggratgp7r4VaswzIxQ8K3MMQ+aTetyj 7gCw== X-Forwarded-Encrypted: i=1; AJvYcCWdNiXaQogRNcA+ARYrEca/TW1pV3AYUTvYWQ+hbEXkENx3Wg5PaETVPz3iNKPRrZqgt17mtuhXJg==@kvack.org X-Gm-Message-State: AOJu0YyEerEuhpGwOs97PuvpukcvVwB9Qut0qNVow9J3AeaK55/hcy4j bP3JzFidV9Y3qdJDjmc8JM+nFSwQJGpfmkHckM8eX152JxYYiaXXeES2ehK3zPs= X-Gm-Gg: ASbGnct8eev864SWH6BtEwIoXW+85cBx3U0XBbZ0IKn+jsDhMEoTeaR+Srmdcs/8cjh H22/B0oEAOMlPeEHtBO2E0kjvZGxg8rADicbeL1SNS0hrw4Pjr85oh5+oi6JlXckQsqmeZUaYxz blCckBiFQHRbkG2/xerw+HiJZf6IF06GBByk22a+okULLjoc4nrRtnzzT16r/d5xMQoFrycIikD T6bcqGT8y0a2P9WBgODM5sfs+NXMo+82h3jyf4Uhv/sEBFh5XUDskk+B8W65c/A1K0joXzbF+PK x8qb1Q== X-Google-Smtp-Source: AGHT+IE2eKUVGb+J7TSGZASTVnkByt6mt8YLIy++PUNY+VFfsnF7zlybMe8WL3Umwm8kwi4ry/BkkA== X-Received: by 2002:a17:90b:54c3:b0:2ee:a127:ba8b with SMTP id 98e67ed59e1d1-2f452ee83d9mr71788615a91.36.1736135630440; Sun, 05 Jan 2025 19:53:50 -0800 (PST) Received: from [10.84.148.23] ([203.208.167.150]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-219dca02f72sm283551435ad.249.2025.01.05.19.53.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 05 Jan 2025 19:53:49 -0800 (PST) Message-ID: Date: Mon, 6 Jan 2025 11:53:36 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 15/17] mm: pgtable: remove tlb_remove_page_ptdesc() Content-Language: en-US To: Peter Zijlstra , Mike Rapoport Cc: agordeev@linux.ibm.com, kevin.brodsky@arm.com, tglx@linutronix.de, david@redhat.com, jannh@google.com, hughd@google.com, yuzhao@google.com, willy@infradead.org, muchun.song@linux.dev, vbabka@kernel.org, lorenzo.stoakes@oracle.com, akpm@linux-foundation.org, rientjes@google.com, vishal.moola@gmail.com, arnd@arndb.de, will@kernel.org, aneesh.kumar@kernel.org, npiggin@gmail.com, dave.hansen@linux.intel.com, ryan.roberts@arm.com, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org, linux-arch@vger.kernel.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-sh@vger.kernel.org, linux-um@lists.infradead.org References: <20250103111457.GC22934@noisy.programming.kicks-ass.net> From: Qi Zheng In-Reply-To: <20250103111457.GC22934@noisy.programming.kicks-ass.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: njtnheysgyum6pdotgaoa6j4rq5gyprc X-Rspamd-Queue-Id: CF39620008 X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1736135631-693775 X-HE-Meta: U2FsdGVkX1+LM5X82AajR0nnqD7aRIynsoMZzvU5M8fejnFGh+WxkSchG8VuivqKuhtoHKjg7nfa4kLJJmcwVOqugIIwNgyXqWNMiWHps8oYh6Yh+/R+nRljp7taKfa29w/uM/Cky9StlR08lpMu09v8/0vsCH1488MgtkZ1NJFvUA+JihhOw+ilG17727dMS3WMrvY+NIZSK8lg5kRV7TriPJaZWHNLxD5sP0RjC+VA77Ws3Oj5xmTEF2rx912lgds1c3xNh9rk4P1t/eOKm0Eg8szxw1zjrEzkPjnhtTwxvD4/5yHzav/JyHMDDXuugQtZ9AuhNP7HILtLEdzFC5r+wSz6GBFH+iyK3NXIInRXAVOzu3CiU7tl/dwsWq52N8MJLbdUYO4OKpogLfMOkkooQfvvgqwLagwE2dfFVMBZHIAwAbCEppJTtJe1kKbImNamr+gjpKsobiYPeRq6E3SMDUhUs0HP6M0US5bwPzZfzrjEqYZK2UzEscmD2j1/65Xr/N/TMu236jvlgqIxQz/PGlTTYjEhhV+Yd46/Ny6dwRYEYGduWs0hMk3XlIRb81NiYeqoxqXkAkfLLXmbGhoNrm0erJ5nlCf+gmEcbgPCS6Pi71TMbausCtOhmj7h4+3So+eqnf4hk2DCqg1oRhRLtkV6MMUs4rIydtvx23e6UJfCm1UuHLxTotjESpBsHZPSlAbo0DQrg4WtudvauF7clL0C93XGWh10hSY7vCBasdBD49VQ7LsVNyhTf0RWM72cZcyxA0yzscL1DbtUS73BuhuRE9QRS7CM/wFnFI8vty/r09rUfdmZD0tYhp4w8bF4vktdk8ItH0L7jH7mNJrOO1IAyqNzGlL04JxfVZ1jvbjnIfEbnOxg7j9UInvzJBVCRk1rP6T8a/PoF+eMbyuJaUAsaMMXhE/7pHx1sgzRSTPxuWIuXn23uRd1RfGJ18EINMIX309BkX13NlK w0+cv1mC KfDKgwTumkLPB4hC9vdG5nwAnDrqrPjLjAIXXbL21OiLItAZtr9eiH2KQEYJDiCmmsTQHWSg3jfB7OVAD3rN2qOTQZAFchQfOCLFuWmilbDEgVjv0tgbKc20ExMWr9SOvl2N/oSzhWZBpe2CKzmQ901xRG/7As3bfc1bCDgUUslCQeIFSi3WxxyeqQDLloHP7b9Y+EydP42j3Z0OKu8iLTogcq4+YQPICh+07h3jTj4/iXj4EhIoS2FaEX2ueqArQPrTD3N3Ry6ZG93TVRfTsgJg5GePiXtTsRAAGR3U0AeS6OzbWNd9V/iMn9mLtCr9CZ+Kqe1O1q4BFWRLecl6t3gu7nsiRVnO7x/aj6Fl5sQI/aBZOM0ffP4GVUGbDKNF8WlzR2nuwLi3TaHpWmcMJps362PF7EgyJzmfoUjhnaGzHPtAq5mF3bXcang9iNRu5ilMSnrjD0dRvROE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/1/3 19:14, Peter Zijlstra wrote: > On Sat, Dec 28, 2024 at 11:26:22AM +0200, Mike Rapoport wrote: >> On Mon, Dec 23, 2024 at 05:41:01PM +0800, Qi Zheng wrote: >>> Here we are explicitly dealing with struct page, and the following logic >>> semms strange: >>> >>> tlb_remove_page_ptdesc((tlb), (page_ptdesc(pte))); >>> >>> tlb_remove_page_ptdesc >>> --> tlb_remove_page(tlb, ptdesc_page(pt)); >>> >>> So remove tlb_remove_page_ptdesc() and make callers call tlb_remove_page() >>> directly. >> >> Please don't. The ptdesc wrappers are there as a part of reducing the size >> of struct page project [1]. >> >> For now struct ptdesc overlaps struct page, but the goal is to have them >> separate and always operate on struct ptdesc when working with page tables. > > I don't see how the current idiotic code helps with that at all. > > Fundamentally tlb_remove_page() is about removing *pages* as from a PTE, > there should not be a page-table anywhere near here *ever*. > > Yes, some architectures use tlb_remove_page() for page-tables too, but > that is more or less an implementation detail that can be fixed. > > So no, please keep these patches and kill this utterly idiotic code. > > The only thing that should eventually care about page-tables is > tlb_remove_table(), and that takes a 'void *' and is expected to match > whatever __tlb_remove_table() does. > > Flipping those to pgdesc, once its actually a thing, should be fairly > straight forward. Well, since I've already sent v4, and that patch series is mainly for bug fix, I'll send a separate patch series to do this. Thanks!