From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1FF8C369B2 for ; Thu, 17 Apr 2025 12:56:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 14C1D2800C8; Thu, 17 Apr 2025 08:56:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0FC592800C6; Thu, 17 Apr 2025 08:56:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EB78B2800C8; Thu, 17 Apr 2025 08:56:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id CE1B32800C6 for ; Thu, 17 Apr 2025 08:56:21 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id B017C12128B for ; Thu, 17 Apr 2025 12:56:22 +0000 (UTC) X-FDA: 83343534204.21.0A929C5 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf24.hostedemail.com (Postfix) with ESMTP id 68C05180003 for ; Thu, 17 Apr 2025 12:56:20 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FYkwNNSN; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744894580; a=rsa-sha256; cv=none; b=JnOlGcki26/xFqdAALkoyaMJJSp5oVG3W5kImsYY8bgrT/r4Znz7rSfZwj1PzGbVvf6Mj+ u5z1KrDoOgOF0u+H7TtWuNTMKVdiw6zgwohgvMhDG0nSU5oUeNspOgxgBM70h9RV5Z570z Kl3b2m/TDvXYEO0yQ0jsGZOrOKrMIIo= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FYkwNNSN; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744894580; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PP6r3Tc0odzOLdnN1Mh6zo2XTeq4+ZCWbhdNqWqpYfQ=; b=XkC3AHzLMHbuMmOXyDlydPVXxmwNEBCjHExBskwSJvSFE8gu1hjIwOsQljAivwujzcZtCJ 5OmgTtQPcYDSaBMD3F6AalwWdReUQWZmQJgE9WDzAkzsY7nDsLzdy53dOIsfXd4KuE1Z7r 3M/7Rhnh1y/R899JayoVbuC2IDaMFJ4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744894579; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=PP6r3Tc0odzOLdnN1Mh6zo2XTeq4+ZCWbhdNqWqpYfQ=; b=FYkwNNSNtzi+5e0vLvm9/TdPSW2VgHNIuK0mENX5YF1ZGfRhIm2irXA5ghkoPyNROSq9J4 KkGpG7oIouCQvae1nGRjB39qQp/6Lbb1qg8yFLhGaB+xbD8M+CgagjD87S/ez/wdomKsEE wugTEBuEYQR2suAyCVjGpHexmXnkNcY= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-211-Sh_la70mNEyE8-pwmdxYRQ-1; Thu, 17 Apr 2025 08:56:18 -0400 X-MC-Unique: Sh_la70mNEyE8-pwmdxYRQ-1 X-Mimecast-MFC-AGG-ID: Sh_la70mNEyE8-pwmdxYRQ_1744894577 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-39131851046so278480f8f.0 for ; Thu, 17 Apr 2025 05:56:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744894577; x=1745499377; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PP6r3Tc0odzOLdnN1Mh6zo2XTeq4+ZCWbhdNqWqpYfQ=; b=e/RHrawCNZIFqvk6V7Zth92KmR5GRtKnYJM0rzrt10httvh05L0pa6S0g+XqBlAqeR TVk3c9lgaSFeRc+zE/fmv/I40JTkXS7ZBJMAGeyZgkj1vow8MAz4Zly7NdNuMDl9eHJE 8ItGEr7thuiZfC/vdXtoTqrsikIITC+ZdbWqZG7gSmxwOcWjaBPL1WTUqvXfpIEpOtyn 6X5wGzMkcr05UP6P2Su/JB/ZnLqssXzaS0C1y4NN2i9Ulcvw5vRn7D9FLJUtPX5XpJ/N shuTZrLVvF1t2Zc7EWR7YFXtSnn24EcoXjcoOtRsDmPdyS8BSajqmWKKs4AOTIYyv/9A dfFg== X-Gm-Message-State: AOJu0YyL23XxlMKc4pI4zMz1n26XWCaBGgxGQkQnd4gc1dMh6JD5dqCi 8oYuXRxmOH0jodOq0NBnh5Q3jJCICft0JoiehlNrh/kdt4gnfjJDJBDWna7KjRc/9m6bnvz9aYD CV48mInRCgjKj8Vr0RuWbAN6Q1Qd80zTn7DfZyJwXn8ODIgK8 X-Gm-Gg: ASbGnctOefV1X0OcwGjaDy2PUOL2NFAHtTXNBMqNI7KxjZMImrDRtQe/k6DhZg9t/ny 8iMvl+fV06CAB75BZHfDrtNgGePSWVG16QXRs23d6osvri630MQ9MW3swluaLy9+26mmDwLcqTX UZSwmmX0cWnhuuwWyCzm+Fl8yg2yhye2xPYvh73e2V2pzlNK+7/AGym8Sg+GmdqH3MFn6AyHNdO lvIaFUScez64VAtYhGvgVM1piFO6yFS64gJQRFNx3feGy9NowQVHUO5YGwJo9A0ZCu+722O4V64 9P2CMBsbuGQl2fCe5ir1hwCylEOApXWQq4UHDbp783UF0NOyUd0SFbvNcppdLmGereSw89tXHPi AJb+a6x6lDeHWoyzQg00ieODWehjbevAY7Vi+L7w= X-Received: by 2002:a05:6000:22ca:b0:391:4999:778b with SMTP id ffacd0b85a97d-39ee5b37b2dmr5018838f8f.28.1744894577322; Thu, 17 Apr 2025 05:56:17 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFhcDh+lOBj95mWyR4xq7n9fZ9ItU2YUKtea/qun2d7Jab+8iRIylTGcc/lV2a/wDdAT6UsCA== X-Received: by 2002:a05:6000:22ca:b0:391:4999:778b with SMTP id ffacd0b85a97d-39ee5b37b2dmr5018824f8f.28.1744894577007; Thu, 17 Apr 2025 05:56:17 -0700 (PDT) Received: from ?IPV6:2003:cb:c706:2700:abf9:4eac:588c:adab? (p200300cbc7062700abf94eac588cadab.dip0.t-ipconnect.de. [2003:cb:c706:2700:abf9:4eac:588c:adab]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39eaf43ce30sm20586336f8f.62.2025.04.17.05.56.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Apr 2025 05:56:16 -0700 (PDT) Message-ID: Date: Thu, 17 Apr 2025 14:56:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/1] mm/rmap: add CONFIG_MM_ID guard for folio_test_large_maybe_mapped_shared() To: Lance Yang , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Mingzhe Yang References: <20250417124908.58543-1-ioworker0@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250417124908.58543-1-ioworker0@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: YXvt9PFwhm5mjVizWcPX_p20RUeS7F8cTgPiIo-mP-k_1744894577 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 68C05180003 X-Stat-Signature: 9memxyx66a75ef63heqgypgjg386rk3b X-Rspam-User: X-HE-Tag: 1744894580-200804 X-HE-Meta: U2FsdGVkX1+OE3KWomnkvl4TV8yxkD1C6KsXYPnmoS36Rw9DiiazoZXVPPZ/sMTeXKRgCVi+UNGQwKLnE9WKFo7JwBrsxJNC4x+s033V6IyJPsYLFVoB0uNubpF194Or3KcEbTV9nfKtG7xTg8p55YeuKxQ5EO7c9wsmmFriFtG1T+yzB36fXEF8+pOAoxOEO6KAJxSYYMpTgHbv2JizJooEQhj4wDo1uWzvfe3/UX8naE41k/9yD+pG23bkZ9XbbiFN3RjZXLJhBdEmOnoB86F5kwhB9b8X//3wC2K92vPWxURz/8LR0flS2SPFEjGaI5rjX1kUuzJoJEKxKkuIJmG2dwHEHqCtRwzXSRNJSluFDa5nSRAAXvExuoPva46GaDhW1cCLNFzujTRtACQPYws9Fb5G6547fSHNpLsSsusDGuwK6wgjBIDX0xhmicwH50QaSPH5TfKLsT68jf/0ktvEavluyjP2oH9lvDdjCfngog6zDgwaMMmgoIzdFPV7Jy/YecDNhU4KXA146oiXPl7gyu1WFC9WPsf72qfpuOl3EDueoKCTxtu1JFqMNgt+wVZpUy3Yf69YZSSj96OjLGj5C+wc54JzBzPOtesSoAF3PA6YDt+tCrOo8f+gziWVWkfUWJ2mibEkWVThOKFbPH3rSCFlNwHRMsMzZAhaCNOyukMwQ5hsrHxkR/QXyr9Ga4Yt25riv50ItMmET87cyhcOHTTDC0X5t1Gmf/efXRhnbA+Brboc1dDI9qKvDXHBU2/H2DbW5LO/RYaBejjmegSaj4XwJ4nu9fMNp3frk0Hb8mApPxMcEXD2zK++HKroBIjylcbbL5JTDFolgNQE+l6W9349Pd2mnUjQd2j73e6kMvEIWqVG+22WhuhlTGQXx/coGaYkUy/WqnLFv0xpA3nj4SRhQ7Wy5wXZc6+tNcQKx/V/ri1kGabzit9BFowxEPqIx/qevb2bis1Nni2 xpU6PPN+ 8sVdCv2L6r8Z8UkSGpQyfnES02qQuXftv7xjQtNpty5b3mgppM0HFu846UhS0YpCRTGE1mpu9sfmrKEFBnHLEC23Llex4YU/g69sFm0KGGLiMcANWmx6NfH8g6g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 17.04.25 14:49, Lance Yang wrote: > Add a compile-time check to make sure folio_test_large_maybe_mapped_shared() > is only used with CONFIG_MM_ID enabled, as it directly accesses the _mm_ids > field that only works under CONFIG_MM_ID. > > Suggested-by: David Hildenbrand > Signed-off-by: Mingzhe Yang ^ should that be here? > Signed-off-by: Lance Yang > --- > include/linux/page-flags.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h > index d3909cb1e576..6bd9b9043976 100644 > --- a/include/linux/page-flags.h > +++ b/include/linux/page-flags.h > @@ -1232,6 +1232,8 @@ static inline int folio_has_private(const struct folio *folio) > > static inline bool folio_test_large_maybe_mapped_shared(const struct folio *folio) > { > + /* This function should never be called without CONFIG_MM_ID enabled. */ > + BUILD_BUG_ON(!IS_ENABLED(CONFIG_MM_ID)); > return test_bit(FOLIO_MM_IDS_SHARED_BITNUM, &folio->_mm_ids); > } > #undef PF_ANY That should work. I can throw this into a cross-compile setup later if I get to it. Acked-by: David Hildenbrand -- Cheers, David / dhildenb