From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC265C5AD49 for ; Mon, 2 Jun 2025 19:58:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 70D996B0325; Mon, 2 Jun 2025 15:58:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6BF786B0326; Mon, 2 Jun 2025 15:58:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5860B6B0327; Mon, 2 Jun 2025 15:58:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 3A4236B0325 for ; Mon, 2 Jun 2025 15:58:39 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D774E81219 for ; Mon, 2 Jun 2025 19:58:38 +0000 (UTC) X-FDA: 83511523116.09.F3402B4 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf09.hostedemail.com (Postfix) with ESMTP id 71CA7140006 for ; Mon, 2 Jun 2025 19:58:36 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="AU/wmSlL"; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748894316; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yXwmfqOSMmu7gi2nZDdGi9t5LkJaG+o3VB1UCoHTcFQ=; b=gaPSgl3TRsf4jmQJ3whgJKj5w8SPSkEaCspmhw7qHPiKCzxn7RioIvOU6npS6ZfDiompeq WH6MOOWF8nfpEVL2yU9PEfxsk30+0wSclmPCCpAPdC2HC9PLvJqEGhIUS6m80fNAbHFYYb FqSSEANqvPBuqJt0cldwTM4ZSNas+Oo= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="AU/wmSlL"; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748894316; a=rsa-sha256; cv=none; b=R+XOYIdOZYQDYfPQEc52a9ph3KUfPlvyir7EHIXuzTMOeLsBxXVPVPaF/uA5uXZMIBekHK 1vB37upOd6N8R/2msxBi//sLUR7jjMkEXuN0oXA7CIRNpfaV7eDGgsxqAey/+PPwmrScX4 84/O4So4t6X5bSBunDspWENml7XI3qY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748894315; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=yXwmfqOSMmu7gi2nZDdGi9t5LkJaG+o3VB1UCoHTcFQ=; b=AU/wmSlLHpP7uaKntHA+pxBofEqfXwxfdutgUgwFlYt7RvztYbO1PlvIs5o7PwzAlNCoHn v3iYFEKR2NMgQKaNq87bgeIWdu/nOtEWt2fLM3ndBNf1EI93ZnP+Qqw6YQ6hplRwWPujKD hg9/P4KttAUajdBd9RyDWKoLDyo50Vg= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-690-0aOf7BnXPXKrruRw1tYzbg-1; Mon, 02 Jun 2025 15:58:32 -0400 X-MC-Unique: 0aOf7BnXPXKrruRw1tYzbg-1 X-Mimecast-MFC-AGG-ID: 0aOf7BnXPXKrruRw1tYzbg_1748894311 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3a4f85f31d9so1324305f8f.1 for ; Mon, 02 Jun 2025 12:58:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748894311; x=1749499111; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=yXwmfqOSMmu7gi2nZDdGi9t5LkJaG+o3VB1UCoHTcFQ=; b=ZIkHfTG8jwaBzGmReHJyFjxJt+0IFUPMmIN1fo5asCJCPtDQ0A3MYeha8JOeb4ex7x LBQ3qImUvK7+ipxc/DqisKLgCSYC0s8xiQiz+IhVqeBUk2inC3WmuGDzvUthNblMNRzG k33GWpQdMV104CKHuHqwd/C23rtjixMd/FN2+Jx0F2VD/KonFQH5s12sRqRoyEeLpJta DPk3rq11b7kF+TtMX6w9k4Wqhwqdp+ufYTEy1Fh7EDgSyaSUW7xHJg2IRrWrHfMSBelv XMnksVXhByl+u8BN4AD6ASdcZKf3X0pN/rlCR61FuNGdKFg7X10dKX0AgHBkBYIrNJE3 ECwQ== X-Forwarded-Encrypted: i=1; AJvYcCWeNptAccMJavsjd/JRH1t08LIE8x2GpRIdiDzoRFiJlMAl3rzFVjDrA9MUxD/QjS9oBOqs+Z9R8A==@kvack.org X-Gm-Message-State: AOJu0Yw/WbK9v1mg+Q6DhkF0oNtSrs5WktFDeAUcVe2vphGhHVIfmY7F G+kfek0RmnHhrG87L28Po4s4XRzueQgmqjSyzs8YS0T9sgdn4+MSlV21ZlPB6tri0WoQpyR2ERh GJHtcAzJGIf0TgPjaMUc5Kw359k9RE1xZjDAIFa9quVLohh01ecGx X-Gm-Gg: ASbGnctW5C6RbT3Beqb9360YnbXUMQxoE+IJZz4cxybdODmhksSCUbhWsTF9IEUZKZq wJdxGm1DUn+PHUFp301wYps52ShxEzGJue11umiaAsEP37S5FiDFQZ2VvyBV6NBlYY/o7cWn+Ly AyZQj+gCGrwKPXywgz0vxZIApHwvYklR8Fw0sPf2zArQMROGosSn9cCsw/Bh5M7zWwslhSGrEki zwaH2QCwDdWEkTli9rrafvyEybwn1lvlHutH8R3eWnkpsSYpxEilBUwgr6/l1ptfES+Pc6LjEHH WdjhpJKz8mvMpLnstIDo5holBvVCDLQgzKSJt81l2XViwcazHX6To/QbxLrpKURLPUaEjZkvgBF lb9Zc+NoQAjHUSk+xAqIlLqh08XDd9Rlgnby9/1c= X-Received: by 2002:a5d:5885:0:b0:3a4:d939:62fc with SMTP id ffacd0b85a97d-3a4f89bf4f1mr9961724f8f.22.1748894311482; Mon, 02 Jun 2025 12:58:31 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG+h18BWJl8oFL1SjCQZA3ubfO6tk99p1t6/++sfvt6gXNpNYL350EOirPnllvr8dya7g1b7w== X-Received: by 2002:a5d:5885:0:b0:3a4:d939:62fc with SMTP id ffacd0b85a97d-3a4f89bf4f1mr9961708f8f.22.1748894311133; Mon, 02 Jun 2025 12:58:31 -0700 (PDT) Received: from ?IPV6:2003:d8:2f34:a300:1c2c:f35e:e8e5:488e? (p200300d82f34a3001c2cf35ee8e5488e.dip0.t-ipconnect.de. [2003:d8:2f34:a300:1c2c:f35e:e8e5:488e]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a4efe5b96fsm15756390f8f.8.2025.06.02.12.58.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Jun 2025 12:58:30 -0700 (PDT) Message-ID: Date: Mon, 2 Jun 2025 21:58:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/madvise: handle madvise_lock() failure during race unwinding To: SeongJae Park , Andrew Morton Cc: "Liam R. Howlett" , Jann Horn , Lorenzo Stoakes , Shakeel Butt , Vlastimil Babka , linux-kernel@vger.kernel.org, linux-mm@kvack.org, stable@kernel.org, Barry Song <21cnbao@gmail.com> References: <20250602174926.1074-1-sj@kernel.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250602174926.1074-1-sj@kernel.org> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 3Pkcp9ULSmNjLBgQXTSIv95QHQKfqM8nZtKv27Oh2UQ_1748894311 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 71CA7140006 X-Stat-Signature: s4pafohaj3oyiup8whibbo79ni1o3ahe X-Rspam-User: X-HE-Tag: 1748894316-610313 X-HE-Meta: U2FsdGVkX1/DQsxgKsXeJgAVe8Re+ELPs8r366Wd5G7GzDLnnTEUAfOq5p0rLU7uBJ1j/Tzx8HWyLyGLqWoXLa0bqdhlPnhXBYJjorJi6xQui3IPnpZ72KITfuKgrFxV4B1LnzjK0cCje4D9vB3nIxX8Aq4SZeHwh4rhGjHZeX4nUrkqJ8ZH64uwIe/fdt4jJCbkD2wkakS25dzkIeZJ6OdIcNJczay42Cv9KHnnfvv/pGKl8d1p9p860fvK2+5CPkEZuJhmfggl8mwAFhN7NIico3WCBSMLJ71eqnz8+RcbLJSoBgJW+/TwG+udYKjJSmmI5Jmb4IWlwbgf47WsTuCwyWb72xtBI59KwJMzNhSAOI5PoeTh4YAaJl0efgdpIQBeUInok0aQXHbBXAlOy6zr5k3JfukpbbpY8EMMngXaqDuvj6gRgKHgSN7QW18Z2iKTWW4Vjo0XghLNns0WVyuxjYS7h0tms0qC8cdQ7iJdpVUBoTpbFP3OEaEmIvvFV1AmaP0spyHReI+f/tyX77ljXhKv0IFSwkfea8vDnnzn+4xnZ41toP0hnCqAI/sUPtDUpW/z050773MdKqaEb9JdqFqVLkfIkQgsWy56STP1+zOAiHjbSgkx44sGUIEfGjC/PxoG6SZadsyAaYks019VTQARQYJCi8AV33Ko2ilbdjfVbkVhFCMS4k4bJ83knodbrJOLdkmx0/nG/xxGkMA1HlDYSxSfkxOyC6y9zXcqcT2JOFK/nRQXXCFe4Ivo3+LWlEOuPJPU0i7MZaWbkzKjGzTBnM5kne6+XyZ4ra2H96fCGW6boHo3Z8NzxrGkjdGxjgYU717kgjAQDgxYP6xLJAddVxyxg6HRDYeCwUrdWV6isbjJPewYEGMM7pm0RbrLvBXispzlSHGDy5AR9/9XyEQZWWy40YiO31FKUJMWvlAA3ncXAf25zUiws8QNoV8ZqsqMksxH9yLRqn2 fwF4jEBK pNaDURALeJj5uUFhgf9++weXKM7NqF0SiPhS8k7FNUs3Hncl7P9YgvWkepsEb1asB19tOl4z786Td5ZW3SGA6Le0uz68tskgs7JXhcZvE+I8L08MPi7r+psCGKxv1emM3KQlQs4h5qmaOMX+Cw/efGzkJaOHI5U13CdrBLV/+nW5eByLesy3tacK97anKf4EtZU0jQ10BcR/JtHwnBMisuLK84cPJAichCQ1bKjUx3RH4qPAwlnFBxS38vvisxqBagchrTrPIhmo11WvH6jQQpTrTM/wV27yXVWJybiDTvqNiGd011SHJ2Kb8QRLIIMAK8G1RPfXuDyGstctOdUnuUYUIgEdEgxkcfGt8co5hGTsEuBOgQ5+1YhKzCyXMbmy1cUZfXX9d49xML8IwCTJ5mYAYGH8lg9D9Gq7JrZJ3oVezzH3PHA+Jr/T0chRaj+WJuxzqhzKyrmNX12uDPLVwKG0U/Q/h0tlYvDduw/TA8TOlERffW7oQUjDgZZ68Bk6xULDLyNRbLm2S64w= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 02.06.25 19:49, SeongJae Park wrote: > When unwinding race on -ERESTARTNOINTR handling of process_madvise(), > madvise_lock() failure is ignored. Check the failure and abort > remaining works in the case. > > Fixes: 4000e3d0a367 ("mm/madvise: remove redundant mmap_lock operations from process_madvise()") > Cc: stable@kernel.org > Reported-by: Barry Song <21cnbao@gmail.com> > Closes: https://lore.kernel.org/CAGsJ_4xJXXO0G+4BizhohSZ4yDteziPw43_uF8nPXPWxUVChzw@mail.gmail.com > Signed-off-by: SeongJae Park > --- > mm/madvise.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/mm/madvise.c b/mm/madvise.c > index 8433ac9b27e0..5f7a66a1617e 100644 > --- a/mm/madvise.c > +++ b/mm/madvise.c > @@ -1881,7 +1881,9 @@ static ssize_t vector_madvise(struct mm_struct *mm, struct iov_iter *iter, > /* Drop and reacquire lock to unwind race. */ > madvise_finish_tlb(&madv_behavior); > madvise_unlock(mm, behavior); > - madvise_lock(mm, behavior); > + ret = madvise_lock(mm, behavior); > + if (ret) > + goto out; > madvise_init_tlb(&madv_behavior, mm); > continue; > } > @@ -1892,6 +1894,7 @@ static ssize_t vector_madvise(struct mm_struct *mm, struct iov_iter *iter, > madvise_finish_tlb(&madv_behavior); > madvise_unlock(mm, behavior); > > +out: > ret = (total_len - iov_iter_count(iter)) ? : ret; Acked-by: David Hildenbrand -- Cheers, David / dhildenb