From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E93FEB64D7 for ; Wed, 28 Jun 2023 10:50:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E243C8D0003; Wed, 28 Jun 2023 06:50:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DD3278D0001; Wed, 28 Jun 2023 06:50:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C9C4A8D0003; Wed, 28 Jun 2023 06:50:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id BD1EF8D0001 for ; Wed, 28 Jun 2023 06:50:28 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 96223C0119 for ; Wed, 28 Jun 2023 10:50:28 +0000 (UTC) X-FDA: 80951837736.14.1511BC1 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by imf11.hostedemail.com (Postfix) with ESMTP id 68B9840005 for ; Wed, 28 Jun 2023 10:50:26 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b=ErAy+lsQ; dmarc=pass (policy=none) header.from=quicinc.com; spf=pass (imf11.hostedemail.com: domain of quic_charante@quicinc.com designates 205.220.180.131 as permitted sender) smtp.mailfrom=quic_charante@quicinc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687949426; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hZzS81ULesm4SQXOGJrB0LJ92KFZXTfL0rkUl0ZKncY=; b=NaB2b9daqsDhNwi37lqbcK++ne5mWnmUSCAkLemdtBPKNS1Oa/rid/f72V2CFCpRdQx3X+ qph33pniKAQN0S1WHAuKtTWMEMyKPKBFsuFgy6ttn8yDvt8npJnceMFqX6OaOQJ85hv50M Y4WMUTA1St2kjwYIAzRM1OYsl5GO1vQ= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b=ErAy+lsQ; dmarc=pass (policy=none) header.from=quicinc.com; spf=pass (imf11.hostedemail.com: domain of quic_charante@quicinc.com designates 205.220.180.131 as permitted sender) smtp.mailfrom=quic_charante@quicinc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687949426; a=rsa-sha256; cv=none; b=qxmA0Xg/ksNbqIiVAQB9Qppf7mE2KIXmovQ/C1RRxBowbDKG0DCOtiFzGXh8pdTa5+OpCt gIomDbyXUTID1JNoJASiX+XlWva5TSp24h/c36oWh47lzHTad4bKwEfKVlzTqNQlHla0Jw j5UxLMOFWqeNoudvOIVew2fbNzZqcdk= Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 35S6wAMu001665; Wed, 28 Jun 2023 10:50:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=hZzS81ULesm4SQXOGJrB0LJ92KFZXTfL0rkUl0ZKncY=; b=ErAy+lsQdOInQcryVGpm22EOvyR0Sujcau5in//nESf44+czURH5rJ9Uqd4IZ153f35/ GLyRewwUaURvQN+k50xr5nwIZekl9bLmQKKFLZrDpxeSkw78Jj8z3iT5phGnJFE2uCio oFKpH9lxN0zFYQKah2dz6pEWWiK3TWE9MB0xCuuV1cdbUndxkKcdCEdaePDW9hQrYjNQ p/G/3uluNkMEUdT4nYpKx5VJL2P2Z2q0sCxHojTHp7TJ7PmF0Ini5jYHJRU98P2Y+GU6 /ofEb28ZmXwsBg0lGXw5YxAd8J0dU/09+0vD21r3rn2QRhm95XpjQ2wiBmqufX4R6vqT Lw== Received: from nalasppmta04.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3rg7x3sc4m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 28 Jun 2023 10:50:20 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 35SAoFZh009987 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 28 Jun 2023 10:50:19 GMT Received: from [10.214.66.119] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.7; Wed, 28 Jun 2023 03:50:12 -0700 Message-ID: Date: Wed, 28 Jun 2023 16:20:09 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH V2] mm: madvise: fix uneven accounting of psi Content-Language: en-US To: Johannes Weiner CC: , , , , , , References: <1687861992-8722-1-git-send-email-quic_charante@quicinc.com> <20230627144639.GA52561@cmpxchg.org> From: Charan Teja Kalla In-Reply-To: <20230627144639.GA52561@cmpxchg.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: HqNwXIsGNUoP2kHcrabXvYsGhEXOVXsD X-Proofpoint-GUID: HqNwXIsGNUoP2kHcrabXvYsGhEXOVXsD X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-06-28_06,2023-06-27_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 spamscore=0 priorityscore=1501 suspectscore=0 malwarescore=0 mlxscore=0 adultscore=0 mlxlogscore=405 lowpriorityscore=0 phishscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2306280094 X-Rspam-User: X-Stat-Signature: dux4yhsexeoj8eddfxnzzyqttfrtxs86 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 68B9840005 X-HE-Tag: 1687949426-686625 X-HE-Meta: U2FsdGVkX1/md7vXWurfXODqA7g4s/o2OZlXMKxEMR1PKuB3ZIFo4AyX6D0xSpJCrR/inuJ8YizYoDuzY/p1OOhfS+9fQN78PyPO8JUNff+w4Z1Ye23CCiLBB/x84qzpL/Q7wL//kYreQhBg+BSTG1GdSA7uHT3pG3DD5gTpKOU+IUDltNCkVOW+HWnO4bbJvpeA+EBR+BH6yAsyioZ91ibozFfkdcm+nAoAMnIMfx9IJuxYtiSpqvvAlwkxDushT4UXBr2V796WNS40uKMAxeG6Vuor5mswktM2YAxeGNlj+uVeaITUYQ1SNg4xLGMq8Z7z9JOPF0QciEcgrRLQDPW6Y305gKFG15ZxK1kzCapJhkBvOae9W2P08Ox1XQaivgJ6j/Ye0GvfrXikWKbdIYDR/RJz9tK605MvpL0P1qS7ODWw+DXn/EVYC7QVQ0A4DZVy+sKBe0Sw0VBWiptUu+e9y6Njx3AYBfiDCKsuD9TZSXkKMNjQCeaj230OlYwLrPHsC40WulMc9TfJAglCA0wwUJKDzFHLIAVy26CWIW4a/otzxygwVpXXCUwZ2AkihbvBbrGxWW0TEVXH7XyAgnyDoMhRlQye0TKkrg2mhv5wAZcM75x8tAbvI+0GSfTBVDZNAf9pCBic02NxV/N1dpJskqeSXL4QikpAdGeGl85qBscaxFHAB4zl5UXzyScAytDOiZoCgigMvwVYNg1P1Nej/D+SONRX0pehCRoopQPY1H0XPH4+/m7Yx1P4sKt2LT4Rymu1kRjzFtG3oAcd+Efdy3nqGHbYWkvqcOVnhMrzGCj4PMrK+1rsi7h4WYY7QEFFKr6HdY6u9tdoTNDs1K7LAefzGSym1R85JzX8wGSnIGh5Mo7EmJAthB/ZPbX3ouVGMPUwuMH75sdgclDfghNod1/Oh6uA+78Enedq2uYB1gSUtvW3SLpGaURoGDR/y/cfZ+E/ia5E3B/WUhS 3HHrccwH QT/N8YkctIAIfWWoPGtAnzvZ7G6kuktNzSWp3AxrMsjx+50alWDZ08LZqtn5zwNbRd4h8iE39wQAa8UrSkqe0kEuKHctpdWMxz+RByHIebDzlSUjhjhsn6CM2h79S+ppAb/hvtVCNsM68wQDrRP7xAzIiO8w18jWL4+G7W9CUryNf27MBua52zA9OB2DnlGOydo3oN9U4/nTWUAS1PB9BYbU7mdWlJwNfyXu/ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000013, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Thanks Johannes!! On 6/27/2023 8:16 PM, Johannes Weiner wrote: > Unless I'm missing something, this also includes inactive pages, which > is undesirable. Shouldn't this be: > > if (folio_test_active(folio)) My bad. Let me fix it. > folio_set_workingset(folio);