From: Charan Teja Kalla <quic_charante@quicinc.com>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: <akpm@linux-foundation.org>, <surenb@google.com>,
<minchan@kernel.org>, <quic_pkondeti@quicinc.com>,
<quic_smanapra@quicinc.com>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2] mm: madvise: fix uneven accounting of psi
Date: Wed, 28 Jun 2023 16:20:09 +0530 [thread overview]
Message-ID: <a80670c8-850c-e0f8-67d3-9d783a666076@quicinc.com> (raw)
In-Reply-To: <20230627144639.GA52561@cmpxchg.org>
Thanks Johannes!!
On 6/27/2023 8:16 PM, Johannes Weiner wrote:
> Unless I'm missing something, this also includes inactive pages, which
> is undesirable. Shouldn't this be:
>
> if (folio_test_active(folio))
My bad. Let me fix it.
> folio_set_workingset(folio);
prev parent reply other threads:[~2023-06-28 10:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-27 10:33 Charan Teja Kalla
2023-06-27 13:56 ` Pavan Kondeti
2023-06-28 10:49 ` Charan Teja Kalla
2023-06-29 5:07 ` Pavan Kondeti
2023-06-30 13:16 ` Charan Teja Kalla
2023-06-27 14:46 ` Johannes Weiner
2023-06-28 10:50 ` Charan Teja Kalla [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a80670c8-850c-e0f8-67d3-9d783a666076@quicinc.com \
--to=quic_charante@quicinc.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=quic_pkondeti@quicinc.com \
--cc=quic_smanapra@quicinc.com \
--cc=surenb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox