From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90BDDC369A1 for ; Wed, 9 Apr 2025 07:37:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 86E5F6B0148; Wed, 9 Apr 2025 03:37:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 81E276B0149; Wed, 9 Apr 2025 03:37:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 64A6A6B014A; Wed, 9 Apr 2025 03:37:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 3E8CE6B0148 for ; Wed, 9 Apr 2025 03:37:41 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 62F5A162041 for ; Wed, 9 Apr 2025 07:37:41 +0000 (UTC) X-FDA: 83313700722.26.488954F Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) by imf22.hostedemail.com (Postfix) with ESMTP id 3408EC0009 for ; Wed, 9 Apr 2025 07:37:36 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Ojcd2mwP; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf22.hostedemail.com: domain of maciej.wieczor-retman@intel.com designates 192.198.163.11 as permitted sender) smtp.mailfrom=maciej.wieczor-retman@intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744184258; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hZvReWNJPasuwyBqXKomLNGu4+Soi4rWevQx2Mdgo+o=; b=G83zckp2jOkJaZVj7bFl5z+VqIvBEJ33/6kK6u9EYQBKt1pu9tg5Gi5EWs3CUK7A8g6PzW aItmnmBGiLzNc2X4v/W1Olyk9HEmMNyUzqutTEFduKrtf7Ip1ac+EIy44tw0O3cyZ8MWt/ 2kchKKpzOBKegYai2ZF5KzwgoKXTlBI= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1744184258; a=rsa-sha256; cv=fail; b=sQJJ6BCisN3D84S5X+7VzQBQJBiyRDXR8CRAgfrnR8E0IqGHbmZ0CsszxP//2FH7jfvlcl dN0cjERcbQ5DLHj1Pj8+E2KB00KSFHSj4gI1utnOf4DDvUG6tD7+sLuDKOalUptGRPlNWv GZIYXVzBL4sUkYUI6E/u8OHyDLwjG2c= ARC-Authentication-Results: i=2; imf22.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Ojcd2mwP; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf22.hostedemail.com: domain of maciej.wieczor-retman@intel.com designates 192.198.163.11 as permitted sender) smtp.mailfrom=maciej.wieczor-retman@intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1744184257; x=1775720257; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=tHSswy6XsMRK6kuFhq3NUaq3M2JEu62sA7RjcVDgH20=; b=Ojcd2mwPffoqPGW81KojkzrrMt0tAskhsqM53oQH8gTVBVlgAWnfhFuT MqUFBtagwba5F2uJkcdtiThuWPF5FVVTryRZNUJKSZeiBkAeEdBQQSFzd qZLr4p6pIziI/HQ5k7pt42inTPHcJpt21o3McBGAJu/VDll8rpJl4FM8U FTSibyyScseT8a92nYF52l/sxR1Yhkcr6z2F9E3hVDKhqPAFnOPPt5V3o RzXPppXvjy64Hp5lD4Qs6D0ldLDY81FQMhfiMKtUZT9IpLKnsbxIFyzcs 3kjgWf5eY1uN5nLaqe+LUFklL4uHurP5dJt3hj2f4iAuLWN4U54gSMVo0 g==; X-CSE-ConnectionGUID: QHhMgh5bSae4XvPglVxjHA== X-CSE-MsgGUID: dXzJU+zkQgqJ3q1S5bt4lA== X-IronPort-AV: E=McAfee;i="6700,10204,11397"; a="56311016" X-IronPort-AV: E=Sophos;i="6.15,200,1739865600"; d="scan'208";a="56311016" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Apr 2025 00:37:35 -0700 X-CSE-ConnectionGUID: 8d+NmMzzRNy/C25VpsmJAA== X-CSE-MsgGUID: eIOmOAbZSQm4giJyrdYA4Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,200,1739865600"; d="scan'208";a="129451211" Received: from orsmsx901.amr.corp.intel.com ([10.22.229.23]) by orviesa008.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Apr 2025 00:37:34 -0700 Received: from ORSMSX901.amr.corp.intel.com (10.22.229.23) by ORSMSX901.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Wed, 9 Apr 2025 00:37:34 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by ORSMSX901.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14 via Frontend Transport; Wed, 9 Apr 2025 00:37:34 -0700 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.45) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.44; Wed, 9 Apr 2025 00:37:33 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=muvyeM0aN0r8xS2TKcM+CCaw+aQEW1w6IQaGvPUjVQ39QMVu4+UQ2Qmug2uydxk9GLK8BJwm+GjwLZpIjKko63Qnw5Cm0rcvL93u1Gr3r9XIL/q2GS6mNtD6F6Nq4+x0nj+ZuM/5XKRlSljxtecL3nG0B+euIVaHzlWqs8LamAACqnioO3vruq0z6jlz+lwwlhZ7ABTyqDoCeW6n7baVBrasktSgWW9rzw5iDOyqp3DypNb9dEsh3XPo49F8E1+WsEbR82gr52/mhuKO0YYTrLtaSukX7exU2oLp0MbdK69m5NqKQNrZTVr+1MEOILL3SD6BvJsxqRPw5ja7x6qvsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CJ6CzhN92oiB5Hct6GpQqdmjuoXgYOgmYkJTHKLM4Ls=; b=HfwM8bOflHoy5ccWQm2+zPT1sDGkePTSpZTCc2LswNzGRLvfZPXLoIkBXgxc8G3AOvBKVlq5bRXHABdRRPQUigB4HdFMQ+TZaKtrHo4TGporvAlPOluSSQiAO7/uVcHvwFtNPxUvzHc0/kA/amr1FoQl8XGjBb3TzXCpBorjgH84Q6tW9Fg/2lWKcbBjMcm/mVNJYRhjREsAcxlBey3SZJ+okRElU/JJONiXOigLhw5v+Rp3Ja0D7gIRdAis0Mwm6Lenl4Krm9hYLQ+3tggBOGeAEXwC2okIMOyJJWp7t7HbsgSyFMpg3kWjjFxcUxQogcRV2Nbmi6lBLwEbIWS5Rg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN0PR11MB6231.namprd11.prod.outlook.com (2603:10b6:208:3c4::15) by PH0PR11MB5109.namprd11.prod.outlook.com (2603:10b6:510:3e::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8606.33; Wed, 9 Apr 2025 07:37:18 +0000 Received: from MN0PR11MB6231.namprd11.prod.outlook.com ([fe80::a137:ffd0:97a3:1db4]) by MN0PR11MB6231.namprd11.prod.outlook.com ([fe80::a137:ffd0:97a3:1db4%4]) with mapi id 15.20.8606.029; Wed, 9 Apr 2025 07:37:18 +0000 Date: Wed, 9 Apr 2025 09:36:32 +0200 From: Maciej Wieczor-Retman To: Dave Hansen CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v3 05/14] x86: Reset tag for virtual to physical address conversions Message-ID: References: <257b39a5-69bf-4e6d-844b-576e9c9d2e7d@intel.com> Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <257b39a5-69bf-4e6d-844b-576e9c9d2e7d@intel.com> X-ClientProxiedBy: DU6P191CA0002.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:540::19) To MN0PR11MB6231.namprd11.prod.outlook.com (2603:10b6:208:3c4::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN0PR11MB6231:EE_|PH0PR11MB5109:EE_ X-MS-Office365-Filtering-Correlation-Id: 7e111d9d-67ec-4cd2-178a-08dd77395ae2 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|7416014; X-Microsoft-Antispam-Message-Info: =?iso-8859-1?Q?gm5JE6RvxiT9WvVipGtIkxidrz/iwVRUEMEDY/zKEki8ruDYBhp2XycuKh?= =?iso-8859-1?Q?67Wviz7oahrFb+BJtk9lEcbo+xWASo2UJvZto01sWa1dawjvyhJMV1brUT?= =?iso-8859-1?Q?t7dZvpqHqE4C4D9rN4U+M1IRZxb0cswFSVAcA9un5N0R4/0jXWAoW6PDHT?= =?iso-8859-1?Q?pD5dvqunmiDj4lqbegV5d7+FnlPqIgoP6CBnheSJk37+BAqHKFOzBBRHOq?= =?iso-8859-1?Q?0CWOcJeB7idYRohHcSpe9Qk+lPJ8VZkByfWFaki+z9fMekOx+cIw7Q30/t?= =?iso-8859-1?Q?GsS7r7Hl5EtfVWzUMe+jpfHR7/4m4x+99GQ2cFNeKDGi6Y04PZOdvBpX2L?= =?iso-8859-1?Q?FRwsz+ffwY4pcrAnpfXn2IB41NRbiT78BkqyoKS3sCRabhEAbHu/QNosUl?= =?iso-8859-1?Q?aE8vQbxT/EArHB+BIOaVoc+0mvYkGETPCclNL89LHFKAhrv4IYcPRsf4nZ?= =?iso-8859-1?Q?j3IKKhCzsD3JzbvrU+96aha/NtgjRKhwkb/Q3OxcH6fE33SUQro5wGmC3x?= =?iso-8859-1?Q?UVlnoRSvtZvIBvQ+sj+4fApFTrpWdxBI3GOSAgUZvBnPK7E1u+Xpn0y0sd?= =?iso-8859-1?Q?tx+dwr6VbyJVI9Qi9X/5kXuMOaiMbSFMqmFnggM/oVC2VA9x4/jSYLSvtj?= =?iso-8859-1?Q?mKs3nhrWYfSRkZsAqgbrC6qmyh0VFG0Fot/uyjiOkrooiN9Ffr5EYFi5t1?= =?iso-8859-1?Q?LyQk2hDKYOw6lLxlP1Zs9fkxnLn5kqYnTNMQZNu0FCeXxtquYpDOQVgOzC?= =?iso-8859-1?Q?ODKV8TumU2TUxwaRVMZyAy7qyo7mDmv6kOGZmm/x253aTmfjIlbo6U5Ceg?= =?iso-8859-1?Q?L+u00NqwngBpq3wKV3sxPCEljf3TxXNwKrF86qtA6M8PmS75A0wTOdWQIv?= =?iso-8859-1?Q?PoXddF9c2Gc8L1e4BkC5Jwap8Qe3vxytwTp9t312sBXG+9WBtjFeCgUete?= =?iso-8859-1?Q?ro9B5KqkvZ6DcPoAY3FHsiNjHDNbrREY9bwbGc3n/GRUNbJz/G+jf8cTen?= =?iso-8859-1?Q?sS6LVZk8Hr/XojYJhZNnnp2FN/DDxEAumQeAMs7zZsTdWeeZNDeo7JudKs?= =?iso-8859-1?Q?+DGFZvaDhEG/mM0F7EkEuQbefwhWPYzE0TgKPSfR2+s7JJowDPYLA/wgiF?= =?iso-8859-1?Q?vHgF6cIFoWe1bVf+XNc6S7S2djPEyXQmu62PfwJmB/jMjSp8ohmGELBkAy?= =?iso-8859-1?Q?1wlKVoFQgjFokmsXE7rNycK8xQhqgAeataKp54S7sEO5HnC+TJ0x97zMAy?= =?iso-8859-1?Q?8odjXmtmTU2+lwxenkIQYTEJAVejskMi/J5er29N2uQlhvdqdg6qfk1k3i?= =?iso-8859-1?Q?JiEKmsxLmcOYSUyuFVoy9mMmdfkmgIp875sDPyNrBmf0LqZUX5nQIq2j/4?= =?iso-8859-1?Q?gv/f9J+Ox6eXFXwGHsCXqGHTdKZs5AT+lxvIz1EwQ9hd2RqRVmqHxo/NWI?= =?iso-8859-1?Q?iDjafMhPJqixjgjf?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN0PR11MB6231.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(7416014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?fV5eZ4juin3bW3Ae4NYIjGjWhGTeRU+u2uA6No9eHcoA6i8n+0D9bK64ju?= =?iso-8859-1?Q?Omabk2vT1nvo31qHX0EJPh/DKcD1UspudA2VTKj9x+iSQBmd8XdljwBmyX?= =?iso-8859-1?Q?wTOxB54Id7kliWCgXLWwhLN43Ri5YEChduHATc58Ik0xaibxs/Y5OBfnE6?= =?iso-8859-1?Q?AB04GyXnqspwhfNgz7RdqPFBVvxAA7H4PwPQzahGQgXymBed68i9uImCC8?= =?iso-8859-1?Q?JmOtEVzpSsbEGBhY+wj+qgyBxEzSMKgnXNM5uHhwCAfjBorAkagtr8NDoU?= =?iso-8859-1?Q?gcTxO9nW0VMg4soMCxXuGxDiMOgNtkgC9keRbbXWcTrgi1wTDOsa2bTlzw?= =?iso-8859-1?Q?6D0anjRmwx7/p4cimi5dSIiJxVxLI1st/EjV7jJbECCGOxmuBslqn56/1c?= =?iso-8859-1?Q?UAbi04S5CQH16UAOddglh7IDZt5+ssY6HGHnpYxzJU+Pvgoz12w97KkbRK?= =?iso-8859-1?Q?oEPJygqTYg7MUhXjkJBeqjGhN6G21KkgCbK6CGvkY5GV+Ncbx5c9rXwv2W?= =?iso-8859-1?Q?iwzbFvbNs8qVP9JmLHezEulRg+Wz1nqHERhgt4Bbo5dW0301j9jr5uJE8M?= =?iso-8859-1?Q?Y3qLJqApgJidhUSG0EWWPaTU+SbC47tTNnKdG4I4HmzyJJ9a52NrWPT/oF?= =?iso-8859-1?Q?QzLSR82lNzVNyYTubxb2n9aSvhfwHUNBjA79VHeJPdEAJk7kIGr6HoIiGV?= =?iso-8859-1?Q?2DiQkOvwj1XRA6jwaRYbOPuFNQS4C13ChiZG7CHJUnkVsTB6VKW8dc2Sl2?= =?iso-8859-1?Q?3PxB5aKwlRr80ReT/hFLMaZ/XdUbcH81ESip45IqzY8O9/k0jA4irc9NnL?= =?iso-8859-1?Q?Ad9BqaAeDOawAeqsXD0EWhqn+bKEWJuI3sfGMj0f1E/157x2A5jwSi0ubt?= =?iso-8859-1?Q?BUDJ262Wtpbajo/QFk0iBDLpqipabSknqVL4GSfUidO/6bWdhzRjXvC3Bb?= =?iso-8859-1?Q?ETkIuavuqR6GPI+f1aBO7hkFmqaATuas3Iz//Yy2j8P6+1kIMDtaqY2NeR?= =?iso-8859-1?Q?H0Zz/tTAathyqzKZ5dBCdDLO+dGAYdqYHkCAv7I0dIVGzlV2mErStmaa1e?= =?iso-8859-1?Q?x8YNWiDyykCN9cOtBCjonqs9rAhAwcQcg45T0qrCicGLxA65Wf9f0dfy6p?= =?iso-8859-1?Q?uchwWl60Ym5jUsJ0JMTrB7cl0IsO52rQuC+51dVxEm4CI7nsaJViO7Oiyp?= =?iso-8859-1?Q?9vlisHK7X1jhkPGk0lIjIYasiA+d+kBjPeqAaAjw/lN1/QvMiBUf7jO+y7?= =?iso-8859-1?Q?U3vWL5B8OkYwhuh2w8JdmWnmAhpgAndEEbtP3pKL5mUUZ/WR/OZ5CgIZaH?= =?iso-8859-1?Q?k/MxLlWyr32K8BYyfjsqVbgCWvDCSQTll/ApIrTC4ej7R3quTjGLzfSwmM?= =?iso-8859-1?Q?zagR166KwMRd/yz+HOgWuUgsKXq+rLTD9+CNGBFpf90+hSuN9W412yxNu9?= =?iso-8859-1?Q?xeQ+LSTXJEZG8DxYas6vpmVv1lIQZeD7TVLgkjP252Ljc/WdZ3ZXjD+kw/?= =?iso-8859-1?Q?51WCeXU7FMxa3SypO4fkUVR/UB18t4zcNPRCavfKSHL+L7JANN2dR6+3aJ?= =?iso-8859-1?Q?HvG+LlTTcYRxw9F6P9S+BXrJFHQ5O70cqPaKuuurSnS2mD4eZTJauuikrG?= =?iso-8859-1?Q?mFhL9EDGEWzzU48/qCl2ffznUCSURWUYhzqR1G0aUZdcKhUmxxalLAhCuY?= =?iso-8859-1?Q?pf/r+7zXKnFzA91sNmA=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 7e111d9d-67ec-4cd2-178a-08dd77395ae2 X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6231.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Apr 2025 07:37:17.9937 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: t06MeM8qBfZRbbYIen/iGGo9063ePKWL9qn8UiL3A2SyU2iPV6iElez1g8jERQaAjVlmdZygmUDne1LzA14lxZ8YGTd1/W6Vlho/fR+bQ0c= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5109 X-OriginatorOrg: intel.com X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 3408EC0009 X-Stat-Signature: st4aeaa4mdwpq3pxqb5cxe8kembo49az X-Rspam-User: X-HE-Tag: 1744184256-865255 X-HE-Meta: U2FsdGVkX19B66rvrBclueSqeWm1OxQjdfUsCrOPv9hH1qUBBxKqElVUpmpvZpgKSBd86ilqLmdEmBj4qyPZoHD6MVgbYfvXWYAvAdJvAgkWwYRx9PEa/eeGkzTb0iGH4OQnfYINsTNwQUIE3+DKQ/k4HyMyBxNVnRRjIF6ys8reVZyLlpTI3dDww4fie4A5tfCDFqU38zbIF5uZS9a90wsclTCFmyW9/QqPvwBdpLZwe6Ck//v/oCQ9piW/WrtojH4UCsp0iGaTSiO1+hmGQXyS4r69jpReDam/Go0SZ8Q2Z4HMLaLPSfWkreJHAHh5DrlwmF3aR6kX9VqE3gpw1Jxff1Fx4r7wguo0l+mWhl3DDoXySN1cDNG321cJohZsq0JvFktwcvUtV0Mzj1wY2bsgnmMPYPlbefzTonhO0IriQYSFMiouY3QaTeQE4kJtQeSIdeAXYz89aLifaMz4SU6W3aIdEM5pV26xMYbrL+fkHt/ASj4rPdqWI38WGtnCGBHEX+DPkSgLRJ65Vbj0AqdQbIk+D1i8Hft0fj2aOBMBBH58S1icEk6+/AmVU3Y0KAYzEszY4OynS4V5WBwET2/qcL88kupugsqZi8QHwA1tDbu1M7H0Kdh3Xe2l6fUWZgmoqZfTx62HhFzqhbqNWAgaCaX8PCZH5vB81mymdOLvbp5Xjh2uF9rrYn0mmwL/clSPiKMMcUr42JdiwHExAwh/NetZn1HpJ+KvyjwizVNWwbm+9vSpjptnP27EN5o+DBADohA1ynXjycqbFirx2CEdyJc2Hgj4yzuBzQdpKVB1kprDBVTmp6F6kvYdZ5Qst5NARsL+Uw7jQ9RbzTZ5KIstysjNN74WmnLeKjf3cGjoVzsiIR8cHroQzOlMkz5LB5JkBqYUeykbxhOZJE5c7CJvJH0jZ3/YwuRP+b1grR3Ih4uAR1T9hF+tVPhxU7tx9JFPG2dnf/vZdkWvLEA ZmSSAPXC FWzxA4tu7lBHtu5jLa68CGndQ9eLf/8Xn9tFoB9K76PN8m5hmnUBnX0A3TIpMr3DtlbwrrD1uoUq/4ZbXWVJ203p9ZpuPBCK5ybPNffGnpB6ML0KGAY+q7bM/99nvMZObK7KzD31FdW8vuFtBdcl7k0vpmo/6gqR2ciVctl4rr/b0VlQeBCLKFjKHF1+599g0bUfWPsbahALhL8wvo5WQW6W5CbnAPwc0LrnnxdvBaDwhr8qwCa+jEtvngPMHe8dLx5qvp6HdQEL4SEzb4XZ93qcyzQkdW5wK3vAz6qVBmvAWnxwLpaMvMMNVxNcdzaLBqbOW+WhLULiYQcKgV0WmRk8/ut2QOTmO7ZMzStLaBw3sGJ+pmzJ9WP7jBDYG0hFvs6w5bfBGZBXYR8dH7uO5yOp6J3jIWPuh3KnULLwI3JouLqAMscqmkMWCkYNE57hMwDN42H17Q62f22NwbMwDa1l/kX6tAFzzPQx71ntt7SffYRw1lNyYWOknljobeoNRucCipxiZDDLkZQpATiGTP1FIoG59S4T9t7HKOXcbMDpUzUIccfP0XZc5ji3TeMve09N7 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025-04-04 at 09:42:55 -0700, Dave Hansen wrote: >On 4/4/25 06:14, Maciej Wieczor-Retman wrote: >> +#ifdef CONFIG_KASAN_SW_TAGS >> +#define page_to_virt(x) ({ \ >> + __typeof__(x) __page = x; \ >> + void *__addr = __va(page_to_pfn((__typeof__(x))__tag_reset(__page)) << PAGE_SHIFT); \ >> + (void *)__tag_set((const void *)__addr, page_kasan_tag(__page)); \ >> +}) >> +#endif > >Is this #ifdef needed? > >I thought there were stub versions of all of those tag functions. So it >should be harmless to use this page_to_virt() implementation with or >without KASAN. Right? > >I'm also confused by the implementation. This is one reason why I rather >dislike macros. Why does this act like the type of 'x' is variable? >Isn't it always a 'struct page *'? If so, then why all of the >__typeof__()'s? > >Are struct page pointers _ever_ tagged? If they are, then doesn't >page_to_pfn() need to handle untagging as well? If they aren't, then >there's no reason to __tag_reset() in here. > >What was the thinking behind this cast: > > (const void *)__addr > >? > >Are any of these casts _doing_ anything? I'm struggling to find anything >wrong with: > >#define page_to_virt(x) ({ > void *__addr = __va(page_to_pfn(__page) << PAGE_SHIFT); > __tag_set(__addr, page_kasan_tag(x)) >}) > >... which made me look back at: > > static inline const void *__tag_set(const void *addr, u8 tag) > >from patch 3. I don't think the 'const' makes any sense on the return >value here. Surely the memory pointed at by a tagged pointer doesn't >need to be const. Why should the tag setting function be returning a >const pointer? > >I can see why it would *take* a const pointer since it's not modifying >the memory, but I don't see why it is returning one. > Right, yes, both your page_to_virt() and removing the const from __tag_set() return seem to be working just fine. Thanks for pointing it out. With the macros I was trying to do what the arm64 implementation did assuming it had some significance that wasn't written down anywhere. I recall lack of the const thing was giving me a compilation error a while back but now it's gone. And I didn't think much of it since arm had the same thing. If Andrey Konovalov is reading this: is there a reason the __tag_set() on arm64 returns a const pointer? And the page_to_virt() does the __typeof__()? -- Kind regards Maciej Wieczór-Retman