From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B1C6C36014 for ; Tue, 1 Apr 2025 08:19:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0AE53280002; Tue, 1 Apr 2025 04:19:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 05C92280001; Tue, 1 Apr 2025 04:19:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DF1A4280002; Tue, 1 Apr 2025 04:19:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id B7011280001 for ; Tue, 1 Apr 2025 04:19:34 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 1CD9F1419BF for ; Tue, 1 Apr 2025 08:19:35 +0000 (UTC) X-FDA: 83284775910.19.CA45A55 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf29.hostedemail.com (Postfix) with ESMTP id 4CD96120008 for ; Tue, 1 Apr 2025 08:19:31 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=h7urjNaM; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743495572; a=rsa-sha256; cv=none; b=WoKnO4HzqCrVp9n190ICSmiRgpOzAwcgwDBFiolkU1KeTD8nm6FVhJCEpmnaeSvgX75wIC Jvc7p3TaZsNLlO8sFM74Z1IzbGcyz3WnX3FxO4+esCx241d9spWL97Vv3egFxUA7RCahtF uElzzdNmIAEJgWxlJxOqgJr0Eu3DGCw= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=h7urjNaM; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743495572; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=G18/0+PB8HRisUibBcwrDtcW76V6IeG/xoloBCihAHg=; b=oKNIx1C5YZus0mfGoYXlchvX2cy+U02Sb6qba3OHxAUgwc7heIkp874GsCQWUwNWn7YCzM VqxiiIyQ8MjoPLv84ofxS1XOPjxGmYK+OOQ6x3d2Ut2ICsQ/wyuelj1R/wdvbVW3rtiWlI VXKkwhecRN47ZkMuWp/QIvXvHchTar0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1743495570; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=G18/0+PB8HRisUibBcwrDtcW76V6IeG/xoloBCihAHg=; b=h7urjNaMMh8nl/bekmYhTeFQTKWQvTbX+Zqyy8m3UDETacIn77ybKj5gYZyT6klhsjP2Hi pEq1XxAb2ZifhaozfKawUjHsBVq0+WNGygppHp66AtijS+j75IFhIl1bDIB4TE0U7MVgUb XGENMBhRAo1k/tc9X2UnAOxi1aGADwI= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-622-K4a2KC95NtKRnnG61hxHDg-1; Tue, 01 Apr 2025 04:19:27 -0400 X-MC-Unique: K4a2KC95NtKRnnG61hxHDg-1 X-Mimecast-MFC-AGG-ID: K4a2KC95NtKRnnG61hxHDg_1743495566 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-43ceeaf1524so27342035e9.1 for ; Tue, 01 Apr 2025 01:19:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743495566; x=1744100366; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=G18/0+PB8HRisUibBcwrDtcW76V6IeG/xoloBCihAHg=; b=avKICNj8130UKJgtR9w3jKuyDRVpcebFWY1unayd4lp6KM+zwyP+K5B1rr7QzqV7ux 41YYkwmD2olqCxsEhpdK21HZA3Frk6ERV1KRXB/6hGa0GSPQgDLGdd3dps+o6DMoC1V1 VDLS7YX0RLcBgKpe9MXwxlhxEF4FLoh0xHgLzE+BL7jqo2FSKoakobrWNhgK6vR29aPw 3q/SPx7vBjb9uTZIND1Zw9Epjyq7L+yBD9vXC206xvxI3EF9KT8FtrLHCzbLSZ/l1uIC vSFd1VIYcz7jVRVdFXkRbVcxcRv3rZUqkeYqhEnV6TPlaxBpGdEZQNIXfdYXfcTd/x7J Rzlg== X-Gm-Message-State: AOJu0YyKk0d9M1PBkIKkBTl2iQb2UQKhW05G521px3A2JzLC57d+hJRN xudDfudttD7ENx77CQx8iAoLHYiJTWYgfkwStvDxTvzcXiQlfJ8R6bYLLcLzcxLOdT5xD1taQ5a uLt1bIWXW/LrZDFtEN0LEYagAbsg6810JrcmM6Ld9TOwPERuj X-Gm-Gg: ASbGncva4Y3TBc+bSIYzUlNs0rNLUGfds7w1ng8z1wCPamN2e2/JNJB3URTX277UOmQ wp99o8m3LmZ3xD5016ak1wgnMTBmjrVqziJwsg02PV7eHkWTla7mxEQLYZWwA3H1ZUACpepUwbF qWOvCdujhitYCrK33TixxQQWwyBDP1rKAAo40e4vQq4kqk2eAV6M7NoBQ27mvc5DTI5K01yaDKz OiJPXy+ODrQqiY9k6SdME/J8cX59NxDn0dUBuu682gLxPNoubRtZkRAf11uYh3BILOhVlDXW/qr RG3fw0rXe8hzpcD+5Fl3HA6wxW2SDEKtIR+PC7yoXCFetcAJPPtuJpmXvWcxe2XQPnt/MNXvZQQ LTDMDbXqGWKFidmM+mVIDmBsQcG4J9TRCjKvY0ldn X-Received: by 2002:a05:600c:3493:b0:43b:c6a7:ac60 with SMTP id 5b1f17b1804b1-43db62b72e4mr108274115e9.10.1743495566315; Tue, 01 Apr 2025 01:19:26 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFcxMWf0eFH42cYOGBM0l+MpFvQXIE5mHVNgPmRXj3lSniz+bBk7y+9/3fIfu4fdV5ATwyx/g== X-Received: by 2002:a05:600c:3493:b0:43b:c6a7:ac60 with SMTP id 5b1f17b1804b1-43db62b72e4mr108273925e9.10.1743495566012; Tue, 01 Apr 2025 01:19:26 -0700 (PDT) Received: from ?IPV6:2003:cb:c707:4d00:6ac5:30d:1611:918f? (p200300cbc7074d006ac5030d1611918f.dip0.t-ipconnect.de. [2003:cb:c707:4d00:6ac5:30d:1611:918f]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c0b66d0dbsm13577415f8f.58.2025.04.01.01.19.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Apr 2025 01:19:25 -0700 (PDT) Message-ID: Date: Tue, 1 Apr 2025 10:19:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/7] mm/gup: remove gup_fast_pgd_leaf() and clean up the relevant codes To: Baoquan He , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, yanjun.zhu@linux.dev References: <20250331081327.256412-1-bhe@redhat.com> <20250331081327.256412-5-bhe@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250331081327.256412-5-bhe@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: gHIUIrTL_XGBMQn8UoVTK95jo9SV89boXDjMTiY0bnk_1743495566 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 4CD96120008 X-Stat-Signature: co8a1mywu7ckazm3fde38za998eu9zhn X-HE-Tag: 1743495571-335761 X-HE-Meta: U2FsdGVkX183JxnOh3iM8r2aopiesEh3ur3VrNJP4Vqf7zttVuRJc+ABIdDRBKsjk9xmkSKrs5DaI+2IJng7zhJPJfDw0YW5AQm44wTI/g+1juAuCZF32ifU8zMXZ/XVZxsRyFR4nIsyPFR/c6nuAFqYk2WLcy/YMAA40DtGfzosx1RCuxe9xzah4MUhN8d12ZoPWOEBiXx+oug3dQWFzJiK1kUF2rduljDwKJ6oGabwMMV4La9o8VhyGdSeRVFZL82hkmqpQXFs6gntM2okjdmJWLGh1zFszoOfcr2ZSwKOZpKia83wub/mjUWFK4wNa93SF3NiTRkkXY54PPLuQvnIzr6VcUTIFCBhcZVcYN4JqhE4VFYIvjbk4ShRhukcPEY204Umy+um/8DeEDYJTRkfTMRCoW1ixvNRlvfo7IkROcyyQnPc8mYVsFd75Dm3gZFbv7S9vD8m8xKA+J8M3VO6jir0j4/8FOa+3VovWRQfI38aHwCe4Ibx3EoWXWam0ah2Zsi88oCELfKlxT296APQfM9EccqNaSq7bl1dKDL+m0uN84OunEYf/ryjdosnYvQBW7zM9FtMOYalI8FxVtglIoqh6J7u5v+AFDGJUa8Z4wis/GjXW1LZr0OrRdpn9gdHYyY7oIvOr78JY9B3K+qi2naiTdji6Ae0w2hOTBxpa/6RmtS0nWHBPqXZ0plj9qNWRe+GAi23ICgZ4aCLRqUB7wLQQa3863i3Djqg80XiSykmyH3EEFVgks7x3l189XreYDbIhfOZIOsNLHVrfcvtUaHUNbL13k8v5ZUMcrfJ3zA0wfo3V8p4u9WK+VfAkASSwHrUkQ26K+HzU70850yY+0WErt57TdPsAXvYhRGxWcMPNvpvOSGI9h4iEaEEtRQy7+6KVor3Nb2PQVqqSt8KvjCpWPv6ovrVljAnLBJ8TVHGFVK8OMzH5tT8+grjUpZZIOe08BUhi+Y82PN Ww31eO6d DyDbMPMnp2XzEMstLMrEibkt8uFRQYGKTypjFHKuYYIqBtGwoVDHSPa3EYSd1i58SPimDlNTGxoYR8x8d3hKMgwNjn6G+lM8wvx/sNDhA/xnwOSaqHLQV4HKBo6E7/8XEw0pQIMroChNr59UvN7p0KmsH9PLzJ993nXfiM5GA4bBCC8BL4ta2N/x9pVHXwgxKTtSuGJ8y4vjaxG61cJI8fhAHTqo+1yw72GSQ9+rM7VV0wJzCm8uoBdi5WqlVLDn4qTnNUW13FCp55gR6oMbKJLdtokZB87FMcR7EJ0kJ/kBFE6Zhgejm8DoV8a+CUQk40DAF0IokMbnjMmP25suiLAjYg70SLbHUU5QX23p4YCN6c9rgpUNYt3hgIQx9Srh0ptT03hA4zJm0neDFxOcW5SmEd8hsIqBiY4qGkc8I/wKqAAlfaeFvnsA29VAgGStt0yFCAFM6aKR/bS9XImBgXaIdqg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 31.03.25 10:13, Baoquan He wrote: > In the current kernel, only pud huge page is supported in some > architectures. P4d and pgd huge pages haven't been supported yet. > And in mm/gup.c, there's no pgd huge page handling in the > follow_page_mask() code path. Hence it doesn't make sense to have > gup_fast_pgd_leaf() in gup_fast code path. I wonder if that was in place to handle (prepare for) very large hugetlb folios. Until a while ago, follow_page_mask() did not have to handle these hugetlb folios. But I assume it never got used. Acked-by: David Hildenbrand > > Here remove gup_fast_pgd_leaf() and clean up the relevant codes. > > Signed-off-by: Baoquan He > --- > mm/gup.c | 49 +++---------------------------------------------- > 1 file changed, 3 insertions(+), 46 deletions(-) > > diff --git a/mm/gup.c b/mm/gup.c > index a15317cf6641..58cdc5605a4a 100644 > --- a/mm/gup.c > +++ b/mm/gup.c > @@ -3168,46 +3168,6 @@ static int gup_fast_pud_leaf(pud_t orig, pud_t *pudp, unsigned long addr, > return 1; > } > > -static int gup_fast_pgd_leaf(pgd_t orig, pgd_t *pgdp, unsigned long addr, > - unsigned long end, unsigned int flags, struct page **pages, > - int *nr) > -{ > - int refs; > - struct page *page; > - struct folio *folio; > - > - if (!pgd_access_permitted(orig, flags & FOLL_WRITE)) > - return 0; > - > - BUILD_BUG_ON(pgd_devmap(orig)); > - > - page = pgd_page(orig); > - refs = record_subpages(page, PGDIR_SIZE, addr, end, pages + *nr); > - > - folio = try_grab_folio_fast(page, refs, flags); > - if (!folio) > - return 0; > - > - if (unlikely(pgd_val(orig) != pgd_val(*pgdp))) { > - gup_put_folio(folio, refs, flags); > - return 0; > - } > - > - if (!pgd_write(orig) && gup_must_unshare(NULL, flags, &folio->page)) { > - gup_put_folio(folio, refs, flags); > - return 0; > - } > - > - if (!gup_fast_folio_allowed(folio, flags)) { > - gup_put_folio(folio, refs, flags); > - return 0; > - } > - > - *nr += refs; > - folio_set_referenced(folio); > - return 1; > -} > - > static int gup_fast_pmd_range(pud_t *pudp, pud_t pud, unsigned long addr, > unsigned long end, unsigned int flags, struct page **pages, > int *nr) > @@ -3302,12 +3262,9 @@ static void gup_fast_pgd_range(unsigned long addr, unsigned long end, > next = pgd_addr_end(addr, end); > if (pgd_none(pgd)) > return; > - if (unlikely(pgd_leaf(pgd))) { > - if (!gup_fast_pgd_leaf(pgd, pgdp, addr, next, flags, > - pages, nr)) > - return; > - } else if (!gup_fast_p4d_range(pgdp, pgd, addr, next, flags, > - pages, nr)) > + BUILD_BUG_ON(pgd_leaf(pgd)); > + if (!gup_fast_p4d_range(pgdp, pgd, addr, next, flags, > + pages, nr)) > return; > } while (pgdp++, addr = next, addr != end); > } -- Cheers, David / dhildenb