From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 265A2C54798 for ; Tue, 27 Feb 2024 10:05:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AD7DB8000D; Tue, 27 Feb 2024 05:05:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A8892940008; Tue, 27 Feb 2024 05:05:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 950058000D; Tue, 27 Feb 2024 05:05:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 85593940008 for ; Tue, 27 Feb 2024 05:05:33 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 3620EA0ACB for ; Tue, 27 Feb 2024 10:05:33 +0000 (UTC) X-FDA: 81837151746.25.E681202 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf10.hostedemail.com (Postfix) with ESMTP id CF8FBC0017 for ; Tue, 27 Feb 2024 10:05:30 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="soi8/goX"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=oqhTd1iM; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="soi8/goX"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=oqhTd1iM; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf10.hostedemail.com: domain of clopez@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=clopez@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709028331; a=rsa-sha256; cv=none; b=x6jnZfqTjfZtpAeL56HpoGWm7e04wIKXFLjWFhafl+lIMy59NyhuFEimngt/ypoWghhDl5 C1mbnv6h6PLI/yDCTycHJOyUcy4Hi5sKnfaJmTOIOTrkRKvEND9nL9jePp8Pu3eD5Bnghi S3bLHGcyQYTI+LXWLBaVO+8zxa4627A= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="soi8/goX"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=oqhTd1iM; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="soi8/goX"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=oqhTd1iM; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf10.hostedemail.com: domain of clopez@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=clopez@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709028331; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3XXrMIze6Y72f4u2ysv6nK5J2tUBv4eD6P0fxLLqnrU=; b=iM2sLZOQEt/dDIuBYZ/32apt3wdjB0shJ1A6jSoRJ0dfRTgQ9bjhSUcnDf9ULOjjlEARgL 1ExWyf67iej/WLlHR+vNqUjSAJfFN8OGc8f7rtSKVAvUwIpok22/RGNi0IcKi6Kia5tXYZ mP/K9z82zplPp0kOZickAKPb4/GX7gY= Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [10.150.64.98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 2853E226E8; Tue, 27 Feb 2024 10:05:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1709028329; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3XXrMIze6Y72f4u2ysv6nK5J2tUBv4eD6P0fxLLqnrU=; b=soi8/goXCUpmlv19LLto6jAlcz8JoEvm1nZpGgqTSTtPbqneegXav+HzwbxK++hleQ9qCj 3k6rRD9ScpgXGEc76aF2PnpvxqqgNu3BOaYXNc7mqXUOKGqmHaQMHFCC9KBlog2uVCvWC3 /QfGbsbvbpNxNVi4ztfU9W6hGk0OshM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1709028329; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3XXrMIze6Y72f4u2ysv6nK5J2tUBv4eD6P0fxLLqnrU=; b=oqhTd1iMyjfXSwqjHSZv10e9xCjuScPkIxVR+BErjIYgTHsvgvdHni1yXcYrAS6McMvw+h JC4OhYkBuLdaFZAA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1709028329; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3XXrMIze6Y72f4u2ysv6nK5J2tUBv4eD6P0fxLLqnrU=; b=soi8/goXCUpmlv19LLto6jAlcz8JoEvm1nZpGgqTSTtPbqneegXav+HzwbxK++hleQ9qCj 3k6rRD9ScpgXGEc76aF2PnpvxqqgNu3BOaYXNc7mqXUOKGqmHaQMHFCC9KBlog2uVCvWC3 /QfGbsbvbpNxNVi4ztfU9W6hGk0OshM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1709028329; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3XXrMIze6Y72f4u2ysv6nK5J2tUBv4eD6P0fxLLqnrU=; b=oqhTd1iMyjfXSwqjHSZv10e9xCjuScPkIxVR+BErjIYgTHsvgvdHni1yXcYrAS6McMvw+h JC4OhYkBuLdaFZAA== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id 9943913216; Tue, 27 Feb 2024 10:05:27 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap2.dmz-prg2.suse.org with ESMTPSA id OsmhHeez3WWzOgAAn2gu4w (envelope-from ); Tue, 27 Feb 2024 10:05:27 +0000 Message-ID: Date: Tue, 27 Feb 2024 11:05:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/4] rust: uaccess: add userspace pointers Content-Language: en-US To: Alice Ryhl Cc: Greg Kroah-Hartman , =?UTF-8?Q?Arve_Hj=C3=B8nnev=C3=A5g?= , Todd Kjos , Martijn Coenen , Joel Fernandes , Carlos Llamas , Suren Baghdasaryan , Arnd Bergmann , linux-mm@kvack.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, Christian Brauner , Miguel Ojeda , Alex Gaynor , Wedson Almeida Filho , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Kees Cook , Al Viro , Andrew Morton References: <20240208-alice-mm-v2-0-d821250204a6@google.com> <20240208-alice-mm-v2-1-d821250204a6@google.com> From: =?UTF-8?Q?Carlos_L=C3=B3pez?= In-Reply-To: <20240208-alice-mm-v2-1-d821250204a6@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: CF8FBC0017 X-Stat-Signature: h3yy9ht3ad65djngqw7fk4mbcdzqkmmh X-HE-Tag: 1709028330-429333 X-HE-Meta: U2FsdGVkX19iXx3qRS7VMdpX84rUx2LdXHhjthjf1tdKPp7/lDrUP2ScB0JCztGEMMPFqOtPbxK6vet/FnxxZ4O6O6N2K+bfFD8M+QSLu0bOnHNAX8ot/znCIO3j2YD65WwXN6iS3wYEy9ejHir6My6HCsuqBrVNgFDSI5FEbnDFMH+TDnxM9+g5Q3xlRObR26tVwRiaE8EHa2vKhUbEcmY9gC6dMwFHUUhTJS68GLdUyiTfOxyuNiS6MK3usPZwSzx7QxHkPFjHYWplCjnwoyxUVOiL3VR35RBwAf5xbGUr+yGaf3O2NscCZz1+G0TrrdWbls3+L633b9dhG7VkiyjYidczL5XFq0tWr5vfVTYuu+RQX3SEfZFSBqXxO+tG5Da60M9/f90D/KwbXYmdLpe9Kg5IdrlKp+X7YPiPjIzHJDQ8qCgxH4X8I+caatupbnE5KCIGIzJgS8wS5h2YC86QIBdMNfX2TB5bK72M4jMdl9hHxt7EyHQZ20IswXxMIdwGqx+t0RvvUJbZW5LrY9NzAKkhEcSbrlUbQSUXY/uvRhHSw8/cbtj3IWQMNEWZNTAeXXC9EQ347KXTIgC43MB5WXFuLWYXdkEbUBWQXpmBnr46AAYqHsp+NAbXE0HquVbjDIvl+QjL5flhnP1gR3DQJSjUUQCJbP/8Fpy5y90qJjBPY4x1ZEmWt3838ek9If0AW81WCLsGraKFgj3hS7H7i5ZRCfzmKTmODaXiJcFU6hKF6WG93PjX50ynPzt/mEa+gEOEG6YnnCJYXBRGXJE64LeCMHR9fPnz82ckl1z24Roa2ZIQyOSz4WAr4BVV6boQ2GdMSCf1swUDF2z/wMRfDk+QsWYsmB522zD4IR69h2lgj8Nzbcszr7jhTdB038qht4UesNfjN4KYzCcKfocqwuhn4RtcfA60m/AaQBl04xHX2dRztZmGRdrj/WjQ6+3ZVzBpcvfg473L7zO IPGaTbQ3 rl2dOqbYnJhW9TFHAwt2RG7sy9C7zutttTMK+jVHRKLGihhH77d4BgxXmoRz5JCqBOfLgiP/2Iaf3R0pHkuk8DsLkQMwVZtB5DHy3azE/huWQmyueGwIwpk7dQXGcYjFkMuXZyPwEzw9tbAfl3zxEyefwD6d2mxzavbmSje7E7YSUp3Eo6wRWxfNyNVp0+TsfasjDPqKJjN0Ku5Yu6GEJ6vHhNCZrOHEj13InqfI95aJqwPGxS9rxOf/vdkfAeYHGUJYGhMDhaL/UJnEw0xIyt6/sExYEomgLBh7EsSEFxnQPI77pZ4TgOpWvMW/PDBwXFqYVT/uBnjiWO1iX3R8dYk4Ac7cY6XtvDcXEWTipCTZNrbNwpFDHv9RGQbWSJiexUfmBY+WKVrKt6vZuA/Spwe1ReiweoJd7Gzg3+EZEsbdBn4S6ZWbaC5AElg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 8/2/24 16:47, Alice Ryhl wrote: > + /// Create a reader that can access the same range of data. > + /// > + /// Reading from the clone does not advance the current reader. > + /// > + /// The caller should take care to not introduce TOCTOU issues, as described > + /// in the documentation for [`UserSlice`]. > + pub fn clone_reader(&self) -> UserSliceReader { > + UserSliceReader { > + ptr: self.ptr, > + length: self.length, > + } > + } Just out of curiosity, is there any reason why this is not implemented in terms of the Clone trait? -- Carlos López Security Engineer SUSE Software Solutions