From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10209EB64D9 for ; Tue, 27 Jun 2023 21:57:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 88D678D0003; Tue, 27 Jun 2023 17:57:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 83E0A8D0001; Tue, 27 Jun 2023 17:57:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6DE6A8D0003; Tue, 27 Jun 2023 17:57:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 5E1488D0001 for ; Tue, 27 Jun 2023 17:57:59 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 2124B160453 for ; Tue, 27 Jun 2023 21:57:59 +0000 (UTC) X-FDA: 80949891078.11.46449DA Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) by imf05.hostedemail.com (Postfix) with ESMTP id 25D8810000B for ; Tue, 27 Jun 2023 21:57:56 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=g+t5Rbdh; dmarc=none; spf=pass (imf05.hostedemail.com: domain of groeck7@gmail.com designates 209.85.210.173 as permitted sender) smtp.mailfrom=groeck7@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687903077; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=t1QqN2jdF+WL3G2Fn2F+gnSyyU4sNUKe3JWXuNtILlE=; b=g3xMDblnGlupYcD8LlX3/yk3+MAgJXpsmB+3gGUm4abOYC9KK/lPzEBneXrG39r1s0eF19 ZRigXDsNpA74P7SMkeVjQ5vKW022GeAq/41/ezMWxtJy3uzpP9WPiC/HdomKwUTiKKab7g dfV24sXNIU9Xjn0Plxo8jwLLTZkGOys= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=g+t5Rbdh; dmarc=none; spf=pass (imf05.hostedemail.com: domain of groeck7@gmail.com designates 209.85.210.173 as permitted sender) smtp.mailfrom=groeck7@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687903077; a=rsa-sha256; cv=none; b=g4csDzuZDYSKpQ7I14ZTlDfeEyA9a2gcX3PfF7fPnIbvzDxhmKuZfCyeFU2FvUnTFDlGVD hdZkOdoSY+QE8QqgioGJgCcnO6rV9QN1bY5YPuHrNkS+JK34I5jwWmhx37MMRSTnJfgc5t PDsQrH9OWI663eGKfY15b081nTxU0oM= Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-66c729f5618so3540538b3a.1 for ; Tue, 27 Jun 2023 14:57:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687903076; x=1690495076; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=t1QqN2jdF+WL3G2Fn2F+gnSyyU4sNUKe3JWXuNtILlE=; b=g+t5RbdhRiaLoYyDKYrUABIe+H7AyRcVTK6Ps8KX11dLH3rVyHHxTIp4jo1F1MLfJ/ 7iNHUg8lMtHSGaBwqfjHucjm6wwc/jl78+I2QtBt+NVF52zFOTO8iGbXC2EXZcfaizxp syPg/dBUX2hToZvcUTpD+czYfrRw5crN2vey7CoePIDlxvhbRn4jKEtVasFgYbYadRKT uIII/cayZYqptv+yRMmyM+Wfpd5/UPoabOL1LFJ6elItbp/e6VHQDna35ucIS9DgJdAS QwUA3GiJRf5dQk/OTJ3hXfUBDFz7VSwh76MedBtdvOPKN3bvoe9PwVVR6Es4OllczpXD WRDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687903076; x=1690495076; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=t1QqN2jdF+WL3G2Fn2F+gnSyyU4sNUKe3JWXuNtILlE=; b=d3U+ja0BaIynrfX24zTpH2ntqO57sWH6YwVQ3LFII0hP+BkzpdkekdMxN7zZawboNN ZVYSFCnGz5Xa8Stlno0UKcjP5rQCgJQglPdSsj4V5A803nEeapPsIaiODsSyM7VopeND h2hm+VGahgI9oRdBBwXhLxRdBbzOQT+HS91q/Mdn61exn9/kV+PxhMfV+//EHPqPrkwb wM4HjIO1guHZAi0MH5vp97oLj8H6wYj6gyMcRP9LswafvOJi9RoDHdl+R8g9KUJumIk9 5mB7b0xpfUDB7gYqUIL98CW9K3U7NYTVmHL5TaGf9bJbyBEloKx8WPpPjReq+DTSQRL2 xfhw== X-Gm-Message-State: AC+VfDwwnkgG1n6DQ3MblP27yEFh8PtnntR/yuExISclJr8FBUWUeCQ5 3buzgN9eyXU8+SHU5C6yb54= X-Google-Smtp-Source: ACHHUZ6lN48OedTSkLTDBhYcXWegZDranrwbL7k9xhFTjM3m37Ei4jw/mCpSF8qmoSte/cwaCNHhUw== X-Received: by 2002:a17:902:c407:b0:1ac:8717:d436 with SMTP id k7-20020a170902c40700b001ac8717d436mr14008978plk.60.1687903075769; Tue, 27 Jun 2023 14:57:55 -0700 (PDT) Received: from ?IPV6:2600:1700:e321:62f0:329c:23ff:fee3:9d7c? ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id e16-20020a17090301d000b001b69303db65sm6438851plh.26.2023.06.27.14.57.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Jun 2023 14:57:55 -0700 (PDT) Message-ID: Date: Tue, 27 Jun 2023 14:57:52 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v5 26/33] nios2: Convert __pte_free_tlb() to use ptdescs Content-Language: en-US To: Dinh Nguyen , Vishal Moola Cc: Andrew Morton , Matthew Wilcox , linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, Hugh Dickins , Mike Rapoport , Stephen Rothwell References: <20230622205745.79707-1-vishal.moola@gmail.com> <20230622205745.79707-27-vishal.moola@gmail.com> <13bab37c-0f0a-431a-8b67-4379bf4dc541@roeck-us.net> <2b7e8b1d-1697-6a25-434d-352f95e6fff2@roeck-us.net> <70776142-a778-9c20-5594-835ed6f7e7a2@kernel.org> From: Guenter Roeck In-Reply-To: <70776142-a778-9c20-5594-835ed6f7e7a2@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 25D8810000B X-Stat-Signature: 765x8pzmmwe96fupdjwjxyigurwypn8a X-HE-Tag: 1687903076-148969 X-HE-Meta: U2FsdGVkX19CujcdgMFbkqz5QN1nATmBkPUzB9317v/NcUvm3nLZCC7vc580BhQ24Ei7uiNm0auR2CuQN61h6NURNnt+sEu1hucLH5iDp1CQ75RATf3X7Kng4dp5ayGuYWRdf1HSUx9WVS4ULM0SDP6c6ug+yHSEUbZdD34cUBNG1PzzwGrlB/JWkaDlJNMo571neoomCngfSnQm0cgJ5RQ0lOk3ERMddaXaku3RBIzotCM57Tk/PzSFrowhw06Z5sCczU/b8DZjts+r4RwEZ3MsLq4/BdjCFSNmlo2Iujar9LskzqdqUetSa8IVul6IoF0Q2PGGxApskZXqIhlO7AjKuU8+2wZZKdGtFVWE6poFN7r0fjzz/fpbETI1G4+HogqWC3cTROg5+jfNy7xNCE3AES3WBRqnCwoYyMKhnk0wyg9kufVCIBrNUXSJAxqmvqyghd3Ui3pQWKQjXcK98obz1DqC9umBEVugWpB3c8s2gpEDe7mh/opOg1t/ikYUOk+ONY8885HnovIzm4YWzGxzn6wdYG0+DTqyHdjWdmfNhYps5qKBUWcNTEARy17d5U2eIGAoq9BSfpdEcf1qBV9A6pm35D7Qz1tjfW4kLNUHbcpCTIluB0sBWn6UVIlIwGnAVl1opmieufGaffutllHmneReBL/y4z92cRhv2QR5HSiIkq1gIMDgaJBlzDN7e4uq0+U4BKQxV38bK27ygUqI0d9Vw8Zay2LMtHY9fXlL+W6LqNnscU9i0919YoVz1C9ACr1UIIOJ7MVwDle2E4vMI1/kPxgQdujW5qb9b0eiuyhPM3KjBPeSoT+yzWTeCQ7RRd2D8hn0Wgz2UgACJR1MisKyGoNgYfBA5bhUkNj8Fe1uiNL5DtlPJp0Urv74VuARuALfWvLIx8DPwVKQHMbq3f0Bmd5mTlyO0wir04/S/gCdm2V5rLDAdUtp8F+OTzGYI4eIYpleSMYrIWa d0451KJs seSfBjpe9LMyGlzsJ7FzBJIZsoxXYQYQ8zk5rnOuVW8yBfQQSUiXCI5BVVtTP7Qqn6TgggF7m5LE3TbsyDKicIHa6mWwnNpnAnrwmMzIJGgp8eZkLWVIfmPcJPvVo1Hh0VFzZxlMeItsefDMcB1tM6698+tARO8CYu4S+t3pT+FoZpYGnVDBJstYV2E1iUB/kFIJr236sP3VHG3OpwLs3cdE42v1R4aSN+E8/lPpUNXB4m+eLMl/e/iRriA/7ejsHGqp8wQqAqSb0mdNJelfmw7PjgbycErlWR7VWVfpSeZgM9J5ICuOJo+ya+ROE1i5fH5Mgk/uUmujT/snoYiL3wsUGguM9nnQLWC+Fp3lLPUGkuWVqkAt0biBaW8tBt2EKOyWo0SqlZecHSHzgl4zmkXSuzVb/Af8xulGEvjILobNAKNaTfgFL1ljn0WpehHsNbnrqAAzcCvgo7/yaM41rsy9a+UUUCm1uvn/RUNbSJGdzSQXLWAOeimD5eo0UsAPi8P40L4kgC9xBdN0F9EnbIEhmyHkJaTRSJQ2u6W3tXzxSO6qtnuYKbF0FpFUNQ0q2qEDWdsQIdobECY151E7qtwqt8Q+bs69T+yzZ1H3gOnOTuZ76imHuDoMeb7ZxnilRXNgEVvUXMxQxq3WPEKyUNyu54utPxagHPSHJUEJyR7oCl0oMDw4GDdFKuGl3GO6XqBY/dBqyC1ss23z55Qr5jgxN27MqWmsWgNAQ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 6/27/23 14:46, Dinh Nguyen wrote: > > > On 6/27/23 16:01, Guenter Roeck wrote: >> On 6/27/23 13:05, Dinh Nguyen wrote: >>> >>> >>> On 6/27/23 14:56, Vishal Moola wrote: >>>> On Tue, Jun 27, 2023 at 12:14 PM Guenter Roeck wrote: >>>>> >>>>> On 6/27/23 12:10, Guenter Roeck wrote: >>>>>> On 6/27/23 10:42, Vishal Moola wrote: >>>>>>> On Mon, Jun 26, 2023 at 10:47 PM Guenter Roeck wrote: >>>>>>>> >>>>>>>> On Thu, Jun 22, 2023 at 01:57:38PM -0700, Vishal Moola (Oracle) wrote: >>>>>>>>> Part of the conversions to replace pgtable constructor/destructors with >>>>>>>>> ptdesc equivalents. >>>>>>>>> >>>>>>>>> Signed-off-by: Vishal Moola (Oracle) >>>>>>>>> Acked-by: Mike Rapoport (IBM) >>>>>>>> >>>>>>>> This patch causes all nios2 builds to fail. >>>>>>> >>>>>>> It looks like you tried to apply this patch on its own. This patch depends >>>>>>> on patches 01-12 of this patchset to compile properly. I've cross-compiled >>>>>>> this architecture and it worked, but let me know if something fails >>>>>>> when its applied on top of those patches (or the rest of the patchset). >>>>>> >>>>>> >>>>>> No, I did not try to apply this patch on its own. I tried to build yesterday's >>>>>> pending-fixes branch of linux-next. >>>>>> >>>>> >>>>> A quick check shows that the build fails with next-20230627. See log below. >>>> >>>> Ah it looks like this one slipped into -next on its own somehow? Stephen, please >>>> drop this patch from -next; it shouldn't be in without the rest of the >>>> patchset which >>>> I intend to have Andrew take through the mm tree. >>>> >>> >>> I apologize, but I queue this patch up for Linus and it's been pulled for this merge window. I didn't realize you were going to take this patchset through another tree. >>> >>> Sorry about that. >>> >> >> Yes, indeed, I just confirmed that all nios2 builds in the mainline kernel >> are now broken. >> > > Please let me know if you need to do anything. I'm going to out for a week starting tomorrow. > Not sure I understand. It seems to me that it would have to be you to do something. After all, you are the nios2 maintainer, and nios2 builds in mainline are now broken. Maybe send a revert ? Am I missing something ? Guenter