Re: [PATCH v7 2/2] mm/memory hotplug/unplug: Optimize zone->contiguous update when changes pfn range

["David Hildenbrand (Red Hat)" <david@kernel.org>]

>>
>> This is nasty. I would wish we could just leave that code path alone.
>>
>> In particular: I am 99% sure that we never ever run into this case in
>> practice.
>>
>> E.g., on x86, we can have up to 2 GiB memory blocks. But the memmap of
>> that is 64/4096*2GiB == 32 MB ... and a memory section is 128 MiB.
>>
>>
>> As commented on patch #1, we should drop the set_zone_contiguous() in
>> this function either way and let online_pages() deal with it.
>>
>> We just have to make sure that we don't create some inconsistencies by
>> doing that.
>>
>> Can you double-check?

I thought about this some more, and it's all a bit nasty. We have to get this right.

Losing the optimization for memmap_on_memory users indicates that we are doing the wrong thing.

You could introduce the set_zone_contiguous() in this patch here. But then, I think instead of

+	/*
+	 * If the allocated memmap pages are not in a full section, keep the
+	 * contiguous state as ZONE_CONTIG_NO.
+	 */
+	if (IS_ALIGNED(end_pfn, PAGES_PER_SECTION))
+		new_contiguous_state = zone_contig_state_after_growing(zone,
+								pfn, nr_pages);
+

We'd actually unconditionally have to do that, no?

-- 
Cheers

David