From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6857FC433EF for ; Wed, 2 Feb 2022 17:01:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E834F8D0113; Wed, 2 Feb 2022 12:01:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E32216B036A; Wed, 2 Feb 2022 12:01:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CD33C8D0113; Wed, 2 Feb 2022 12:01:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0237.hostedemail.com [216.40.44.237]) by kanga.kvack.org (Postfix) with ESMTP id BD6E16B0369 for ; Wed, 2 Feb 2022 12:01:58 -0500 (EST) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 729341813ABB1 for ; Wed, 2 Feb 2022 17:01:58 +0000 (UTC) X-FDA: 79098457116.27.C2A4939 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf27.hostedemail.com (Postfix) with ESMTP id E56F14000D for ; Wed, 2 Feb 2022 17:01:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643821317; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D25YjSr7KJ4sxl/Zh1uNR8s2aJGVWxQUiTzrhOO5QZM=; b=PAVhHaIeZOhKBB05nYseW9KX8s4Xcttj3rIYWtkFPk4LbEo02+fAIusZ0Dj/HpEl35oDJ0 fVa2cPPrGsrAiEJDv80OOPm1PR6cEC98P5Iq4b1W/ssIOnA9gYW5vVmK8X7OYIRpLJOwx/ /OrA/zDc3HPjJFDfLCVCqMPFuzcpODA= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-466-g1WaUgOlMuGlz8ja9ZVUtw-1; Wed, 02 Feb 2022 12:01:56 -0500 X-MC-Unique: g1WaUgOlMuGlz8ja9ZVUtw-1 Received: by mail-wm1-f69.google.com with SMTP id m3-20020a7bcb83000000b0034f75d92f27so18679wmi.2 for ; Wed, 02 Feb 2022 09:01:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=D25YjSr7KJ4sxl/Zh1uNR8s2aJGVWxQUiTzrhOO5QZM=; b=u2JAF6Gkh9VG4ILNr4lrR7VqwZ0cl6fgzoQ0grHQNo40M3UIVGU1z8GacvN3TTZdd+ Rgo37OXP/SbFK8RRw8bwkWXGzchZygHyIDlsnY0HaTc/ZlQDg9p1bLm7vNTAwqnEORwW Uyqdqef+1pW2Yj9BUXXvbCDwnDhsw0YLft3yGygA/pWihwNSYVd0tVFCr66uPcX3i1m3 /y2eTwSpYtshSmXa7yxNNRn1YwGTnv1FV4kYLEnM59tHJ0uO/BYgAFVScn/8x8cOzyob ZaqOWyXv7BW3fEt1C1LOthBxKBmL80CGNjm5sG6WkVPcHtuYqcgYLWlRqUbyEUpzz/kO xm0w== X-Gm-Message-State: AOAM533g+Q291Stx0XJvF/hrXbuXSbQBnG653epjRJ94FqFZZE0haQz2 aJ1W+PsTUhUuQxE207Fjgy4YtyJVGv9RTAxT9X4gvl5axd3xKHNrjcsGZ2u8wWaExOauC6+qtzG qzwfnve7Q3TI= X-Received: by 2002:adf:f8c6:: with SMTP id f6mr26089519wrq.290.1643821315077; Wed, 02 Feb 2022 09:01:55 -0800 (PST) X-Google-Smtp-Source: ABdhPJyBUnBUSnsyQiXftcnch1RhXBPr4CAoPeFm5KDXx4DpxbNsCZ64xkm+qIkPtlCiPBMMG4kedw== X-Received: by 2002:adf:f8c6:: with SMTP id f6mr26089483wrq.290.1643821314779; Wed, 02 Feb 2022 09:01:54 -0800 (PST) Received: from ?IPV6:2003:d8:2f11:9700:838c:3860:6500:5284? (p200300d82f119700838c386065005284.dip0.t-ipconnect.de. [2003:d8:2f11:9700:838c:3860:6500:5284]) by smtp.gmail.com with ESMTPSA id n5sm5957602wmq.43.2022.02.02.09.01.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Feb 2022 09:01:54 -0800 (PST) Message-ID: Date: Wed, 2 Feb 2022 18:01:51 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH v3 7/9] mm/swapfile: remove stale reuse_swap_page() To: Christoph Hellwig Cc: linux-kernel@vger.kernel.org, Andrew Morton , Hugh Dickins , Linus Torvalds , David Rientjes , Shakeel Butt , John Hubbard , Jason Gunthorpe , Mike Kravetz , Mike Rapoport , Yang Shi , "Kirill A . Shutemov" , Matthew Wilcox , Vlastimil Babka , Jann Horn , Michal Hocko , Nadav Amit , Rik van Riel , Roman Gushchin , Andrea Arcangeli , Peter Xu , Donald Dutile , Oleg Nesterov , Jan Kara , Liang Zhang , linux-mm@kvack.org References: <20220131162940.210846-1-david@redhat.com> <20220131162940.210846-8-david@redhat.com> <20220202143549.GA24789@lst.de> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220202143549.GA24789@lst.de> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: 87eyidtao41ismgobmcw7kj5gdrd3ysw X-Rspam-User: nil Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=PAVhHaIe; spf=none (imf27.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: E56F14000D X-HE-Tag: 1643821317-638828 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 02.02.22 15:35, Christoph Hellwig wrote: > On Mon, Jan 31, 2022 at 05:29:37PM +0100, David Hildenbrand wrote: >> All users are gone, let's remove it. We'll let SWP_STABLE_WRITES stick >> around for now, as it might come in handy in the near future. > > I don't think leaving a flag that has no user an a completely trivial > place to set it around is a good idea. This is a classic case of > bitrot. Right now I'm planning on using it in part 2 -- on which I'm currently working on. If I don't end up reusing it, I'll remember to remove it. -- Thanks, David / dhildenb