From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB899C4345F for ; Sat, 13 Apr 2024 20:57:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BF6B16B0092; Sat, 13 Apr 2024 16:57:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BA7266B0093; Sat, 13 Apr 2024 16:57:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A6E8C6B0095; Sat, 13 Apr 2024 16:57:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 894D26B0092 for ; Sat, 13 Apr 2024 16:57:06 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 448771A0158 for ; Sat, 13 Apr 2024 20:57:06 +0000 (UTC) X-FDA: 82005718452.18.51263A1 Received: from vps-vb.mhejs.net (vps-vb.mhejs.net [37.28.154.113]) by imf20.hostedemail.com (Postfix) with ESMTP id B26CF1C0003 for ; Sat, 13 Apr 2024 20:57:03 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=none; spf=pass (imf20.hostedemail.com: domain of mail@maciej.szmigiero.name designates 37.28.154.113 as permitted sender) smtp.mailfrom=mail@maciej.szmigiero.name; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713041824; a=rsa-sha256; cv=none; b=edt4RlSxhqwy/OpD1LUPJV7r3fX4/nrPM4D9qlhGK+nMfhg1Na6HQz30dj1AOr7S0BXjDp 9BzyaM78qnca6UjnJ9B6lewzymcSqLrcVlYfpnJjpNmUusqgCTkdvwzRG0LDFwBZ8HxuQo lwmbBhzYoD30ZISx/xdxGksCjPGzT3E= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=none; spf=pass (imf20.hostedemail.com: domain of mail@maciej.szmigiero.name designates 37.28.154.113 as permitted sender) smtp.mailfrom=mail@maciej.szmigiero.name; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713041824; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QkYl8sOuS5TbzoiwFY3N6fRBDOmCwOGgkhqME+3IL9I=; b=PqYeY4KUjqgNFUXCBL3qO+2QYg7RmTlqZ7ZpXgQKKSGP5ZSN4h3I2o95VUQzXjjmoScNiL eq44xBCuHJOjPylASSoOMo44AIK7rFFD5Q2GE0wiHrRKTWKxJkxGjY2Ld6prdw218fz3FZ frMSWcCLCWyXuHDh86wR8bV+V8qX6B4= Received: from MUA by vps-vb.mhejs.net with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1rvkQf-0007CL-KT; Sat, 13 Apr 2024 22:56:53 +0200 Message-ID: Date: Sat, 13 Apr 2024 22:56:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 4/4] mm: zswap: remove same_filled module params Content-Language: en-US, pl-PL To: Yosry Ahmed Cc: Johannes Weiner , Andrew Morton , Nhat Pham , Chengming Zhou , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240413022407.785696-1-yosryahmed@google.com> <20240413022407.785696-5-yosryahmed@google.com> From: "Maciej S. Szmigiero" Autocrypt: addr=mail@maciej.szmigiero.name; keydata= xsFNBFpGusUBEADXUMM2t7y9sHhI79+2QUnDdpauIBjZDukPZArwD+sDlx5P+jxaZ13XjUQc 6oJdk+jpvKiyzlbKqlDtw/Y2Ob24tg1g/zvkHn8AVUwX+ZWWewSZ0vcwp7u/LvA+w2nJbIL1 N0/QUUdmxfkWTHhNqgkNX5hEmYqhwUPozFR0zblfD/6+XFR7VM9yT0fZPLqYLNOmGfqAXlxY m8nWmi+lxkd/PYqQQwOq6GQwxjRFEvSc09m/YPYo9hxh7a6s8hAP88YOf2PD8oBB1r5E7KGb Fv10Qss4CU/3zaiyRTExWwOJnTQdzSbtnM3S8/ZO/sL0FY/b4VLtlZzERAraxHdnPn8GgxYk oPtAqoyf52RkCabL9dsXPWYQjkwG8WEUPScHDy8Uoo6imQujshG23A99iPuXcWc/5ld9mIo/ Ee7kN50MOXwS4vCJSv0cMkVhh77CmGUv5++E/rPcbXPLTPeRVy6SHgdDhIj7elmx2Lgo0cyh uyxyBKSuzPvb61nh5EKAGL7kPqflNw7LJkInzHqKHDNu57rVuCHEx4yxcKNB4pdE2SgyPxs9 9W7Cz0q2Hd7Yu8GOXvMfQfrBiEV4q4PzidUtV6sLqVq0RMK7LEi0RiZpthwxz0IUFwRw2KS/ 9Kgs9LmOXYimodrV0pMxpVqcyTepmDSoWzyXNP2NL1+GuQtaTQARAQABzTBNYWNpZWogUy4g U3ptaWdpZXJvIDxtYWlsQG1hY2llai5zem1pZ2llcm8ubmFtZT7CwZQEEwEIAD4CGwMFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AWIQRyeg1N257Z9gOb7O+Ef143kM4JdwUCZdEV4gUJDWuO nQAKCRCEf143kM4JdyzED/0Qwk2KVsyNwEukYK2zbJPHp7CRbXcpCApgocVwtmdabAubtHej 7owLq89ibmkKT0gJxc6OfJJeo/PWTJ/Qo/+db48Y7y03Xl+rTbFyzsoTyZgdR21FQGdgNRG9 3ACPDpZ0UlEwA4VdGT+HKfu0X8pVb0G0D44DjIeHC7lBRzzE5JXJUGUVUd2FiyUqMFqZ8xP3 wp53ekB5p5OstceqyZIq+O/r1pTgGErZ1No80JrnVC/psJpmMpw1Q56t88JMaHIe+Gcnm8fB k3LyWNr7gUwVOus8TbkP3TOx/BdS/DqkjN3GvXauhVXfGsasmHHWEFBE0ijNZi/tD63ZILRY wUpRVRU2F0UqI+cJvbeG3c+RZ7jqMAAZj8NB8w6iviX1XG3amlbJgiyElxap6Za1SQ3hfTWf c6gYzgaNOFRh77PQbzP9BcAVDeinOqXg2IkjWQ89o0YVFKXiaDHKw7VVld3kz2FQMI8PGfyn zg5vyd9id1ykISCQQUQ4Nw49tqYoSomLdmIgPSfXDDMOvoDoENWDXPiMGOgDS2KbqRNYCNy5 KGQngJZNuDicDBs4r/FGt9/xg2uf8M5lU5b8vC78075c4DWiKgdqaIhqhSC+n+qcHX0bAl1L me9DMNm0NtsVw+mk65d7cwxHmYXKEGgzBcbVMa5C+Yevv+0GPkkwccIvps7AzQRaRrwiAQwA xnVmJqeP9VUTISps+WbyYFYlMFfIurl7tzK74bc67KUBp+PHuDP9p4ZcJUGC3UZJP85/GlUV dE1NairYWEJQUB7bpogTuzMI825QXIB9z842HwWfP2RW5eDtJMeujzJeFaUpmeTG9snzaYxY N3r0TDKj5dZwSIThIMQpsmhH2zylkT0jH7kBPxb8IkCQ1c6wgKITwoHFjTIO0B75U7bBNSDp XUaUDvd6T3xd1Fz57ujAvKHrZfWtaNSGwLmUYQAcFvrKDGPB5Z3ggkiTtkmW3OCQbnIxGJJw /+HefYhB5/kCcpKUQ2RYcYgCZ0/WcES1xU5dnNe4i0a5gsOFSOYCpNCfTHttVxKxZZTQ/rxj XwTuToXmTI4Nehn96t25DHZ0t9L9UEJ0yxH2y8Av4rtf75K2yAXFZa8dHnQgCkyjA/gs0ujG wD+Gs7dYQxP4i+rLhwBWD3mawJxLxY0vGwkG7k7npqanlsWlATHpOdqBMUiAR22hs02FikAo iXNgWTy7ABEBAAHCwXwEGAEIACYCGwwWIQRyeg1N257Z9gOb7O+Ef143kM4JdwUCZdEWBwUJ DWuNXAAKCRCEf143kM4Jd5OdD/0UXMpMd4eDWvtBBQkoOcz2SqsWwMj+vKPJS0BZ33MV/wXT PaTbzAFy23/JXbyBPcb0qgILCmoimBNiXDzYBfcwIoc9ycNwCMBBN47Jxwb8ES5ukFutjS4q +tPcjbPYu+hc9qzodl1vjAhaWjgqY6IzDGe4BAmM+L6UUID4Vr46PPN02bpm4UsL31J6X+lA Vj5WbY501vKMvTAiF1dg7RkHPX7ZVa0u7BPLjBLqu6NixNkpSRts8L9G4QDpIGVO7sOC9oOU 2h99VYY1qKml0qJ9SdTwtDj+Yxz+BqW7O4nHLsc4FEIjILjwF71ZKY/dlTWDEwDl5AJR7bhy HXomkWae2nBTzmWgIf9fJ2ghuCIjdKKwOFkDbFUkSs8HjrWymvMM22PHLTTGFx+0QbjOstEh 9i56FZj3DoOEfVKvoyurU86/4sxjIbyhqL6ZiTzuZAmB0RICOIGilm5x03ESkDztiuCtQL2u xNT833IQSNqyuEnxG9/M82yYa+9ClBiRKM2JyvgnBEbiWA15rAQkOqZGJfFJ3bmTFePx4R/I ZVehUxCRY5IS1FLe16tymf9lCASrPXnkO2+hkHpBCwt75wnccS3DwtIGqwagVVmciCxAFg9E WZ4dI5B0IUziKtBxgwJG4xY5rp7WbzywjCeaaKubtcLQ9bSBkkK4U8Fu58g6Hg== In-Reply-To: <20240413022407.785696-5-yosryahmed@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: B26CF1C0003 X-Stat-Signature: qnito7h8tj4k5u6xqwkmwihufo1f9umr X-HE-Tag: 1713041823-220094 X-HE-Meta: U2FsdGVkX19OLA9igkqAURBHQQ9p8+EbbshZ6wUgXJ9WhXqstmmlQxkD4UnA16w0FNcfBc6Ppkj+hgdGkQYJVABxuqpvAh48cHV58F3fgJuDVR68D8vME5E1mbXUFNyqCP0Z9PlhK+8LbgnlFXFH2L7/R+UDqQkccpoOZAIQ68kEKHQ+lP7n6mjHit6RLayh+Eo5NBMpz0SlWnZSyAs2CDeEAsaj3GlYk6N2TMzkLSIkB/c1xhOr+ZVEUnFgtb/Ix8UuOmLJlmQBLukybXwFdW/yILeKDHNWcte9XKswDPHkYuW16ZwqOCrgIsbz57G9TyG8DORWGS+5sh2qUcZR+j9aYCuJFH1/YIe7u4j9i/VH1f+D/5UXavsCruJfylh/PTtkDhyfMDZP4lPRsxktuAm57HPyQ0yV1uHq3ljCCkWFY2yByA7TqgE8wXvJ5gapGL+4SZzcEwkFWPAheMEyPVK2HGpc4W0Pso9hvxNWyVVKOkAbfXqxhR+xq4xB7rTB3lX9jYdAZ+K6BnODJqWpNngoQAL4eWbQFT0UR1rfQpBodDcHoKEZ0cOUD6Kezy5gNhCmGnAjZUoa12huLtT6VOLOWh3CpSo+xBC4DWDYJBQIUerL0NNtL5loZJ23dop1zNnwGswGBHiYZtG5VykJNtJ/cjifkkXqntWixytdYDOeBEDmBISs00zBVESg0Pyerv9oycDmtSwgLTwqF3/hE14V2XOfKwMxqxFzzkNXAYicTRdZHALtCnPczoe26FbCGsfWM5MZEd4I0U/RuVMdRHTKCuO3yroRAuJmKHJGTT5L9l18rKe77BW7jc6UQNcg X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 13.04.2024 04:24, Yosry Ahmed wrote: > These knobs offer more fine-grained control to userspace than needed and > directly expose/influence kernel implementation; remove them. > > For disabling same_filled handling, there is no logical reason to refuse > storing same-filled pages more efficiently and opt for compression. > Scanning pages for patterns may be an argument, but the page contents > will be read into the CPU cache anyway during compression. Also, > removing the same_filled handling code does not move the needle > significantly in terms of performance anyway [1]. > > For disabling non_same_filled handling, it was added when the compressed > pages in zswap were not being properly charged to memcgs, as workloads > could escape the accounting with compression [2]. This is no longer the > case after commit f4840ccfca25 ("zswap: memcg accounting"), and using > zswap without compression does not make much sense. > > [1]https://lore.kernel.org/lkml/CAJD7tkaySFP2hBQw4pnZHJJwe3bMdjJ1t9VC2VJd=khn1_TXvA@mail.gmail.com/ > [2]https://lore.kernel.org/lkml/19d5cdee-2868-41bd-83d5-6da75d72e940@maciej.szmigiero.name/ > > Cc: "Maciej S. Szmigiero" > Signed-off-by: Yosry Ahmed > Acked-by: Johannes Weiner > Reviewed-by: Nhat Pham > Reviewed-by: Chengming Zhou > --- I think you need to update zswap kernel docs, too. Thanks, Maciej