From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB1DCC71136 for ; Fri, 13 Jun 2025 20:12:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 508126B0098; Fri, 13 Jun 2025 16:12:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4DFB26B0099; Fri, 13 Jun 2025 16:12:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3F5A86B009A; Fri, 13 Jun 2025 16:12:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 2597C6B0098 for ; Fri, 13 Jun 2025 16:12:42 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 9648B121130 for ; Fri, 13 Jun 2025 20:12:41 +0000 (UTC) X-FDA: 83551475322.03.6CC44A1 Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) by imf18.hostedemail.com (Postfix) with ESMTP id 8E1C91C0009 for ; Fri, 13 Jun 2025 20:12:39 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=neon.tech header.s=google header.b=Z82fE3vU; spf=pass (imf18.hostedemail.com: domain of sharnoff@neon.tech designates 209.85.208.49 as permitted sender) smtp.mailfrom=sharnoff@neon.tech; dmarc=pass (policy=reject) header.from=neon.tech ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749845559; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NweKF8SVH3injbfSiS2fNVqMZQ6C6K10QpkWTAAVIKo=; b=SLaDroevQQWIPJtYVTzqt6QhVVdlDOd3CUMaP8fOKwsGzfSaqtDl+fP5D25tMyLFixrpm/ 1DZoLhzdnnaHtgxOd1N0wOXoNCfPPi9/F5XOvm3jVj09EuKYBlyJruVrlJHsckklz2uNR+ JObF9qWryTMkMPnZlJ3o8iwTtaTbHBo= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=neon.tech header.s=google header.b=Z82fE3vU; spf=pass (imf18.hostedemail.com: domain of sharnoff@neon.tech designates 209.85.208.49 as permitted sender) smtp.mailfrom=sharnoff@neon.tech; dmarc=pass (policy=reject) header.from=neon.tech ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749845559; a=rsa-sha256; cv=none; b=t9+8jawrex/0q/xKsgoqo07u/YG2dLkaKnHNbTsKZ4Ti2h3nVR9bFoud7hcsB+J+eAMYvL ohFnKw7XKm86dzu/JDQhDQhffWQBodcLq9XZ0He9P05jbtiT0zHgCadbfiVAfg0vkcf+J9 gGK2evmLYqevpH/I82cp4aXdtbVqREI= Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-607b59b447bso4388712a12.1 for ; Fri, 13 Jun 2025 13:12:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=neon.tech; s=google; t=1749845558; x=1750450358; darn=kvack.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=NweKF8SVH3injbfSiS2fNVqMZQ6C6K10QpkWTAAVIKo=; b=Z82fE3vUhcGJvGYnPjGCcnMdS75pFMdqqCj3M0lAsLnTaql365JhESM6mwd7RS1qT3 8pO8qE8s+pTKgwE9YgeDgjECPxUMoJu1UkWbDaaBv/yQ6KSZ+TJpX1HSkfG7rT6KhYvt 5bBoLzOPkeVCRGreOD9KeyJ3NcOT2NLEvu5es= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749845558; x=1750450358; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NweKF8SVH3injbfSiS2fNVqMZQ6C6K10QpkWTAAVIKo=; b=RHm9SOqSbWZILe/QrDOT6n+Qo47GLX9g5OFbeJDd7BwRxQnDSIE247DXbmhU3/dI8C y8uM+QFiceufwIWE/y44PdC8QMPlvmNrTopjSssCx34QPIDKVkzPhrcvVP6NjGc6awAb hqJ4WyaMr50lBaSV70JsTyaDiBbCQlmDOQVRCV8z58dZG6tEcevTQjAn0TjzzZ22lxAx RlmwYcj4APVFMUEMHfdzY8PgBM5FHI3IZOREMiSIfLtiS1o+znSdNTwdCykM4qJx3oNR LmvmjT4YS6l5GKXVAXeaEPwULAz/2p+XrR4ydFmrb27K1fyxvWiiBUnFezjLCJwEMUOS 6bsw== X-Forwarded-Encrypted: i=1; AJvYcCVMZKwm5DCdiC4bmJWQfVpjeBb9oxmXLH6SVNLn+g0XUV43TyLvvg8BEyDcb2Q7Ttc+TGEMV8sRqQ==@kvack.org X-Gm-Message-State: AOJu0YwWDz2Hsrb5ANpvX/gfMdtISkoevEV0uQwp3RkCAq4LhJZx6Qfp 4J9Xxi2wd/5khaSQWZMAcL68njE/D7U3rUdp7nUIIs7ZcdtnsTm3d6DNXM0uzozon/I= X-Gm-Gg: ASbGncuq/BFbaQNqWvdy+UKjajleOXpjjnslIfa9STO07tvahPOkWSjiqbjMhLvNFmq 4uBnjg0knmb8byI8bGoL0mD9ycyxxI4O+kkeCgCXT445E2e74xpRdAYiHsLUwELDuwNFS2X7vjN YQkb43XebJDER1GWJLfR2Wxu2rn1s0oQ14p8YsDSWj1LsmReWFQo4SEhlLOSr8iAYM94vT5OtrP n2XcNYSPl6fJHlw8vZH6sIbBT0GnDpZ4reidVQ23eKxDw2+pXDcOKDGQkW080hZ5SGOXwOujTNw pKbcr/HOTkKW3BrPNE15N7Zj6u8rIRp+Zk7f7lDFugIvaXz0OBrGfb8Can+IyekOeQ== X-Google-Smtp-Source: AGHT+IHZOIdE98Xx/meIwe4RQMdXHRB+vSVgcGbiS6IiDa0l13qNjjNb8DTbd8V27rMfCiXEpAIELg== X-Received: by 2002:a05:6402:d0b:b0:607:3344:6ef1 with SMTP id 4fb4d7f45d1cf-608d0979c1emr379552a12.29.1749845557982; Fri, 13 Jun 2025 13:12:37 -0700 (PDT) Received: from [192.168.86.142] ([84.65.228.220]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-608b48a8bf8sm1640985a12.11.2025.06.13.13.12.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Jun 2025 13:12:37 -0700 (PDT) Message-ID: Date: Fri, 13 Jun 2025 21:12:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v4 4/4] x86/mm: Use GFP_KERNEL for alloc_low_pages() after boot From: Em Sharnoff To: linux-kernel@vger.kernel.org, x86@kernel.org, linux-mm@kvack.org Cc: Ingo Molnar , "H. Peter Anvin" , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Borislav Petkov , "Edgecombe, Rick P" , Oleg Vasilev , Arthur Petukhovsky , Stefan Radig , Misha Sakhnov References: <7d0d307d-71eb-4913-8023-bccc7a8a4a3d@neon.tech> Content-Language: en-US In-Reply-To: <7d0d307d-71eb-4913-8023-bccc7a8a4a3d@neon.tech> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 8E1C91C0009 X-Rspamd-Server: rspam03 X-Rspam-User: X-Stat-Signature: 3ttqp8zwknhmkft161fmmxqub6ny6fk1 X-HE-Tag: 1749845559-253956 X-HE-Meta: U2FsdGVkX1+LtR+qKAI16ddRqsosurtxIF1UcHIZaxmd5Um5hcYA3sSz1z/ZKxAg5GaaDKz4m4aRtdtUV/66zMKLD4qV4Y8Etf4cLI0DRT9+ae5RhronITMwaKpOr0xM/rOeZVxcwM8VvODZPXq3sZ97O5UdNh1Be9I4p4epy/dT4KdLBHnclGbo/SuLuz5iKhueC1ifqDel4z8AL1a3rKZtRhCY5kw76lASD+1CNQlN1yO9Qv3H7eoOe9ONtaSAvMPs+/UFBYjR/G3PjYarQSRfPiWEGD/doiupiEktlXz19EJkCXJQbjPpTjqNTrORORol1AnxRu6xKcXvlx3Rl3viHdgG4bgP+kpffIPI/OQjl0J80yngvLzs1Iwsfso8KP5kowcUf+FrKWk28bQTk7LeYjASRWr/5qYwBiDGpP+nlCEND4apNX6mnBjODwQuD17HJilvAKKdOotMgCzuX2/T3Rilax73Gs1RqSjYxAfUmJRlwkqS+MHP0pd/RA4+k/FvKZUVl4T6+8tK8MLRRxlTxh8wbIraVWFcOl0qhS+pSdTdleTSTRTU5Zce584jxvxMwOOkZSGsp3Ny+5yyhtlagg0iVrZLz0bAlk9ZisdxOy2SszTEN+6Tp1dFTam7FYS8O79OWBCBhRYOPZ9/Ab3uzajuUIgKV8qR9IDg1wG+w33CRixDobnL2i+U/5ybek/3TjLrkhPGO1m8GNUmk6dbkpr+stpT5j7XcRrrmahvDFJrFgg/iVsKjml/EDT1xxfjW4eFlnvbf3COrL+6KQ/I38spt2FfciMWFtfNPz+eqRKp9LWCynF5qDbZq1l8PpbKOBoWSyzdfcAilmQAtBG9VqY1K4nua2xwlmxdAvyCc+mj+GPNGvuRHJH3u100taUz7MilcMJE9nPBMKySG/kV1IlED8l3MX5Ui+UyDWOMcQ3cHoOPlfeTF260JwH/j683dEuXm+BaJJrlw3n yV+ssJMn jALWNXSDpfpkNWhwE/J1YMaSnsJlTcl6V5D+9sTwETBJ6j4jYmUPtIA2f4itcXvSFC6MQoC3kIUNp+LtsyJtKK5uq+JLUoZCtIJItQ07Pxsicj+aeltEAEBSiub3hjLaq2md3Tmt1qVp3vpQmS171/IBhQOddk1Af6eJsFbgZxcjsf9kuYhNaw0PY8Y4gg5L9cCrtT2+3Iq12DrBZIBPC2CZUCg5nImkOM6xlNE9XgfZEUnAifO8jhzYAOGqF7s+IMV506pFRMjq3k9quJR9VPj3641Xq9+cC/s80vhTUYJc1wX7EnftIzqqjAJ0YP5nbDC5jkEYd3x+GEK0NQ9O6V7LT19sNrYMsyKyRa1yC4ghi2tYPz+SAu/zPgxynpBEf4qSArmMiRsv04A0ubUqMTHSu9HCojMbtbjq8eEi1i1ano5aRjsxVPiNwnOTL+fOib3wwzstAP+kP6eeVt8ikkqt1ZLdnqj9Hdb1w2/NOkJSZi1LBGNFtOS6nfg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Currently it's GFP_ATOMIC. GFP_KERNEL seems more correct. >From Ingo M. [1] > There's no real reason why it should be GFP_ATOMIC AFAICS, other than > some historic inertia that nobody bothered to fix. and previously Mike R. [2] > The few callers that effectively use page allocator for the direct map > updates are gart_iommu_init() and memory hotplug. Neither of them > happen in an atomic context so there is no reason to use GFP_ATOMIC > for these allocations. > > Replace GFP_ATOMIC with GFP_KERNEL to avoid using atomic reserves for > allocations that do not require that. [1]: https://lore.kernel.org/all/aEE6_S2a-1tk1dtI@gmail.com/ [2]: https://lore.kernel.org/all/20211111110241.25968-5-rppt@kernel.org/ Signed-off-by: Em Sharnoff --- Changelog: - v2: Add this patch - v3: No changes - v4: No changes --- arch/x86/mm/init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/mm/init.c b/arch/x86/mm/init.c index 1dc8fbd8cb63..80eddcef992b 100644 --- a/arch/x86/mm/init.c +++ b/arch/x86/mm/init.c @@ -131,7 +131,7 @@ __ref void *alloc_low_pages(unsigned int num) unsigned int order; order = get_order((unsigned long)num << PAGE_SHIFT); - return (void *)__get_free_pages(GFP_ATOMIC | __GFP_ZERO, order); + return (void *)__get_free_pages(GFP_KERNEL | __GFP_ZERO, order); } if ((pgt_buf_end + num) > pgt_buf_top || !can_use_brk_pgt) { -- 2.39.5