From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9E84C7EE2C for ; Thu, 18 May 2023 21:56:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4E318900006; Thu, 18 May 2023 17:56:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 492EB900003; Thu, 18 May 2023 17:56:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 35ACD900006; Thu, 18 May 2023 17:56:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 272A2900003 for ; Thu, 18 May 2023 17:56:58 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 0008BAD8D0 for ; Thu, 18 May 2023 21:56:57 +0000 (UTC) X-FDA: 80804736474.28.942D715 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by imf20.hostedemail.com (Postfix) with ESMTP id C510C1C000B for ; Thu, 18 May 2023 21:56:55 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=JCnlPWKc; spf=pass (imf20.hostedemail.com: domain of dave.hansen@intel.com designates 134.134.136.24 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684447016; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ye7PIXEBcWsisBfOW0yPHFMXCs0UZBa5FPVuMkC6s6s=; b=sSfQezc3mb+tS26AdzeFiS/NUBipNyMa/rnC5NmoxE0dPrl/rfiGNpLk3G6VvRONdJBQSZ sPwZjmLJeJkcslP59rulAnkUpsldWICTc6VZ07ey/2N1YRiiNe7K+eAPdh23EOtncr/cxe XcK3VzTmr80fv7mk8bhBjbfhSIsB7pA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684447016; a=rsa-sha256; cv=none; b=unHGPLpHYn2Erz2HOn/+Fo/IAUWS97IGYHa+rnzEzwpPLxiLH/RUU0+mUhX7bLPtNXj54J /DZ1Mq/3OLHjw4t9vxgEBmSSpsMch095dson5ey6eBuS4P+7fY4/6aLE9ric9y83EWRA4W mvE883jGnnp8EqEKv032ty+a+KJ70Ds= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=JCnlPWKc; spf=pass (imf20.hostedemail.com: domain of dave.hansen@intel.com designates 134.134.136.24 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1684447015; x=1715983015; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=TfncyPoLkgEVKt4cWoEjhnDcsRhR4hVCsiDKfdnguT0=; b=JCnlPWKcOuA8uKkHVHRLPXdXE7jpm8pBAXOUf9aKTf9ZHFPNexAlGv9s oOAzV9CspXMTTfcMQCca2h5iHp7Tyd1AZy79XAyBAhi3iOtYCe/paFRJb 63cHvdN2QRiXCqJWhyUqqhciG6MK2FxDMifZJ8mIzt4efofgJy0Uq8ryD 6mZph2/wjbFQSRegAd040eg+lHTs9tI9pog9kEpQinWhnzAF7ZhcTd/yu eVOPhgD2i4j/gIvFg3gi6YlG9bdaeDyR1R+fD7UbpcicIfP1EFn4Jdlmw 3rzW5d/gnDaVfRuE0el541jA+Z2J0F5WsbbHQoq1sKkQ7381IeZaJjYqB Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10714"; a="354550241" X-IronPort-AV: E=Sophos;i="6.00,175,1681196400"; d="scan'208";a="354550241" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 May 2023 14:56:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10714"; a="948852100" X-IronPort-AV: E=Sophos;i="6.00,175,1681196400"; d="scan'208";a="948852100" Received: from nroy-mobl1.amr.corp.intel.com (HELO [10.209.81.123]) ([10.209.81.123]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 May 2023 14:56:52 -0700 Message-ID: Date: Thu, 18 May 2023 14:56:52 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH 00/20] x86: address -Wmissing-prototype warnings Content-Language: en-US To: Arnd Bergmann , x86@kernel.org Cc: Arnd Bergmann , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Andy Lutomirski , Steven Rostedt , Masami Hiramatsu , Mark Rutland , Juergen Gross , "Srivatsa S. Bhat (VMware)" , Alexey Makhalov , VMware PV-Drivers Reviewers , Peter Zijlstra , Darren Hart , Andy Shevchenko , Boris Ostrovsky , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-pci@vger.kernel.org, platform-driver-x86@vger.kernel.org, xen-devel@lists.xenproject.org, linux-pm@vger.kernel.org, linux-mm@kvack.org References: <20230516193549.544673-1-arnd@kernel.org> From: Dave Hansen In-Reply-To: <20230516193549.544673-1-arnd@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: 16pwrkyjz1yz8mrbp67d4p5hg7ohsmor X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: C510C1C000B X-Rspam-User: X-HE-Tag: 1684447015-82668 X-HE-Meta: U2FsdGVkX19OxnIEfq0zKZGquJLB2us9oSe8VYGxTSEYeD3VqItsSE0W/hK67LCkzLnle60GRag0EDmNRRFQxxE1U2nfRHMtDo896HB7KMZjeOotEnFvn3ycZ30ZtQTWdjCHnLh/m6XiqKA5VonaZBnuq4ojfDz+7YpKPLX1s5/GN6vzr7XiLqfBhYURd/eiwrPfVC/dfvSbZfyb+lY2LGURopHFWSYHyur2grshExMHqHzAGOapOgi4dd4Q8KuOzyqPrfMVU/6fTnfzsdCH9wVMl4RMt6oUifHVrtXr3x3H6pAdMkqlqWnZbm+aQSUumCMOwde9VnUSWvHxx7altE7qLzJEb2oUKa+0NRhlBZXaBmVaHpLl6wK8Q2n4vsU6yxFs4sZMAYABhyGC4TYfjqYowQT1U2EZz/7sp92xjqVmUkVpWKkmA7Kak/YR9RhsXFxb09lNFLxgtLcgP1cCqJ6zvXB0PdNZkaJ/uDWYWSKLCmE/BGQqMD/TRLCXh+YJsE0D2jXXAQlNhracOsP4qL/QO9cRkxUXq/B6DJeq2L5zXaFesx0Z5nnqjA13NMg+8QmPipBJ3eQ9V7IVc4N4M10g/NurCkkKn08esyyu+YTy5By7B38RYeku8ia6qcPbTTf9qQ9d556rXAtXi3XPbuR1Q4/mEb2DELgbH0uUjJ22dvBRTIsDMsGc49MXrmmAfN0Oe6T7d1PYQGbxq4S3pDBBeztbDGj4qRSV8n7psaD4lvKILZo84nhbBh/7UmeNfRnbTTvEbwwdgy0GqjL/T7SbFEMtUW+gn8OtXUuY7YZNQ0JVMbE0CvnvlZ/QRi4EqjH7dDKMSDm0HRCD8DDCMxkLBsdPGjyWNXkdNUtLgPMeYZoHxRN1tJqyLC2lHk+meJs1brPS+/8pZtmBvTTCRgdeNweTv0f0DN7Yzx4TRCFZW5mzoQ2bNvlT6HCnlQRyISQHorgY3CKNqAzbnvF kdGmvKVh ZJRo8zMvsDAm2zyniPiLBjsu3JlxzYZjh0KnVm4nM6Z2rAX/e+fsL7h694Mtu2FBYxwlH2gmKuPGfP/HmcnX2UqW7PU0JWbYcX5Kdjec5eHXLbeqBVqTtatA/FgHvV3eL5E5Gev5DbfTg10HOPe+lPwbZjQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 5/16/23 12:35, Arnd Bergmann wrote: > From: Arnd Bergmann > > This addresses all x86 specific prototype warnings. The majority of the > patches should be straightforward, either adding an #include statement > to get the right header, or ensuring that an unused global function is > left out of the build when the prototype is hidden. > > The ones that are a bit awkward are those that just add a prototype to > shut up the warning, but the prototypes are never used for calling the > function because the only caller is in assembler code. I tried to come up > with other ways to shut up the compiler using the asmlinkage annotation, > but with no success. > > All of the warnings have to be addressed in some form before the warning > can be enabled by default. I picked up the ones that were blatantly obvious, but left out 03, 04, 10, 12 and 19 for the moment. BTW, I think the i386 allyesconfig is getting pretty lightly tested these days. I think you and I hit the same mlx4 __bad_copy_from() compile issue.