From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FFDBEB64DC for ; Wed, 12 Jul 2023 01:42:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9D1A76B0071; Tue, 11 Jul 2023 21:42:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 981BB6B0072; Tue, 11 Jul 2023 21:42:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 848E16B0075; Tue, 11 Jul 2023 21:42:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 71E536B0071 for ; Tue, 11 Jul 2023 21:42:51 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 3B6B6B0320 for ; Wed, 12 Jul 2023 01:42:51 +0000 (UTC) X-FDA: 81001260942.03.D9473B6 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf07.hostedemail.com (Postfix) with ESMTP id 6FCB740004 for ; Wed, 12 Jul 2023 01:42:49 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=B8aJ2GG+; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf07.hostedemail.com: domain of gerg@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gerg@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689126169; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AfW10e7/b7hTfisQybHcu+WC1w6y3STKEv6tpxe1+eY=; b=m1s3vj6We4/y5SCRRNK11GKiHdIAPyH27SGoDhBsKfjIjh2i3wDQ9wifN+yppOU6JwvrK+ MRoRUqbvxIjpR8A4xLwcaOXquC3ytmiKPalY4zEXWWDxApb6b80AlZE5+A/c8jxuCTmeAh apnASUZMj17tvVRiO8yMIPGmNCm2+FU= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=B8aJ2GG+; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf07.hostedemail.com: domain of gerg@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gerg@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689126169; a=rsa-sha256; cv=none; b=LoC8wsq1MCBBrmHCnvSfK4knDGOx25wNlt6L9uFKxyz9CxLkXZyehrsNfvvCppL6QofE6a npIsEkof9XUIHnD2fxe7pSNH7XBJHfG44bT5QxIxDLMVd3vQkVIH8uPB5rawNAOJtwoEu0 0frEU+7wvv+qpMirR9gESRCz245YU1c= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6090661640; Wed, 12 Jul 2023 01:42:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2B788C433C7; Wed, 12 Jul 2023 01:42:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689126167; bh=HcjfZVS5j2QnPWisyqJiHTOrvnNm8k6hX0Manu9q8/8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=B8aJ2GG+y/4t3XEzdp/waPtP6ocY9E6lnlx+ug/lldeFATlh4BTecbXjwUztC3TsF 0t/o0sz1LQYlj1fuwN7s+qUApGcfv0OUrSSaPwXG0+V9LYGvpU4/4OCWhbV80N7Diu SlJlcjxd72USrsutUGUgLJU7XDjkaag1HdohcoO0NFzeW5zbeXwouQTBVNXqUczuEA 4J1vcFyqHgT9uNnFHrKG+rw4FVTUAUxGXHvzUmFu/wINpnzVhhPEXiIGQ/lAWwCO76 dT22G2bIVPE13YaOZc+2xINJbiJ3n4pqsYEBHmpNd/3Or9lSl9nVv/G0JORAAQpbPk 1rRYYWLJMAJ+g== Message-ID: Date: Wed, 12 Jul 2023 11:42:40 +1000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v2 2/2] riscv: support the elf-fdpic binfmt loader Content-Language: en-US To: Kees Cook Cc: linux-riscv@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, palmer@dabbelt.com, viro@zeniv.linux.org.uk, ebiederm@xmission.com, brauner@kernel.org References: <20230711130754.481209-1-gerg@kernel.org> <20230711130754.481209-3-gerg@kernel.org> <202307110852.E093C93F@keescook> From: Greg Ungerer In-Reply-To: <202307110852.E093C93F@keescook> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 6FCB740004 X-Stat-Signature: uyewtjckcjkmi8zeztgdyihawz6ayz5f X-HE-Tag: 1689126169-298145 X-HE-Meta: U2FsdGVkX19bBBOVK3sYz3mSaqgBcliuNmRj9jsFQZjgs+Tu96KVvJ8Jah3Wa3p1+PdLHuiSq9Q3YC4pHawKi1gDsYYFDSHSLO27y7dwIXOL1/NwOikPiVe/npXJKKlWh9Uajx0fJJw2ZmI2iXYyhB9OwJnwW6XNdp41075ud/wH08zOPV1A4Ga+rZt5sejKvTbvsDNAAxt9yVVv3K3qwpz9F8lbMdFlq42SD08rVwIVZyd0gyZmg0JWo+X9mnSx8UvL/DwgjKTfP+fczPVErKPgzSSIwi8R4G9EgheEPaBcF457TVzgOyZ8/y1lGUZfzxQGGmI0IIxq2lXHsfmh8ngHNvQCcQfFMov2p0/U2u7otmdVt49toh2uvG5IevnQsdXXblC+umPviXM91ZbFpKMUN4s9MdAaBnI4qVXGxjKWmYb6fxI1CRApkKh3Ji4W/SRLgn7pYDC9GTO5AdZMF+r/SycATliXxe0IGPk8QaeWq1WcQsaqu03k/my/SuXNZmnd/sLmIdv8dLOl7dgLTJGlzbmGKRo6e+QgB8HEhQiJPK+ukDKs9R+2pjjsiNvQdboYu3d1nz0sfqSxmyJoir37c5PN78aY5RjwAYzke98qdWswc9rzYe7eC+neMAGZ6cgSZTBdEKBFTdS/kdXXLt/vaZz5QT2gB6PcGXIY9qQBA6Qg6KBTO+fA4RhquiQqB3DQqAIiPM8zsSQN8j1rAaSxsB2pIFHoxLnvs5mnho7dm+N8Hkbwk1Rl3LBIrIdn57/ZuASmhGrNQ14oo+kZ/fex/19jbKJ4puqXbDJcLEcpDSsAqqfdCrvAmOc3uucTUAJJGe2M5nrTzTyFa0W42hCq1GkSmRm1VF3QXweBRKUO1BfyXwjDVa7pLEsvSNa482VuqlEOtZZr/njg+Eyke+KgjKq19OSpLCqF6lEZEMfD9j7tNmosYpKGFAAW6EAddKbPdpogZxe9f/X57nG gIAYrplf uddBST8kc49R0pk2KvLeELl6aF+SclILnPMBNkQgxwHs0wyrC6lkBEncPL+mzdD+7cCI8+BchBWESZNUMSe/rcfwlwLXyeMuAzrXyD1R/zhrvufbkOZWkRoQhmfoAtlIUG93mSTYKPM2axXZV3y205TMQN4MWxLjK2N/JUacfthDPNxWBtnoiUDHoIDCi/o7NJr6tjiyKs88+aeJbixfXc/PyoR4bdQInO8GOKuiiOXCJkYF1KfB1d+JpIzwInsFfZ+cZL7KMN8HXEI4PUDIkt7DEqhc//xnlwq7w/wRVWuL/9mYd+RtqYKk1a0+CnRButqhtG5qaqGGibgGcktWsQCeto7IZY/lq8DE/2pVQWMJ9saSrY0RXVAml+F1TblN1i6asE6JVjClorSYkZa7SIMAlZg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Kees, On 12/7/23 01:53, Kees Cook wrote: > On Tue, Jul 11, 2023 at 11:07:54PM +1000, Greg Ungerer wrote: >> Add support for enabling and using the binfmt_elf_fdpic program loader >> on RISC-V platforms. The most important change is to setup registers >> during program load to pass the mapping addresses to the new process. >> >> One of the interesting features of the elf-fdpic loader is that it >> also allows appropriately compiled ELF format binaries to be loaded on >> nommu systems. Appropriate being those compiled with -pie. >> >> Signed-off-by: Greg Ungerer > > ELF stuff looks fine to me. If the RISC-V folks are happy with the rest, > this looks good. > > Acked-by: Kees Cook > > Please feel free to carry this in the RISC-V tree. If you'd rather it go > via execve tree, please let me know. :) Thanks for the feedback, much appreciated! Regards Greg