From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6816C3600C for ; Thu, 3 Apr 2025 12:58:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F3FA1280005; Thu, 3 Apr 2025 08:58:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EEF07280001; Thu, 3 Apr 2025 08:58:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D8E10280005; Thu, 3 Apr 2025 08:58:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id BA173280001 for ; Thu, 3 Apr 2025 08:58:28 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E1A70C0659 for ; Thu, 3 Apr 2025 12:58:29 +0000 (UTC) X-FDA: 83292736338.13.0504AFC Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf17.hostedemail.com (Postfix) with ESMTP id 91C204000E for ; Thu, 3 Apr 2025 12:58:27 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=mQBeFlbO; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=cBOzrwSD; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=mQBeFlbO; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=cBOzrwSD; dmarc=none; spf=pass (imf17.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743685107; a=rsa-sha256; cv=none; b=Uikaa9jVpovL4h1xpvxAxz8j4plnJGVUrKQNNWjfTrBLlzqzgRYFg9htsJ+3QfGuM1cF7S D1yZSwSv9L5H1TmtJOpt4irzCuybmPeqPSfcZuYVX4AHkNDK5Ndvg30+F5qvxSU0BogbOy lKs2di1sVsGi/pc2FjzJLdcADKJiYjk= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=mQBeFlbO; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=cBOzrwSD; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=mQBeFlbO; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=cBOzrwSD; dmarc=none; spf=pass (imf17.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743685107; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=z/JpmK1FdMpopONKIgxvs2nUGf/kiuG8cftum9/rbTw=; b=cWwkhlocS0wYcXV2B372Ca7FOE1L55I829CBfrQbw09AlxtwoRvGRW1GGI6AK5Vd9XQfGp r8af9X1MzC82TjM8uW5f+O374A8J7oNIlFoNAUuq7qs+BWp2VAeaX31d/g84dUauYqwGYs zEiYuQB5M1uDzQfE2rOT101lP7sLWCw= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id B4B662118C; Thu, 3 Apr 2025 12:58:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1743685105; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=z/JpmK1FdMpopONKIgxvs2nUGf/kiuG8cftum9/rbTw=; b=mQBeFlbO0R64kIkWZURZFc1++nuu+xm86PIKvFrsrKJWb4/0sQnzjRUb6ZSOn0B6i1R6oJ 8fOf0xRatXrHPZ6PAx4p99ubb1ZSeSDfSdQiyqlghN0aNTMoBMm2YNUL79D6UBca3wW7Sr g5SkRX8wYcGFM91npkZyNGvYO2uBWmk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1743685105; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=z/JpmK1FdMpopONKIgxvs2nUGf/kiuG8cftum9/rbTw=; b=cBOzrwSDMbzdP3XWIlI/qBXRIaBz/HKo63HmDkWRvJZw9XGQYfqiTgTtqWFI920KnGGFCx rIMek12jkz6wksDQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1743685105; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=z/JpmK1FdMpopONKIgxvs2nUGf/kiuG8cftum9/rbTw=; b=mQBeFlbO0R64kIkWZURZFc1++nuu+xm86PIKvFrsrKJWb4/0sQnzjRUb6ZSOn0B6i1R6oJ 8fOf0xRatXrHPZ6PAx4p99ubb1ZSeSDfSdQiyqlghN0aNTMoBMm2YNUL79D6UBca3wW7Sr g5SkRX8wYcGFM91npkZyNGvYO2uBWmk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1743685105; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=z/JpmK1FdMpopONKIgxvs2nUGf/kiuG8cftum9/rbTw=; b=cBOzrwSDMbzdP3XWIlI/qBXRIaBz/HKo63HmDkWRvJZw9XGQYfqiTgTtqWFI920KnGGFCx rIMek12jkz6wksDQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 851EE1392A; Thu, 3 Apr 2025 12:58:25 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id OxrdH/GF7mcDOAAAD6G6ig (envelope-from ); Thu, 03 Apr 2025 12:58:25 +0000 Message-ID: Date: Thu, 3 Apr 2025 14:58:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Potential Linux Crash: WARNING in ext4_dirty_folio in Linux kernel v6.13-rc5 Content-Language: en-US To: Matt Fleming , willy@infradead.org Cc: adilger.kernel@dilger.ca, akpm@linux-foundation.org, linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, luka.2016.cs@gmail.com, tytso@mit.edu, Barry Song , kernel-team@cloudflare.com, Miklos Szeredi , Amir Goldstein , Dave Chinner , Qi Zheng , Roman Gushchin , Muchun Song , Michal Hocko References: <20250326105914.3803197-1-matt@readmodwrite.com> From: Vlastimil Babka In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 91C204000E X-Stat-Signature: 71afyxbdxsrczntn6ceupo7568citmb7 X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1743685107-381382 X-HE-Meta: U2FsdGVkX1/I33PtD3ydjuUb8rhPTc3oJ12A+YSvyiXz/Bv5FdNWnaE7ayE7l9MNKMqDqh4OX4N/RZ+MbdUqrv1nNI7jXaofjv7mCTxwoPPNLZ22zpRsQ+GC77GPdHjwCtqRBtZA9uxDN7IONMgR27jjtboiwVGhePrAI06jvCCZUT2MqyFSOPnDyP/OUURddUH9r+/4mTzoKWIqcV4QtKl9cNDyImhK85/HKGuzoehvaO+bQJWtfuDaQ1EQScb2O745TFYf1w1yw9pg0cWU2c//ChBVA3LzbjdiJYOt6+ShOP2XvuhdkRfWWwjTWa0TQBTVZ1A/E9arbmzjssFCqGYmdDwgkxNQVHELONhsc+R6RCi/7M14mzKsD1ayrpTB2td6gMYq5Kr36Tddc96Rslsr2k4S/im2ajKYtSOeOYFrUgAIGPP9pmhItBEUiBuJcbZRtMo7kNFQZ/xGjag7F3fUEyV39hIPNY8kmF8pChjcddyBIxd7ITGkPDQHIvt8zKUkv+HGlXPkQO5fAth0EJCISVOopMPIXiuEksNJP/xnJcfR04D4ZonR7rr5N20TlWCgF9mGyACv9qHkI+bwm23UimHh/4oQgFZ7Rej4H/OhN8Ycix7ZujTJgqguuTqUJMo/42qXZrKoIr6ctkMRjKLR8ypqhm+/Kq9UMMUqt58JKj8+Rx1SScDRkTGEcFL3GoHP3f7EnoJVGvldJtAch5tyH24bP2pNexu3k04VAajetFeAV9D5IQPUojnFJXVCZytSkOjriQtoEZxWsvVmvsHvLvybgYS3oxBwU9sHEhscwBtb1cxhIQsRhTzeMNuzrDCrkhvU6WcALlQ3OFKAE3AtwWbDKi8wL7HgCM3AZUiOlvo55UU+UTb5GpEYsCmF9DY8yF0ps5x+knDrQ1/1FJunY1kwUYbj+3P1zPStwyDnXJ+pAST0iGs0gH+Cypq4Iv/TpGdB45jj4HuNAy5 aN16UBh/ dqprDAMgJs7S4iMWIUFhiKQFvtbN+ngZBAwprkMGf07lX3dZCw37fPe8hJjog3IceE7zAVEAxMg4U79Oi/fLDM0oPtFp4pjrNmklQXxD0VVZyAObu8kmSsxuurW/J405AyvuGHP1OLTJzHS7tm136Tr49RyD8ZcAHT+VTIxr8YxAXPJtOK2C3g/1Y+aI2BEFfApti3raYJQLGNNOY6rAnfPXYrjkS1curCp9//pv0lqrnHgmD2JuvSCRC8biAzaRa9Q1fNU6UktFwotOWtL2NyzwcX/t2RddPDEOb8HxwYMHYFn1Hny5Hrp7blYrIcieitSLibUmA2GmAK3ooUwoSABy73cF/UjiQ5U3KFS1gwAfj2X75zwlzaKUdQURhTz/+73Ew/7hZRX6Rqu34j/44o4rTRwOH7XfVJX+oRcrp6w+EImJbIXshI7hvQAD6vYoWu/ln/68aGnwCftZmKCEAFVUXYFxjzfJnIbnUul+gakENah8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000334, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/3/25 14:29, Matt Fleming wrote: > On Wed, Mar 26, 2025 at 10:59 AM Matt Fleming wrote: >> >> Hi there, + Cc also Michal >> I'm also seeing this PF_MEMALLOC WARN triggered from kswapd in 6.12.19. We're talking about __alloc_pages_slowpath() doing WARN_ON_ONCE(current- >flags & PF_MEMALLOC); for __GFP_NOFAIL allocations. kswapd() sets: tsk->flags |= PF_MEMALLOC | PF_KSWAPD; so any __GFP_NOFAIL allocation done in the kswapd context risks this warning. It's also objectively bad IMHO because for direct reclaim we can loop and hope kswapd rescues us, but kswapd would then have to rely on direct reclaimers to get unstuck. I don't see an easy generic solution? >> Does overlayfs need some kind of background inode reclaim support? > > Hey everyone, I know there was some off-list discussion last week at > LSFMM, but I don't think a definite solution has been proposed for the > below stacktrace. > > What is the shrinker API policy wrt memory allocation and I/O? Should > overlayfs do something more like XFS and background reclaim to avoid > GFP_NOFAIL > allocations when kswapd is shrinking caches? > >> Call Trace: >> >> __alloc_pages_noprof+0x31c/0x330 >> alloc_pages_mpol_noprof+0xe3/0x1d0 >> folio_alloc_noprof+0x5b/0xa0 >> __filemap_get_folio+0x1f3/0x380 >> __getblk_slow+0xa3/0x1e0 >> __ext4_get_inode_loc+0x121/0x4b0 >> ext4_get_inode_loc+0x40/0xa0 >> ext4_reserve_inode_write+0x39/0xc0 >> __ext4_mark_inode_dirty+0x5b/0x220 >> ext4_evict_inode+0x26d/0x690 >> evict+0x112/0x2a0 >> __dentry_kill+0x71/0x180 >> dput+0xeb/0x1b0 >> ovl_stack_put+0x2e/0x50 [overlay] >> ovl_destroy_inode+0x3a/0x60 [overlay] >> destroy_inode+0x3b/0x70 >> __dentry_kill+0x71/0x180 >> shrink_dentry_list+0x6b/0xe0 >> prune_dcache_sb+0x56/0x80 >> super_cache_scan+0x12c/0x1e0 >> do_shrink_slab+0x13b/0x350 >> shrink_slab+0x278/0x3a0 >> shrink_node+0x328/0x880 >> balance_pgdat+0x36d/0x740 >> kswapd+0x1f0/0x380 >> kthread+0xd2/0x100 >> ret_from_fork+0x34/0x50 >> ret_from_fork_asm+0x1a/0x30 >> >