From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F200C7EE23 for ; Wed, 24 May 2023 08:42:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 218316B007E; Wed, 24 May 2023 04:42:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1C8926B0080; Wed, 24 May 2023 04:42:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 06A46900003; Wed, 24 May 2023 04:42:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id EA4D56B007E for ; Wed, 24 May 2023 04:42:26 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 20B151C7681 for ; Wed, 24 May 2023 08:42:25 +0000 (UTC) X-FDA: 80824507050.23.A497988 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf11.hostedemail.com (Postfix) with ESMTP id DE64E40011 for ; Wed, 24 May 2023 08:42:20 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MNIBwzLK; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684917741; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/B+1hoJpqT+pbTGuUlwiPo2e5yfvTv5Rs4wh2wPtP6U=; b=0yTG99iHyQSjhn70h2IP3LDR72HHRv+hEEkRQ0++dLKgL6DDW05VIPuQ9TStBWaBW9JrRB yGyoPDjBqz1g4vqfY+tyFWV9wjLqwUU+YmCvkNlpkHMorbBhmSFR6J87C3CrNC2dRTYoiW wf3MQy1IxSUt+dV15pZHtrufRD3V+d4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684917741; a=rsa-sha256; cv=none; b=lHePmcrp/Qt9IvdRkvbiBIvBNHJ6pxZwYObkGX3aEuwQ0LDHKAzcXGeK8FT9qwEOOArR1f cMkyBkDAzkB7EyTr/XoJqiJaiAdEGMEaiKbrK6C/5swRgQyejSUMITj/Tz0fTgcCebO70f uiey5RYMq4+VtMRGGleAjWNYng4VPLQ= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MNIBwzLK; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684917740; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/B+1hoJpqT+pbTGuUlwiPo2e5yfvTv5Rs4wh2wPtP6U=; b=MNIBwzLKfccc5jWDHoiPxP/lCxut28mBv9QV4LeDyUN1aF8M2CF/vT4oK79as8kvAM+DVx k3Omn/7tCFx97OnX7xe6TQwcL6qRYf41SpqPpeosfdIZn7MH0H0hVEW/Xb8bk8Sjy7aMHU qlA24n7t/9r/wDycRTfw1wawk3ETbIo= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-649-YK4hXXyIP4-opfN68yYj8Q-1; Wed, 24 May 2023 04:42:16 -0400 X-MC-Unique: YK4hXXyIP4-opfN68yYj8Q-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-3f5df65fa35so2586195e9.3 for ; Wed, 24 May 2023 01:42:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684917736; x=1687509736; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/B+1hoJpqT+pbTGuUlwiPo2e5yfvTv5Rs4wh2wPtP6U=; b=YnX1BAIpz6LbANUhht31edHg1t3AoB0q8of1P0thlEyp1jp+SwIVPhK1jfD2WNL6to DGvWcwO6MZXexFrJsMF7dWUdWnJcjDDpE9GV1owsaSV0rgy2qALS1nO4sGBc1qvWXajq 35b0enIQdfjXoJkAyGj/7G5jc1wDUPvA+bjDDOM6N4S6N5JxmN5XALDiJNjHUMk0ZkSE 5CTO5RuQG9pDOyBMv7A+wOjeFLl3CCNphuXfo2Ykmb6evsgPNdCrCOEwTahIKA+NB11r S5zvdk3cexmqtTEL7kwDCdDGo3i6pZ9TCzWPAjTq1NQlTGbFOBf72EdcoKu/ziki534+ rLHA== X-Gm-Message-State: AC+VfDx5xm5vrdii7zhNZgzrg7wx1jxcaWoa+4lTt/NiD6Z2vdK+NILZ f97sUM/dVJSb9pgtRpFmF5QfmI+BUTQlDAQckoEKcDysn5N85FjIb4qe55MHudD5ymS2K5ateOy oU6azRt1j424= X-Received: by 2002:a05:600c:208:b0:3f6:389:73b1 with SMTP id 8-20020a05600c020800b003f6038973b1mr7300681wmi.6.1684917735801; Wed, 24 May 2023 01:42:15 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4wRuRoddKnb48gieFESVgQ9nnsytpWldTKKrvDqsMaChqEKT8zOQrEn+6SYuIMZvLELDufjw== X-Received: by 2002:a05:600c:208:b0:3f6:389:73b1 with SMTP id 8-20020a05600c020800b003f6038973b1mr7300664wmi.6.1684917735448; Wed, 24 May 2023 01:42:15 -0700 (PDT) Received: from ?IPV6:2003:cb:c70d:f700:24cd:855:1c60:1ff4? (p200300cbc70df70024cd08551c601ff4.dip0.t-ipconnect.de. [2003:cb:c70d:f700:24cd:855:1c60:1ff4]) by smtp.gmail.com with ESMTPSA id l22-20020a1c7916000000b003f607875e5csm1551866wme.24.2023.05.24.01.42.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 May 2023 01:42:14 -0700 (PDT) Message-ID: Date: Wed, 24 May 2023 10:42:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [patch] mm, debug: allow suppressing panic on CONFIG_DEBUG_VM checks To: Linus Torvalds , David Rientjes Cc: Andrew Morton , Michal Hocko , Alex Shi , Johannes Weiner , Matthew Wilcox , Alexander Duyck , linux-kernel@vger.kernel.org, linux-mm@kvack.org, "Justin M. Forbes" References: <53dd9df8-e88f-f466-89f9-3fa141a10267@google.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: DE64E40011 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: jyd9h8ybhjdigjcb416htmwqh6dh6jsh X-HE-Tag: 1684917740-607039 X-HE-Meta: U2FsdGVkX1+T7EwxiU5OU9vDKunzg0NoZuYHRgeA+1luLU3BYTZsFWKunMoUPOBLb+cswDY+YA0eHVY6UPdc8u+F7hmGLwd4lPCfIRYTeypXvoPrTFg6+zNYNPfTyeMo1vszBS7PO+Fd8Q9sjOZHM1MONCGdOwyMsOEXxZ/P1BW4rvWPd09DyAls4H7rYIsGr6bf7XhwpjKW6iqCOm7McrE02gE/RGwPTimiAEliwf2Xhw+Y47MzOiEnFK6/AC3sqiwogegNBARllrswNBZvrP4fnDpmb12Vp93ezqUqqU+euBdzWKzA2rH6/ZqVratlehwq1/Wlj4Ybz9iIDcwcDcP7TSWPIK3YQgqWLmWz4EHODzP7B0zliQDg10cKgTnt/8c3SEgA/z37qtHObsKAmPyK0xSPCU7E885UBu7R8ZgwZndfpCgn51gQu6WAa2aDJaGf8xPgUKDonrpNQHX+5B/2RIZxgrYyulGWvmy4lE6/d/GbF+zSzBH9EvYm0HkdaoJFuUChtnvX3zLVLzot6zIQz3A35aWQR7DNhSw0tR34VugSiTlKaUUUXCAFiVqifuN1Do9rFKcPV6HTYcIsWtKq9MP/S+gGD/14ag7B0CYporMvwXakp2+GF+E3TZIApaWFATXg5Sw+OVbVqCFILA0tAKAIp2VT1i6cAi58cbBHzu+Asa+5e5KTWW4/50tj3e5PbbM6UwvylXrHBhMbXwoB10oSkLjhVttTMu3hSNNgvBw4+sXBXm0It0+cSByM7yPA1et9vAIMcpk2dUs/qFyKL+/z7EDrVuPauXzZzOgY8q+koem5WFosuw+JiBltEuPiRaCyITZZE8TiNOtX0CrdjM8mlzUGygVnJGLxloKr4LfcMO1+AjCwY9gv4YI1Ohjd4DbKl899SYJWm+TGn/pRbK2EaFW3ERH39K1Xky+Alfe5F3GH2bAoH4gzEfDZ3RFE4Rdb9Ci4M7thSko QlHdD8uG qBFu8j/B4zM8HONoSyyfarAqFstkGepQkZUbTiWGoStV/bW5WcSWaw3KUpz2aNZBeWOgGx3aQVCFBb0T8Z2QTyKvvy0yW2iKFPFCINuQCcobxoAmeAEerKeHGv0BmPHLeOK5A4DFLrvOnztOVlgbnr4M1LkLrK7hCZ3P4L3djTq1lSQGqkjhV2rcotvf49rrXpqSMxOYWe/C7kTltKmAWHp2s++A0B8Qy0E0L51nDKNzDLq5V++gUPnCszNOSumqJmz4o9SMVzz5xkkcNdz5ip3rFHN3nCLMUrVf4as0h9VnpPxN0UZiGg8K9h7XIMlKQWtb6Hk6t7BuvwVDC157gX0DDIGsW+UtA0n0NkOtX9MdYZpS5Sn9FATRvCaMhaRS1yaQMLVNbxcowFBWqfuNuNDreb2FSUU0t07y9Uav3EZQ872MGOdTTr8PQvzDBvH1pRxflRDuDB6SE3KbagH2v0smWEx4aiwLGgSBy X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 23.05.23 03:47, Linus Torvalds wrote: > On Mon, May 22, 2023 at 5:52 PM David Rientjes wrote: >> >> Right now kernel.panic_on_warn can either be 0 or 1. We can keep the >> lowest bit to be "panic on all warnings" and then bit-1 as "panic on debug >> VM warnings." When CONFIG_DEBUG_VM is enabled, set the new bit by >> default so there's no behavior change. > > So right now CONFIG_DEBUG_VM being off means that there's nothing at > all - not just no output, but also no code generation. > > I don't think CONFIG_DEBUG_VM in itself should enable that bit-1 behavior. > > That may be what *you* as a VM person wants, but VM people are not > exactly the common case. > > So I think we've got several cases: > > (a) the "don't even build it" case (CONFIG_DEBUG_VM being off) > > (b) the "build it, and it is a WARN_ON_ONCE()" case > > (c) the *normal* "panic_on_warn=1" case, which by default would panic > on all warnings, including any warnings from CONFIG_DEBUG_VM > > (d) the "VM person" case, which might not panic on normal warnings, > but would panic on the VM warnings. > > and I think the use-cases are for different classes of kernel use: > > (a) is for people who disable debugging code until they feel it is > needed (which I think covers a lot of kernel developers - I certainly > personally tend to not build with debug support unless I'm chasing > some issue down) > > (b) would probably be most distros - enable the warning so that the > distro can report it, but try not to kill the machine of random people > > (c) would be most cloud use cases, presumably together with reboot-on-panic > > (d) would be people who are actual VM developers, and basically want > the *current* behavior of VM_BUG_ON() with a machine that stops > > and I think (d) is the smallest set of cases of all, but is the one > you're personally interested in. Just as a side note, I stumbled yesterday over [1], which apparently disables CONFIG_DEBUG_VM on !debug Fedora builds. The commit description does not contain a rational ( it's empty :) ), and I don't know if this is just a temporary change. I'll CC Justin, maybe Fedora also would like to keep building with CONFIG_DEBUG_VM, but default to WARN_ON_ONCE() instead. [1] https://gitlab.com/cki-project/kernel-ark/-/commit/ade780e10ae1fdcb575ab100bf02d61eb12dd406 -- Thanks, David / dhildenb