From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0E3CC10DCE for ; Thu, 12 Mar 2020 18:22:11 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 80E42206EB for ; Thu, 12 Mar 2020 18:22:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 80E42206EB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 335FF6B000C; Thu, 12 Mar 2020 14:22:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2E6746B000D; Thu, 12 Mar 2020 14:22:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1FBFB6B000E; Thu, 12 Mar 2020 14:22:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 02FA96B000C for ; Thu, 12 Mar 2020 14:22:10 -0400 (EDT) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id A3597181AC217 for ; Thu, 12 Mar 2020 18:22:10 +0000 (UTC) X-FDA: 76587529620.29.wound92_300e0e8612e25 X-HE-Tag: wound92_300e0e8612e25 X-Filterd-Recvd-Size: 2063 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf24.hostedemail.com (Postfix) with ESMTP for ; Thu, 12 Mar 2020 18:22:10 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 9AE88AF9F; Thu, 12 Mar 2020 18:22:08 +0000 (UTC) Subject: Re: [PATCH 20/20] mm: add "+" in show_free_areas() To: hui yang , akpm@linux-foundation.org Cc: linux-mm@kvack.org References: <1583985752-42143-1-git-send-email-yanghui.def@gmail.com> From: Vlastimil Babka Message-ID: Date: Thu, 12 Mar 2020 19:22:08 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <1583985752-42143-1-git-send-email-yanghui.def@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/12/20 5:02 AM, hui yang wrote: > From: YangHui > > if there has not "+" , it will show below: > DMA: 305*4kB (UMCH).....5*2048kB (C) 13*4096kB (C) = 67196kB > actually it's an addition expression > so we should add "+" > > Signed-off-by: YangHui Yeah but I think it's quite clear even without the '+' which would just make the output longer harder to read, IMHO. > --- > mm/page_alloc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 3c4eb75..d90b3d7 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -5399,7 +5399,7 @@ void show_free_areas(unsigned int filter, nodemask_t *nodemask) > } > spin_unlock_irqrestore(&zone->lock, flags); > for (order = 0; order < MAX_ORDER; order++) { > - printk(KERN_CONT "%lu*%lukB ", > + printk(KERN_CONT "+%lu*%lukB ", > nr[order], K(1UL) << order); > if (nr[order]) > show_migration_types(types[order]); >