From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5894EB64D9 for ; Tue, 27 Jun 2023 07:27:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 14C948D0002; Tue, 27 Jun 2023 03:27:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0FB038D0001; Tue, 27 Jun 2023 03:27:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F056D8D0002; Tue, 27 Jun 2023 03:27:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id E22068D0001 for ; Tue, 27 Jun 2023 03:27:32 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 98BD980943 for ; Tue, 27 Jun 2023 07:27:32 +0000 (UTC) X-FDA: 80947697544.11.C726C7A Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf20.hostedemail.com (Postfix) with ESMTP id ADB1C1C0005 for ; Tue, 27 Jun 2023 07:27:30 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf20.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687850851; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XufoSG2Dt3maXPMc+bI9Xf/r23Vg1hq/b6ApbBXmNc4=; b=UDY88EnSupO5Um1Ynau5NcREx8eF6nW6PEQI7pY1gFjH85cMIw2LaN2j/MZD3qdSQjP4DZ IxrpBjKKgBNq8KFgLaSmLMVcVGiO9DBm94brekJpEZJKy0FtwZPJVEmvFY+sumZ3NcT8hw t8cHBfo7sGFBFliuo2edZEzxvCx2kG4= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf20.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687850851; a=rsa-sha256; cv=none; b=l2RHONoZ+E2ucV6RsTTHbLigDHAR1cgT4IGIUl5iVP5cOwWmRgXKxulsLDH49fPLJJBjWm 7zadCXczsgDA7otkL02bpLzh7gfUVWp6kyXKgPKfAKoBGBLteBTF5lDfYiD3ncyY+6Y8gH SU2LaIeKU/jrPdDjpipWvWwuDRGiX4o= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8111411FB; Tue, 27 Jun 2023 00:28:13 -0700 (PDT) Received: from [10.57.76.16] (unknown [10.57.76.16]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 476E23F663; Tue, 27 Jun 2023 00:27:26 -0700 (PDT) Message-ID: Date: Tue, 27 Jun 2023 08:27:24 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v1 02/10] mm: pass gfp flags and order to vma_alloc_zeroed_movable_folio() To: Yu Zhao Cc: Andrew Morton , "Matthew Wilcox (Oracle)" , "Kirill A. Shutemov" , Yin Fengwei , David Hildenbrand , Catalin Marinas , Will Deacon , Geert Uytterhoeven , Christian Borntraeger , Sven Schnelle , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-s390@vger.kernel.org References: <20230626171430.3167004-1-ryan.roberts@arm.com> <20230626171430.3167004-3-ryan.roberts@arm.com> From: Ryan Roberts In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: ADB1C1C0005 X-Stat-Signature: 9ro3dh1toqmwxg6y8iceodd3oqejapfk X-Rspam-User: X-HE-Tag: 1687850850-225353 X-HE-Meta: U2FsdGVkX1/owneIlXJNtjsR91s3wAnlVo0LhmAJFN88jpZpSY/CpT9cYDTeVxUQtNfswSfHzh+AA0dC1i1SoQiBZnwfCz6OOBuoTQ4jh8+ax+k1O6C4h5n0VHoeBkZSIElWgFH0s2U/BvQEyAT61tkTRzrDq3maeWxlIpEZUxIe1rhYpcANRbg53Y3aQ6oZSHD9RBiWdM7cbRRx9H/OnVO7Rx7OZqAmCkC/F2thU/sFkCmPK4BgsdB+ufE8Bkut8wEAwxxHm0TlL7XnFozT3MOd1mRjHFfVLt8GNfUYbsyfHLe7E69Oa01jl3TME1mPYiY3SWIwqd8il9A7RDnpg64Ztrr7yIKmteoET6tz/g1+FBeJ0K7j+J/aFU1wrlnNsKUbrcLsyWluDMDuJaV3Ad23l4gCnpeglIJggGDocnjupt1aUOzabjbDwmCkpZovzXdFevSMokLNKPm6qjo/BanMu4Bd/GVGHAT2I1wJ5ElBB8PoVROIqM2HeSMG4judelhGwl1mo5Pe1fHMFHEE4N8uxUOFZG2Ec35ThZvO7h4Cv5O+c8L0F/OXAajXI3hcA1NY9Y0pjgL7VT8mOwRF/HTHhXt1v2VjEsLlc75u+sOdEMAUwyDDnr5Xaxt5NxoEzO2PmWxtybwXoATPTHmTX3mY3PSNDiS1Rx3bo9+i3waC8GwlsTUqba+FUT+LIw6OQzr8kY6cU4DcnsvSfbhE6Pa3lqq+31bxtebkAOyyAkDy+qkniwz7WFh+/C7BAu4QbLO1z5iZstTkK8KF88k1DFCtMmF+l5XeJCYsuAFXccBG8qmuAQCnQerdAqWURkRuia79BZW+Jt6EVC5TxHhcPwyBuFO+/uP8UZCfNDuth7pYXhBMJkEbNRwtnv4ryomoOFadgA1LqvcC2WIw7CdZ9QapwzwPrOfxL8yuIH3XVsldk4YjeDf3YOcMQ63F8YBTkqb/ncbOhizY4qTAd9U Z1VDeMAV ZOGQoXn2+2lD8t8+fU025OpKuk0Ar4mAqZpkN4T2ho4mHMYKd49jw6XL5IruVhHdBV1OrM4UqJkUqBIW1oNYhOSizo5yxqqcYzzlZE535lPOmatJRAfLB6kLRJKKUIdx9GZ97dV64vywbJEWo99m9b9qsN6C1UadaifFAH6NP95rbbAK82WuA9CA/FtI8DAMuyo3q2XRorXW0eVIG3jB0hfehmg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 27/06/2023 03:27, Yu Zhao wrote: > On Mon, Jun 26, 2023 at 11:14 AM Ryan Roberts wrote: >> >> Allow allocation of large folios with vma_alloc_zeroed_movable_folio(). >> This prepares the ground for large anonymous folios. The generic >> implementation of vma_alloc_zeroed_movable_folio() now uses >> clear_huge_page() to zero the allocated folio since it may now be a >> non-0 order. >> >> Currently the function is always called with order 0 and no extra gfp >> flags, so no functional change intended. But a subsequent commit will >> take advantage of the new parameters to allocate large folios. The extra >> gfp flags will be used to control the reclaim policy. >> >> Signed-off-by: Ryan Roberts >> --- >> arch/alpha/include/asm/page.h | 5 +++-- >> arch/arm64/include/asm/page.h | 3 ++- >> arch/arm64/mm/fault.c | 7 ++++--- >> arch/ia64/include/asm/page.h | 5 +++-- >> arch/m68k/include/asm/page_no.h | 7 ++++--- >> arch/s390/include/asm/page.h | 5 +++-- >> arch/x86/include/asm/page.h | 5 +++-- >> include/linux/highmem.h | 23 +++++++++++++---------- >> mm/memory.c | 5 +++-- >> 9 files changed, 38 insertions(+), 27 deletions(-) >> >> diff --git a/arch/alpha/include/asm/page.h b/arch/alpha/include/asm/page.h >> index 4db1ebc0ed99..6fc7fe91b6cb 100644 >> --- a/arch/alpha/include/asm/page.h >> +++ b/arch/alpha/include/asm/page.h >> @@ -17,8 +17,9 @@ >> extern void clear_page(void *page); >> #define clear_user_page(page, vaddr, pg) clear_page(page) >> >> -#define vma_alloc_zeroed_movable_folio(vma, vaddr) \ >> - vma_alloc_folio(GFP_HIGHUSER_MOVABLE | __GFP_ZERO, 0, vma, vaddr, false) >> +#define vma_alloc_zeroed_movable_folio(vma, vaddr, gfp, order) \ >> + vma_alloc_folio(GFP_HIGHUSER_MOVABLE | __GFP_ZERO | (gfp), \ >> + order, vma, vaddr, false) > > I don't think we need to worry about gfp if we want to make a minimum > series. There would be many discussion points around it, e.g., I > already disagree with what you chose: GFP_TRANSHUGE_LIGHT would be > more suitable than __GFP_NORETRY, and there are even better options > than GFP_TRANSHUGE_LIGHT. OK, but disagreeing about what the GFP flags should be is different from disagreeing about whether we need a mechanism for specifying them. Given I need to do the changes to add `order` I thought it was sensible to add the gfp flags at the same time. I'll follow your advice and remove the gfp flag addition for now.