From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA4C4C54E58 for ; Mon, 25 Mar 2024 08:38:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 558296B0092; Mon, 25 Mar 2024 04:38:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5078F6B0093; Mon, 25 Mar 2024 04:38:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 381836B0095; Mon, 25 Mar 2024 04:38:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 2983D6B0092 for ; Mon, 25 Mar 2024 04:38:18 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id F372380A21 for ; Mon, 25 Mar 2024 08:38:17 +0000 (UTC) X-FDA: 81934909434.26.3D2DD86 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf08.hostedemail.com (Postfix) with ESMTP id A4DCD160013 for ; Mon, 25 Mar 2024 08:38:15 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=HuIEbM8l; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711355895; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Drd0XXBEc52s2kbDKhkgxC/419tBJV5jTdVV0EP9/Mg=; b=xdhSxKS0oIow0bnvT8iVtzvpfJVgpe7cbR5vvmyZDb4VVqGnJcBDu7g/d2xxA3OiD+p5ub 8JQCyJF7OxuBFBjP16iX7PaTHFxrN4EhWNLEC6AOPNPw77XxAmX5k0UViA8gje/6f3V+an osHrWxRVIcXGAOqQaUz/h9TrZLCeCYY= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=HuIEbM8l; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711355895; a=rsa-sha256; cv=none; b=RNK4tML6pV/Fj6X5y3O2FHyPfILIsy+foi2eMkvVvkW5IMT5ST0L1Fk6uncMyTWgk1vSDv QxkcrCYIp1c4ChoYp9upZQ3+0euxiVAAnjEQRt1F1k88AgF1Cen+f53dR0INzhnNh/CCA9 zHF5wFfdMInKPPj3RgyfyAZDM9pRi9s= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711355894; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Drd0XXBEc52s2kbDKhkgxC/419tBJV5jTdVV0EP9/Mg=; b=HuIEbM8lRg29QfOndo8QrsVdd3bjwT8n1mQN2IlOdGbpqgEGCKdPh6QxMpFoRVkqXgpOTa gI5Cpwc+e6Q72qhNgweUxZH0xpMX4zqXWFvBbx3JLKSHuy8czI5aGRlNmPoUwg74JHPusW V9De0qlXWG+Pz2HPglssg7R3zSfTT0k= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-59-UlbLVcbYOXSLhlaUQAWbRQ-1; Mon, 25 Mar 2024 04:38:11 -0400 X-MC-Unique: UlbLVcbYOXSLhlaUQAWbRQ-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-33e7ef510aaso2614748f8f.0 for ; Mon, 25 Mar 2024 01:38:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711355890; x=1711960690; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Drd0XXBEc52s2kbDKhkgxC/419tBJV5jTdVV0EP9/Mg=; b=GGcXmCi27BspLCEe4UriN5MskcYQj3VgddI344VssPGPlDFT+viG2XJdG8xOlg5t8l BPAP8dDkh4InJ3JtMkYBhi2QJ/CoflC4GbHYvZXNIm7ehCZCZwR1IdaE6GHLXHMxWbXW 4Oqb9Hu2GSC+8m6CODXV4X3q3E+PnjsAmPXg25/rBKHIyTgqo5cGN18sbe7moblD0wze 5ODG2tCs2xGNNhBG4lxQWQcut99nTt1V005UoLUa87pdI1ChREVLZ/msAmR1topvjt+U CAvvOAOll0/fREWu07YoHOKQBZbaE/V2qYCXknhHufMnXpHMWDVVURXYYi/VoI+K5adl 5W7A== X-Forwarded-Encrypted: i=1; AJvYcCVqDbFvsDs4in2SPFT8USepOY/GL2gNAKJUckh51dTXVaAidFeTjyNdaYursPOYn8P7s1njEjZkbZRtvCJOb/gsvV4= X-Gm-Message-State: AOJu0YyQf9JLgRHgSaX8dVdlSKv4+fpd8W62mCsmCyKpuMYXejS3jSX/ NhE8K2NaSgMxgmWD3xo89h7dL8w/VtpEDeZY/C9+iwa9RQQDecLTRZIbfPcZIgmKndmzLm3Q/5V /IuHeMMuWtw2GQoLroCay5FD1tINaEh6AmUpvpplnzoSJaUX8 X-Received: by 2002:adf:e98c:0:b0:33e:76a1:d031 with SMTP id h12-20020adfe98c000000b0033e76a1d031mr6006174wrm.50.1711355889936; Mon, 25 Mar 2024 01:38:09 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG+kkKom7DaC9lV7J0Cn1tqgZ7hB782Ej0sFW24wXhnby8TYj7qDZfBpw/gEOKt+oIvhGbdhg== X-Received: by 2002:adf:e98c:0:b0:33e:76a1:d031 with SMTP id h12-20020adfe98c000000b0033e76a1d031mr6006160wrm.50.1711355889572; Mon, 25 Mar 2024 01:38:09 -0700 (PDT) Received: from ?IPV6:2003:cb:c738:b400:6a82:1eac:2b5:8fca? (p200300cbc738b4006a821eac02b58fca.dip0.t-ipconnect.de. [2003:cb:c738:b400:6a82:1eac:2b5:8fca]) by smtp.gmail.com with ESMTPSA id cl1-20020a5d5f01000000b00341b9737fc5sm7886807wrb.96.2024.03.25.01.38.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Mar 2024 01:38:09 -0700 (PDT) Message-ID: Date: Mon, 25 Mar 2024 09:38:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] selftest/mm: ksm_functional_tests: extend test case for ksm fork/exec To: Jinjiang Tu , akpm@linux-foundation.org, shr@devkernel.io, hannes@cmpxchg.org, riel@surriel.com, wangkefeng.wang@huawei.com, sunnanyong@huawei.com, linux-mm@kvack.org References: <20240322060947.3254967-1-tujinjiang@huawei.com> <20240322060947.3254967-3-tujinjiang@huawei.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: A4DCD160013 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: hro3a31jz4jj18t5oiw45p5ot4w4txm5 X-HE-Tag: 1711355895-384198 X-HE-Meta: U2FsdGVkX18xDL29UoqeDfZrB44ofsIf9MSiJikz6cwHpYLoSslWKIFL2oL3hL8OZR2syknYGs65VDcaktbg9+wc1lDbypYLYnYT2MX1RhGXNWgVemhkhkdpk8tNUFfNQ/lYx3PsnJP9O94jEJxC+hWpfmaBJmUNlcCCI1xHUkhF/Ga++ZQzPaj1kxr2GiSKd2oxBDdwuGAPYIf3ec9jqGMvpUm6UhuXnDnZLQjq8iikWnbkNCBherIwQvR/hLhJmD1lAG8e9qVIHM3aeKpdDKVN+ysuQ4KQhIHH+oOjHiaFkSBBqeaLTYGyK4X1XaBq/6RIjfYRgVrAMG0QWx+SxyuNUYEBD6o96QUQWM9doENTwqdi+J4IwlO9/DUFh385jU24kkmgIE/MacbYYUxni4G8bFfwT400YBxYXgo7VIbtrdgXJEV/M0JLWxM6JaP7nP5Mdyfzu1Sex2zplJqFbUoWJ5gwa1pCVUAnZ+BW3srSvny2LHpDNfNK0OoGdPPcPXOMFuZWB1bS9l4HXIh/1ZK/n5FdmljZOZWwyech33zpRoN2aKBeYxOk9AHpsyhie8ug1xOMjVKqYe28jagsrrJBcll3Q33GFocQo2Xg33gb4nE2vXrdD01Kdl84tqH+Ac2xpI+OnaRf6KQmvaJJkYlPspdu0ehFs7nWtCkvvOYw1mZ0i13k+mXfg/WK7iiwZTrC5juzF6hPiRCQkXdLWm9frG5KXpyKQzMfeEiXmzXAjifr9euIIY0xA/4Z/6rySJBffLCpqR/rxTY5MszTh/8HaTvnmOQ7cg4985z8HT1KeLI//i65qOWpnMVkuKqVTUmju0MZ/Yc8AwWctjQPO4eI8yjiok6oBRWWdFoW9PXiBA2m2ca3fKQcSjrNYw1406/RBEsRZJisSTb4lkWbk/1MZvkOmzgPIhZM9rV1VaknjyZaajJmvVEMfJjiHI5Wd9zsDpGCzW7SvEou00j 6K+Px3Jr V694+HIc4uMP+2eE9qdJXx8boJMYMvs/tppFuw7q5fUUUUpcfMfsb/IjOEsxhgvPVPDmJKtqImZrHYIy+IG0uy4oD+gcIf+wLPHkC9hLnD+QPZYkqTvlYGcraVJ2QzpdVDd/HMRPe5+ZR+WJFPfMH5a2bmg42hGJn0LVWo/zSaUzS+iU9IrH4cmYmiV2WPNs0sJAtCGYE+1gN40R2n9r0sTG8LV4miQuO4xzWFypjkP0bWOtUCm0rmoI74xe4gCSyvAXInJTFCQGjdz19s3YNuiZZ3fMx6MEAbjVnhEha5EaEmUY/hjEYIvGBIbkgWx9bNuBGSX5WTk2GiqApIS9BNQxR3v9mn0D8l0Keo+Nt4zYaJJNWVn0f6zOi38yHqRsnh7IIPN+A3LYizP8lFpKw7JQm88CeBPZGompyiIysuRuLQs+Erz3sFP8bEJeTgJi4rEmYVd8Vhl1v+40lK1jnBqG1XC77jMCV0iYiJu8BW/6Xwggc+RXsRB+rzCaMcHwwWlYc1YVUqPqNbqTyn+cYIfDOOs0HPQSvA7qM X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 25.03.24 03:24, Jinjiang Tu wrote: > > 在 2024/3/22 19:43, David Hildenbrand 写道: >> On 22.03.24 07:09, Jinjiang Tu wrote: >>> This extends test_prctl_fork() and test_prctl_fork_exec() to make sure >>> that deduplication really happens, instead of only test the >>> MMF_VM_MERGE_ANY flag is set. >>> >>> Signed-off-by: Jinjiang Tu >>> --- >>>   .../selftests/mm/ksm_functional_tests.c       | 79 +++++++++++++++++-- >>>   1 file changed, 73 insertions(+), 6 deletions(-) >>> >>> diff --git a/tools/testing/selftests/mm/ksm_functional_tests.c >>> b/tools/testing/selftests/mm/ksm_functional_tests.c >>> index d615767e396b..01999aab2e37 100644 >>> --- a/tools/testing/selftests/mm/ksm_functional_tests.c >>> +++ b/tools/testing/selftests/mm/ksm_functional_tests.c >>> @@ -146,6 +146,54 @@ static int ksm_unmerge(void) >>>       return 0; >>>   } >>>   +static int child_test_merge(void) >>> +{ >>> +    const unsigned int size = 2 * MiB; >>> +    char *map; >>> +    int ret = -1; >>> + >>> +    /* Stabilize accounting by disabling KSM completely. */ >>> +    if (ksm_unmerge()) { >>> +        ksft_print_msg("Disabling (unmerging) KSM failed\n"); >>> +        return ret; >>> +    } >>> + >>> +    if (get_my_merging_pages() > 0) { >>> +        ksft_print_msg("Still pages merged\n"); >>> +        return ret; >>> +    } >>> + >>> +    map = mmap(NULL, size, PROT_READ|PROT_WRITE, >>> +           MAP_PRIVATE|MAP_ANON, -1, 0); >>> +    if (map == MAP_FAILED) { >>> +        ksft_print_msg("mmap() failed\n"); >>> +        return ret; >>> +    } >>> + >>> +    /* Don't use THP. Ignore if THP are not around on a kernel. */ >>> +    if (madvise(map, size, MADV_NOHUGEPAGE) && errno != EINVAL) { >>> +        ksft_print_msg("MADV_NOHUGEPAGE failed\n"); >>> +        goto unmap; >>> +    } >>> + >>> +    memset(map, 0x1c, size); >>> + >>> +    if (ksm_merge()) { >>> +        ksft_print_msg("Running KSM failed\n"); >>> +        goto unmap; >>> +    } >>> + >>> +    if (get_my_merging_pages() <= 0) { >>> +        ksft_print_msg("Fail to merge\n"); >>> +        goto unmap; >>> +    } >> >> Looks like all you want is use mmap_and_merge_range(), but neither >> setting the prctl nor madvise(). >> >> Two alternatives: >> >> 1) switching from "bool use_prctl" to an enum like >> >> enum ksm_merge_mode { >>     KSM_MERGE_PRCTL >>     KSM_MERGE_MADVISE, >>     KSM_MERGE_NONE, /* PRCTL already set */ >> }; >> >> Then, you can simply use mmap_and_merge_range(0x1c, 2 * MiB, >> PROT_READ|PROT_WRITE, KSM_MERGE_NONE); > I have considered this before. But, mmap_and_merge_range() calls > ksft_test_result_fail() when error occurs, ksft_test_result_fail() > prints prefixed with ksft_fail count. When mmap_and_merge_range() is > called in the child process, the ksft_fail isn't consisent with the > parent process due to the global variable ksft_fail is CoWed. As a > result, ksft_print_msg() is intended to be called in child process. > > Maybe, We could introduce a macro ksm_print() to control which function > is called according to ksm_merge_mode : As an alternative, convert all ksft_test_result_fail() in there into ksft_print_msg(), and in the callers of mmap_and_merge_range(), do something like map = mmap_and_merge_range() ... if (map == MAP_FAILED) { ksft_test_result_fail("Merging memory failed"); return; } -- Cheers, David / dhildenb