From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77136C282EC for ; Fri, 14 Mar 2025 21:49:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7E90C28002E; Fri, 14 Mar 2025 17:49:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 771FA28001D; Fri, 14 Mar 2025 17:49:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 59EEC28002E; Fri, 14 Mar 2025 17:49:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 3460D28001D for ; Fri, 14 Mar 2025 17:49:31 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 6596A12054A for ; Fri, 14 Mar 2025 21:49:33 +0000 (UTC) X-FDA: 83221498626.01.3109855 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf12.hostedemail.com (Postfix) with ESMTP id 5F3104000E for ; Fri, 14 Mar 2025 21:49:30 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cK8O0wPg; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf12.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741988971; a=rsa-sha256; cv=none; b=qNtplaspmI3alIGLTvUhlkf2hzUBELIpw2q4wqBuRdawgLYsW+BFT4iSGu0XAjGVFS2Omu itWXGrRR5x8DYIUvsXpKGZxIJDHQw6ejGJjJSM4zEIO4kQSfqkwEAvkX8DT9T+e4YWwlIq taoUjHHlmNMCyi150F2kyj5WLA8Wkk0= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cK8O0wPg; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf12.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741988971; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cZYWsdOHP6C4+PdhHTwr9/dCeV0iB2FgD+XADh6k0a8=; b=5BhPdrS23jjb9kKTaHsSlRr1RVC3bVikzHTBMXcXpeh/q+pt7KMlfa3S6/nxT+e41Vr93G w2DQMfMDFG6WmUvhSMYwcTeEv2SUldp6RmwUZMZFOsN4WVDOm7tcgTdyFGuDkH/O6FwIcP BrFhy6wtS5NrxBFpQfM9cBH0MxjmSL0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741988969; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=cZYWsdOHP6C4+PdhHTwr9/dCeV0iB2FgD+XADh6k0a8=; b=cK8O0wPgicYuLmev7drin3WCvampa1v1yJiYjtLe+5qzmS79ja67lvOawzjYPRkNSjqxpO 2iODgfkQ/raAzgkrJ6+U23A4dpsW+d3DodYC/etQ7GrMhPCP6RwhFLHSIyduxP+m9Fr4ls sk+1rnw+tjHqF2Xgne6g8WCJ6HNvCF8= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-211-9T9X0geJNE29rfYAFVO60A-1; Fri, 14 Mar 2025 17:49:26 -0400 X-MC-Unique: 9T9X0geJNE29rfYAFVO60A-1 X-Mimecast-MFC-AGG-ID: 9T9X0geJNE29rfYAFVO60A_1741988965 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-43ab5baf62cso1577815e9.0 for ; Fri, 14 Mar 2025 14:49:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741988965; x=1742593765; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=cZYWsdOHP6C4+PdhHTwr9/dCeV0iB2FgD+XADh6k0a8=; b=O+2t06mOeaJtPnuI9MrZQgnrgqFBeZ9VJmbuM2LdbxR/9GLyCbNAzj6RR86jY6V6q1 XB0b2y+BsUC8tN4XyvYrgXjL/aTgPNSVKai8wxsJPIFARQeWXrNOL3nBFWMNHz3t/ewC OL5Bo1bKTdu1Rj8dosOZduVjzg3pxmwocw3r0uFK1nSe6xKVgQdojw8CA7oJ45/BscXC /fh8WxYXnBSGP+81gbY31P57osYCu857/DodXq+xWIHESdBhCZ5YQQdE/+REcxVc6Lbv mgyc0AEZEXL0FXkWA4Cu7CORyb5dk1/TlyFwTtStiNL6J7Z+SJq3oP2mmDRiminMV4Xz /GSA== X-Gm-Message-State: AOJu0YwHSYFcsiQJncrj0ForAtLoBwDDdOQXL6oUM9IAV40VskncGorQ 27cGq9OcRmg0k3vQUla0U76dExzZXbjvpxFeGiAWwKIdTdvlXuq3Ar4rCEAva5NFanAjDcHWigN 22p4FRhOwFxaKKcezgSUazUNQdwsFeg0UPGP5AlmNx1HHVzFD X-Gm-Gg: ASbGnctHar7n9CmeyDUPNACpWLtYL61b9NUQClgBPeEig1TY1jsiZvqdblwfZdeJaqu uIZC1B0YCkWwAnkpCm4ONz9b9RYYXtXdNbgv2tEWK8GPnYB7s6Cs7EVOyctija/cXYpY6aqLk5c azV8st86hGhpDA+favIBHi3yhj3xcTHtDl3wiNS5K/1gotdCUFw7W4A4KG8dJ4230e+zQ7ck4QI GPllgoqERvEUF6uE9/e3vq67nISv2GRAAThLeRsWjZE3BiCFj+MEXuwbQoZTmwhHdiR3fRZ8as6 9oU9CuBUApWiQKN8tAITyYFfaX3ByvSWE5k5zr3l0job0katCK6EVtJ0DqX5EWIRAYj5slx3eT9 9gwQNji9tefE2JwlScw/bjqKLncOzrQ2nn0wk179Vp5Q= X-Received: by 2002:a05:600c:4f8a:b0:43c:fad6:fa5a with SMTP id 5b1f17b1804b1-43d1ece2ef3mr53476385e9.24.1741988964992; Fri, 14 Mar 2025 14:49:24 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEYeQbo/IFne9gpgIN2GfhYoxaOYD0PqZUhtSLLU0gxTK94FbB62AArr/WjPvWPJo4xZMHy9w== X-Received: by 2002:a05:600c:4f8a:b0:43c:fad6:fa5a with SMTP id 5b1f17b1804b1-43d1ece2ef3mr53476145e9.24.1741988964514; Fri, 14 Mar 2025 14:49:24 -0700 (PDT) Received: from ?IPV6:2003:cb:c745:2000:5e9f:9789:2c3b:8b3d? (p200300cbc74520005e9f97892c3b8b3d.dip0.t-ipconnect.de. [2003:cb:c745:2000:5e9f:9789:2c3b:8b3d]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43d1fdda30esm29788875e9.5.2025.03.14.14.49.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Mar 2025 14:49:23 -0700 (PDT) Message-ID: Date: Fri, 14 Mar 2025 22:49:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/5] mm: Separate folio_split_memcg_refs() from split_page_memcg() To: "Matthew Wilcox (Oracle)" , Andrew Morton , Zi Yan Cc: linux-mm@kvack.org, Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song References: <20250314133617.138071-1-willy@infradead.org> <20250314133617.138071-2-willy@infradead.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250314133617.138071-2-willy@infradead.org> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Yld7yxh1D5p6Q__28iKUnIDIBHJiXCW0MXhnuQGeZMM_1741988965 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: wtis5o7pdmsjon5aj1qk1wicmpn6r6fe X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 5F3104000E X-Rspam-User: X-HE-Tag: 1741988970-52841 X-HE-Meta: U2FsdGVkX1/s2IPQOSBJcTH9bxYhPRelipmlBRWlIQamm2GnZF4LIroOn7ExjcSR0bTQ8QMZQuBhSSenaoRelIfDGcD7C+4o609b+BfjiaFXB8OX88Lhyg6vSurk+YN+SQKZ4fdPHMWYBKtd3DcBgIkP+UU1Mq65WR+Bm2br/7ZQfxE594EK3krlx5i/r5QeVyLGJiprHW6jypM7fys0MP+7BKxQ6PfO5vCBj1UE0OOqmWDorI6W6N4VV3+PgZj0WnTJ3hAbe7yudZ59KNvNaoffwPAKqxa45T5dSYfN/z36qKgmZd10+FRuR/XXbmV59oID2btg4qiddHEPDGUQG1dY0dgLYxgIBCWOrcfMePxPfkr0z4J4Qtj6HoaPUBPfOYgd/7WkJHjTg5s2DOw4UUJjwCXjB3jB9CDjoj04idErhZ7feiyG6Ud8LbO4n1j7o7mOQY5f+SZmZjbtMmBs4hVIQfRkl0e5fimCuuzBaneWn/Wkj/oUxG0t4jgMjOlWxO7RADou+lYPrsO51WTpzjd+T8C+cCd5naZzMokXbDNK6L+fVXP+O1l8Jd/SgPhdA/N+9G0/wXJ0GSY/CjFI5PxWjtdlzTey9dIwoLF+qE0qz5UGl+oMtFsXIss2KXCcP+1qFSAcnPul8hHJB2hH8FekdtNODUcqU6A0+rrdYoouqciyf56rN3ruHXMcT/dzoF+bzOC8UBqDj/nByeSKmSfQxAEPUrcNRE0DUzctPoSKoIgTa5wLjfl5MHUx2VGNS885YMvZPzLdv5fYTFJEv9i5WBQxD+VvL2ZDKI0yypDbnRNt9yQw2H5yR+9F5ZF7s0uGoGLKIqY2V0tbBfBZ6xhCxAXbEFLVqn468GU4dFeqSsoI9AbV6PGUoBnVyI7HECPCIaaiYmeauz8u7RukFRdSaT4Ajc4EFFcer6Nq5FOfLpjrJwhpmjwG2IxlkxVA0LageAYxhXryvB31bdl rqL/oqZ1 wcmMK8BRePKo0TDMgtLrZZSqIxAdMZZWJjTf4Y5dK+g4T/M1VdisEt2CRzdAcxyzpDWk5Ynh38VLyaonF7p4MQcL8vNQePtloncXBLpAv+tV4dQmRY8VWouZem3R+bRoFY96+jf/nsPNmAzw51Bb7tZ2DRWJv0HmOoroogzvi/9WmQjm3euWg26eOjxnN4iKAW3BanXnEWiovRmZzCGe6PTJaJ5QvbA/cSOEgYD6C9fi1+q5IEW6sa/e1JDsGMfGPSEsIpnDkllEwyJ9wPFI8FhI8bUsCZhHU1z5uz7rrlvxwOi0y7QRmcZrStBcFRfOsZjSQByF6JShHVjmnNqvm4jz4M4oiCOtoi1ej4/8WkCbxgWnL505Gidk4/DigF9hsKgDRsyCk4D3b1iW4IXBc/vouDZYyMVJjJO3yVC0qSH7aP6/Z1isVz6qHs1wgXOgf/KcHEDcrVsoIfpRehTOtXl8KyMmfEAN7WpngHqDJK8RXEvHPpHp9W9XanNMy8wrP3N0QcC7FTIAZjb7x2u/w/ckZ2tY5wYl5trMk6nasLYovqIL3Ld0m4ppG3/rtgD5WH3aXyedkVcI8L7I= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 14.03.25 14:36, Matthew Wilcox (Oracle) wrote: > Folios always use memcg_data to refer to the mem_cgroup while pages > allocated with GFP_ACCOUNT have a pointer to the obj_cgroup. Since the > caller already knows what it has, split the function into two and then > we don't need to check. > > Move the assignment of split folio memcg_data to the point where we set > up the other parts of the new folio. That leaves folio_split_memcg_refs() > just handling the memcg accounting. > > Signed-off-by: Matthew Wilcox (Oracle) > Acked-by: Johannes Weiner > Acked-by: Shakeel Butt > Acked-by: Zi Yan > --- > include/linux/memcontrol.h | 7 +++++++ > mm/huge_memory.c | 16 ++++------------ > mm/memcontrol.c | 17 +++++++++++++---- > 3 files changed, 24 insertions(+), 16 deletions(-) > > diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h > index 57664e2a8fb7..d090089c5497 100644 > --- a/include/linux/memcontrol.h > +++ b/include/linux/memcontrol.h > @@ -1039,6 +1039,8 @@ static inline void memcg_memory_event_mm(struct mm_struct *mm, > } > > void split_page_memcg(struct page *head, int old_order, int new_order); > +void folio_split_memcg_refs(struct folio *folio, unsigned old_order, > + unsigned new_order); > > static inline u64 cgroup_id_from_mm(struct mm_struct *mm) > { > @@ -1463,6 +1465,11 @@ static inline void split_page_memcg(struct page *head, int old_order, int new_or > { > } > > +static inline void folio_split_memcg_refs(struct folio *folio, > + unsigned old_order, unsigned new_order) > +{ > +} > + > static inline u64 cgroup_id_from_mm(struct mm_struct *mm) > { > return 0; > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index 14b1963898a7..3e5ecc8f3d13 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -3394,6 +3394,9 @@ static void __split_folio_to_order(struct folio *folio, int old_order, > folio_set_young(new_folio); > if (folio_test_idle(folio)) > folio_set_idle(new_folio); > +#ifdef CONFIG_MEMCG > + new_folio->memcg_data = folio->memcg_data; > +#endif > > folio_xchg_last_cpupid(new_folio, folio_last_cpupid(folio)); > } > @@ -3525,18 +3528,7 @@ static int __split_unmapped_folio(struct folio *folio, int new_order, > } > } > > - /* > - * Reset any memcg data overlay in the tail pages. > - * folio_nr_pages() is unreliable until prep_compound_page() > - * was called again. > - */ > -#ifdef NR_PAGES_IN_LARGE_FOLIO > - folio->_nr_pages = 0; > -#endif I remember that we could trigger a warning without that, but I don't immediately find where that warning was. IIRC, if we'd split to order-0, page[1] would have indicated that it had a memcg set, and something bailed out. Maybe Zi Yan recalls where that check fired. In any case, if that warning no longer fires this is a very nice cleanup! -- Cheers, David / dhildenb