From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1990C61DA4 for ; Tue, 14 Feb 2023 06:50:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 306F56B0074; Tue, 14 Feb 2023 01:50:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2B761280002; Tue, 14 Feb 2023 01:50:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1A6A4280001; Tue, 14 Feb 2023 01:50:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 09EA66B0074 for ; Tue, 14 Feb 2023 01:50:01 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id C3F34AB40F for ; Tue, 14 Feb 2023 06:50:00 +0000 (UTC) X-FDA: 80464972560.08.191AA9F Received: from out30-113.freemail.mail.aliyun.com (out30-113.freemail.mail.aliyun.com [115.124.30.113]) by imf13.hostedemail.com (Postfix) with ESMTP id AC55E20014 for ; Tue, 14 Feb 2023 06:49:56 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=none; spf=pass (imf13.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.113 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676357399; a=rsa-sha256; cv=none; b=tMpEVo34KO+24c2JSBisTqPdwkHr80bfuO5e+7qEwA/0KAn64dtlPo4EN0qjH17vmNWLaG YYl9hrnyG48v39tPdLaQ0mZn/40uEHVThJ43te2A44deir0ZEAnWTzYtrYGiAanXSoPLSi xdBXQDhPeuUblaFup5j03hpToESNlnk= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=none; spf=pass (imf13.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.113 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676357399; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5JkrAXurRL0B7BVwfzYv2eWmRnhhWbb1fUb0JaHmAks=; b=uKayxZ2I28ZTB9XlWKo+Xj0c4HIJhS3tww6gdy5T5loH9gbHx1Urk9UKLjeHGXj69kLpNn FoX0cWGqmWpDtf6IXTKY0ppsl4hy4k5Y4N9qIUifFv1m+PxKfVuFaHaDMWhi1gc+BdbDs7 lobgevKjwZtumFtqoED5ne/Nplt2yv0= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R411e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046059;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=13;SR=0;TI=SMTPD_---0Vbeknu._1676357391; Received: from 30.97.48.79(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0Vbeknu._1676357391) by smtp.aliyun-inc.com; Tue, 14 Feb 2023 14:49:52 +0800 Message-ID: Date: Tue, 14 Feb 2023 14:49:51 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH 0/3] Some cleanups for page isolation To: Matthew Wilcox Cc: akpm@linux-foundation.org, torvalds@linux-foundation.org, sj@kernel.org, hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, shakeelb@google.com, muchun.song@linux.dev, damon@lists.linux.dev, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: From: Baolin Wang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: AC55E20014 X-Rspamd-Server: rspam01 X-Stat-Signature: 5hphk64j1eydfuds1in8pe3goqfyg37n X-HE-Tag: 1676357396-34056 X-HE-Meta: U2FsdGVkX19ob4mG9L5fNWhBmtTHoEuAtBrnUOVILL+OekpzS3FnvkuuUXCfSYdDhvrhyeRtdTBq7MiZg4a8+ROq7YgllUxEoKUyBqSLMpL1Oeqk4TQcAiffX2cbHe308JezLwg3EMO55I15rXcTfANkBSU6oV5ssKBHk483nsEBIz9tblDEk9Z1XGauMZYzBUWwFRiJNeNxExv+6daoGCkVXi5rTFi75NrsEcfjiRr9gjwHVNYthcCg5L/WlD0Yxr1NWnRyvqBNxsovFIgUG0yEX5sWkDv5ylTbd4/h+8xVBScE8cd3YEut5A0nMqmyufLjAJ6Pl61H1G/aZ+BtRfkxs008z6FIaK5OE0zEg/PtcBn4t0yigjX+tvNjmL9hZ4yqMScwkWxLc1HFcbVgqrCGuY4zlloLKt044kP8rDilx+8bZ9TdA84lBFuBvoUXNoE7oqTtLSFXFqk99RoyzbQ+Ori+mGM0dG1yDFaPGLxK3qER9A7RcXKmSU4cmZ1cc8awj5UdPdhEX5r1jDLHtm97ufIxfYelXlX6A5HqJ8t2c10gvYalLowUkp8cZRd9eQ5miqtD4BYD53IkK/VN6eOZ8yfILo3ufxBdYhqFsOycNmdc8+vvuZ6NQnMw6K4KoT5taaVVxW/oY9MYSxIHzxM9+RJbrj33B+zzfdn9oM+Yslmd4cbDzOsqkDa8Fv31eyXjkJQis0w7RZ0NueKFlVtOIOxHLqK59dw0C6y8CnKaitzh1q3DiCzCx9M+RBI1JHdrYtQtCNyw89PfXSxV3CS1T+Hb0Jo9L+9Bt8LZbaX+3lTl4LCAqPdx85TrBBa5DSbNYBzL4vdiQkgCqWZWJs1K5eTW+Bc/TXp5S19/Wh2DBqcQuVUrnaYJmaGrp0pTHzhx8mkZRCeCt6no+Kk+iZPEqdhCkgTAIsO7sr5taYv+F7gKF+G5BM4cPEWcUj+xOpBkaEom7bA1ybCbx9Q c9KrRR1X wrJJCkiJMC+By+j2qMtR3NnZ5x6/PDHO2xDf9pwSx10kLG4MdTP714YjgcHcVXHs563CiQ+vCtvnXbvisKT6k8S5OdCvTWP5HRJnIoJkYMz91zPgMA4XW4+PinBNVyQl5LNGyF5PWryb8mz0uuoBv/2RkmhurtPQaZggPj2LuXh2jLAav+D7vtw5iODO+SY+giXJW X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2/14/2023 12:50 PM, Matthew Wilcox wrote: > On Tue, Feb 14, 2023 at 11:18:05AM +0800, Baolin Wang wrote: >> The page isolation functions did not return a boolean to indicate >> success or not, instead it will return a negative error when failed >> to isolate a page. So it's better to check the negative error explicitly >> for isolation to make the code more clear per Linus's suggestion in [1]. > > Only one caller of isolate_lru_page() or folio_isolate_lru() actually > uses the errno. And the errno can only be 0 or -EBUSY. It'd be > better to change the three functions to return bool and fix > add_page_for_migration() to set the errno to -EBUSY itself. Sounds reasonable to me, and I can change them to return bool in next version. Thanks.