From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 236B5C25B0E for ; Fri, 19 Aug 2022 07:43:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ACCCB8D0003; Fri, 19 Aug 2022 03:43:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A55728D0002; Fri, 19 Aug 2022 03:43:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8F6228D0003; Fri, 19 Aug 2022 03:43:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 7B3808D0002 for ; Fri, 19 Aug 2022 03:43:34 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 4F409140264 for ; Fri, 19 Aug 2022 07:43:34 +0000 (UTC) X-FDA: 79815552348.24.C364C95 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf07.hostedemail.com (Postfix) with ESMTP id 2BAED40015 for ; Fri, 19 Aug 2022 07:43:32 +0000 (UTC) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4M8DG34789znTcy; Fri, 19 Aug 2022 15:41:15 +0800 (CST) Received: from [10.174.177.76] (10.174.177.76) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Fri, 19 Aug 2022 15:43:29 +0800 Subject: Re: [PATCH] mm: hugetlb_vmemmap: simplify reset_struct_pages() To: Muchun Song CC: , , , Mike Kravetz , Andrew Morton References: <20220819035532.6189-1-songmuchun@bytedance.com> From: Miaohe Lin Message-ID: Date: Fri, 19 Aug 2022 15:43:28 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20220819035532.6189-1-songmuchun@bytedance.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.76] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660895013; a=rsa-sha256; cv=none; b=lyUXIm432Kq+C3pOZeppKSAv1I72Tl/+JPHkFbxjPWwCPTHkicTzp6jxguNKG5fVvMD+Nu 0efjvxd6x8Jh56wHvIYQTdgsKEH6UdIayggpRcdeDrDIQFgAktWZU76XUJGD84HuC4ITpG o+/0NyqxCY1pUHmSOKbYKt5PnvQs+YA= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf07.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660895013; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XBjIYvNIR3SwpDiIU0dxCOxEcITKQ1knzRy7xIHIivw=; b=nYKd+jZVhNhCTOoAWdP1nniXuUy2TdwDkabByXSVp5cKNEBCoQMzZraxNBJcAdXEzZRClA RMm3fYdnOQQ/UztQGtij3KjodkHUwIr371ILMy1HunBNZD2Yg0IQP45eZys3hyuvtea2rg KCdnNMLC/oXaiUhpYsUfE9ahApKqSak= Authentication-Results: imf07.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf07.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com X-Rspam-User: X-Stat-Signature: k3qoe1ya9j36srnsaphg1zwew51huef9 X-Rspamd-Queue-Id: 2BAED40015 X-Rspamd-Server: rspam03 X-HE-Tag: 1660895012-885754 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/8/19 11:55, Muchun Song wrote: > We can choose to copy three contiguous tail pages' content to the first three pages > instead of copying one by one to simplify the code and reduce code size from 229 bytes > to 63 bytes. The BUILD_BUG_ON() aims to avoid out-of-bounds accesses. > > Signed-off-by: Muchun Song LGTM. Thanks. Reviewed-by: Miaohe Lin Thanks, Miaohe Lin