From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F02CCC4725D for ; Fri, 19 Jan 2024 17:00:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 66E0A6B007B; Fri, 19 Jan 2024 12:00:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 61EB36B007E; Fri, 19 Jan 2024 12:00:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 50CE86B0080; Fri, 19 Jan 2024 12:00:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 434FB6B007B for ; Fri, 19 Jan 2024 12:00:50 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 197D31C16C7 for ; Fri, 19 Jan 2024 17:00:50 +0000 (UTC) X-FDA: 81696675060.21.7BF4845 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by imf15.hostedemail.com (Postfix) with ESMTP id CBFE1A0033 for ; Fri, 19 Jan 2024 17:00:45 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b="M1 OURMW"; spf=pass (imf15.hostedemail.com: domain of quic_charante@quicinc.com designates 205.220.180.131 as permitted sender) smtp.mailfrom=quic_charante@quicinc.com; dmarc=pass (policy=none) header.from=quicinc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705683646; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Qy1pMhP/rRJ1IzNoHsuqbIjw26g6hcRy+ObDQ8oRG60=; b=B8vIUgXcFZUUsbBQHdgt9OJ93XwrraQIQRim2Vy8dUSOtPgK87PQhss+DtH980owvhbq3Q /aOLRGRvHD//eGXRAatvAtWnkLQLpXGurTQB2hF1wXoFMwAA4ewjLUxC6iS86iIQgw850n FQRHKB2k+udPSh22sPGoGWiZdXEcL50= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b="M1 OURMW"; spf=pass (imf15.hostedemail.com: domain of quic_charante@quicinc.com designates 205.220.180.131 as permitted sender) smtp.mailfrom=quic_charante@quicinc.com; dmarc=pass (policy=none) header.from=quicinc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705683646; a=rsa-sha256; cv=none; b=WU0Lm6k/BHTxiF7mLCql+nfMHMTr9LAdNXAxOUY8k2lYY3TQgGqxNYqsL3/UOgzySxu5h/ n0IcQlb6sHA+koGnb80EXmXVooVFbLyoPcO5j69yBb9SqfORiuwFwU1Dkqc8nrn8zzH6ev eOXF1XcEKHBjF+M67wmoFMZ0+DH+LbU= Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 40JCbQb8010388; Fri, 19 Jan 2024 17:00:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; s= qcppdkim1; bh=Qy1pMhP/rRJ1IzNoHsuqbIjw26g6hcRy+ObDQ8oRG60=; b=M1 OURMWYeZjNu87Msk/DWWDq3WAcNenMOtUDr/I17mqxbp0nz5TAx7AK0pZtFDqddz PD3J3/LJnwaSLii5oK3gbwbWs2qAxLsinqg4SqChxiwgO+X2OnDyqiHlTSOTjtkg aDghS70ki9OActoy+puA49g7RNDzbo4avdQDCzrEno7NzjzBXz+W/1gyHlrUAlaY qmzqKveYgFpkjbwRHA1Awbz6CIMD8YYT8i+NFlQXoIv+YYwMN9zRv062d4/p4Heg Hkms5+W8ALH/KGuyphpsrd5hLIyDMkMZD0ohoQQgb1TVuc//LRCcit/ZeKkMj79n EN4vGK+6QsCRi7UQa5Rw== Received: from nalasppmta03.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3vqpkvguj8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 19 Jan 2024 17:00:32 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 40JH0UMe027236 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 19 Jan 2024 17:00:30 GMT Received: from [10.216.49.108] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Fri, 19 Jan 2024 09:00:26 -0800 Message-ID: Date: Fri, 19 Jan 2024 22:30:22 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] mm, kmsan: fix infinite recursion due to RCU critical section To: Marco Elver CC: Andrew Morton , Alexander Potapenko , Dmitry Vyukov , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , , "H. Peter Anvin" , , , , References: <20240118110022.2538350-1-elver@google.com> Content-Language: en-US From: Charan Teja Kalla In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: vwcSK_orfgT8C__2D3CJHzd-MY-j7Ask X-Proofpoint-ORIG-GUID: vwcSK_orfgT8C__2D3CJHzd-MY-j7Ask X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-01-19_10,2024-01-19_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 lowpriorityscore=0 mlxlogscore=739 phishscore=0 bulkscore=0 impostorscore=0 suspectscore=0 priorityscore=1501 adultscore=0 malwarescore=0 spamscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2311290000 definitions=main-2401190097 X-Rspamd-Queue-Id: CBFE1A0033 X-Rspam-User: X-Stat-Signature: 681adxh8gsk6tbwyaenr1d511agn7k8m X-Rspamd-Server: rspam01 X-HE-Tag: 1705683645-61798 X-HE-Meta: U2FsdGVkX19H+5f4MqgqaHfYwM75SKXpolKLCNtEMXvEm5A6So8nVy2PSEJPn4yRv9HM6CqeebMS/y9hFCL3bO8VIjGQim8Bq/h3lGFp0rKZRCi70On3eZHLlyjwuZVamO73mn1pgGslrV0fjKrZRLfJqrYW4hz7A0qBT+QvzneU8JKEY0jwVXU2nblLa/nFwZ05WExPq66+sdET/qwTTpwpmHe7JxKH17yt2Q7+CHyqLQOzEfDzwmrLWULZwME6kSwbDW3W4Eeegs2auA9ZWvPMN14CLElmmjgF3nLnG0qhUg3AhNppf1s7iz7RBg8H307ZyBt06PpcCsJgb2a36mTTMixoH3z8+4PWOplw/5gv0ogqC3fvFgr3HYTSoMY87H0v+Ns8yXZE/i/YAzSL828zrjCYqVRJ3IWIC3xnbJP16WYhgpWayg2RcmIXSQOxqHvSjE5cFzl9Ehwl1T5KjiO0K6BIyPtNIA1FE4016rgpG64MPf6uKc3BkBbaUuKeU2IkC9nQvM0OFFuIlcmBF1EP6mZlR10/FsS1kT1O1EcYqYSQ4eToWWqc7qIEXOa/dXLg+JR+wYmvehWMngapE+THQ2Jk1w3dsSOP+B+D3dtb+yGcQs44494OiiiTveTV9YgEYl0xZ2DO7Z0JzJ74PkifofTXNz+DDhW3k+uuKcb7WzhQ+bdw0by0lGWilmCtXeRecK7iz0+cxTkN/gkp7fteJDx2NPp8VHBCLCWRMzlpSST8QH056bw7p2O+VmAUkc3Un4ikGBmHFB6w9JDB/K6rBjIQtH8oHxq26qIcObhrvGRKxHsXhU71dOCBlnbIQ+EVA70dc0BR/zr+sB6GRMzvOfpsThX1+fAWgXdgr7aBrftVZ3RWpUG2EIEwhOaTayabMJRinYZzBpodKliTdEHEsMJOP8mzH+v/DTQu58nwH/QRa7t2DP/fFvwPTiDdB7CoQM6vjdmx/aTyg4Z zlrQzAUY uUFtARAHByc21+4e8E9Ub8xxCHspgtoTEXc3bq3rkZcgO5xptIzl8LmfW1n6sLF9XGPcFrrdzS7OrBivUjotzwin6tlgbDwtsfzpZb3oO/oxuryN43enNyutQnYVReCpEcaXAHgGl4uHVa96SLH7Jn9CEmaAqQCafKYEQKkYegSgqwX6MVDeaQa6XcSjT1Tq0Izvw2P00UVv9Wl2fWEUW7Wbj0Ay8kg9aAFrbbu/V+h7fUjUbUAxsBQjmq8PRW3mXurGRs+Bbb4s3L+mLZSAjpYxnzDkbyw/8YBeKF6mj1agBvv3bLaC4xpIyjBv7DIgAzhsxPx9BkurXqs9ecxDqqrcJs0eXJdXsU+KwWKjONZnZmRM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 1/18/2024 5:52 PM, Marco Elver wrote: > It would be nice to avoid duplicating functions - both options have downsides: > 1. Shared pfn_valid(): it might break for KMSAN again in future if new > recursion is introduced. > 2. KMSAN-version of pfn_valid(): it might break if pfn_valid() changes > in future. > > I suspect #1 is less likely. > > What is your main concern by switching to rcu_read_lock_sched()? No concerns from my side. Just wanted to know the thought behind changing the pfn_valid instead of kmsan version, like for some functions. Thanks for the clarification.