From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: Anshuman Khandual <anshuman.khandual@arm.com>,
linux-mm@kvack.org, akpm@linux-foundation.org
Cc: linux-kernel@vger.kernel.org, catalin.marinas@arm.com,
steven.price@arm.com, gerald.schaefer@linux.ibm.com,
vgupta@synopsys.com, paul.walmsley@sifive.com
Subject: Re: [PATCH 1/2] mm/debug_vm_pgtable/basic: Add validation for dirtiness after write protect
Date: Fri, 27 Nov 2020 09:22:24 +0100 [thread overview]
Message-ID: <a6f79aba-9f9f-326f-5d73-6e0175f554ab@csgroup.eu> (raw)
In-Reply-To: <1606453584-15399-2-git-send-email-anshuman.khandual@arm.com>
Le 27/11/2020 à 06:06, Anshuman Khandual a écrit :
> This adds validation tests for dirtiness after write protect conversion for
> each page table level. This is important for platforms such as arm64 that
> removes the hardware dirty bit while making it an write protected one. This
> also fixes pxx_wrprotect() related typos in the documentation file.
>
> diff --git a/mm/debug_vm_pgtable.c b/mm/debug_vm_pgtable.c
> index c05d9dcf7891..a5be11210597 100644
> --- a/mm/debug_vm_pgtable.c
> +++ b/mm/debug_vm_pgtable.c
> @@ -70,6 +70,7 @@ static void __init pte_basic_tests(unsigned long pfn, pgprot_t prot)
> WARN_ON(pte_young(pte_mkold(pte_mkyoung(pte))));
> WARN_ON(pte_dirty(pte_mkclean(pte_mkdirty(pte))));
> WARN_ON(pte_write(pte_wrprotect(pte_mkwrite(pte))));
> + WARN_ON(pte_dirty(pte_wrprotect(pte)));
Wondering what you are testing here exactly.
Do you expect that if PTE has the dirty bit, it gets cleared by pte_wrprotect() ?
Powerpc doesn't do that, it only clears the RW bit but the dirty bit remains if it is set, until you
call pte_mkclean() explicitely.
> }
>
> static void __init pte_advanced_tests(struct mm_struct *mm,
> @@ -144,6 +145,7 @@ static void __init pmd_basic_tests(unsigned long pfn, pgprot_t prot)
> WARN_ON(pmd_young(pmd_mkold(pmd_mkyoung(pmd))));
> WARN_ON(pmd_dirty(pmd_mkclean(pmd_mkdirty(pmd))));
> WARN_ON(pmd_write(pmd_wrprotect(pmd_mkwrite(pmd))));
> + WARN_ON(pmd_dirty(pmd_wrprotect(pmd)));
> /*
> * A huge page does not point to next level page table
> * entry. Hence this must qualify as pmd_bad().
> @@ -262,6 +264,7 @@ static void __init pud_basic_tests(unsigned long pfn, pgprot_t prot)
> WARN_ON(!pud_write(pud_mkwrite(pud_wrprotect(pud))));
> WARN_ON(pud_write(pud_wrprotect(pud_mkwrite(pud))));
> WARN_ON(pud_young(pud_mkold(pud_mkyoung(pud))));
> + WARN_ON(pud_dirty(pud_wrprotect(pud)));
>
> if (mm_pmd_folded(mm))
> return;
>
Christophe
next prev parent reply other threads:[~2020-11-27 8:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-27 5:06 [PATCH 0/2] mm/debug_vm_pgtable: Some minor updates Anshuman Khandual
2020-11-27 5:06 ` [PATCH 1/2] mm/debug_vm_pgtable/basic: Add validation for dirtiness after write protect Anshuman Khandual
2020-11-27 8:22 ` Christophe Leroy [this message]
2020-11-27 9:44 ` Catalin Marinas
2020-11-30 4:25 ` Anshuman Khandual
2020-11-30 9:38 ` Catalin Marinas
2020-11-30 10:58 ` Anshuman Khandual
2020-11-30 11:01 ` Catalin Marinas
2020-11-27 5:06 ` [PATCH 2/2] mm/debug_vm_pgtable/basic: Iterate over entire protection_map[] Anshuman Khandual
2020-11-27 9:14 ` Steven Price
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6f79aba-9f9f-326f-5d73-6e0175f554ab@csgroup.eu \
--to=christophe.leroy@csgroup.eu \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=catalin.marinas@arm.com \
--cc=gerald.schaefer@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=paul.walmsley@sifive.com \
--cc=steven.price@arm.com \
--cc=vgupta@synopsys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox