From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06426D3C52C for ; Thu, 17 Oct 2024 19:37:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 741436B007B; Thu, 17 Oct 2024 15:37:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6F0CE6B0082; Thu, 17 Oct 2024 15:37:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 592126B0083; Thu, 17 Oct 2024 15:37:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 39F136B007B for ; Thu, 17 Oct 2024 15:37:11 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 38BB11C271C for ; Thu, 17 Oct 2024 19:36:58 +0000 (UTC) X-FDA: 82684102368.22.E5B8727 Received: from mail-il1-f169.google.com (mail-il1-f169.google.com [209.85.166.169]) by imf08.hostedemail.com (Postfix) with ESMTP id E8EFA16000B for ; Thu, 17 Oct 2024 19:37:01 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=fs96GUMg; spf=pass (imf08.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.169 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729193683; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6kDt4PSqwqzed7xdM+ppYuwWc64+1n90tTzAqCyOu+w=; b=G1182FhbjTdzsMZl5v7oll0nshr5fmAZbIUONunBywLwhW0KAM8A/9XGA+JGRY6ckvrqkz RN1cCzbFhWaIrgwuEqYLYCRfYgrX6taUximqtN+QIwAIVuJVtHadCfa9dthMEojztuq0HD wiBt/srXNPYAmxSRHPxwR6Pc0SX73Gk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729193683; a=rsa-sha256; cv=none; b=Sv2jbSnZ2BEmcfEzjj22j1BCFsxwffpmKCXP7ruRlSCscqNcBgkxTqyrFUTE153MI1imvE KZFrrLo0aockJIEOqch7aNha550T1ats13vHYadqjYv51hvUp9ftwNDoNej23ruhm/YqmP PHJ4NeEmE1h8KgKhiPfqdDXVCkNRJ6Y= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=fs96GUMg; spf=pass (imf08.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.169 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org Received: by mail-il1-f169.google.com with SMTP id e9e14a558f8ab-3a3a7b80447so5245925ab.1 for ; Thu, 17 Oct 2024 12:37:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1729193828; x=1729798628; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=6kDt4PSqwqzed7xdM+ppYuwWc64+1n90tTzAqCyOu+w=; b=fs96GUMg+44TDzOFsfl39fzTv1WmqpUeCW4dBfJ0UQ9wyxJ5E17qO/f0qdY4yl1GRT x16kcEHzRy5KiewXB+ejP3DK3XDYdEE0tZayR2yfovyDbv963hV2G7JWdQf6O3Srrlgk g+36kfkmQKtsUFRF6F6QU541tdhc2KcGPxUTs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729193828; x=1729798628; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6kDt4PSqwqzed7xdM+ppYuwWc64+1n90tTzAqCyOu+w=; b=L17/LvjTyaa3OzOWvJTN2WCLDKsj7JlSqpUK0ylFryzLDfJRNSwVjwtVzgh780TDPq a8YLTBx2E/idSKRu114SPs4R5WoSHWkXcpuxR6E4rUqXCTUmY3eoGsvepaHtqbcJFP7w CyMT8v73aQQ/WNwWBNfLLPySVry2yRiYNK388sAzn5KT0nYNGMHTibQ9kK/zkPvx+AyB xxJdIVVUUNdMV1feQ7vRxtgFjcKz4y45fl3q57ikVg5XSuD1IrSDVHkUHxjIK8rqQO80 DnJdK72ZjOwlSeb1HVesQ3XevlnMYHFn1omv3+bMHSPGiLbZluhshFl6uymiPP8CAhvM 3ksg== X-Forwarded-Encrypted: i=1; AJvYcCWjudP5RqF4QHABIyCCMD185vMxWq0niP6xvEXdOMkw5hH6+oiwd3SzFeHvxBdf8yIIFwT8jxn5sA==@kvack.org X-Gm-Message-State: AOJu0Yx87h+8KXr3vImflDrNiVtdk58wy42WwCITMkj83HIHrNzoQOFA 2Qug+YXoJI/NxvV1nIHAZmwiBx5l5Irswn19K2Bu5tfLH+5GqkU92eQawxu2I7w= X-Google-Smtp-Source: AGHT+IFkoyHAtNPtcVEkmnW87sgrwm9C/4bHGNtVw7TLSwB6i4QHE4KUdS6c4sui6FUCDwQh0ZK9/g== X-Received: by 2002:a92:b701:0:b0:3a3:dadc:12d9 with SMTP id e9e14a558f8ab-3a3dadc1780mr78958115ab.25.1729193827785; Thu, 17 Oct 2024 12:37:07 -0700 (PDT) Received: from [192.168.1.128] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id e9e14a558f8ab-3a3d70747besm15386025ab.11.2024.10.17.12.37.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Oct 2024 12:37:07 -0700 (PDT) Message-ID: Date: Thu, 17 Oct 2024 13:37:06 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/3] selftests: pidfd: add tests for PIDFD_SELF_* To: Lorenzo Stoakes , John Hubbard Cc: Christian Brauner , Shuah Khan , "Liam R . Howlett" , Suren Baghdasaryan , Vlastimil Babka , pedro.falcato@gmail.com, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, Oliver Sang , Shuah Khan References: <84c0de17-899e-46fd-8b72-534d8a02c259@linuxfoundation.org> <6080fb15-9073-461c-a87d-80e6daa326e6@lucifer.local> <6e0bef3a-6667-461a-80f9-791891e11d8d@lucifer.local> <97b6a4ea-d53a-47f1-8e64-5b9558f194c1@nvidia.com> <28184c3d-3c88-4f8a-a25d-7b5268b55c93@lucifer.local> <79f70ce6-f2ad-4fa6-90b9-6a0a936669e5@nvidia.com> Content-Language: en-US From: Shuah Khan In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: E8EFA16000B X-Stat-Signature: ekh5c8mng3ce8ow6ugcj4dpmkwm5xkjm X-HE-Tag: 1729193821-69491 X-HE-Meta: U2FsdGVkX1+3U8YrUU7BosCrRZr5XBAJOtBI3BolKP8YLmc1Hxz5N/1VgUhNWf6CqeYLWfRJ+5UgcGG2Dyxhr8IRsoqG1wkW4QK4TkHpUg4cfzmUa9WYhQQkw5vJXkWIQGqgOWjtgJNFgb7AZ1xIxjsbv7hthoQfcQFJ2Qt3ybzWTm9CjHH5kjMxccYX3hY5Zu20ptNt6Qe/az09ckAqANPsUepeBdSO0jSv5iZHosMnWC6o0HK1MMHqmw6YmfxQB/6BPWQzVd3efgtBOeYQYEIAb8upG6hiLOGuFMWiYPBZsRJHEkZ924cVt5MNh+5BnRCDW0rPeyZ8mJ8komTdi9ZmoRg7wVY4ZI0zLrAYG0OGQ3i4DvevODoxdFWt4deQPwC0C9SeijH9YZAzO/Ma+zJ6tDuw/A4NnrhSraoPyl/ToFbgFwazgsquetSls7bRqtie1IBjH68D0muup4TncOyTJcxAP+t7heawNrqvfGU8F2qAr3uVB1vWf2myyFPD9Z789UZ626G76b80kBtUvCM4crmXGodxxS2f7mITcKJsYqmGjJhIgdRjLqEbcWvw5x+FkEyrt04TLXQAy2dT/gl/eNSunRwPOkd75EKBlzEqIHH0oAa1zhG4Q9b0qyii8yUUiUxd2JdIe4Ylc+bQCoCsId+6TS6bWUiOoEwhmrw9KqWGl1YSQ7QL9+kkIrNTo8E/qo4Gl0IXWxGxPvd8n12I0W2BJnQHCrhqJGzjCVYQe+FOK2tz1jq+IYvzvPVi79FSzTVDKPfJ5Hy0nJAmdecncOojaSzUbOpxTCxWgbzL0H5E6PlBx199GZQXI2+YEVn2eXL0ifMXjd6sfkwDfW/XJwfPUXgTcqioiGFJeTCiJeKM4r1aFzrYGIaLMURn/G/WOjIfkmyyfg9dTU00plRTDUGt3SwO5nvt7utFFuSR/kPBkGD+9xAH4RHjHBhsvS0AooOyRjI9ejpXPAE ShpjOx73 y0TBUNPXGPy7CY0UIlKq3huOCxE+1cEsP7m33V0oea1TlRm88mr/PYhRBE1ZqZVdnwVmZOEbLh3vI69uELDx6deTN3zuyS7aBMsXCV2U83Ful5JF8J1kGIZzF5huGl3vBOP18BgFXORIRyTYEICQmUTDzw32PobZ+MGM2aZ8NkL3RVNIoMNQFnHPRjmd9k7Wg/naF4Oeg4iOK7vm2KWKc4soATdqQMchkTShaqw0yqFE25Ytf1w/wdiozCkN1eaV6alC3b7r4uZuUcbFVb7CO9RZR5L4cViQ0HLgKoI9qhBm90pJnty/7ghyAsl5UjaDahUaatIqhXLC0NBL7uVfg88UyADn9zzf7MrVwqfzqoVrje2b05KDgxk9smZdTEo81nemlSIhpF9aZq86sA2CPBYuGz+V/VvlBzlMw8hcMM2YpzWwsN/edrFBjyOmUjSryHq4yauRY05Zun0Z+AYo8kKsCZJP+HAQwxYxktsz3ZUKr1BHd6HeKwN8zHa+ffuRqHzGkBoAxUc9z+vRqLVcVwBe6Gw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/17/24 11:38, Lorenzo Stoakes wrote: > On Thu, Oct 17, 2024 at 10:37:00AM -0700, John Hubbard wrote: >> On 10/17/24 10:28 AM, Lorenzo Stoakes wrote: >>> On Thu, Oct 17, 2024 at 10:17:54AM -0700, John Hubbard wrote: >>>> On 10/17/24 5:06 AM, Lorenzo Stoakes wrote: >> ... >>>>> #ifndef __TOOLS_LINUX_PIDFD_H >>>>> #define __TOOLS_LINUX_PIDFD_H >>>>> >>>>> /* >>>>> * Some systems have issues with the linux/fcntl.h import in linux/pidfd.h, so >>>>> * work around this by setting the header guard. >>>>> */ >>>>> #define _LINUX_FCNTL_H >>>>> #include "../../../include/uapi/linux/pidfd.h" >>>>> #undef _LINUX_FCNTL_H >>>>> >>>>> #endif /* __TOOLS_LINUX_PIDFD_H */ >>>>> >>>>> >>>>> Then the test code needs only to update the pidfd.h file to #include >>>>> and add a simple $(TOOLS_INCLUDES) to the CFLAGS += line in >>>>> the pidfd self tests Makefile and we should be all good. >>>> I like this solution. I should have read this message first before handling the others. >>>> Yes. >>>> >>>>> >>>>> That way we always import everything in this header correctly, we directly >>>>> document this issue, we include the header as you would in userland and we >>>>> should cover off all the issues? >>>> >>>> Very nice! >>> >>> Thanks! >>> >>> I saw from your other thread the idea was to take snapshots and to run scripts >>> to compare etc. but I suppose putting this into the known-stub directory >> >> Actually, I'm not running scripts, because the only time things need to >> change is when new selftests require a new include, or when something >> changes that selftests depend on. >> >>> tools/include/linux rather than tools/include/uapi/linux would avoid a conflict >>> here. >> >> This is the first time I've actually looked at tools/include/linux. That >> sounds about right, though. >> >>> >>> Or would you say the wrapper should regardless be in the uapi/linux directory? >>> >> >> No, not if there is already a better location, as you pointed out. > > OK perfect, I have a patch series ready to go with this (and addressing > Christian's comments). > > Shuah - if you are open to this approach then we should be good to go! I am caught up with the discussion now. I am good with this change. Reviewed-by: Shuah Khan thanks, -- Shuah