From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FF64C47DDF for ; Thu, 25 Jan 2024 08:17:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 25F1A280002; Thu, 25 Jan 2024 03:17:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1E7E88D000C; Thu, 25 Jan 2024 03:17:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 03A43280002; Thu, 25 Jan 2024 03:17:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E8C128D000C for ; Thu, 25 Jan 2024 03:17:13 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id A84A4A0C88 for ; Thu, 25 Jan 2024 08:17:13 +0000 (UTC) X-FDA: 81717128346.22.2583A8F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf29.hostedemail.com (Postfix) with ESMTP id 85CAD120025 for ; Thu, 25 Jan 2024 08:17:10 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=b3FB+0O2; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706170630; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UZLvbQ/sj/IqlociRX/ySFK6it2BLTBR7c6/FUndS40=; b=r9C+fIcaKOp+c3C8Hvt0y+BvV3wlPdiWb1wUbgdWFeFsyqR1l7XYBF5+jaJxpwlh7dEgli m/tEVy+4kihFxBTZSOstD6UEhO3VDOyU2qOLmUK2fMbTxz1HNxaci2+W4rXUFDXfbOpQ5K F1s7HR6sNdey1fdxKslwgz3BSE4XObI= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=b3FB+0O2; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706170630; a=rsa-sha256; cv=none; b=WZ5bHyZkejOAiBoUHRcA7YvQ/DzsMm3r2sgyM0dDDly7+rIplHeyW5OeFxcObqAl9t0s8u SwwuFK/23vt/bpyVsUcrg9CtDLjnqy9M8iHfH1j1eAi7PTitWJpEaNmlGg8DU2CHUJp1B5 7sTHHm9+lOimbDQiIoc9Ej3gTdrSG9k= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1706170629; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=UZLvbQ/sj/IqlociRX/ySFK6it2BLTBR7c6/FUndS40=; b=b3FB+0O24/tJNSao7q6o9oekbSb8UOVWAvGUjyP/wOYbQvSd9WC0L2cQHwzS1OnScIIQ69 VxrCU+JaKxcVP2SB871eNAGCpUUVgFnlo9Um3Hj/vEn/FtorLFaN/8Zgi/MMYti5kmVBYI pU3VZtvfhAQMVOKueg66K2HNMLYSghY= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-675-zknCrQriMsKWt9OUb-TN3Q-1; Thu, 25 Jan 2024 03:17:06 -0500 X-MC-Unique: zknCrQriMsKWt9OUb-TN3Q-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-40e53200380so55305205e9.3 for ; Thu, 25 Jan 2024 00:17:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706170625; x=1706775425; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=UZLvbQ/sj/IqlociRX/ySFK6it2BLTBR7c6/FUndS40=; b=WTEZA4YFflNm2Fcvndl0xjAFxz2ElV7y58rWB3a30eldcQb8sGo8XxuFwnfSxXO4hN YuiU4ts4DQnRla7kTSRYH8T5YGSfBAKrPOr0sWV/n6FbfGIZZMCyEvGvP8pzmF5l5NyL ye0R2nCuHzMgZCAS5SibezIjvD97sH64XwghLK4L2EeME4ioYgEMPu8h+nLWduW+/C+2 akCSExJ1r6VOS83c7ZHoayb+3Zn/tIBvCKBpjsEI+sA8zv+tjqGxYxMQ0n26BEToSMDl 3+R8CnNu1Pt5V+MW84SXuK2ONNFT/UmYdUwbEZPQY4OmaQcRGYSUFtuxMqUIHij3VxMc 6gYA== X-Gm-Message-State: AOJu0YyqmS44uSTqvfCrU1afmQgeQA+2pM87GyVJUSw0ARIWEle6JOey Fl5YqjbUVHRgVkubDyRrOFSBKUObW5BaO/5d04oMIn3+W4SXgEggrJg+92mLdjcYdj029dupMMD cbnjMVGeCSElsq8bJndbZG35xvThlOmzpbnk5vzH9oErciYaO X-Received: by 2002:a05:600c:4f4d:b0:40e:a32c:988d with SMTP id m13-20020a05600c4f4d00b0040ea32c988dmr107920wmq.4.1706170625365; Thu, 25 Jan 2024 00:17:05 -0800 (PST) X-Google-Smtp-Source: AGHT+IHBXG0c1n69CXCyo5Gso5jszoyqCLj5BPA212FZgRTdtFdTJYJL0uYG9mHoKZFGV423EU1+WQ== X-Received: by 2002:a05:600c:4f4d:b0:40e:a32c:988d with SMTP id m13-20020a05600c4f4d00b0040ea32c988dmr107862wmq.4.1706170624814; Thu, 25 Jan 2024 00:17:04 -0800 (PST) Received: from ?IPV6:2003:cb:c70a:7600:9a0b:ceef:a304:b9a7? (p200300cbc70a76009a0bceefa304b9a7.dip0.t-ipconnect.de. [2003:cb:c70a:7600:9a0b:ceef:a304:b9a7]) by smtp.gmail.com with ESMTPSA id o14-20020a05600c4fce00b0040d30af488asm1658538wmq.40.2024.01.25.00.17.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Jan 2024 00:17:04 -0800 (PST) Message-ID: Date: Thu, 25 Jan 2024 09:17:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v1 08/28] mm: Define VM_SHADOW_STACK for RISC-V To: debug@rivosinc.com, rick.p.edgecombe@intel.com, broonie@kernel.org, Szabolcs.Nagy@arm.com, kito.cheng@sifive.com, keescook@chromium.org, ajones@ventanamicro.com, paul.walmsley@sifive.com, palmer@dabbelt.com, conor.dooley@microchip.com, cleger@rivosinc.com, atishp@atishpatra.org, alex@ghiti.fr, bjorn@rivosinc.com, alexghiti@rivosinc.com Cc: corbet@lwn.net, aou@eecs.berkeley.edu, oleg@redhat.com, akpm@linux-foundation.org, arnd@arndb.de, ebiederm@xmission.com, shuah@kernel.org, brauner@kernel.org, guoren@kernel.org, samitolvanen@google.com, evan@rivosinc.com, xiao.w.wang@intel.com, apatel@ventanamicro.com, mchitale@ventanamicro.com, waylingii@gmail.com, greentime.hu@sifive.com, heiko@sntech.de, jszhang@kernel.org, shikemeng@huaweicloud.com, charlie@rivosinc.com, panqinglin2020@iscas.ac.cn, willy@infradead.org, vincent.chen@sifive.com, andy.chiu@sifive.com, gerg@kernel.org, jeeheng.sia@starfivetech.com, mason.huo@starfivetech.com, ancientmodern4@gmail.com, mathis.salmen@matsal.de, cuiyunhui@bytedance.com, bhe@redhat.com, chenjiahao16@huawei.com, ruscur@russell.cc, bgray@linux.ibm.com, alx@kernel.org, baruch@tkos.co.il, zhangqing@loongson.cn, catalin.marinas@arm.com, revest@chromium.org, josh@joshtriplett.org, joey.gouly@arm.com, shr@devkernel.io, omosnace@redhat.com, ojeda@kernel.org, jhubbard@nvidia.com, linux-doc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kselftest@vger.kernel.org References: <20240125062739.1339782-1-debug@rivosinc.com> <20240125062739.1339782-9-debug@rivosinc.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240125062739.1339782-9-debug@rivosinc.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 85CAD120025 X-Stat-Signature: cadw7p3d3t7a63orna7n9htgdp3mqmuj X-Rspam-User: X-HE-Tag: 1706170630-115523 X-HE-Meta: U2FsdGVkX18nPPevnhSJURZGWeUx0xzCkWuuX1EXEoegRCqXhuvLyxxmDsquW2W2kQS8KWLKbbd1GlVgGwdkHauVVpCYYhdjOS4N3zBYtvaSITWxf4N/Md/Cgi5khG4hW6hKs2OP1Rgj04sUf5vA1qo1mK9GcFeDDadXtTvhnDUko26vvqIGK3lR1C01j/fbjFRuj4pTFUm28UOw3kMxbl3i0ByNwwpITMSfvVDUspmbnsIG0lKz3Rs5NeTJT/DgLnfLL0AXD6ZrH6ARyQzg8mRT/pptPO+paVSHVEzRD4flmdQSViWLoC6BJ+g4S8S1EKEJI927tnZddkFRJYEkUIqURpnh31uXLMvXJ3aZY+4AEJtznqicepoXM07auM27M4vC497FCc7K5CPBuhlVv+uA1Eealg3QOYdYZ+hglKSNgNq+SQtEAXenAzgx5WAq6NxaO9bBuxI1WH1WOV9X7hpU0X9xkyqEaZGp4XmpvuGDU0N3qcZM9bGpeXtoflyKTAegmjsh3V2ZR7N8Cy8KtvMA1dOqCcMEqfG+t4Om3M5UPiEneBUbM2mpdOYUS2V8xNMUFN3XR7zTVHP2/h/qM2FxXm5BEuqVCbmh+TmME3u0dErb5Pv3IYwhp9IN2G+2jPLCFIRW0ZCQ3uRL7Btnl39TmnSOGsX+auS/K46byCyB1Ih2WWb+n80wnbMDqCpGnPQDeYjCg0liT0luSUWRBmEFFAbWDgX6HFZl5S7W16a93XaK5N5F41rh9VZnQEIH67GTXwy/+yDdLlg/Hw+1gLFkS5AIPnZLotcThUUAY0byIZb2RvQgsL4OatHlL4T4cH2shZ7vufHMqhnPDW0fZ2mGtrs94nVAjqIvvmYYIN9scP81qyIzb0+IajOcE3Oyr8zRfpSYGFZVaSdg/o5v7MH/aaqrn2zHErvWyQJSdlU0vAvOdkD7+h7udcPpa+1IihEcTQrwiJbndvOHRsf s0024N4b Uyj4Ed8C1RpuWoNZojPn2XWF6dT3E+mr3dTgcuuYj5LXaXgh51tG0vDvjQifsAwARV42UYJ/hqNz8IlauETHyO1WiP8Lq1s2EUFSBStyP/UUX9V0txj6PaqdiDN4eQdm14nV8buNt4ptnDsqOsjkEr/VWU3TGcU3fjpJ5NhAxr2n+EFOQmiUxsB3YwUC2c2NYBJOdD2jWoH8L1iJLjJEJLMW8H93G6xEd+Usn0PsVROeNkfk3AmH8zgXNvzIoq/enPZKepfyLhuVKWmevPmCzH9jZzRMtGlnWuZjBjTd1D0rYB0OCZlwO/NOEgWr/iwnsR6iqNLiPqfnutBdZZJ6+Qn8FEUELSwg8EWxu6ST0S9ignGAAIsnretGc6nQl+TWmhKpwpN1CZEe6+lq5vR+ttRgyUqWRX9bGVUtnhPyaZiVxsrmrbnrY0LqeeHAaKCIDRm83lgnw8Kz3m2vLywiJ0fBH8S3tjXgiQGgQpeaC090Xf178zwY3pbBrc8jXaPljbWUh1ZkVkzuklDBH3KhSpi7zV+tmaEHcHPbGt113rRRXBtIGqQvErTJWP/o1vym06ELlhn6XqpX1MNf99uueBRZBNQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 25.01.24 07:21, debug@rivosinc.com wrote: > From: Deepak Gupta > > VM_SHADOW_STACK is defined by x86 as vm flag to mark a shadow stack vma. > > x86 uses VM_HIGH_ARCH_5 bit but that limits shadow stack vma to 64bit only. > arm64 follows same path > https://lore.kernel.org/lkml/20231009-arm64-gcs-v6-12-78e55deaa4dd@kernel.org/#r > > On RISC-V, write-only page table encodings are shadow stack pages. This patch > re-defines VM_WRITE only to be VM_SHADOW_STACK. > > Next set of patches will set guard rail that no other mm flow can set VM_WRITE > only in vma except when specifically creating shadow stack. > > Signed-off-by: Deepak Gupta > --- > include/linux/mm.h | 14 +++++++++++++- > 1 file changed, 13 insertions(+), 1 deletion(-) > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index 418d26608ece..dfe0e8118669 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -352,7 +352,19 @@ extern unsigned int kobjsize(const void *objp); > * for more details on the guard size. > */ > # define VM_SHADOW_STACK VM_HIGH_ARCH_5 > -#else > +#endif > + > +#ifdef CONFIG_RISCV_USER_CFI > +/* > + * On RISC-V pte encodings for shadow stack is R=0, W=1, X=0 and thus RISCV > + * choosing to use similar mechanism on vm_flags where VM_WRITE only means > + * VM_SHADOW_STACK. RISCV as well doesn't support VM_SHADOW_STACK to be set > + * with VM_SHARED. > + */ > +#define VM_SHADOW_STACK VM_WRITE > +#endif > + > +#ifndef VM_SHADOW_STACK > # define VM_SHADOW_STACK VM_NONE > #endif > That just screams for trouble. Can we find a less hacky way, please? Maybe just start with 64bit support only and do it like the other archs. No need to be special. When wanting to support 32bit, we'll just finally clean up this high flag mess and allow for more vm flags on 32bit as well. -- Cheers, David / dhildenb