From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8C4EC021BF for ; Wed, 26 Feb 2025 11:46:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2F47B280019; Wed, 26 Feb 2025 06:45:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 20DEC280015; Wed, 26 Feb 2025 06:45:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 06189280019; Wed, 26 Feb 2025 06:45:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D45D3280015 for ; Wed, 26 Feb 2025 06:45:53 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 8F831141362 for ; Wed, 26 Feb 2025 11:45:53 +0000 (UTC) X-FDA: 83161916586.02.4FC971D Received: from pv50p00im-ztdg10011301.me.com (pv50p00im-ztdg10011301.me.com [17.58.6.40]) by imf19.hostedemail.com (Postfix) with ESMTP id A41471A0009 for ; Wed, 26 Feb 2025 11:45:51 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=icloud.com header.s=1a1hai header.b=f8lZWyvS; spf=pass (imf19.hostedemail.com: domain of zijun_hu@icloud.com designates 17.58.6.40 as permitted sender) smtp.mailfrom=zijun_hu@icloud.com; dmarc=pass (policy=quarantine) header.from=icloud.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740570351; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UlmH7lnQ/SSIrKM5aMl2BHpkT+fwdodZZLv8W8GXIsc=; b=4SmOI+UvhKV6M+CKS4t7L0uWx6jurinvS+qDwcvflpwyTmbED5cmfHEZMdrU7oNstjk/b1 JBp9um+spwcdsaAqh8SiW8alFt2/M7FUyYQbmEj8hM0oQKYZeGzZrtbPh+E1p8gcWwxls9 1zOPoVE2UUF84k3kf0hrSPxCQ46lIgs= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=icloud.com header.s=1a1hai header.b=f8lZWyvS; spf=pass (imf19.hostedemail.com: domain of zijun_hu@icloud.com designates 17.58.6.40 as permitted sender) smtp.mailfrom=zijun_hu@icloud.com; dmarc=pass (policy=quarantine) header.from=icloud.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740570351; a=rsa-sha256; cv=none; b=RhqE+ew5YcCBs6fkM2+Oy1531wfZ4fYiPkJkhWl/ZCQDFRlDONNRqSFPNQOCtO3WpXhZ9b ZA6GtFp+juToZfxcyM4oHs0yPzokVeAQXIMjzYDk/OACZTG1F1HLnMyORFVbeoXxZO0Kyi v7NYGbHUuZl/btlzisRg/qckHA6uewo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=icloud.com; s=1a1hai; bh=UlmH7lnQ/SSIrKM5aMl2BHpkT+fwdodZZLv8W8GXIsc=; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type:x-icloud-hme; b=f8lZWyvSDPQwKr7SDXIE6VdW5kZrI22cRU+v86cMZBg8M63ib8K+MKQDsZPYVZ+Mz VIc01nNZYPIWEtaq9AznMiQTF7n48OFpxRM5YhSgpY2okVb9cwuvzP1KIikiB+2fRu d+7AduZcNoirLHLK7K4h8pgvS0d1L0tQbLrFrF/Od88tDX/EZXod457QB5bg4qbmFp DbogBPgs3Q7iQQ0mZfmhQRiw2/P900rSG5OeZM5GDf/tYeCwP0bcGCpZ97ZFFl8n8G biW93Aup+84jC3T2ck5W5lDGV0KXW+sjwetmqndyZG8OIOv24PsphQXGiGBlN7Elxi r4aI2TycTa3Rw== Received: from [192.168.1.26] (pv50p00im-dlb-asmtp-mailmevip.me.com [17.56.9.10]) by pv50p00im-ztdg10011301.me.com (Postfix) with ESMTPSA id 5CEAB180350; Wed, 26 Feb 2025 11:45:37 +0000 (UTC) Message-ID: Date: Wed, 26 Feb 2025 19:45:34 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH *-next 01/18] mm/mmu_gather: Remove needless return in void API tlb_remove_page() To: David Howells Cc: Greg Kroah-Hartman , Will Deacon , "Aneesh Kumar K.V" , Andrew Morton , Nick Piggin , Arnd Bergmann , Thomas Gleixner , Herbert Xu , "David S. Miller" , "Rafael J. Wysocki" , Danilo Krummrich , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Johannes Berg , Jamal Hadi Salim , Cong Wang , Jiri Pirko , Jason Gunthorpe , Leon Romanovsky , Linus Walleij , Bartosz Golaszewski , Lee Jones , Thomas Graf , Christoph Hellwig , Marek Szyprowski , Robin Murphy , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-rdma@vger.kernel.org, linux-gpio@vger.kernel.org, linux-pm@vger.kernel.org, iommu@lists.linux.dev, linux-mtd@lists.infradead.org References: <8f36be7c-6052-4c5d-85ff-0eed27cf1456@icloud.com> <20250221-rmv_return-v1-0-cc8dff275827@quicinc.com> <20250221-rmv_return-v1-1-cc8dff275827@quicinc.com> <20250221200137.GH7373@noisy.programming.kicks-ass.net> <2298251.1740496596@warthog.procyon.org.uk> Content-Language: en-US From: Zijun Hu In-Reply-To: <2298251.1740496596@warthog.procyon.org.uk> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: iqw5w_RmeMXu0iJloMXtrzoP0X8vVIzf X-Proofpoint-ORIG-GUID: iqw5w_RmeMXu0iJloMXtrzoP0X8vVIzf X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-02-26_02,2025-02-26_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 mlxlogscore=985 malwarescore=0 clxscore=1011 phishscore=0 bulkscore=0 adultscore=0 spamscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2308100000 definitions=main-2502260094 X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: A41471A0009 X-Stat-Signature: gt9n4oc1qb6rw3u7x1opd7poh6h6ct11 X-HE-Tag: 1740570351-810389 X-HE-Meta: U2FsdGVkX1//oRugqg6eHM7jCx/JgRKpVEjfKquoDxX8Y8iYz7KX4rJBd5oduoJvJyTLABlIainEtoqdGetCwpVrvn1/QZW+6zGs48gTLEP//txNENy4JE0b1plyRvv68PLJsSLobLBu0sToYHp/yCUvCofxPShTOYNh0AvnKnnvnRgXEGIbJw18ZhH7toZ4Av5Itj3bIF+jZvqlmFFYL/qFrm7XRwjC0GtubK5XklxaeaUZW92Qz9Z+ehsL8fri7pyeIghcX8Qq+OATvQAw2GpxQ4IqozaRHpMZZGvSRo0T+WkzduCo6pZ26ephnEt2AZyY1eOtvY7lCoHUMaOmR5qE2OoazTI9yZlLWpt97BzOIHJ6UHXjS8L5hwo+OO8sceSeAuA950Ar78+0t3VAN9Lqmsuf1eZN/3LghVA/dBN6tEK9vjDpLh642LdEzM9CPvJKNpvLBbuYWKWG4PXVT4k1p/VMCOGRtYy46WawJ5dgm55kBiCOonhsKj/z2SeH5FjUwRVllQP57gx02tEDkp4zfAGjUOVTQUkbYB+RE89HdZLyCRoWUSAX9gliSi8gnFP3G08gU3dTRViq8rVeY3R7Bu2u6nccKzwKvAWcBn//e5GnxdvBhSkFf/U4M2tkXUjpEk8mhc1IYl5nT2GJBXvQNqj85ms+oyIc2QLwNv+/OC6XVM+vIGO8/cg4kfIplTf9/DAydp/awSx1x3KAFYkom3xZWgf0M/gsg3Bzzo85m19/Y8yJQ7NOWNFJU1z57y/PoxWdgiukTmhSLQfD+o/4T9fFTXKl/WdeuWMGzkJVSLyqlDRsz87gvZKenOL+3EEAek2xFGZXB58M9nXwK7WWZ6DvqGK/huiGhSR59gQ2z4N60+0wMbfW8bMLK6rXM+cMZ+8akFb7mOAzSVqUt+Y2pgBWkvvK1MnW7UbWs7UAhS1TDLSuU6dxKGmFaQ+5onp/vo8epEiyzO+I1Mr UzEXvBuG f5at0Uyj5aP/HtYNY9E5dWkrl/IElrI108JS+PNzQ4XTw3Zv382xGIIdHWHMU5CR44WBgfAiHl1r7eF3X57GOeh6ATNQ5yojgjyvJCTPe1yIioYT65AuV4czA4ZQxC9+K5LiPCdyC0s324NhNJWKEo7EXRkls8YXFae9sGB6DsflaQCJuZxaPi0FKSgfHMCfleNG7j7RoZBEK+FrXtSNAs03j2+Y/n1CpTfV7O0dLn18MomN5pQqkaSwWCPXDTnFj47acYrQrbjiGm357daaU7Ps61uutQopotLLJoPKzo+n/MLmkshMCNEYL39QsoRIiOjieroO0oFBEMIj6hZGJ+NHii6QacFLMyrBhU6xdRwp5e4eVL8INesu3dP5dVf+HWFOFDd5cyVKgnQkAdai9g/EdWi+mDBbMlGPlFctoJHWQcI/hyzyEsMbubzzLavBER3T0tNdKsmC2Pg/dAGX51ixJNTtFRCQyOwEGC2o4ZXfpwRo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/2/25 23:16, David Howells wrote: > Zijun Hu wrote: > >>>> static inline void tlb_remove_page(struct mmu_gather *tlb, struct page *page) >>>> { >>>> - return tlb_remove_page_size(tlb, page, PAGE_SIZE); >>>> + tlb_remove_page_size(tlb, page, PAGE_SIZE); >>>> } >>> So I don't mind removing it, but note that that return enforces >>> tlb_remove_page_size() has void return type. >>> >> >> tlb_remove_page_size() is void function already. (^^) > > That may be true... for now. But if that is changed in the future, then you > will get an error indicating something you need to go and look at... so in > that regard, it's *better* to do this ;-) > i understand your point. if the callee tlb_remove_page_size() is in the same module with the caller tlb_remove_page. it is meaningless to watch the callee's return type. otherwise, provided the callee is a API which is provided by other module author. once the author changes the API's return type, he/she must take effort to cleanup this weird and lots of usages, that is not nice for API provider. this is a common issue. i will list my reasons why this usage is not good in cover letter of this series > David >