From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 392F3EB64D8 for ; Tue, 20 Jun 2023 15:15:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A06FE8D0002; Tue, 20 Jun 2023 11:15:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 990358D0001; Tue, 20 Jun 2023 11:15:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 831058D0002; Tue, 20 Jun 2023 11:15:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 7236B8D0001 for ; Tue, 20 Jun 2023 11:15:39 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 2ED5612094F for ; Tue, 20 Jun 2023 15:15:39 +0000 (UTC) X-FDA: 80923475598.27.57D0597 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by imf25.hostedemail.com (Postfix) with ESMTP id 62B73A001F for ; Tue, 20 Jun 2023 15:15:34 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=apDmY1ZP; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf25.hostedemail.com: domain of dave.hansen@intel.com designates 134.134.136.100 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687274135; a=rsa-sha256; cv=none; b=5sWCq8o1BdaQCbpALh2VOMJKSJJ0r4Uoj/G+vAijIbiI0tkkZy8HGWYCZgi3fJ0og1hq/U Y55vnv7EjTLfU+rp++5aZIVra9qUkWEwrD877xWUKdJeQ3qJ25i+rLN7mkkbEoHfSQj/A3 anXq+y6N0iPGX4NH6bvyLCi5MPkhaBA= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=apDmY1ZP; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf25.hostedemail.com: domain of dave.hansen@intel.com designates 134.134.136.100 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687274135; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=t1Wni/fGr1C+L/WEWRnIZPUZsCmvjbjkyg9db53taxo=; b=aySCrCDCBVPazmwy0Og089DnApmFLr5onH88J9GfPx9o73MMOVFtLSPdF5Mj634xrZngPr LZcFArT97y+Tu6V+Fctuf8Ugl5MsaDEmu8o0VhBRJ6ZGV0cFjGcT6KWvoCmo/Md70CDRet vqsqCnucC4QHKU9hzM/Qg34+uSxXL0Y= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687274135; x=1718810135; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=EkOKMTe987MyhE5QTRwsU/e71+NrklxUguEAgpGVtRc=; b=apDmY1ZPKBlYocsglGJ17KO+maACM+CuMN2nV/Y8CwVlM1ArEi23bzgF BHLq1ZbXN/p9foZQ8tLXBmDbFo78mS3e+z+iOSY6a24r5kK+JqwkuDB2y eowiQeJgZecZGD604iM+L8UjGfTWRRBGGOoQDCRh5y7cuLpPlu3P96+Dm Uk+LZ/gvfsaHM44Lt8E3QQ4oNdfURucM61WAUSIiXfRMN8TcH4Ho5vVch YvHbaQ9t/osCwu92c4LyRClGsdYubjwFtWaMDNFHB9gujpYlI96ioj4SM UVyt8p3RKDAgzffIpUi7x2jR6qTvnMSU2cqgITJtGyKC3L1QSQugC792y w==; X-IronPort-AV: E=McAfee;i="6600,9927,10747"; a="425842242" X-IronPort-AV: E=Sophos;i="6.00,257,1681196400"; d="scan'208";a="425842242" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jun 2023 08:15:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10747"; a="691466429" X-IronPort-AV: E=Sophos;i="6.00,257,1681196400"; d="scan'208";a="691466429" Received: from rashmigh-mobl.amr.corp.intel.com (HELO [10.255.228.28]) ([10.255.228.28]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jun 2023 08:15:31 -0700 Message-ID: Date: Tue, 20 Jun 2023 08:15:31 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v11 05/20] x86/virt/tdx: Add SEAMCALL infrastructure Content-Language: en-US To: David Hildenbrand , Kai Huang , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: linux-mm@kvack.org, kirill.shutemov@linux.intel.com, tony.luck@intel.com, peterz@infradead.org, tglx@linutronix.de, seanjc@google.com, pbonzini@redhat.com, dan.j.williams@intel.com, rafael.j.wysocki@intel.com, ying.huang@intel.com, reinette.chatre@intel.com, len.brown@intel.com, ak@linux.intel.com, isaku.yamahata@intel.com, chao.gao@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, bagasdotme@gmail.com, sagis@google.com, imammedo@redhat.com References: <759e3af5-6aec-7e50-c432-c5e0a0c3cf36@redhat.com> From: Dave Hansen In-Reply-To: <759e3af5-6aec-7e50-c432-c5e0a0c3cf36@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 62B73A001F X-Stat-Signature: 39tdcqyuyxnowj1srkycyty6exngfesx X-HE-Tag: 1687274134-756667 X-HE-Meta: U2FsdGVkX18+c123kaACUxFwE6sR8krTWQzUS53hGka2PH83W3h8ziF+yqPTqEw8wBWuN+z1s7IQqWve2H2VowKQ4eMlKBnrf1UWYiU0SCCmfFLv67HMIgr1t6yWizrJUSuKXvA1o4Q5uul80uBzIQupEuUfHFPgbAQLNueO9CGs01AAZSmYcloL6bltXQwG/+shkypZdYVjBuXXV3Taf3Lc15UTFRjtdg4adZqF4+GCEXXpILJeBV2nXEmiiOvmGNCsInV0nVeEtWXqfxv/sYa/f91LNZ3dFyhyjDCGUNOIQAWwtEaCmIEYtlloZYqWm8t2iQwqGZN13l1+YBqf+PxqHsKTMn1ziD2IRIosvMr72820sOfkGbwxFMAeksMAGBbZh/tPUjozaUuMjDj9S+p4O5fvk1gmg2kfzRmVxHYuP/URd5HLW69kNhXrUDRU1hR1QgfUTv2hNi9bkNU/a6aYVr/SDblBfi0azbIJPknFlWsPU4mk1bF9+qYEdkbPqqXQXam0WghfmKiX0bPmq5dCqE5+4B47+kAb8fnH4OiuWkEEGgVNpOo5sg0wPtWjscRCvmsBaEow5Xtdz2OwVSZKDxvRBgSvObYCOW7eeKqRfkn2Av7/9kGLeIgGMpBXFfS533ts7MHM/pdLhd++OBRc1W3OpqJOI9FlRT8ufrrtrGAMUSEGdHKI40ePmV5AFKzJ5CjEajwUO3duWrvWEEnsDeiUVXNICz04avYSJqoOTa8AvspJtgrgUmZWN1N1f+9ZF8FvKTgQOx2PTQPigKvcGr8ldmOdwjuntmev1+1WGnT1FCT4Anlt/LRBAN+35OorC+Ktk4rsNku7hweDL1ToWp+DhyrQ0/95HfO6j3KP1NiXPCWmn6g6A4n4Qnohrm4B9oYUqbvBcHX7hKLDCxmMWzZYIWR5lutubjSBtAAsReG9AaETvx0AFYXLmc1GvmLi6OOAuxkW/iOBYlt a2PHniWK bTF9btmBi8a/DM9lmOTuAC6KDJosT7OefNi7vlE8JSP39/C2g20l76s/r8Yyk5lOQKV6/obQDiEhdhEzftahQv0SO0I2p16r1GON6kDX2zIsXwrJMERP6+Z/dJoFuB+eYUpWewuibY2DOr2mRSLwhNrgRZw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 6/19/23 05:52, David Hildenbrand wrote: >> +    /* >> +     * SEAMCALL caused #GP or #UD.  By reaching here %eax contains >> +     * the trap number.  Convert the trap number to the TDX error >> +     * code by setting TDX_SW_ERROR to the high 32-bits of %rax. >> +     * >> +     * Note cannot OR TDX_SW_ERROR directly to %rax as OR instruction >> +     * only accepts 32-bit immediate at most. > > Not sure if that comment is really helpful here. It's a common pattern > for large immediates, no? It's a question of whether you write the comments for folks that read x86 assembly all the time or not. I think the comment is helpful.