From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2828C25B75 for ; Tue, 4 Jun 2024 01:38:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 37EF26B0088; Mon, 3 Jun 2024 21:38:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3083B6B0089; Mon, 3 Jun 2024 21:38:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 15C7E6B008A; Mon, 3 Jun 2024 21:38:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id E7A036B0088 for ; Mon, 3 Jun 2024 21:38:23 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 831ED80989 for ; Tue, 4 Jun 2024 01:38:23 +0000 (UTC) X-FDA: 82191496086.27.815CE61 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf02.hostedemail.com (Postfix) with ESMTP id 1F61A80009 for ; Tue, 4 Jun 2024 01:38:19 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=none; spf=pass (imf02.hostedemail.com: domain of chengzhihao1@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=chengzhihao1@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717465101; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4qK80qAVfwrrD+yNTASVNh77CgaL8hJrmMYWiIK9Z7U=; b=jPl0JsS0L8gfDrPuQtc4Mmk1uO+jx7LKu3VxnoI9zYEDaUhnTetx0tomWHgY5A6wMrHnxD pUGrnbkFLR0DUdIn+MhwPgD+Pwfpqf992fKD1aaehgWhWjz10/lulxZHnW+HrX/WprgekJ gsZ7NcJgmdYsHATS0w9gYbvT+tjH4wE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717465101; a=rsa-sha256; cv=none; b=tbJoiDY2eB871y+zw6KYYZHPNaQ8jBoSCjXBOergYMmPL8iL1qOBtHUDCwk/05a2vrgUBV TcFjhdEkxOPEFkA5zrtJuM9zgmDvnc6Kl2PsoItyUYtug4Qe4yMqjOJYZaJEI62oUK9mj8 mtPudB61my5gC6HopbmY5+9hwOQuVqc= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=none; spf=pass (imf02.hostedemail.com: domain of chengzhihao1@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=chengzhihao1@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com Received: from mail.maildlp.com (unknown [172.19.163.252]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4VtY6M5szWzwRV0; Tue, 4 Jun 2024 09:34:19 +0800 (CST) Received: from kwepemm600013.china.huawei.com (unknown [7.193.23.68]) by mail.maildlp.com (Postfix) with ESMTPS id 7C016180069; Tue, 4 Jun 2024 09:38:14 +0800 (CST) Received: from [10.174.178.46] (10.174.178.46) by kwepemm600013.china.huawei.com (7.193.23.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 4 Jun 2024 09:38:02 +0800 Subject: Re: [PATCH v1 1/1] treewide: Align match_string() with sysfs_match_string() To: Andy Shevchenko , "Rafael J. Wysocki" , Greg Kroah-Hartman , Corey Minyard , Allen Pais , Sebastian Reichel , Perry Yuan , Giovanni Cabiddu , Herbert Xu , Nuno Sa , Guenter Roeck , Randy Dunlap , Andi Shyti , Heiner Kallweit , Lee Jones , Samuel Holland , Elad Nachman , Arseniy Krasnov , Johannes Berg , Gregory Greenman , Benjamin Berg , Bjorn Helgaas , Robert Richter , Vinod Koul , Chunfeng Yun , Linus Walleij , Hans de Goede , =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= , Nikita Kravets , Jiri Slaby , Srinivas Pandruvada , Stanley Chang , Heikki Krogerus , Abdel Alkuor , Kent Overstreet , Eric Biggers , Kees Cook , Ingo Molnar , "Steven Rostedt (Google)" , Daniel Bristot de Oliveira , Andrew Morton , Hugh Dickins , Abel Wu , John Johansen , Mimi Zohar , Stefan Berger , Roberto Sassu , Eric Snowberg , Takashi Iwai , Takashi Sakamoto , Jiapeng Chong , Mark Brown , Kuninori Morimoto , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , CC: Michael Ellerman , Nicholas Piggin , Christophe Leroy , "Naveen N. Rao" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , , "H. Peter Anvin" , David Howells , "David S. Miller" , "Rafael J. Wysocki" , Len Brown , Sergey Shtylyov , Damien Le Moal , Niklas Cassel , Daniel Scally , Sakari Ailus , Michael Turquette , Stephen Boyd , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Heiko Stuebner , Peter De Schrijver , Prashant Gaikwad , Thierry Reding , Jonathan Hunter , Huang Rui , "Gautham R. Shenoy" , Mario Limonciello , Viresh Kumar , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Jani Nikula , Rodrigo Vivi , Joonas Lahtinen , Tvrtko Ursulin , Karol Herbst , Lyude Paul , Danilo Krummrich , Jean Delvare , Alexander Shishkin , Pavel Machek , Chen-Yu Tsai , Jernej Skrabec , Tony Lindgren , Adrian Hunter , Hu Ziji , Ulf Hansson , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Potnuri Bharat Teja , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Miri Korenblit , Kalle Valo , Mahesh J Salgaonkar , Oliver O'Halloran , Kishon Vijay Abraham I , Matthias Brugger , AngeloGioacchino Del Regno , JC Kuo , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Sebastian Reichel , Daniel Lezcano , Zhang Rui , Lukasz Luba , Thinh Nguyen , Helge Deller , Brian Foster , Tejun Heo , Zefan Li , Johannes Weiner , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Valentin Schneider , Masami Hiramatsu , Mathieu Desnoyers , Jason Baron , Jim Cromie , Paul Moore , James Morris , "Serge E. Hallyn" , Dmitry Kasatkin , Clemens Ladisch , Jaroslav Kysela , Takashi Iwai , Liam Girdwood , Linus Torvalds References: <20240603211538.289765-1-andriy.shevchenko@linux.intel.com> From: Zhihao Cheng Message-ID: Date: Tue, 4 Jun 2024 09:37:50 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20240603211538.289765-1-andriy.shevchenko@linux.intel.com> Content-Type: text/plain; charset="gbk"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.178.46] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To kwepemm600013.china.huawei.com (7.193.23.68) X-Rspam-User: X-Stat-Signature: kfu61nip8m1y98syh1qniiex4z85z83u X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 1F61A80009 X-HE-Tag: 1717465099-206874 X-HE-Meta: U2FsdGVkX18HuphzYzW0A3gmWAz1RpWviw1xU4i+h5bVhOa91Jg2GnpJEOmzJBdcZaoq1bUR15yHsacK/oVvPtCav0Z2v6DusenTEtIPX8AYld4F1OI1u1LS1PqUgKPa4mgVebpEh69XQ3JTv+9vKDquHltsjiWPq4K5tdyK5bEwwnfJ5DN/AgG7hwzrGyNMTZWq12GUeHH+fCscXabZ+/oRa8kEgo0nAlbiemgR8lrDdyTQF3WHGk8OPfVKUWejok4bgXRhwdJbOlQFyyNdNFWPL6Q+0AttGk000ybrTne6PYcsE46T9Txiu7TUrCK8Y9RoTY/96JSN83jUBNFCvG1LmSfKV+qInK2N/fBafjxd8rxjTWVl0DpH8wQ6C7eklKQjz26tVxkXEjbFmxIBrtJbtOXR5k3dNX72mxqMjZZ8wc9amcg0tVFZmvZbu9fdI5NbdiKga0tgQOToxxLpkwHzsnQUkxsDjugW9jsC6U/O3opjFqPZLOs0wgt3XOrs28F+2hhp3U2XYH+pkCyRKg4Lun7zpltSLRJRWPdXB3CBvmhL1tBfx1+0lUaqGvQe1wYVgc87UFPNdqleYkVe2VijRpZoyGs7jCvWZ4bA+swsNxmlU9tmfxobha2C5C/1IhNaAPdp7Bz9O0GXWF3ovXlg3rewadZP6ukRN7fJ3orFc72f90RAEeHsaxD2DpWARvoHLS4fkQHgqfu82rI47wT7m/eSfq81iB0+xey799nqGRHEM8SMxv9kFZtJcPZMfKfVG7JTJ76i5Tzy15TkybJq1tq43rcztIfaINrcsCTc5ajm1kEYra9J6fOUXIEy36rW7pfMon12ivw8Un9ozWUXyz4cvikmpf7QpW/0q3UsxO4ViHleRaMeGMoMbo89Pyul2csOwy35Fg151zqMzv597Vr41B4P2J6cHG8rdOmFJIRewgZf1szKDNUwIJhOv04eodFgoEMxWP2ACgN 00qaKlt9 JM0QBQZAoHT9B1TYiTiVQqhIdu6nVmJA+RimaJoEH1sq7t7bY8CI3moRhFc/fxWrZP6bN0TP87RpZ2UbI7Jc8WNndvylN76NywT1wfiE/wdtFj4KrKGRxTLT3mxnWI2fPWJh31a1b9ZhuzLMo8hrQkXyN6VomkFfdA8SLAwEYEtiXCD4dtUdYHRR4ILmINVWQbyF6zaw6qXrZMmTjVJEBIQlvLN41Ux5Zt2ZA9wmckU461C07Shaq4E3rFKwbM6Yg7+66EWwef8lULF0098PWsjzm4K5yY1uMwtU0LYVQdkz0N+I/X6QHxyFrGGBdx95nxYPbxKmxjWG7qzY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: ÔÚ 2024/6/2 23:57, Andy Shevchenko дµÀ: > Make two APIs look similar. Hence convert match_string() to be > a 2-argument macro. In order to avoid unneeded churn, convert > all users as well. There is no functional change intended. > > Signed-off-by: Andy Shevchenko > --- > > Compile tested with `make allyesconfig` and `make allmodconfig` > on x86_64, arm, aarch64, powerpc64 (8 builds total). > [...] > diff --git a/fs/ubifs/auth.c b/fs/ubifs/auth.c > index a4a0158f712d..fc0da18bfa65 100644 > --- a/fs/ubifs/auth.c > +++ b/fs/ubifs/auth.c > @@ -264,13 +264,13 @@ int ubifs_init_authentication(struct ubifs_info *c) > return -EINVAL; > } > > - c->auth_hash_algo = match_string(hash_algo_name, HASH_ALGO__LAST, > - c->auth_hash_name); > - if ((int)c->auth_hash_algo < 0) { > + err = __match_string(hash_algo_name, HASH_ALGO__LAST, c->auth_hash_name); > + if (err < 0) { > ubifs_err(c, "Unknown hash algo %s specified", > c->auth_hash_name); > - return -EINVAL; > + return err; > } > + c->auth_hash_algo = err; > > snprintf(hmac_name, CRYPTO_MAX_ALG_NAME, "hmac(%s)", > c->auth_hash_name); Reviewed-by: Zhihao Cheng # fs/ubifs