From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6A92C433DB for ; Wed, 24 Mar 2021 20:17:36 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 861FF61A0A for ; Wed, 24 Mar 2021 20:17:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 861FF61A0A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 15D046B0312; Wed, 24 Mar 2021 16:17:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0E6796B0314; Wed, 24 Mar 2021 16:17:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EA4456B0315; Wed, 24 Mar 2021 16:17:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0053.hostedemail.com [216.40.44.53]) by kanga.kvack.org (Postfix) with ESMTP id CE1426B0312 for ; Wed, 24 Mar 2021 16:17:35 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 90B3A2484 for ; Wed, 24 Mar 2021 20:17:35 +0000 (UTC) X-FDA: 77955878070.22.E56F677 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by imf01.hostedemail.com (Postfix) with ESMTP id 8BD715001529 for ; Wed, 24 Mar 2021 20:17:34 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: tonyk) with ESMTPSA id BCFFA1F45E77 Subject: Re: [RFC PATCH 2/4] mm: shmem: Support case-insensitive file name lookups To: Gabriel Krisman Bertazi Cc: Hugh Dickins , Andrew Morton , Alexander Viro , smcv@collabora.com, kernel@collabora.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Daniel Rosenberg References: <20210323195941.69720-1-andrealmeid@collabora.com> <20210323195941.69720-3-andrealmeid@collabora.com> <877dlxd3oc.fsf@collabora.com> From: =?UTF-8?Q?Andr=c3=a9_Almeida?= Message-ID: Date: Wed, 24 Mar 2021 17:17:21 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <877dlxd3oc.fsf@collabora.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 8BD715001529 X-Stat-Signature: 3mpc8xuosbjzd4yu9hwqnmkmwrroqjxw Received-SPF: none (collabora.com>: No applicable sender policy available) receiver=imf01; identity=mailfrom; envelope-from=""; helo=bhuna.collabora.co.uk; client-ip=46.235.227.227 X-HE-DKIM-Result: none/none X-HE-Tag: 1616617054-598945 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: =C3=80s 17:18 de 23/03/21, Gabriel Krisman Bertazi escreveu: > Andr=C3=A9 Almeida writes: >> opt =3D fs_parse(fc, shmem_fs_parameters, param, &result); >> if (opt < 0) >> @@ -3468,6 +3519,23 @@ static int shmem_parse_one(struct fs_context *f= c, struct fs_parameter *param) >> ctx->full_inums =3D true; >> ctx->seen |=3D SHMEM_SEEN_INUMS; >> break; >> + case Opt_casefold: >> + if (strncmp(param->string, "utf8-", 5)) >> + return invalfc(fc, "Only utf8 encondings are supported"); >> + ret =3D strscpy(version, param->string + 5, sizeof(version)); >=20 > Ugh. Now we are doing two strscpy for the parse api (in unicode_load). > Can change the unicode_load api to reuse it? >=20 So instead of getting just the version number (e.g. "12.1.0") as=20 parameter, utf8_load/unicode_load would get the full encoding string=20 (e.g. "utf8-12.1.0") right?