* Re: [PATCH] mm/vmscan: Use folio_migratetype() instead of get_pageblock_migratetype() [not found] <20230825040848.1542-1-user@VERNHAO-MC1> @ 2023-08-25 7:12 ` David Hildenbrand 2023-08-25 7:31 ` Vern Hao 0 siblings, 1 reply; 5+ messages in thread From: David Hildenbrand @ 2023-08-25 7:12 UTC (permalink / raw) To: Vern Hao, akpm; +Cc: zhaoyang.huang, linux-mm, linux-kernel, Vern Hao On 25.08.23 06:08, Vern Hao wrote: > From: Vern Hao <vernhao@tencent.com> > > In skip_cma(), we can use folio_migratetype() to replace get_pageblock_migratetype(). > > Fixes: 5da226dbfce3 ("mm: skip CMA pages when they are not available") Why did you think "Fixes" was a good idea? -- Cheers, David / dhildenb ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mm/vmscan: Use folio_migratetype() instead of get_pageblock_migratetype() 2023-08-25 7:12 ` [PATCH] mm/vmscan: Use folio_migratetype() instead of get_pageblock_migratetype() David Hildenbrand @ 2023-08-25 7:31 ` Vern Hao 2023-08-25 7:34 ` David Hildenbrand 0 siblings, 1 reply; 5+ messages in thread From: Vern Hao @ 2023-08-25 7:31 UTC (permalink / raw) To: David Hildenbrand, akpm; +Cc: zhaoyang.huang, linux-mm, linux-kernel, Vern Hao 在 2023/8/25 15:12, David Hildenbrand 写道: > On 25.08.23 06:08, Vern Hao wrote: >> From: Vern Hao <vernhao@tencent.com> >> >> In skip_cma(), we can use folio_migratetype() to replace >> get_pageblock_migratetype(). >> >> Fixes: 5da226dbfce3 ("mm: skip CMA pages when they are not available") > > Why did you think "Fixes" was a good idea? > The skip_cma() contains the folio argument, and the folio_migratetype() is already implemented in the kernel, so I think it's fine to keep it consistent. Thanks! ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mm/vmscan: Use folio_migratetype() instead of get_pageblock_migratetype() 2023-08-25 7:31 ` Vern Hao @ 2023-08-25 7:34 ` David Hildenbrand 2023-08-25 7:36 ` Vern Hao 0 siblings, 1 reply; 5+ messages in thread From: David Hildenbrand @ 2023-08-25 7:34 UTC (permalink / raw) To: Vern Hao, akpm; +Cc: zhaoyang.huang, linux-mm, linux-kernel, Vern Hao On 25.08.23 09:31, Vern Hao wrote: > > 在 2023/8/25 15:12, David Hildenbrand 写道: >> On 25.08.23 06:08, Vern Hao wrote: >>> From: Vern Hao <vernhao@tencent.com> >>> >>> In skip_cma(), we can use folio_migratetype() to replace >>> get_pageblock_migratetype(). >>> >>> Fixes: 5da226dbfce3 ("mm: skip CMA pages when they are not available") >> >> Why did you think "Fixes" was a good idea? >> > The skip_cma() contains the folio argument, and the folio_migratetype() > is already implemented in the kernel, so I think it's fine to keep it > consistent. If this doesn't actually *fix a bug*, then please don't add fixes and confuse people looking for actual bugfixes. See Documentation/process/submitting-patches.rst -- Cheers, David / dhildenb ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mm/vmscan: Use folio_migratetype() instead of get_pageblock_migratetype() 2023-08-25 7:34 ` David Hildenbrand @ 2023-08-25 7:36 ` Vern Hao 2023-08-25 7:37 ` David Hildenbrand 0 siblings, 1 reply; 5+ messages in thread From: Vern Hao @ 2023-08-25 7:36 UTC (permalink / raw) To: David Hildenbrand, akpm; +Cc: zhaoyang.huang, linux-mm, linux-kernel, Vern Hao 在 2023/8/25 15:34, David Hildenbrand 写道: > On 25.08.23 09:31, Vern Hao wrote: >> >> 在 2023/8/25 15:12, David Hildenbrand 写道: >>> On 25.08.23 06:08, Vern Hao wrote: >>>> From: Vern Hao <vernhao@tencent.com> >>>> >>>> In skip_cma(), we can use folio_migratetype() to replace >>>> get_pageblock_migratetype(). >>>> >>>> Fixes: 5da226dbfce3 ("mm: skip CMA pages when they are not available") >>> >>> Why did you think "Fixes" was a good idea? >>> >> The skip_cma() contains the folio argument, and the folio_migratetype() >> is already implemented in the kernel, so I think it's fine to keep it >> consistent. > > If this doesn't actually *fix a bug*, then please don't add fixes and > confuse people looking for actual bugfixes. > > See Documentation/process/submitting-patches.rst OK, my bad, i will remove it, thanks. ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mm/vmscan: Use folio_migratetype() instead of get_pageblock_migratetype() 2023-08-25 7:36 ` Vern Hao @ 2023-08-25 7:37 ` David Hildenbrand 0 siblings, 0 replies; 5+ messages in thread From: David Hildenbrand @ 2023-08-25 7:37 UTC (permalink / raw) To: Vern Hao, akpm; +Cc: zhaoyang.huang, linux-mm, linux-kernel, Vern Hao On 25.08.23 09:36, Vern Hao wrote: > > 在 2023/8/25 15:34, David Hildenbrand 写道: >> On 25.08.23 09:31, Vern Hao wrote: >>> >>> 在 2023/8/25 15:12, David Hildenbrand 写道: >>>> On 25.08.23 06:08, Vern Hao wrote: >>>>> From: Vern Hao <vernhao@tencent.com> >>>>> >>>>> In skip_cma(), we can use folio_migratetype() to replace >>>>> get_pageblock_migratetype(). >>>>> >>>>> Fixes: 5da226dbfce3 ("mm: skip CMA pages when they are not available") >>>> >>>> Why did you think "Fixes" was a good idea? >>>> >>> The skip_cma() contains the folio argument, and the folio_migratetype() >>> is already implemented in the kernel, so I think it's fine to keep it >>> consistent. >> >> If this doesn't actually *fix a bug*, then please don't add fixes and >> confuse people looking for actual bugfixes. >> >> See Documentation/process/submitting-patches.rst > OK, my bad, i will remove it, thanks. > No need to resend. Andrew can drop that tag when applying. -- Cheers, David / dhildenb ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-08-25 7:37 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20230825040848.1542-1-user@VERNHAO-MC1>
2023-08-25 7:12 ` [PATCH] mm/vmscan: Use folio_migratetype() instead of get_pageblock_migratetype() David Hildenbrand
2023-08-25 7:31 ` Vern Hao
2023-08-25 7:34 ` David Hildenbrand
2023-08-25 7:36 ` Vern Hao
2023-08-25 7:37 ` David Hildenbrand
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox