From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51499C3DA6F for ; Fri, 25 Aug 2023 07:37:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D46A128009C; Fri, 25 Aug 2023 03:37:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CF4D28E0011; Fri, 25 Aug 2023 03:37:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BBCD428009C; Fri, 25 Aug 2023 03:37:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A9E6A8E0011 for ; Fri, 25 Aug 2023 03:37:31 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 84F131404C9 for ; Fri, 25 Aug 2023 07:37:31 +0000 (UTC) X-FDA: 81161821902.19.106144D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf23.hostedemail.com (Postfix) with ESMTP id 4F60914001A for ; Fri, 25 Aug 2023 07:37:29 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=aWeMZqQt; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692949049; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pnj66daazMp7cNcIjFO+EqMnKflgV7c8qtO7Inq7NlY=; b=SYvxRCNwi/cBFIm8nBmQVg3BgEV5J3mf00uz8R69sb7coOZyEmKoJ4Hc+T/xupnpb61Uni Jt0RWPCesD0Y+Vc/qEBHbx53/xRZ+k6FjK4JkbKk3XNhzFEZmyIASAGq8IAzbwC4iD4KXg WKx5qC8QnuYlDDZu+ut0oHrob4i92jE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692949049; a=rsa-sha256; cv=none; b=NGs2l8b+5L1FQaZuQod1E9Tq4Qu+BfI1CPoB9BgpoKPSsetHyp5+QUymfLxOBE8YpQePCd loKZnPnKs3xyspMxJjhss/i63F+JsF2/YjwpduOJyySpMuEo1SCGBO9fucaQSvDIiYKMvx /bjlD2yyb3EkPXOhfk2ZLbhhEzCh25A= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=aWeMZqQt; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1692949048; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pnj66daazMp7cNcIjFO+EqMnKflgV7c8qtO7Inq7NlY=; b=aWeMZqQtZCb2gVDxYcKRx35AtybMySniy9GbPo0rJxX9/INjkLNvFmb+fGb51aZlxaLO0Z rMdTrrTfFU8QRIcNxGiKE5eyo2EQVxeglGmjKX4bGCape9GV57Fr0KuwpiVUsKtb0XLgQQ s8gy2fPNgvRVgTB02s0YsSdD1AIX2xM= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-278-HLbvz0UgNjezxLdql0NSUA-1; Fri, 25 Aug 2023 03:37:27 -0400 X-MC-Unique: HLbvz0UgNjezxLdql0NSUA-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-31c7b8d0f0aso454477f8f.3 for ; Fri, 25 Aug 2023 00:37:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692949046; x=1693553846; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pnj66daazMp7cNcIjFO+EqMnKflgV7c8qtO7Inq7NlY=; b=ahYuSpGpTj1PoS1tL2bgwDQyq6WHv3y3UT/xdg5N1Zyw+nUGMknJo4nzc40W/3sDPa yBJgbKbfH8ihNfiEe2G125UneLqm7fj7xBArfMc9Qsn5WglW/A30SRRY6+1k/K7lYM9/ UHY/iZ+hWbBAgyORmRBSCr6UivvoIKSfnaBcwmi2I5Vo+3Z+sOfJIFQePecbRB757PyT mMX1bLj0yKyVjLjk+PZ0DoIa7R64oPTpSLlvn8dtetoCQxqZ3twidQj/dMgSn8Gg5NfH MRH/SpsBX+r6T/rpDv07XT+WNlbxJG/CsQdbGpa2fsE10DcyNtXt0TdzFP5Klv62iEkt 24aA== X-Gm-Message-State: AOJu0YxsRC43z9QPrJU/Jt/qkxWepgcH/fEeqadh8uVTuFf5IGodvQWe 1yGn5nVKxdWX9l3Cq634wl2wEFXcLLajPgzxP7eqCKc5Szu1FFodvDUdl9zEpWGQOuSRGzwed/D Q6WeAKK6JAwTY8BfvMnI= X-Received: by 2002:adf:ce02:0:b0:319:6b5e:85e3 with SMTP id p2-20020adfce02000000b003196b5e85e3mr12061984wrn.71.1692949045921; Fri, 25 Aug 2023 00:37:25 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFKIgA2U9Vxpsz/IZArf9xGgiPdBdcR2RRWiffD6OYBacfD6fGlz67nU8gaKxQgqhi2iYmv+Q== X-Received: by 2002:adf:ce02:0:b0:319:6b5e:85e3 with SMTP id p2-20020adfce02000000b003196b5e85e3mr12061973wrn.71.1692949045578; Fri, 25 Aug 2023 00:37:25 -0700 (PDT) Received: from ?IPV6:2003:cb:c70e:9200:ce93:b5e6:8aa9:65d4? (p200300cbc70e9200ce93b5e68aa965d4.dip0.t-ipconnect.de. [2003:cb:c70e:9200:ce93:b5e6:8aa9:65d4]) by smtp.gmail.com with ESMTPSA id w12-20020a5d4b4c000000b0031416362e23sm1408837wrs.3.2023.08.25.00.37.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Aug 2023 00:37:24 -0700 (PDT) Message-ID: Date: Fri, 25 Aug 2023 09:37:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] mm/vmscan: Use folio_migratetype() instead of get_pageblock_migratetype() To: Vern Hao , akpm@linux-foundation.org Cc: zhaoyang.huang@unisoc.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Vern Hao References: <20230825040848.1542-1-user@VERNHAO-MC1> <9d4d0643-6a7e-22bf-1f54-19646bb7231e@redhat.com> <90562ff0-9689-4d00-848e-87347cacdbae@gmail.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <90562ff0-9689-4d00-848e-87347cacdbae@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 4F60914001A X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: ketzn5mjtnxxtpcty67z3zbkc5n4cc9p X-HE-Tag: 1692949049-856449 X-HE-Meta: U2FsdGVkX1+IOpevAjI6HjiuMieRtYVdFVKPLE/MUQ5pZKc/Wf1ScKuMJMNVXAY1UrDOFY/Qdq0N8en4ugOpSEibQ0KeNn+9ApYWXnK8/Fb8pbiAaXXHsBnpswuNZeoSN2yKll60UsFJ7pv7oYzYOqjrkVmF/bJ4+ExsMRgHBjGzBdA2lABrRRWb0F2vd97Z4+9bofKEyGThiihzLDqhk+ZKqtAhSnkjonWJZpw+FWJmzYU78saXXjomSFtvwGT/GIzURpNPHjehDVjGJ3+IQs+2szIWkESkDKtPuRNjjyuxo1RTcmsfg/uP8MGHxFQ439PE97uWchwhJJJ3bPqpboeaylJzueK5sQKgRoiVcGw7atqF4lxSB6XGGrVMHcWo4ppWz2TqUnJPHpFsBWGOd6dP4IXi8TqnjSTNyHPKuaXMd52nffvLg1Khl349GOBgmpDnSzXLPqlud27sYgV9RD0cmpJxsnTeyLLYvJbc4GRUE9Apu7GC7KRnMj0jV9zFWP8DAOYIaA6UxPu0jWRu42dH9xDqPur4wUXHXadK4XmU0vWUY9hwRUsATrquspr3HqqVID0mJMUVXuLjPIc2q+gZWnQMCiFGzWjHL4883/r21h0EfIZxH72R9Lm0T8hMsNZss+o5zTOY2NPtB1ZVgARLJeVX2VLoVwlaGpu9donWhyJwOdeSvYhJqjJEKtT1djpHUbJbvpXi55bZsCq9nH3bk++y9mNO1q3oBQRNCEOPAdmW0d/J5zVFqINeA7I5qgUeFcAv56f/8VIc8hw60Vt8UgIqtKp08EAyBNTIiFSdUAtffHDUUGEwOfjm6lH7ey5q4OWGPU5Xkv6xX9QxK7GEJpmRGc1LNARy32CiIyvFmTAISvXaQS6KHSYZK4g0PAXxzQqMtwyxm7inuFdjrRg4KS3mbpn1P+e7/SCwtnhfVNPUAP7RPuzmV7DfaUzmUoc3Zr4/nnThWYwxWc8 Hsii5yxo 7Ytr0X6ja5iIxzdAioVHUSdCFG5y2ca5iLGiXkIgJvSexuBnViigyWsM282r7/Ss3WVzl0k6eiE56y5qH4/Ks3RGpgLbcNCfKG5x99pP+58IUJgz7Ge8Q9Nom7pzNl1sNs6GqB/V7g/dLHEvfiLssSYgG3ybXhz++QOdWyTV1fGAAR48N81rntj3M7VNcKv5JGZCnD24oIUIqRL2E7l9XiuHPoaJtHeBX4Sa2uJwc4BqUAo3VCYiebfsJfGwSUXOl0/DAY0w4ibleRI6fo2n4BGd8JA0ds0vSGJME7H552UJpAUQXZb6cgkGRkSKUxTYQfqvPFd2u6KRaGykuMlZtDChuqC8lNNKfqBfDl5P5FnO8pmpULAIMH3BGGcF6+/948f9RstWXYNQteuBK8D/Gf5B2/pWf+kYcWsm8QgvpFHOH3B7nJ6Z4+pcwSjp8bGX7WE6QfBvMSFF3VzvvABnFKV7C6t7bHijmeIlLHXd4q+0HASc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 25.08.23 09:36, Vern Hao wrote: > > 在 2023/8/25 15:34, David Hildenbrand 写道: >> On 25.08.23 09:31, Vern Hao wrote: >>> >>> 在 2023/8/25 15:12, David Hildenbrand 写道: >>>> On 25.08.23 06:08, Vern Hao wrote: >>>>> From: Vern Hao >>>>> >>>>> In skip_cma(), we can use folio_migratetype() to replace >>>>> get_pageblock_migratetype(). >>>>> >>>>> Fixes: 5da226dbfce3 ("mm: skip CMA pages when they are not available") >>>> >>>> Why did you think "Fixes" was a good idea? >>>> >>> The skip_cma() contains the folio argument, and the folio_migratetype() >>> is already implemented in the kernel, so I think it's fine to keep it >>> consistent. >> >> If this doesn't actually *fix a bug*, then please don't add fixes and >> confuse people looking for actual bugfixes. >> >> See Documentation/process/submitting-patches.rst > OK, my bad, i will remove it, thanks. > No need to resend. Andrew can drop that tag when applying. -- Cheers, David / dhildenb