From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DA42C3DA4A for ; Thu, 1 Aug 2024 09:41:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 293796B0089; Thu, 1 Aug 2024 05:41:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2435A6B008C; Thu, 1 Aug 2024 05:41:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 06E0C6B0093; Thu, 1 Aug 2024 05:41:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id DABF26B0089 for ; Thu, 1 Aug 2024 05:41:14 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 8825C40A5F for ; Thu, 1 Aug 2024 09:41:14 +0000 (UTC) X-FDA: 82403183268.22.196BDD8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf18.hostedemail.com (Postfix) with ESMTP id 3F2AD1C0006 for ; Thu, 1 Aug 2024 09:41:12 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=d4gWvAg9; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722505197; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JqaOCZP7dv3D/jOl/pWT+vlAhTBWLDEcV/CyJ7dI+tk=; b=Z8usQPoYR/Z9yXLAx6W2+I+RSkqvN1+JO3UC3HPoFP+Hb0kkjRjmgMuQGMQAwb7mxTSAy5 eZaSZeBdFxbBme6c/myOxwEdDpdGFXg7lSgXpWpEXX+/TM0jqfc71ZalaXljLhOiVvnkKp rMo4Pd6vQ2445o+VwyqKfjpcTzJKt04= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=d4gWvAg9; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722505197; a=rsa-sha256; cv=none; b=beCGZ+e4plPX+CLVZ3rEbDcob4SOWdTMPntuNTEs62L/Mb/YPNF+FM3jaismZ9GHVp6COY 09PTY0d5uNJPiU3bc3Z0s34dRwwjmx5Cc++7PNX4lPhv79MQcPqOsD+RX1xn1HRTPTeVzP UV7A6xnojBI1JieGBMf/J848t+AoFEo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1722505271; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=JqaOCZP7dv3D/jOl/pWT+vlAhTBWLDEcV/CyJ7dI+tk=; b=d4gWvAg9yDIwgbkQKE21skbOuDe+oiVcojw6HoVG1EeqVq1X/Dwd4hlIDLfcs5SAi/4ZYu 6Ob3EJZIpV8+vNEhUcDKWN5nzQsK35YZDbHhAd6p9KYdeDgsVSIRjYVMX6eJ9Zmd6n5OFg /U2kTG8p6MzaICunM9u7Arls3LXpzII= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-378-ffdUzawDPxGnyb3uNp9T8A-1; Thu, 01 Aug 2024 05:41:08 -0400 X-MC-Unique: ffdUzawDPxGnyb3uNp9T8A-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3687529b63fso2942262f8f.2 for ; Thu, 01 Aug 2024 02:41:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722505267; x=1723110067; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=JqaOCZP7dv3D/jOl/pWT+vlAhTBWLDEcV/CyJ7dI+tk=; b=klk+p74RENlFacXaIHoY7NymqWROhmXrR0ZbD3H8FUky9gf9SpKEOJP0fo+t10G3AP bxYbLfLCXBe01zpJm0xpRREscp/d60HA4F+optEzRRWmyQoL1vB/++A3gb58lQwSWKtV +kNAOWdwdllJ+hwS5TZFN+oNr8k/GKf6kZegmFoKJHIUq/Y3gze1QXW+VDlhtd0iF60B Pu4tL6KA9wp8/ef4v5Z4g97nbl+J3yx+Ur714XDw4ogYXmEzF2CdvBNjLvwzf/ecSUuL gr8I2dAtWQyOFrsKs3W5dlUHflspHF+fhoFgk+zbNb8XCZKuyHBu0j98Y71Wj0yxTWLO wp8w== X-Forwarded-Encrypted: i=1; AJvYcCWqzs1xfXSCt8OM5wW7R7HVysxL89FT3n2H8SLpjzwjJNc9H5ob6Ov5XWslbtgQdz8Keg5SWoKS3kH7iyU1jHi7mQk= X-Gm-Message-State: AOJu0Yxt56H4NYD4i5DP91yTprtmaUJyKvwzNqWr/Z2PX/940bno8o9R /ow3JcuP9tzc2Ius6xZ0tlumoy0RE/oUoP8sJZufvkvNOMAMuKq+W4fEthYOPfVYt76klY1TewO x8tSSdT7aI7Gcj34kRdpfw5tqIYnidYVg38tD671Jag8cwIwf X-Received: by 2002:a05:6000:c44:b0:367:8a00:fac3 with SMTP id ffacd0b85a97d-36baade6840mr1238176f8f.30.1722505267038; Thu, 01 Aug 2024 02:41:07 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHUXSfCLweNJWwgc+QabjZVMvT0mNLyetEJuPNRBQl0zNI7lyZZSfLnIIlE8dXeHZBbubBd5A== X-Received: by 2002:a05:6000:c44:b0:367:8a00:fac3 with SMTP id ffacd0b85a97d-36baade6840mr1238131f8f.30.1722505266425; Thu, 01 Aug 2024 02:41:06 -0700 (PDT) Received: from ?IPV6:2003:cb:c707:5c00:e650:bcd7:e2a0:54fe? (p200300cbc7075c00e650bcd7e2a054fe.dip0.t-ipconnect.de. [2003:cb:c707:5c00:e650:bcd7:e2a0:54fe]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-36b367c0668sm18975127f8f.10.2024.08.01.02.41.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Aug 2024 02:41:05 -0700 (PDT) Message-ID: Date: Thu, 1 Aug 2024 11:41:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Race condition observed between page migration and page fault handling on arm64 machines To: Dev Jain , akpm@linux-foundation.org, willy@infradead.org Cc: ryan.roberts@arm.com, anshuman.khandual@arm.com, catalin.marinas@arm.com, cl@gentwo.org, vbabka@suse.cz, mhocko@suse.com, apopple@nvidia.com, osalvador@suse.de, baolin.wang@linux.alibaba.com, dave.hansen@linux.intel.com, will@kernel.org, baohua@kernel.org, ioworker0@gmail.com, gshan@redhat.com, mark.rutland@arm.com, kirill.shutemov@linux.intel.com, hughd@google.com, aneesh.kumar@kernel.org, yang@os.amperecomputing.com, peterx@redhat.com, broonie@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20240801081657.1386743-1-dev.jain@arm.com> <3b82e195-5871-4880-9ce5-d01bb751f471@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 3F2AD1C0006 X-Stat-Signature: yr7qb1ubgsjietciansbhsq7aicorahi X-Rspam-User: X-HE-Tag: 1722505272-195027 X-HE-Meta: U2FsdGVkX19Pg2HGuUgNT0IBa/DHRueM+9rCUqd9vHWSTE3xsx9D2/ygbO2mAPxj6E4Z7s33ZZrXuJROLUoG7TTl6e/qMJoV75shnMg/hjtCjs9xzGVWGfPbxSqtPWdZjj+UaCrDe1HFMIQyNbXIjKeluAPneXfeMC+raC1pfVhVn58jgtFuNiIXBxyhi2Y5cER8u02tiDAgm0VpTnGB1X6WthEp50EziMBUnJqkqA4onl3icTzacJ4scYp2p4MCcZ1oLTDwQQDJJ80uGHXNZ7Dtz7MZu4wS5ZC2RnR1taQWRlNNDbwAPNYEvVsoH81GVNpNTV0v2WJ7FklliQf/BX9DvLQCRAiMbJ+Mb1a2/rKbJRkwI7J93e5mB7Q8fhF0eEmbyxLV+Dmeh2et0D6zF3giY9bqVJtRlUlDzKEh6IiaMm1wHK8mPKGjVtOvdnltfuvZyclysuFbLDGYp7TYfWOdehpigtW5x806G2yzDdH3LKq7d7IYm9Z6Hc2O55RM0o3SCBQnsp3Hw3mn65yUUdy8OhNm9e4/4b5lXZve78tbdCxbshLl+wl0tJlqfKu3SyFjZ0GVfCPhXR0Xd0psgDQdnT9AUXzx2uj742hwYIlMepWLK/dwCQj2hYozjMtkjDAFb7InzWbcJEMHo1ygekAosWUA13do4OJYIq+kg3Vc9IFquKk1/9CzFhKGxvTvzYFL6jMhAGGJkS82EhJ5fbUZWm1rLl2U/03UeSK7w5MyhhAYYln4+nz187V58Ev5o/1Mp/+g2tX5Jq6CO/yzPRcep8oVGZEpQ4cp/jtrKQUDiAHCW0gqWKCpr4zjB/u1v1VXkjT8JVHobAGiZ2p0DMh5ZuXvM26iBZsJvncMSy/nVVoGGD7LjDRZm9z2HJugdc9kCZbXcMyW6ElZGvKgjtTyPBEo9y4/m4NfxD5fXb5Le30cdnlUZUnP536+x7YqpEeMWKL771LCgxkDxIi r/id9St3 wmUzK3H/W7baGpysR/dr5L70vHQNJtcneCinVM2ZhlV33EagEE1KyaGPHBIqm299iTakFFymW9Uh4jQKxEJAgcXSfv1FmlozLduzMadrwU9BKH34rWLjRt8jL35v1svpcCRa5gnXfEBojP78D6AkPUlkmRwFv0iI+7Lpal9iHARLktgpLUQ1GJkR924LMHVsgMSZWxKXfV4tr0LZgrXCfFDuc8m7cnVkCNeI2R12Wcw2PZhBPFB4U7JGITYnIGGqmTSOVNEmkG81y/pdNoN2x5DZ/Im/sK9+gHlyD+rOfGCwKaYyS/ZYvlOmWIqddEZvQCmlaoVCj5MAZbrgZ1KXUU6wU5uTQ23HWq4W2dCqaWy3SigsD5X8yaYsTSlU6HV7FIwTjTphHxoe1Vh8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 01.08.24 11:38, Dev Jain wrote: > > On 8/1/24 14:12, David Hildenbrand wrote: >> On 01.08.24 10:16, Dev Jain wrote: >>> I and Ryan had a discussion and we thought it would be best to get >>> feedback >>> from the community. >>> >>> The migration mm selftest currently fails on arm64 for shared anon >>> mappings, >>> due to the following race: >> >> Do you mean MAP_SHARED|MAP_ANON or MAP_PRIVATE|MAP_ANON_fork? Because >> you note shmem below, I assume you mean MAP_SHARED|MAP_ANON > > > Yes. > >> >>> >>> Migration:                        Page fault: >>> try_to_migrate_one():                    handle_pte_fault(): >>> 1. Nuke the PTE                        PTE has been deleted => >>> do_pte_missing() >>> 2. Mark the PTE for migration                PTE has not been deleted >>> but is just not "present" => do_swap_page() >>> >> >> In filemap_fault_recheck_pte_none() we recheck under PTL to make sure >> that a temporary pte_none() really was persistent pte_none() and not a >> temporary pte_none() under PTL. >> >> Should we do something similar in do_fault()? I see that we already do >> something like that on the "!vma->vm_ops->fault" path. >> >> But of course, there is a tradeoff between letting migration >> (temporarily) fail and grabbing the PTL during page faults. > > > To dampen the tradeoff, we could do this in shmem_fault() instead? But > then, this would mean that we do this in all > > kinds of vma->vm_ops->fault, only when we discover another reference > count race condition :) Doing this in do_fault() > > should solve this once and for all. In fact, do_pte_missing() may call > do_anonymous_page() or do_fault(), and I just > > noticed that the former already checks this using vmf_pte_changed(). What I am still missing is why this is (a) arm64 only; and (b) if this is something we should really worry about. There are other reasons (e.g., speculative references) why migration could temporarily fail, does it happen that often that it is really something we have to worry about? -- Cheers, David / dhildenb