From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F04BC5321D for ; Tue, 20 Aug 2024 08:42:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B9BC56B008A; Tue, 20 Aug 2024 04:42:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B4AE76B0082; Tue, 20 Aug 2024 04:42:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9EC946B008A; Tue, 20 Aug 2024 04:42:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 7F9A56B007B for ; Tue, 20 Aug 2024 04:42:58 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 125C58185A for ; Tue, 20 Aug 2024 08:42:58 +0000 (UTC) X-FDA: 82471983636.15.7FD836B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf17.hostedemail.com (Postfix) with ESMTP id D571C40002 for ; Tue, 20 Aug 2024 08:42:54 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CR19MwXG; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724143297; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SWUJzm0sbz/iWmHi3n/+8keFLyHjzE1PiBGZgurmPcM=; b=S/xUxR/AbFSbtdfd0HXhaJQ/e0bHUn0rFTYWODOyQaaThpld9fI7eC+ZiraybfGsjpNpZo UVkAUqq57GCO4j7WhYCgJ4V1wW/spyspzsC/CCMSztcy69a7VcCgehXX5CW1IN1HLeF0g0 74tGz/on/23dJd3fdTgCNQBJfZCLoH4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724143297; a=rsa-sha256; cv=none; b=8WyKbOoZARL7uhed1YLXfbn2Zn07UXi5rFVGpCoJhzrjyhXYKArdvSKMeBR5AaMYujlRvV GNXjb5Q8DA/g+itdPMwNNTQq82H8mjgiZf8GKVLLvRzFCo6XcJcqcu2K6XtAJuwP/CkMsY +9evsbETX9Aj3H4BrHRZzjm0oOUx574= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CR19MwXG; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724143374; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=SWUJzm0sbz/iWmHi3n/+8keFLyHjzE1PiBGZgurmPcM=; b=CR19MwXGxVNR5iPMOsYGkuCh6QfR6IilM4jrilEyjQa3wQGz8gcKBIxiqBxnApyBzmsSg+ d7EADPhbUyfnIxGNOZ0vXw9zQ5HqgGjafW0Zr47db1Huv6wa2qdDliV8Q6h+84YkbNUEmV Ob367n1TqILOVCwn+hQv6lvI827cha8= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-94-l0DfA_T2McmCEkjEa2xbkA-1; Tue, 20 Aug 2024 04:42:52 -0400 X-MC-Unique: l0DfA_T2McmCEkjEa2xbkA-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-42816096cb8so57188775e9.0 for ; Tue, 20 Aug 2024 01:42:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724143371; x=1724748171; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=SWUJzm0sbz/iWmHi3n/+8keFLyHjzE1PiBGZgurmPcM=; b=Jz+cHakthIkZgyKcltFeg3dYiCGrtpMsXloKZDg5srljGxSxdi9efjSrb20RhB5rHX aerDB5wgFMLwkAF39QdFpAIWvsVWr+zPueQwjWesNKyMUpaxojuY2A35q9fUeBX6bQOe tHBWCEFRZFzA49NKu9oE/DsbW2viEDpbysA1q/MKGWOWgifm1EB3mkzqhILbuytkv7kB gxbWFWAI2FlmnlEf8uWUt52jixy98HbCyGbm47XxSI8lid888f8mr/oN7G+FAtpIU4Av mJVZFW6cSwPQCok+zxZ2nxj3YNUrd+M/vBpY/7ohP1sPDU2pos9MMvlBV7Y8MNUXIxj9 r/6Q== X-Gm-Message-State: AOJu0YwhgnDLjhohn+SdxF6Qxu/OHXk3x1KeIkpdn0iB/kXJkJMd6QeJ XXa7rIpZrL2yRWfoPLwznK0PMN0OmNjnYjVzy0ccb4vyGl/IoH3gXrwJS1wUdBGD0StMliA0EXH S+I9xhAqBjFXfLhfSkdHBKKw7oODp9AsgjTLV1qDV432ri67d X-Received: by 2002:a05:600c:358b:b0:428:e30:fa8d with SMTP id 5b1f17b1804b1-429ed784090mr116330345e9.6.1724143370729; Tue, 20 Aug 2024 01:42:50 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHdyGlYpYB6wUWyWkSdee9tjYe2uXQky8ZlConO8vugeVJZXMy8MPGutLoSL6yxNKztzyNnSQ== X-Received: by 2002:a05:600c:358b:b0:428:e30:fa8d with SMTP id 5b1f17b1804b1-429ed784090mr116330075e9.6.1724143369927; Tue, 20 Aug 2024 01:42:49 -0700 (PDT) Received: from ?IPV6:2003:cb:c74b:e00:9c12:cdf2:bf1c:b8ed? (p200300cbc74b0e009c12cdf2bf1cb8ed.dip0.t-ipconnect.de. [2003:cb:c74b:e00:9c12:cdf2:bf1c:b8ed]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-429ed785708sm135014605e9.37.2024.08.20.01.42.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Aug 2024 01:42:49 -0700 (PDT) Message-ID: Date: Tue, 20 Aug 2024 10:42:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] mm: remove migration for HugePage in isolate_single_pageblock() To: Kefeng Wang , Andrew Morton , Oscar Salvador , Zi Yan Cc: linux-mm@kvack.org, Matthew Wilcox References: <20240820032630.1894770-1-wangkefeng.wang@huawei.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240820032630.1894770-1-wangkefeng.wang@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: D571C40002 X-Stat-Signature: unazpb88y5uc3f6hsdj7gurapqjtj8j6 X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1724143374-62422 X-HE-Meta: U2FsdGVkX19cBLCUdmus1MsYLYp1YqHVRc1/WSGRXH/l8EJ7q76vFHQO3fCv3pDO65BHIboXNyCdzP61zuieKTDmiA4qKCzzs0ESm2AVTWdX9OWGIy294AyoATt3Dwa8Wm1moJWCzanLTxX14vbms8Q8OjQdz9mpc5MOuYHIBmTr2UaP1IYLVSSazuvS4bLDfD3piZVOfPGxhxpXgWuLfXKOGRmtaEES7MuuCmjmI9dWkady3jMM5jO13uqnIUvtZ22Q6NbiO1HUnwoc6Ri8PlSiH7QdFT1VjgCbRC4MszmB7mOhU/vNolaNoENaSk1NQZl4Ig48XjsaTFPVVUppp30wtoxxccjMD+KWGB01COcINcPC+h021vALMhkC/0QdpF9vPlE5E+gOXUPqoRmb21zkj/lJ2IQ5RynyPlmUJe9xth7FQ0UQSGN7K0hZNDCTPGKjIDfKuJdqdWFmbRxlSpUPxKfDUISMhtIhzIEWONkiRS88tIOlaI79uMqgMpwrXDKjmLl89+5rcCk6a73piukKPURDFdBpaKcongD2aUGTrV+6hEKXcQfPSl3eJxJlZ29cC/A1nsyf/UV4ceHs2f/qOh78VHhcURe2HQR+wCC3DtZn7c5M87pU5e/2hyE5/z1nsf4sGJNJj0Pc7wvUr+ueaLe80Ldk8IvddDwDyWyC0l5hQOV93jX7UJrE0pA3xKCkXBjcEvbmYr/SCkuN7lOLx31rWBNKTXi6Y0GTjNWz+apLVI+i6qTkxcaU2ZAWYWYHwaDaxJwR1fpMKW6++RFmF99a6O9mJBAJThu0P/vxy277xk8uyMWaSKy7kCdy+r/Q6wwkvaLjah9+HRCQo77mX8rRc4n0a0kq614dPblFtjMjBXjwtxJVGwABzh4lZ6U0o+eQiKFWQ4qGoDpPH18wzXN9JfgBSVBqqOPSdA3vbg5qYIvlDzJVtrgTCT5PduzTwKJ3ESGlMXoHoTU Cw8Nlz0a pPnD6Txw2IVY9mZocSnZP79IhlQJXMnxeCLZjVHi2dc6Vve3QgtmyV6EHOy8d8UWbvFnr0khe2QZ+XyaDzsnzEGaJVCNLR0rxhT+7Y/G93O36Ii6PdD/iN3O9eaMbHwhZ3wn7TdiPIuMCXd6QZbtkt2o2vQZ3KA7NpdwHxZidMwOvFoGz9gNj8kagiXA19hpES+kLVcplrrpX2TcmupOaGdQp2S//FOl+tbEr8ps/hr8ev1ktcNKyKwQbIatrPd9XejXzxvYt521RY/STJs20P7P3xskjTcrGrqfRq4Jzq4uwE3PWufya6v3c28M46iOaO4DYQdoW6QnakeuUtrB+NMk+3h9Ny2nQcrVR05dGEDbGDC+txRWqc5x2G+3imLK+nQCc0mX5BXszg6TNN40KwjgfFjjN8T5HNLvLzuLSUmZq9lTeQqpZMdKxAna97NTUbA0Igi0aj0t3SatGtWfjvUZF8A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 20.08.24 05:26, Kefeng Wang wrote: > The gigantic page size may larger than memory block size, so memory > offline always fails in this case after commit b2c9e2fbba32 ("mm: make > alloc_contig_range work at pageblock granularity"), > > offline_pages > start_isolate_page_range > start_isolate_page_range(isolate_before=true) > isolate [isolate_start, isolate_start + pageblock_nr_pages) > start_isolate_page_range(isolate_before=false) > isolate [isolate_end - pageblock_nr_pages, isolate_end) pageblock > __alloc_contig_migrate_range > isolate_migratepages_range > isolate_migratepages_block > isolate_or_dissolve_huge_page > if (hstate_is_gigantic(h)) > return -ENOMEM; > > [ 15.815756] memory offlining [mem 0x3c0000000-0x3c7ffffff] failed due to failure to isolate range > > Gigantic PageHuge is bigger than a pageblock, but since it is freed as > order-0 pages, its pageblocks after being freed will get to the right > free list. There is no need to have special handling code for them in > start_isolate_page_range(). For both alloc_contig_range() and memory > offline cases, the migration code after start_isolate_page_range() will > be able to migrate gigantic PageHuge when possible. > > Let's clean up start_isolate_page_range() and fix the aforementioned > memory offline failure issue all together. > > Fixes: b2c9e2fbba32 ("mm: make alloc_contig_range work at pageblock granularity") > Signed-off-by: Kefeng Wang > --- > v2: > - update changelog, thanks Zi, David > > mm/page_isolation.c | 28 +++------------------------- > 1 file changed, 3 insertions(+), 25 deletions(-) > > diff --git a/mm/page_isolation.c b/mm/page_isolation.c > index 39fb8c07aeb7..7e04047977cf 100644 > --- a/mm/page_isolation.c > +++ b/mm/page_isolation.c > @@ -403,30 +403,8 @@ static int isolate_single_pageblock(unsigned long boundary_pfn, int flags, > unsigned long head_pfn = page_to_pfn(head); > unsigned long nr_pages = compound_nr(head); > > - if (head_pfn + nr_pages <= boundary_pfn) { > - pfn = head_pfn + nr_pages; > - continue; > - } > - > -#if defined CONFIG_COMPACTION || defined CONFIG_CMA > - if (PageHuge(page)) { > - int page_mt = get_pageblock_migratetype(page); > - struct compact_control cc = { > - .nr_migratepages = 0, > - .order = -1, > - .zone = page_zone(pfn_to_page(head_pfn)), > - .mode = MIGRATE_SYNC, > - .ignore_skip_hint = true, > - .no_set_skip_hint = true, > - .gfp_mask = gfp_flags, > - .alloc_contig = true, > - }; > - INIT_LIST_HEAD(&cc.migratepages); > - > - ret = __alloc_contig_migrate_range(&cc, head_pfn, > - head_pfn + nr_pages, page_mt); > - if (ret) > - goto failed; > + if (head_pfn + nr_pages <= boundary_pfn || > + PageHuge(page)) { I'm wondering if we should have here some kind of WARN_ON_ONCE if PageLRU + "spans more than a single pageblock" check. Then we could catch whenever we would have !hugetlb LRU folios that span more than a single pageblock. /* * We cannot currently handle movable (LRU) folios that span more than * a single pageblock. hugetlb folios are fine, though. */ WARN_ON_ONCE(PageLRU(page) && nr_pages > pageblock_nr_pages); But now I realized something I previously missed: We are only modifying behavior of hugetlb folios ... stupid misleading "PageHuge" check :) So that would be independent of this change. Acked-by: David Hildenbrand -- Cheers, David / dhildenb