From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB9B5C43334 for ; Wed, 20 Jul 2022 00:17:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 267CE6B0072; Tue, 19 Jul 2022 20:17:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 216486B0073; Tue, 19 Jul 2022 20:17:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0DE9E6B0074; Tue, 19 Jul 2022 20:17:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id F04686B0072 for ; Tue, 19 Jul 2022 20:17:48 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id BAFA8140381 for ; Wed, 20 Jul 2022 00:17:48 +0000 (UTC) X-FDA: 79705565016.25.EE25883 Received: from mail-qt1-f174.google.com (mail-qt1-f174.google.com [209.85.160.174]) by imf26.hostedemail.com (Postfix) with ESMTP id 524E3140070 for ; Wed, 20 Jul 2022 00:17:48 +0000 (UTC) Received: by mail-qt1-f174.google.com with SMTP id x11so6644813qts.13 for ; Tue, 19 Jul 2022 17:17:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=in1U7QOoHlBT9spKzaUde6TVoZcpMDEN9PmUJ+MkwlE=; b=J5FE9SMckzYGleW+eLaTtjqk8aZngKiBjyR0di4cob19UE4XFM1CU9wX0WOjFp7A4O +LCU/JozugF1/EYLsGyuYVFwC6NMAPxpw7R4mtj59ovg+m/nlsACKEoKNCGFhP80VNpg 18AdPXbRUIk70EhukXKjgEdvResKflt0mteXWCna3c4nqjKUNFYlU9B1ZLKa6lOX6WfJ AAvD9Nsr+6jRC+lj0DJWbLxod3qyNl05mG2+up6gFiRTIZ3bjXXedYUBAuJywaTi253M Uw3bw40CW8s8S/pq43/DZ6375K2u2w2SInqSNAhz69hP7gU/t+d1Ls1aSIYnc23W4MGr ERNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=in1U7QOoHlBT9spKzaUde6TVoZcpMDEN9PmUJ+MkwlE=; b=0CdRGr/DuTMns27QT3NFMjZ+e2+cXKea6w+4nTCoBTXaVUhm3Nk1qrr89DS6eKvAuj PjZjzmuFDd9nDad62wCt8a5sjyqj8nbpVr11rcK6rFNnsM4EnFF/53z47Iz+sHEBfGeR QsDEhD8gw9oexOAFzEcXRFNoAXg8bC1Ko9e8AH7yiQy8BwWIy542J21K8XL0RoWnZlmr e8btYD1QzoRkzY3qWzZalXBKuogtaRxbE70xLyAy9g4dRnrRjqkhdfCMWpGuSZyOdZPI 29ZrLiaQzjV4PnJ4NlSFpk74UPP0VAATY/qzcGf2iSjIvIWkhq64mR/aPVTxKRPlfpD1 dyFg== X-Gm-Message-State: AJIora/FIuDaTsqz8+dwSyxiI8Xr5FGd1ezJ6ePgt+07TboOl5mHAC6u g1fWOKECLJ3km2yhWvCOZQ== X-Google-Smtp-Source: AGRyM1uKcUQ+y4eU6fW/0QyzZ4ryd5dL3sm2pXqBFOki8Aq7ocPKB5pgyPAjxGfHSzV4i0VhSRnlkg== X-Received: by 2002:ac8:7f91:0:b0:31e:fec2:eb18 with SMTP id z17-20020ac87f91000000b0031efec2eb18mr4398808qtj.485.1658276267541; Tue, 19 Jul 2022 17:17:47 -0700 (PDT) Received: from [192.168.1.161] (c-73-219-103-14.hsd1.vt.comcast.net. [73.219.103.14]) by smtp.gmail.com with ESMTPSA id 67-20020aed30c9000000b0031ea2328edcsm11517534qtf.82.2022.07.19.17.17.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 Jul 2022 17:17:46 -0700 (PDT) Message-ID: Date: Tue, 19 Jul 2022 20:17:45 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v4 00/34] Printbufs - new data structure for building strings Content-Language: en-US To: Steven Rostedt Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, pmladek@suse.com, enozhatsky@chromium.org, linux@rasmusvillemoes.dk, willy@infradead.org References: <20220620004233.3805-1-kent.overstreet@gmail.com> <20220719191522.4002a5fb@gandalf.local.home> <7462e934-f746-eef7-ff92-0eeb8cc08b82@gmail.com> <20220719200507.361b06ee@rorschach.local.home> From: Kent Overstreet In-Reply-To: <20220719200507.361b06ee@rorschach.local.home> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1658276268; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=in1U7QOoHlBT9spKzaUde6TVoZcpMDEN9PmUJ+MkwlE=; b=R0gfMF6IG3LcAw+Q/8ZxeNVVhJF4MnhXxttykKPNc451yZ/0tLg5rvsWZszS//FVEAhgWl ZUOgM2u2o0C6JQvBaJTVcIV8xW/yGp2tBfrUUdPFK4fYKkWbu+9PqQ1AXM4W1qE5FNs3Mu d/o2H65kYAjHan0LkSMq7yUMwKgoRKQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1658276268; a=rsa-sha256; cv=none; b=i2Wa13hjZ75ahV53ZjFlXM4P7V3CRf2y/hiLySn8/k49XUns/ibi06xIn5J6M3UlN6CJiX DvTjRpHEfnQHAMCkcRyu719+E74oVTuOQxfAjIL0Fqk44uRIqEph4gUUnrWswkqseWh4Jv gOBzkQtejCKsU1mDJXpybo4f8z0W674= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=J5FE9SMc; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf26.hostedemail.com: domain of kent.overstreet@gmail.com designates 209.85.160.174 as permitted sender) smtp.mailfrom=kent.overstreet@gmail.com X-Rspamd-Queue-Id: 524E3140070 Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=J5FE9SMc; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf26.hostedemail.com: domain of kent.overstreet@gmail.com designates 209.85.160.174 as permitted sender) smtp.mailfrom=kent.overstreet@gmail.com X-Rspamd-Server: rspam12 X-Rspam-User: X-Stat-Signature: fg9ytktggrdqg3hgaoys83867j8kd9qb X-HE-Tag: 1658276268-564889 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 7/19/22 20:05, Steven Rostedt wrote: > On Tue, 19 Jul 2022 19:43:46 -0400 > Kent Overstreet wrote: > >> On 7/19/22 19:15, Steven Rostedt wrote: >>> On Sun, 19 Jun 2022 20:41:59 -0400 >>> Kent Overstreet wrote: >>> >>>> Core idea: Wouldn't it be nice if we had a common data structure and calling >>>> convention for outputting strings? >>> >>> Because seq_buf gives us this already, the cover letter really just needs >>> to state exactly what the benefit is to replace seq_buf with printbuf (and >>> why seq_buf can not be simply extended to do some extra features). >> >> - seq_buf has the wrong semantics on overflow for what vsnprintf needs. > > More specific please. Steve, look at the man page for snprintf if you don't see what I mean. This discussion has become entirely too tedious, and your _only_ contribution to the discussion on pretty-printers has been "why isn't this using this thing I made?". You haven't been contributing to the discussion, you haven't been helping figure out what the APIs, helpers, data structures should look like, IOW _actually_ building something that could serve as a low level string formatting library. I get that you're busy - but look, we all are, and this patch series has already been set back what, a month and a half while I was waiting on you. I've got the tests now, I'll CC you when v5 is posted.