From: linmiaohe <linmiaohe@huawei.com>
To: Hillf Danton <hdanton@sina.com>
Cc: "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"syzkaller-bugs@googlegroups.com"
<syzkaller-bugs@googlegroups.com>,
syzbot <syzbot+c5d5a51dcbb558ca0cb5@syzkaller.appspotmail.com>
Subject: Re: general protection fault in unlink_file_vma
Date: Mon, 14 Sep 2020 01:51:41 +0000 [thread overview]
Message-ID: <a6660196fa5a4b71b8f5d6e1bc2aa262@huawei.com> (raw)
Hillf Danton <hdanton@sina.com> wrote:
> On Sun, 13 Sep 2020 09:17:26 +0000 linmiaohe wrote:
>>
>> I reviewed the code carefully these days and I found vma_merge() do only fput() the vm_file of the linked vma in remove_next cases.
>> This gpf is much likely because the ->mmap() callback can change
>> vma->vm_file and fput the original file. But my previous commit failed to catch this case and always fput() the original file, hence add an extra fput().
>> The below patch would make the things right:
>>
>
>Take another look at the Cc list and the link below.
>
>https://lore.kernel.org/lkml/20200911120222.GT87483@ziepe.ca/
>
Many thanks for your teach. I think I could send the proposed patch to the syzbot directly.
Thanks again.:)
next reply other threads:[~2020-09-14 1:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-14 1:51 linmiaohe [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-09-16 9:05 linmiaohe
2020-09-16 6:50 linmiaohe
2020-09-16 8:39 ` syzbot
2020-09-16 1:48 linmiaohe
2020-09-16 4:24 ` syzbot
2020-09-15 11:13 linmiaohe
2020-09-14 6:42 linmiaohe
2020-09-13 9:17 linmiaohe
2020-09-13 11:16 ` Hillf Danton
2020-09-10 6:26 linmiaohe
2020-09-09 0:19 syzbot
2020-09-09 4:15 ` Hillf Danton
2020-09-10 2:13 ` Souptick Joarder
2020-09-10 4:17 ` Hillf Danton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6660196fa5a4b71b8f5d6e1bc2aa262@huawei.com \
--to=linmiaohe@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=hdanton@sina.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=syzbot+c5d5a51dcbb558ca0cb5@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox