From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6CC4C71136 for ; Mon, 16 Jun 2025 09:14:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6330E6B008A; Mon, 16 Jun 2025 05:14:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5E47A6B008C; Mon, 16 Jun 2025 05:14:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4ABC36B0092; Mon, 16 Jun 2025 05:14:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 39B156B008A for ; Mon, 16 Jun 2025 05:14:23 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id B06BBC0D6A for ; Mon, 16 Jun 2025 09:14:22 +0000 (UTC) X-FDA: 83560702764.14.E6EF83E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf22.hostedemail.com (Postfix) with ESMTP id 3E5DCC000E for ; Mon, 16 Jun 2025 09:14:20 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=YgON7Lq7; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750065260; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Wuv2mA62fcjoUn35N/C8umkBOU3qJG3E1wudHQl3vVY=; b=jA32FsilDLjbsK1zjSHfagqQdqUXUQKAzoKohHBFLiFWQNPHpTDeM44oJC3TOV9VCRJb3T ftVpAUYn7No8pzlzD58xIXRRc7mFgcJ9aWfXbZOoA1OaPkacphaZ0IhaW86HU3yhKvRZgf NpA0+fIoUkSajcIYXHQPeDRBkw0srxE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750065260; a=rsa-sha256; cv=none; b=6cs50y0tuLwapXUzHCxUDxt/QncasKCyyK0EtaBO035pqueq0Ms8Hul+3h+4GAsoAtXRj/ zx23R575ZplPaiwUil40w32ZOaIUg7HmmTC4m212wz/PQZ8ZfTNxE/FSTpE6yzdi0BEfIR FT3tl9s92Exv9cXQrRbrrGeEEpEdiNI= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=YgON7Lq7; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750065258; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Wuv2mA62fcjoUn35N/C8umkBOU3qJG3E1wudHQl3vVY=; b=YgON7Lq7xFM9NS7WTtgiq7U3zyu7rkV3zPxZT+z5/LQHghYlA7pmNZg+Cei+baGAxtE20l cDJj6LoXu/lWfQ7twAs9lsJ7iZKpY5itJeK9QN9Yca7E6VS7berm+/SKDwmdxyxd/7zohM AvUGaaCqTFBuLX2amdkqhlOI4C7VaTM= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-37-y_1SYMZDOsCE_9A1qTJ4OA-1; Mon, 16 Jun 2025 05:14:12 -0400 X-MC-Unique: y_1SYMZDOsCE_9A1qTJ4OA-1 X-Mimecast-MFC-AGG-ID: y_1SYMZDOsCE_9A1qTJ4OA_1750065251 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3a3696a0d3aso1503306f8f.2 for ; Mon, 16 Jun 2025 02:14:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750065251; x=1750670051; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=Wuv2mA62fcjoUn35N/C8umkBOU3qJG3E1wudHQl3vVY=; b=XviS4DWyGZS/a3a+m7x6cCR4eKmXxaBQRqQc43n3jXVl1Z/Gspmn2xUlfuShy3kMjG ct5UAWHuDnpXkMGe+C2KJyHK/WkRq3ep2Nd7ghO7vbJoEwnIkHrsVRJiNq26BT1pV1x3 V0MLZXpdhzev91LLBMbD3XY4oTCxxBqE69mXPfXPUuJMxndgrokb7qvFU3znukksBXTt 5JzQe8YzboZudCwV3LAw4ecRz2quObm4mkVL5uB6reZTnZfjCrtjbleCOschtso8+BIj VN0sNxJIVFmL6MsQ2hU+1q03rLlHh8AWMTwIs7/id9Tj0xTu7ggC/r2EJdb4YEIsP4S7 Q1mg== X-Forwarded-Encrypted: i=1; AJvYcCVkDGzs+68d8HV1jtPL4eVlbPsKE6eIr+pqEByj70sn2l2Ne7zIrYBBOULqKS2sLkjH7eW2hKoS5w==@kvack.org X-Gm-Message-State: AOJu0Yz6wRr7XwyQ06COPyA/d08DD0A2Z6BrGFyLISYBu+aQhLEI4gVQ RbqmGHPUrmqDVtyr0Rn25WLG42AWUAdKjaIjJK4ABp2z1oWWWgHa4OHFED4blOGKTLJqaOMrts8 LClg3oa7m9DeHjajoEr+iNo7gqSvVN9xT9jqE5vB5chel/8uVx794 X-Gm-Gg: ASbGncshhR7n3gnov9u7WW43S+Wup+4XLrWgHXhOwU0AJK5VObQ3AXiE/UKrq1RJKq0 u+BD4EFsN0XgEHwhKaaV0UniCdxfcKESQcaPQWY/+jPqEv1kIrbl+dTNXq7cpF0cBA3lpEZ3d2L MLOwVcUBcspzTsTmVTfMepYqEea+Sm6PwlUKwYp3RE7Q1iQAvdKNE/3LtIG9ULz0p8xHhd+XxHo FT39QC/7ir2J01xIwnP54y4cVlroC4bVCDRFJPQ0gSmflfw9mPukDY4BJ6wES6Z40waNPeHmat8 UZAwVNrPeX9IYsDL2GiildnMVQaugXG1bGhPKKMqM/k3kUFXYV4MI5Sts3S0wdrm406xLfH6dXJ T1pClU9f/ZDB7SycQ2IMiJs7Ge52f1mkBfIf4ZNJiGAJ5M90= X-Received: by 2002:a05:6000:22c1:b0:3a5:276b:1ec0 with SMTP id ffacd0b85a97d-3a572e8c5dbmr6274574f8f.45.1750065250775; Mon, 16 Jun 2025 02:14:10 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH1eku5C1wKEWMA/zLh1Kb+dGj72gg4ERn3ZZ3O6rewQsnKxfuyXv1A1iI5gYDDemL/53xxLg== X-Received: by 2002:a05:6000:22c1:b0:3a5:276b:1ec0 with SMTP id ffacd0b85a97d-3a572e8c5dbmr6274538f8f.45.1750065250350; Mon, 16 Jun 2025 02:14:10 -0700 (PDT) Received: from ?IPV6:2003:d8:2f25:bd00:949:b5a9:e02a:f265? (p200300d82f25bd000949b5a9e02af265.dip0.t-ipconnect.de. [2003:d8:2f25:bd00:949:b5a9:e02a:f265]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a568a7f8f9sm10462943f8f.42.2025.06.16.02.14.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Jun 2025 02:14:09 -0700 (PDT) Message-ID: Date: Mon, 16 Jun 2025 11:14:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/5] mm: add mm_get_static_huge_zero_folio() routine To: "Pankaj Raghav (Samsung)" , Dave Hansen Cc: Pankaj Raghav , Suren Baghdasaryan , Ryan Roberts , Mike Rapoport , Michal Hocko , Thomas Gleixner , Nico Pache , Dev Jain , Baolin Wang , Borislav Petkov , Ingo Molnar , "H . Peter Anvin" , Vlastimil Babka , Zi Yan , Dave Hansen , Lorenzo Stoakes , Andrew Morton , "Liam R . Howlett" , Jens Axboe , linux-kernel@vger.kernel.org, linux-mm@kvack.org, willy@infradead.org, x86@kernel.org, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, "Darrick J . Wong" , mcgrof@kernel.org, gost.dev@samsung.com, hch@lst.de References: <20250612105100.59144-1-p.raghav@samsung.com> <20250612105100.59144-5-p.raghav@samsung.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: SCiXBuqcosRkak-V9XUKSC4PHXqlWiGCc2jndoIpRfk_1750065251 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: ptb9iup4nw3aqxuqnnc85c35med97m9d X-Rspamd-Queue-Id: 3E5DCC000E X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1750065260-29781 X-HE-Meta: U2FsdGVkX18MtA6TXo9Qb9QG0oOYn94sgmRIyGlCaXJq/1BlF6C02mRMXrUCgZJIzztV+ZBk5S3jjdXv5tI+SBTGvVvi56We492HkQitI/tBs6xY12xvYwd2Wm4XMoCZPPBHXJV1kOZTU/eNC59yCnECXuMPqn560Rzjvpu06PPGjqWkA+lHapHiu52oE4IVnVT0pfaFLYCSFlz6dKcMHb51Ej/CgcxSulO61MllPJWi/b8AgO9g+mu7kaQZWk65ZmvngziCva3X5Ez/DonevO1Nv4ukB3gtAXRDHee8isSf36FLeJ0reDemtJVNm1cxtZd+iAb+S7kn4qbQ1utRJStk1aTYxntXBBY+RuMW7REtZNFHTBnR/z7PgPpdVvxHwoEi7VhznCfm8/6imSEaMZZjp8b0ZTzXhaLGrsjCyi24RXTWOj68iOrOkDtzF6a0r6naZRUNchGBjJqgi47TQjs6FNhxDX/Ez3OL8xXiHOlt5JD2ftjLjdrkOXJ6Zh7POSnXXcAcOR+zaRWVblpKZVvLw+p4Wc9qWczVcJoFULTfmiPynLjhVk8IOya+yA1yUZ8VK0hFbo81RATslVyDsrDFBQ/yKPorN4iJ/ymx4xTTjYEMS0r+UCMuM2EIMPlufOsAmFfpdV4rpKWvh7/kbSYh9Yo5LXWXv05mN+qBS79gvbHhk/BRz90GDLXMEu1F9fcjEXVkrQRtWXlXuA3PgN2XrfKpiObhbH8m6BFFDsye0P8yXR0oyD/nDy/HsSGi7w5d+ZsYLnD2UjbcPEEJVPJYeN7hQljuj02Tb2bH0J9Jo6d5Pl+Osl+vxCZjcf0UJqIMl/vYZVl0w/ohSs+HD2CWG5UHzZWOrkhpuC1/WMsTOSYP97jyzE2nlnN21Ymm150YX9Ed9NyyQeUo0X1f5JLXkty5bfJo3Vsh2FqOAa7Y1Hac8BFO3/OiMXrshDbnTnX8QLS4dA1WG+z9UQ5 5NVn7xFC Uwu+NexBymEzotpuKCH/WS5ADm7PX/96rLY30DzDsNgZcYSDrBtfEFMeZfLShrJOy5dL0daU+xOLYG8jzn/BZYdhLjJXAWJA323/tpKlq1BskM9F+NpJSuso94nHZ+rbNYSTO6mJSejeTRyZoM7DLBsFGrHFjisgjdOgpAeAtdDM7gUmBlBJAv3B6MoqzfzQQN/0v2fuJqtrBVQJ/bdx1/lqhQXxsC8eCYncLvFVSEzKV0PIcUCB0lOMV25mL+KffQrnUgKCatyXpAK7VaLU+3FbVxOaWLDktM+Vn4CexLLXKFuCmWgKJ1K2p1FMUdjPbcFsaB7v1p18vzr44mb/ItG6onONxe1zpwYO18Y2BW8sYkchig5nG5/33ydyaMjyQTS3+W5HiEPca0VWcQwM7lfgQn6O7PFS93J9FmaaO4ICOgSSo9/vrxmgDe7YuBIJFj9VoeE2PDP7mXHk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12.06.25 22:54, Pankaj Raghav (Samsung) wrote: > On Thu, Jun 12, 2025 at 07:09:34AM -0700, Dave Hansen wrote: >> On 6/12/25 03:50, Pankaj Raghav wrote: >>> +/* >>> + * mm_get_static_huge_zero_folio - Get a PMD sized zero folio >> >> Isn't that a rather inaccurate function name and comment? > I agree. I also felt it was not a good name for the function. > >> >> The third line of the function literally returns a non-PMD-sized zero folio. >> >>> + * This function will return a PMD sized zero folio if CONFIG_STATIC_PMD_ZERO_PAGE >>> + * is enabled. Otherwise, a ZERO_PAGE folio is returned. >>> + * >>> + * Deduce the size of the folio with folio_size instead of assuming the >>> + * folio size. >>> + */ >>> +static inline struct folio *mm_get_static_huge_zero_folio(void) >>> +{ >>> + if(IS_ENABLED(CONFIG_STATIC_PMD_ZERO_PAGE)) >>> + return READ_ONCE(huge_zero_folio); >>> + return page_folio(ZERO_PAGE(0)); >>> +} >> >> This doesn't tell us very much about when I should use: >> >> mm_get_static_huge_zero_folio() >> vs. >> mm_get_huge_zero_folio(mm) >> vs. >> page_folio(ZERO_PAGE(0)) >> >> What's with the "mm_" in the name? Usually "mm" means "mm_struct" not >> Memory Management. It's really weird to prefix something that doesn't >> take an "mm_struct" with "mm_" > > Got it. Actually, I was not aware of this one. > >> >> Isn't the "get_" also a bad idea since mm_get_huge_zero_folio() does its >> own refcounting but this interface does not? >> > > Agree. > >> Shouldn't this be something more along the lines of: >> >> /* >> * pick_zero_folio() - Pick and return the largest available zero folio >> * >> * mm_get_huge_zero_folio() is preferred over this function. It is more >> * flexible and can provide a larger zero page under wider >> * circumstances. >> * >> * Only use this when there is no mm available. >> * >> * ... then other comments >> */ >> static inline struct folio *pick_zero_folio(void) >> { >> if (IS_ENABLED(CONFIG_STATIC_PMD_ZERO_PAGE)) >> return READ_ONCE(huge_zero_folio); >> return page_folio(ZERO_PAGE(0)); >> } >> >> Or, maybe even name it _just_: zero_folio() > > I think zero_folio() sounds like a good and straightforward name. In > most cases it will return a ZERO_PAGE() folio. If > CONFIG_STATIC_PMD_ZERO_PAGE is enabled, then we return a PMD page. "zero_folio" would be confusing I'm afraid. At least with current "is_zero_folio" etc. "largest_zero_folio" or sth. like that might make it clearer that the size we are getting back might actually differ. -- Cheers, David / dhildenb