From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAD37E784AC for ; Mon, 2 Oct 2023 11:15:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5E9538D001F; Mon, 2 Oct 2023 07:15:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 599938D0001; Mon, 2 Oct 2023 07:15:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 461CE8D001F; Mon, 2 Oct 2023 07:15:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 36C878D0001 for ; Mon, 2 Oct 2023 07:15:42 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 0E06E1C9ED7 for ; Mon, 2 Oct 2023 11:15:42 +0000 (UTC) X-FDA: 81300266124.10.2B7F82E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf06.hostedemail.com (Postfix) with ESMTP id B7351180019 for ; Mon, 2 Oct 2023 11:15:39 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=H0d9i7Fj; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf06.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696245339; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vloWIm8roEEtkpE7kohbeVMYbuY6qmZVGsigEMAa8jk=; b=t8pv/6Z0pNReLDKFbZ3RLPLhz369sHlTUToNrnNqAU2y8r8INqYrfw4ntRS2ZQ1fSzZ1Hz 1uzM3azv0YzqtlSJF9KPWqQ/BhHMDB/WZA5gd7FF2Af0qeorprOuW9Org/3BlniPpJK5TK saPPncdhwVgrUbjRXw9GYLAXcK6RaU8= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=H0d9i7Fj; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf06.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696245339; a=rsa-sha256; cv=none; b=RIElPX5jUArfY5ku6ZzAUQG6rUuKgUMLY5sR0ZayYX9J0Dcf5R11VaoZQoxfcl3wWuT1dV grsSl3iy5yA3HMeP5gdQwJNTHm29LJk4hLFHkO/IHDUprEDkFemLu1595TK1VmbRxjqqCR 3o0V3G926dvyPfZAB+4wWtPI92PadNM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1696245339; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vloWIm8roEEtkpE7kohbeVMYbuY6qmZVGsigEMAa8jk=; b=H0d9i7FjxgFDw53qerelKijbHvbe6c7mkmnLtTc/p/zB28Rebb+bMl/uNX0bc7EbgGwfjf r2gZW5AOz6vXxcQApNzG5zsfJsongi0lycB6/3ZGJfP7EXXfGnAyKxs0HGLYbzCCFNJDUA k8UiXNWiYgW8nfKrsGHdPbyhRisG1BU= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-227-cXHyCXEAPPyGlpW6IZgP5A-1; Mon, 02 Oct 2023 07:15:37 -0400 X-MC-Unique: cXHyCXEAPPyGlpW6IZgP5A-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-405629826ccso121485655e9.0 for ; Mon, 02 Oct 2023 04:15:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696245336; x=1696850136; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=vloWIm8roEEtkpE7kohbeVMYbuY6qmZVGsigEMAa8jk=; b=aDa6HsMNvUh/BR3yjgMNnv99B/AqQcMb2XqW6EijgdakDEuFnWz415+ISbxp2WKfFn t+FjqPjci4+dzNH/cXNWRnqLRquUSi2xwd8fBvIYM9uHw0wJeG62r2nMPRcFB6WxxpHT 5NdVtgI48KwDvi+MeDFJF4diu4FPiCG2gzaAFsiYRZCuUWiFDWDoDOcxPo5iNs8g3Tgf uP+GT2yzm1saT2TqQctym6y9hbncfmb6nvfisooiIMR5CpE6vacsuTYw9GxB98oUrPiB cyx53bfj8TSc/qAY2hduiulXlOKlyelFiBpjQ5tsiU8Z86AviM/FkQTffbVKSRphE/4q CKGg== X-Gm-Message-State: AOJu0YzR0N2tFONoDdWijvCTKMezLeaGAQUBkNZRQWlg3FYcsbH5AGkq Ju7/xAszd+0m/Pl1iVhGTCIasNJRHZ5WqIoFOUd5bkVEZPPVEL9OkUWqqqNBWrxgnUAjOiFyEhU tu0xxciaAbyMlWHK/89c= X-Received: by 2002:a5d:4c84:0:b0:317:5182:7b55 with SMTP id z4-20020a5d4c84000000b0031751827b55mr9436587wrs.42.1696245336567; Mon, 02 Oct 2023 04:15:36 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGW9393cqtNAAuZ44EYJhv8HMERFb7Fxyq1hsOhUqUd37RVvM2CvD/2j4qcON/3kGZkcdStFw== X-Received: by 2002:a5d:4c84:0:b0:317:5182:7b55 with SMTP id z4-20020a5d4c84000000b0031751827b55mr9436571wrs.42.1696245336137; Mon, 02 Oct 2023 04:15:36 -0700 (PDT) Received: from ?IPV6:2003:cb:c735:f200:cb49:cb8f:88fc:9446? (p200300cbc735f200cb49cb8f88fc9446.dip0.t-ipconnect.de. [2003:cb:c735:f200:cb49:cb8f:88fc:9446]) by smtp.gmail.com with ESMTPSA id 6-20020a05600c22c600b00406447b798bsm6999866wmg.37.2023.10.02.04.15.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Oct 2023 04:15:35 -0700 (PDT) Message-ID: Date: Mon, 2 Oct 2023 13:15:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH] mm/gup: Clean up errors in gup.c To: KaiLong Wang , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <1748b504.8b0.18ad9d487ae.Coremail.wangkailong@jari.cn> From: David Hildenbrand Organization: Red Hat In-Reply-To: <1748b504.8b0.18ad9d487ae.Coremail.wangkailong@jari.cn> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: B7351180019 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 1fgizs7ujwmqr84mqcde6zon6qwymgj6 X-HE-Tag: 1696245339-120072 X-HE-Meta: U2FsdGVkX19K8WQO86P4bQhH+1WhgtifV3bwYCEWZeHd+CeTCWXwjQ4XClk502ErmIO8Ve8ejEF6rrxdBxSIoTeOBbWWDQrJfGXe7nyvyaSAzirZWHZutOSQERapJ3Meck95hcHW1GXKE+hdjWO9aeDrVBdXkqogvnXPSB2gVvVYYqL5WKEYS4dVOk6Nkl39ZkkSoskF7sqXbQd/XvHUyHET+rRZ7BX2HY9MdHiG8eZfSwkVosyRFkYzWEz3UJ+3/v0vfnGLYqtpSKTX3N0AVojMMAONlImdoXTkP8OMIJOHHhovzKAxAl65e0wi1FlgmOxpDMD3TCW9UqDGCMkXpbcF3Y/NMwYnFlrr/q5WXn608OmvRnNtksuAR0ODLxHJrIqlXTkiwtvhUrCgUpMxmHdgp957J52kOczWgmWH8jBKhmjC5EsXMwSdUCf7m2tReVWkhRrvrGMNrAp68jQD7E4r/PtiVgDXZglZN/Gp/g8R99Jnd0HGvAnPe6q1J9RkjdAO0CfB/N0xZweZMyyKSrTGPKROSgYlSXgcbkluITJ+NbguLenklqKqclUO152IDqdskoP2C7erWbCDV/sNUazjQZbnZGO8reKQbdPObxW6S/sRcEtOxxuICEd62mcHVyFcNRshE1W2Qx9vi5l8aBhuLFWHGin+GKOuFSEuyUu1qPtP83exan6G2ugWUDTU84Gm0f+dVqQecjm/bGZsta5PmDk8fwQvIdZPRT6ZyxjBo7q2ZIRa7UOK+Jn6unC1jurpf7o+9IcGdA99xHJWfLuldOAP6P8UkXWq31O8SJkYTI5yBG8xr/WslnBzNi4/MF2Gc8DSfcAcu1sBV4aWnGsMQRr0o971Dz6YHj3zadU3CL4NVRZ3TLvH+kwQ/mlH6GMN/rbdKSI5ISdQHR39NYH5gaSJ0qWjr4fA2GqugsIXxCM6dEoQxsqYfnsVIWBLnQr6p+LOWKl0vjkB/MG oDYvVsxd j77vdgO33OTeZFt3MeN7XxwLUlCc8v1pyKDM4fd9aX/N8tvX+nGLcq6wKJWbvpjyIcq/OZIj3VtrQs6KUeBiiBnfKgfyR8kgAOTU0BdROOIuqH/Noy6gIjjaitYFKXw975k952Vm7ssTRZgJRQB3Ir0b52dHtIg0iGNgUcvztH9hWQC4815pOAhrvuo+PKyoh4PqKFF60QSNHdiFB2M8NHwmNvdpI+9i1mPQ+nalspJmX7YoGg9Ta8nW/iMgNdRi7Ip9NhknlT0I3+ik2RRaNIHpPbEbCQRFkchDhwf8oPiaKuDOQvG4nP1jxmU5NL2+TFbsk2OLz/kEhAG0lOomv721bu1otNxdGAUZM9o8Jz0xwh37h3osuzoLSFwGB9tdkERRwxLUJ5cjZX9j81grorAJOdQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000828, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 28.09.23 05:28, KaiLong Wang wrote: > Fix the following errors reported by checkpatch: > > ERROR: else should follow close brace '}' > > Signed-off-by: KaiLong Wang > --- > mm/gup.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/mm/gup.c b/mm/gup.c > index 2f8a2d89fde1..aed327450250 100644 > --- a/mm/gup.c > +++ b/mm/gup.c > @@ -1480,8 +1480,7 @@ static __always_inline long __get_user_pages_locked(struct mm_struct *mm, > return -EAGAIN; > must_unlock = true; > *locked = 1; > - } > - else > + } else > mmap_assert_locked(mm); > > if (flags & FOLL_PIN) Please see Documentation/process/coding-style.rst "3) Placing Braces and Spaces" -- Cheers, David / dhildenb