From: David Hildenbrand <david@redhat.com>
To: KaiLong Wang <wangkailong@jari.cn>, akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/gup: Clean up errors in gup.c
Date: Mon, 2 Oct 2023 13:15:34 +0200 [thread overview]
Message-ID: <a65a8eb8-8889-051b-f46b-b797ed91e0b0@redhat.com> (raw)
In-Reply-To: <1748b504.8b0.18ad9d487ae.Coremail.wangkailong@jari.cn>
On 28.09.23 05:28, KaiLong Wang wrote:
> Fix the following errors reported by checkpatch:
>
> ERROR: else should follow close brace '}'
>
> Signed-off-by: KaiLong Wang <wangkailong@jari.cn>
> ---
> mm/gup.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/mm/gup.c b/mm/gup.c
> index 2f8a2d89fde1..aed327450250 100644
> --- a/mm/gup.c
> +++ b/mm/gup.c
> @@ -1480,8 +1480,7 @@ static __always_inline long __get_user_pages_locked(struct mm_struct *mm,
> return -EAGAIN;
> must_unlock = true;
> *locked = 1;
> - }
> - else
> + } else
> mmap_assert_locked(mm);
>
> if (flags & FOLL_PIN)
Please see Documentation/process/coding-style.rst "3) Placing Braces and
Spaces"
--
Cheers,
David / dhildenb
parent reply other threads:[~2023-10-02 11:15 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1748b504.8b0.18ad9d487ae.Coremail.wangkailong@jari.cn>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a65a8eb8-8889-051b-f46b-b797ed91e0b0@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=wangkailong@jari.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox