From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EF7BC5B549 for ; Fri, 6 Jun 2025 08:50:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 591376B007B; Fri, 6 Jun 2025 04:50:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 542116B0088; Fri, 6 Jun 2025 04:50:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 430B46B0089; Fri, 6 Jun 2025 04:50:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 275E86B007B for ; Fri, 6 Jun 2025 04:50:45 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id C79A01D75C8 for ; Fri, 6 Jun 2025 08:50:44 +0000 (UTC) X-FDA: 83524355208.17.85DEF30 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf06.hostedemail.com (Postfix) with ESMTP id 63ED7180007 for ; Fri, 6 Jun 2025 08:50:41 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=RRZ9qt8S; spf=pass (imf06.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749199841; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+jVGCLNE+Y84dY/dAizM1Jz9ChfchugSBK8bEjTnJ48=; b=qCGg/SsXTIpk+qJboApc8XgBRVsaDpJpuzuTax/hClmtA+p5/JwTBxjmP+UqBbute3f10I 07wn0KM03GhIDZnIrXT62jYCNQmB4oJbyF2d/IhJrqYZpmDdKc2HWjBomRjh2mtvF4tEDI HEY1K4FguV2TNxQp1KFwA4+UmJhSBVk= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=RRZ9qt8S; spf=pass (imf06.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749199841; a=rsa-sha256; cv=none; b=nqQeMtBBUgzjDoZjCUnryKNhOLeJW+pBlxENTdL9gzwu3MehO9x415W51V3lwsS/DBJs+M Ih3Ckx7BXc4mAja/6PO6GMg8VZ+9c4sWHmP6eOHKD8c21CyUpzhkHvjE4Mitt/UPY20vGo lftkfwlCggLhn/ar5IaMz5vvhTyr+a0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749199840; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=+jVGCLNE+Y84dY/dAizM1Jz9ChfchugSBK8bEjTnJ48=; b=RRZ9qt8SkbvDwmYNtjUCZnnng60MhLQmk2yo0tQkRQSynTDotWzt/zqW1t/q4FxYPHkOkE IaBEtk8kTBCCeR7G190hCSLpwCM/9FInGrFa3ugq1fpRqLxRqtQo1FmBSFOf6/ig45HMGo xBy7NbuqLmbsijeDb+1WD3MGnNvVgDE= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-137-Q_5317D5MzGnrHmqAx_kag-1; Fri, 06 Jun 2025 04:50:37 -0400 X-MC-Unique: Q_5317D5MzGnrHmqAx_kag-1 X-Mimecast-MFC-AGG-ID: Q_5317D5MzGnrHmqAx_kag_1749199836 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-442e0e6eb84so12454415e9.0 for ; Fri, 06 Jun 2025 01:50:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749199836; x=1749804636; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=+jVGCLNE+Y84dY/dAizM1Jz9ChfchugSBK8bEjTnJ48=; b=n8Zvi042PP0/Hp/Cc/tHCcEDI54yRhGG0Pzd/bPu7RkTSlSq9TpPbDAKwBXjlGnrhJ gpLSl77aeFA47R1H6hi4nxmhsI5Nh6TbnxMXG0OHm3AhmdWQIXWFvGyLr26+6J1X27gK 4FGaGYgLbrrOO60mHSAfxowed4RVVmdDZduyMD5nx3x+dPuhz6ySwbKdOH67LQeyOWlS B1k43K7g544ww/5ANal1Y2ewGOeFf2uSCa4m2gVQ+ApWz4SmdgQlHH1imakjgn/+eDBQ Bj8JYOhS93dSXpZQlsV6gU7g+mlTlqUwNo9bMdlrWNyEIeMuXsLRNYs30ha08nJVGxER tgSw== X-Forwarded-Encrypted: i=1; AJvYcCXmBkZLklmGousVlUy3iMn4cy+hRvSc9A1KNFFb0WVulsH3POIQeSoZyIZxuBubfV21MJgS8QGqfg==@kvack.org X-Gm-Message-State: AOJu0YxO3sI8aF90LEjXEX+7hbLC91N0MIdld9huwzdKv0a4iG+vY9Go QxwbRSVFiYpRrh7fmKELkZcX1T4mHRiuVu+FvgwK5InOzHyCsPjIbYGgY+3nXhlLS9Kfpznk5cD oQQQOHdPLoT1sigyrp4YzVqlR42SuWy4obVy50kwp1n0m3y+RTmxM X-Gm-Gg: ASbGncurTg9WT5ShHCceovi/8GPjTg7SzwE7BEx6m9Wv3EWgY13IBnQ0j2BHfJlj5F+ WkwHbD9iDZZ/KiwpNWMMC9ZRvRcOJDGZgvu4r4BlGag5f1OVQ8ETT0FDC+dw91sYkKZNOeRK+RK YnSK49FqZvXtJGKn0uJmSZknBzw2hQekl4qxmjfuyXBO6gvX7O5MwIpU8vwPZoG9dAo5NmYlYf/ dULIhJpsdTKfEF6W4lhROhJ4NtSC/3RAs+65gs4dSxQ8HGeEx2qqMIib44LRdBWWT2QTd1xu5Wv 353MtDgWg/BrrOWPlhwdHw1SuM9XuUrTDvoShrvbjqhXxHO1BqIZ27CsKLpSzMQnWyX/1nZwQcC 2oxViVmYH6dpD2DgVgjUrnNNTkDkzjqaRJ3ucH1ZZOQ== X-Received: by 2002:a05:6000:188f:b0:3a4:fe9d:1b10 with SMTP id ffacd0b85a97d-3a531caff2dmr1937777f8f.45.1749199836355; Fri, 06 Jun 2025 01:50:36 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEFL0MNruz0U+4MdgmRWYwnLfF4ubZWX/hEe7N/lMd0fy1ZWGQtYG5R4YydA9ydpEvubuZqTg== X-Received: by 2002:a05:6000:188f:b0:3a4:fe9d:1b10 with SMTP id ffacd0b85a97d-3a531caff2dmr1937762f8f.45.1749199835886; Fri, 06 Jun 2025 01:50:35 -0700 (PDT) Received: from ?IPV6:2003:d8:2f19:9c00:568:7df7:e1:293d? (p200300d82f199c0005687df700e1293d.dip0.t-ipconnect.de. [2003:d8:2f19:9c00:568:7df7:e1:293d]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-452137281b0sm16686905e9.29.2025.06.06.01.50.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Jun 2025 01:50:35 -0700 (PDT) Message-ID: Date: Fri, 6 Jun 2025 10:50:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4] gup: optimize longterm pin_user_pages() for large folio To: lizhe.67@bytedance.com, akpm@linux-foundation.org Cc: dev.jain@arm.com, jgg@ziepe.ca, jhubbard@nvidia.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, muchun.song@linux.dev, peterx@redhat.com References: <6f0ee0d4-60a9-4453-a08e-2353b234dac1@redhat.com> <20250606082713.87113-1-lizhe.67@bytedance.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250606082713.87113-1-lizhe.67@bytedance.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: jMceyemNLlqaxTKSs7fvCPt8acVJ90KcBLuf2y2XL8I_1749199836 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 63ED7180007 X-Rspamd-Server: rspam09 X-Stat-Signature: cxmnt5bguysnm5bwz7j1n1abfssuoqj9 X-HE-Tag: 1749199841-361264 X-HE-Meta: U2FsdGVkX1+tKDqCxjL+seVyAJtthss55xehgk7a39HPa29UQlZ3VObpLjYmKQSXFvRW87obS3x4LXxGtSz4+x19jvY8F+DfOpVGDWZVoR/6xf54t/30HCfAiS3fvCTx19/ucTPKz1Ybruqx/497vk++lYB7Z809M4DG1IQ/ZwGuglZ6oy1JFUPM6YF2p+zovWRkSXmYqtCst1q2Zl2eeoY+i08oXs4AVQkyHHeVTEjt71RCU60OPmvjw3tR5M9sqCZ0Kd/hLUX1wzwYaF/JpcKqr2iNUIUt74mgpTrEoOcECQNMuQiW5yrblRnI1Idt2rUl499fq5aloLntzHJSnak3NA1VeJ6fdbvk2tTo+rSu2HAQuJgyZ1RnqhpNHEe7UnGmyvKHxzhxCHTB/E4mTWapZ/fenLGinao6hcFhw7WmKO4V5hf6WX1P3Ip1P6MR/U/FytgR/MdzkazHUjoYWiAGBnPFN69ocOfTt3k8GHx5FcWic7l8pPoJm4/BrhODlbSB02TYxKUac0sY2RKfxUHtI14lJGDYZEGzJV3U8kJX9l2Q/SYlegkaPqtQkNB1EXZhOPv+133wLRx1Ll7eHYaSR42HKQjmnKGXhil5C49PeEeilglmk2eY6FtwcyGpT8v9qsjaiNntyF7yDTpV1IK9QG48NyN6NikzD0x48ysWf1qQls0bdK9Fapy3WwHfar5HFqNtjxkXIF5qeam3JrvEyAUiNCVH38O5H5TexcX+yNvwVPTnaGs/UhL9DF/TNE2bTXg9Rjh4M6Z+hlG9IUMp1lFgg1weBaBlea//HdVQYZAjA2V7drkpQp1SkeWx6mI1/pXPWudVqkkOVt8DXLpTjIAM8y5bFvU1MwGzj1RDV1IQ+WCz/SzXdZv0OPftXpO2oGq2k6+rfVdDjDXPrus+AKCmUDe+0xdW62CXRapZHSOy19+e8h/ZIDVSaWJxJE1L8Fijl1JuZKnXf93 gS3RYwAf 08eBnSDXFZyyHrAElSxge6sTkM9fBLFtp2l1fhvbyWd8xw/+ucfyMMn4ENy69qZBCJ7d4YOxFhZsSEvH4yr9xWhunPbdYiL431s9OTk9Gk7cwRKuiO7creKJFvCDMgW4jYmxwTKjMUig7q5bOTghqOUSYwlNnoXs4+nobWI6bvFspNwMsaPhoIlsoCMnAUsOAiyjzQyD+2SxCvYrF542KTfE2F8BZXj3fnNgNz3HpxgL+7R3TwZus0Im418DmKt58cyUHgWvJDJBY/mCTNfNxPjSuKMB0vj8et6rU0mojCShXR71L1rktjdRhMbxtDxTmjogvQSm0cD2QonBBIKklbTo0zSJ8exlFiwmiwLpQ/iyh1zUP7IxdlPUSTymde/f0U19jZ3VrkbkW/RQqIhuQZgvEofYUddx9PaxwXX7WUQ3vJDA7uqS//Wbh+oaYQrNdIojl7JZ0GFh9T3tsMMJLF6QtQhNVZoLF6J0HGu/9eFmPqUS8LWbP+2Vymf0AL6T9SwU3SFU3e3YAE4ep5TmZ8ZgByp+8BEqJq0LH X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 06.06.25 10:27, lizhe.67@bytedance.com wrote: > On Fri, 6 Jun 2025 09:58:45 +0200, david@redhat.com wrote: > >> On 06.06.25 09:37, lizhe.67@bytedance.com wrote: >>> On Fri, 6 Jun 2025 10:37:42 +0800, david@redhat.com wrote: >>> >>>>> * Returns the number of collected folios. Return value is always >= 0. >>>>> */ >>>>> @@ -2324,16 +2349,12 @@ static void collect_longterm_unpinnable_folios( >>>>> struct list_head *movable_folio_list, >>>>> struct pages_or_folios *pofs) >>>>> { >>>>> - struct folio *prev_folio = NULL; >>>>> bool drain_allow = true; >>>>> - unsigned long i; >>>>> - >>>>> - for (i = 0; i < pofs->nr_entries; i++) { >>>>> - struct folio *folio = pofs_get_folio(pofs, i); >>>>> + struct folio *folio; >>>>> + long i = 0; >>>>> >>>>> - if (folio == prev_folio) >>>>> - continue; >>>>> - prev_folio = folio; >>>>> + for (folio = pofs_get_folio(pofs, i); folio; >>>>> + folio = pofs_next_folio(folio, pofs, &i)) { >>>> >>>> Nit: indentation is still off? >>> >>> In my editor (vim with ts=4), after applying this patch, the folio on >>> this line would be positioned directly below the folio on the previous >>> line. >> >> Documentation/process/coding-style.rst >> >> "Tabs are 8 characters" >> >> :) >> >> Good choice on using vim. This is what I have in my .vimrc regarding tabs >> >> set tabstop=8 >> set shiftwidth=8 >> set noexpandtab >> >> set smartindent >> set cindent > > I truly appreciate your correction and guidance. I sincerely apologize > for the formatting issue that I've caused. > > I noticed that Andrew has already integrated this patch into the mm-new > branch. mm-new is for new stuff, unless it's in mm-unstable -> mm-stable, it's still considered rather "experimental". > I'm just wondering if there's still a need for me to send out a > v5 patch. I'm happy to do whatever is necessary to ensure everything is > in order. Feel free to just send a simple fixup as reply to this patch. -- Cheers, David / dhildenb