Re: [PATCH v4] gup: optimize longterm pin_user_pages() for large folio

[David Hildenbrand <david@redhat.com>]

On 06.06.25 10:27, lizhe.67@bytedance.com wrote:
> On Fri, 6 Jun 2025 09:58:45 +0200, david@redhat.com wrote:
> 
>> On 06.06.25 09:37, lizhe.67@bytedance.com wrote:
>>> On Fri, 6 Jun 2025 10:37:42 +0800, david@redhat.com wrote:
>>>
>>>>>      * Returns the number of collected folios. Return value is always >= 0.
>>>>>      */
>>>>> @@ -2324,16 +2349,12 @@ static void collect_longterm_unpinnable_folios(
>>>>>     		struct list_head *movable_folio_list,
>>>>>     		struct pages_or_folios *pofs)
>>>>>     {
>>>>> -	struct folio *prev_folio = NULL;
>>>>>     	bool drain_allow = true;
>>>>> -	unsigned long i;
>>>>> -
>>>>> -	for (i = 0; i < pofs->nr_entries; i++) {
>>>>> -		struct folio *folio = pofs_get_folio(pofs, i);
>>>>> +	struct folio *folio;
>>>>> +	long i = 0;
>>>>>     
>>>>> -		if (folio == prev_folio)
>>>>> -			continue;
>>>>> -		prev_folio = folio;
>>>>> +	for (folio = pofs_get_folio(pofs, i); folio;
>>>>> +		 folio = pofs_next_folio(folio, pofs, &i)) {
>>>>
>>>> Nit: indentation is still off?
>>>
>>> In my editor (vim with ts=4), after applying this patch, the folio on
>>> this line would be positioned directly below the folio on the previous
>>> line.
>>
>> Documentation/process/coding-style.rst
>>
>> "Tabs are 8 characters"
>>
>> :)
>>
>> Good choice on using vim. This is what I have in my .vimrc regarding tabs
>>
>> set tabstop=8
>> set shiftwidth=8
>> set noexpandtab
>>
>> set smartindent
>> set cindent
> 
> I truly appreciate your correction and guidance. I sincerely apologize
> for the formatting issue that I've caused.
> 
> I noticed that Andrew has already integrated this patch into the mm-new
> branch.

mm-new is for new stuff, unless it's in mm-unstable -> mm-stable, it's 
still considered rather "experimental".

> I'm just wondering if there's still a need for me to send out a
> v5 patch. I'm happy to do whatever is necessary to ensure everything is
> in order.

Feel free to just send a simple fixup as reply to this patch.

-- 
Cheers,

David / dhildenb