From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48938C5ACB3 for ; Tue, 21 Nov 2023 10:03:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B46DF6B025F; Tue, 21 Nov 2023 05:03:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AF77E6B0280; Tue, 21 Nov 2023 05:03:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9BE3E6B03B3; Tue, 21 Nov 2023 05:03:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 89D796B025F for ; Tue, 21 Nov 2023 05:03:10 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 56119140B1C for ; Tue, 21 Nov 2023 10:03:10 +0000 (UTC) X-FDA: 81481523340.20.92364D6 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf03.hostedemail.com (Postfix) with ESMTP id F16F120008 for ; Tue, 21 Nov 2023 10:03:07 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=GtHeePB6; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=G+Blnnuc; spf=pass (imf03.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700560988; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=E6qoyWwClhugI9VZwP6suNYgWlewOSxpRzOpSziEEZA=; b=7/HOmxj78OcdsdlelmVmQ95Uj+H24kO+2fke5xDbm0R3oKLqYh1kJze/iNQE3lgrgmn33H I4JvqDlm115tpnkC4X7gDg44j9Cndzfcmx5E7tfYo3Jc4nN7B0PkZ2teUZOLo6tPHgRqtI OGWAH26om0UBMRY6J6D72s376FJOMO8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700560988; a=rsa-sha256; cv=none; b=7o7tmERFGOEjJjveG4JsdSrUX+J0xTKHBmkl0IP85w4HqFrfC8qnPuMMTTQYD4pI52T+DX 04kITksB7yvlgx37ZaMax9TxrDGGNybQnjX1/xOv/iWNW1h+tRj08lH8hwOr6tXTtR7tIH edFXDaP1/tckd0kRKnltKLDhI9RYFOk= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=GtHeePB6; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=G+Blnnuc; spf=pass (imf03.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 62A3D2189D; Tue, 21 Nov 2023 10:03:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1700560985; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=E6qoyWwClhugI9VZwP6suNYgWlewOSxpRzOpSziEEZA=; b=GtHeePB6BAvXazbBiyL1UhF0JAInm19ujuhcw5kw+/Qvx1GNMz4oUpUo1s/sVBfGLgA1It jJU9QZUXN+/Z9jVWwKQEnu/4Ys/ubA7LGk8g9CwJ7PIafqdZNpYWM4c384UA4EMWtpp1p1 MvztAt2ayDrSs7n/uaTn1dY1jxW/Lpg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1700560985; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=E6qoyWwClhugI9VZwP6suNYgWlewOSxpRzOpSziEEZA=; b=G+BlnnucPVfo1qGtny6AHeirbbuuvmiz0hwFHEYdV/WWHTgyQboeY9pZe0G/1jL52EAm+Y /Gm5nhaq2+vidiDQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 31A5E138E3; Tue, 21 Nov 2023 10:03:05 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id WSFiC1mAXGVgPAAAMHmgww (envelope-from ); Tue, 21 Nov 2023 10:03:05 +0000 Message-ID: Date: Tue, 21 Nov 2023 11:03:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH 4/4] mm/slab: move slab merge from slab_common.c to slub.c Content-Language: en-US To: Hyeonggon Yoo <42.hyeyoo@gmail.com>, sxwjean@me.com Cc: cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, roman.gushchin@linux.dev, corbet@lwn.net, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org References: <20231120091214.150502-1-sxwjean@me.com> <20231120091214.150502-5-sxwjean@me.com> From: Vlastimil Babka In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Stat-Signature: 3iiiwiohtects5379kpt4gtmcuaqbxf7 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: F16F120008 X-Rspam-User: X-HE-Tag: 1700560987-26000 X-HE-Meta: U2FsdGVkX19CbuvZPVzezOrDn18AD9HFLeQiOW+EK8to1hLW4BUKML2T/cAIVLEGW9dP6l+P1uv3oDncfctN2ZrPaM77nQdAa394e2dHaWXyB27WkSBs0Ies+Mxf65GuNQRKftWkow5QG4bWKYO9MAmaNg5vHsEv/0r9E87ZUnP+22bNx4DD24FEEQv8hiwoNxtQ56d6z0MfloPsh/VrtUlOoP8vTb3FM75anfGiLA+XpkLsmmurjwC1Kdgs+eNmXzKuFSFaP7TlyoIXwbW0P3zVeJkB7BDkMOJ46bnn2KXGqVnz8mjntDFHEThpd4eK2mpSUXLZ53cPLAumU4NYqDs+q1bclPqgnEGNnTW5uYQkcHMaMcEfV1VoiGUTe2kt+ovVGTmif6gl0fkbr515ni9uIm+UeLQtplUI9QfCPH3qkNyss67RzCRL6+P6d9EAXnuaxD4O68BBwv6F0p1iUY3rfwIVKDmQWFi2TMjhX8hifIt0PD+EtfAHldcpxYap0+T1Z24N1fC2w8yIYjXRY28nSF85TEjoDGSUNiOiNqwpG5wwGGTrESDyyR+xOQVlgeupA9YuSL6ZzQoqVqk3+e0H8QOc6ofJ03DKR3SPQEZC+lYF4xqta5SBA7nZad6pTfeViOGY3XvEcNLBsVpObcGXI3SmoCg6D8ZL8gx12MewBDNBYsXFs2aecbhGRXEpj9xXQ4tM5i2Vxlytx3Lcv6E+GcgLaW2u4kIbFJAdJJ/AwC67od4I+o6/LWCtRQC+N385hqAwfLX2e1+WnVIkQIf6W/n1h+kxMfGcMxhal0XszfYB58C0UD3S4fQ/zVpNsNAy/pJvIcdA1yd9tnaHQftqYOVQRnwakdIMJPCaKUVXQHMt3JmYc+xv5z8SscS6TJ6GjbC7MatrEKavJGMwdFX565zHYp/w2doSrbCYZOwoKvHo06WD0fiZ1/7bRn8iXGoZt7Mj7fzuY17F97O ArI+dpkL 1o0GcNA9okTK8Dzpo6OOwpCs9gPXIyHr8WloaXi4AxlQiiBtmVeWFT7z4V7D65L5WiBFupzMt1cNvHRgQR6ZPE5U5XVln8SXqmOGTgfaUJyVYIf4OHUo9pz2gupRV1auHcsHTlC4GXy6GTYvAZ3v7Q63upPZ/R25memrNCPSzsgECQgvp3zG1cvOrdK6PbOBTl8/XhERkATuLVwqHd3jDzpOW1eytDuvIhbyw5/zO3LK5tvbxZq4rRr+ZkHUwDpWN0dhzKUi7TyhECCRwKrX0YX/MI/iuFo2kyXTVpzM1AjxWcLE+EcY2QknvCb6R1ZkOtcZP6o7qsAZIoHnunHjJUYhoMjKJUBrySQ1uxzJlA/9rM8T9tfu1LhH0IlAVPb+CG0mxhWmLxdSyle0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11/21/23 09:54, Hyeonggon Yoo wrote: > On Mon, Nov 20, 2023 at 6:13 PM wrote: >> >> From: Xiongwei Song >> >> Since slab allocator has been removed. There is no users about slab >> merge except slub. This commit is almost to revert >> commit 423c929cbbec ("mm/slab_common: commonize slab merge logic"). >> >> Also change all prefix of slab merge related functions, variables and >> definitions from "slab/SLAB" to"slub/SLUB". > > Could you please elaborate a little bit? > I am not sure if I understand what the last two patches of this series > are useful for. > > - Why rename variable/function/macro names? > - Why move merge related functions from slab_common.c to slub.c? In my series I have moved functions that were part of allocation/free hot paths as there should be performance benefits if they are all in the same compilation unit. > (I mean merging slab_common.c and slub.c into single file might make sense > but why move only some parts of one into the other?) OTOH slub.c becomes quite big, so I think it would make sense to not merge mm/slab_common.c fully. The non-hot code that's handling e.g. the caches creation and management, such as what this patch is moving, could certainly stay away from mm/slub.c. We could just pick a more descriptive name for slab_common.c. I'd even investigate if more parts of slub.c could be split out (to a new file/files) without compromising the hot paths, i.e. sysfs, debugging etc.