From: Vlastimil Babka <vbabka@suse.cz>
To: Hyeonggon Yoo <42.hyeyoo@gmail.com>, sxwjean@me.com
Cc: cl@linux.com, penberg@kernel.org, rientjes@google.com,
iamjoonsoo.kim@lge.com, roman.gushchin@linux.dev, corbet@lwn.net,
linux-mm@kvack.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] mm/slab: move slab merge from slab_common.c to slub.c
Date: Tue, 21 Nov 2023 11:03:04 +0100 [thread overview]
Message-ID: <a6472546-b169-a88c-66a5-972d54edcd76@suse.cz> (raw)
In-Reply-To: <CAB=+i9RFxqFg2jz3ULbmmswqp0K7SK8O9Uv1=wpUZMQUtSGB1Q@mail.gmail.com>
On 11/21/23 09:54, Hyeonggon Yoo wrote:
> On Mon, Nov 20, 2023 at 6:13 PM <sxwjean@me.com> wrote:
>>
>> From: Xiongwei Song <xiongwei.song@windriver.com>
>>
>> Since slab allocator has been removed. There is no users about slab
>> merge except slub. This commit is almost to revert
>> commit 423c929cbbec ("mm/slab_common: commonize slab merge logic").
>>
>> Also change all prefix of slab merge related functions, variables and
>> definitions from "slab/SLAB" to"slub/SLUB".
>
> Could you please elaborate a little bit?
> I am not sure if I understand what the last two patches of this series
> are useful for.
>
> - Why rename variable/function/macro names?
> - Why move merge related functions from slab_common.c to slub.c?
In my series I have moved functions that were part of allocation/free hot
paths as there should be performance benefits if they are all in the same
compilation unit.
> (I mean merging slab_common.c and slub.c into single file might make sense
> but why move only some parts of one into the other?)
OTOH slub.c becomes quite big, so I think it would make sense to not merge
mm/slab_common.c fully. The non-hot code that's handling e.g. the caches
creation and management, such as what this patch is moving, could certainly
stay away from mm/slub.c. We could just pick a more descriptive name for
slab_common.c.
I'd even investigate if more parts of slub.c could be split out (to a new
file/files) without compromising the hot paths, i.e. sysfs, debugging etc.
next prev parent reply other threads:[~2023-11-21 10:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-20 9:12 [PATCH 0/4] supplement of slab removal sxwjean
2023-11-20 9:12 ` [PATCH 1/4] Documentation: kernel-parameters: remove slab_max_order sxwjean
2023-11-21 8:30 ` Hyeonggon Yoo
2023-11-22 5:19 ` Song, Xiongwei
2023-11-20 9:12 ` [PATCH 2/4] mm/slab: remove slab_nomrege and slab_merge sxwjean
2023-11-21 8:44 ` Hyeonggon Yoo
2023-11-22 5:27 ` Song, Xiongwei
2023-11-22 5:59 ` Hyeonggon Yoo
2023-11-20 9:12 ` [PATCH 3/4] mm/slab: make calculate_alignment() public sxwjean
2023-11-20 9:12 ` [PATCH 4/4] mm/slab: move slab merge from slab_common.c to slub.c sxwjean
2023-11-21 8:54 ` Hyeonggon Yoo
2023-11-21 10:03 ` Vlastimil Babka [this message]
2023-11-22 5:29 ` Song, Xiongwei
2023-11-21 9:01 ` Hyeonggon Yoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6472546-b169-a88c-66a5-972d54edcd76@suse.cz \
--to=vbabka@suse.cz \
--cc=42.hyeyoo@gmail.com \
--cc=cl@linux.com \
--cc=corbet@lwn.net \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=sxwjean@me.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox