From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FAAAC77B73 for ; Wed, 31 May 2023 12:53:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C4C4A8E0008; Wed, 31 May 2023 08:52:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BFC698E0002; Wed, 31 May 2023 08:52:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AEBAA8E0008; Wed, 31 May 2023 08:52:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 9B8DA8E0002 for ; Wed, 31 May 2023 08:52:59 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 71DF5C012E for ; Wed, 31 May 2023 12:52:59 +0000 (UTC) X-FDA: 80850540078.11.9BFEA6F Received: from out-57.mta1.migadu.com (out-57.mta1.migadu.com [95.215.58.57]) by imf05.hostedemail.com (Postfix) with ESMTP id 6536210001B for ; Wed, 31 May 2023 12:52:57 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=dw0p9yEq; spf=pass (imf05.hostedemail.com: domain of qi.zheng@linux.dev designates 95.215.58.57 as permitted sender) smtp.mailfrom=qi.zheng@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685537577; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2ShbrEgfZy4By4UohTrcklSg54xQgs+3EWdpTAp00z8=; b=XTPfFuePh/o/Uw2KavnR3umcy0JzgV8IBZJvqIcHO1ousLC79jxt13ldueHghofu5+T3WB Gh7liSN4D9F4ZPMq3PY+HXRRSIZX0ZyzmrI52Y3PLWdSVzFQqyE8nONoUbRXk80y0Ojk+x GQwTY5d94VhuKTEyXWu5m90Q6h14/iA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685537577; a=rsa-sha256; cv=none; b=xY/Y5TCharviIcMqja6PJ5e2WoANsmgz/SzAznJF2wZmnel13851gH27yc3dGNpkvBsth0 UyY8nVevyFpkL96D5Nk+knFZiKuFLliigLcTHsVeLgtv6Ph5f5KQu8yBfa7N4Ykxlfp7MH zkb9IsNGXjWqdNj4ML0sv9+R0d1HpZQ= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=dw0p9yEq; spf=pass (imf05.hostedemail.com: domain of qi.zheng@linux.dev designates 95.215.58.57 as permitted sender) smtp.mailfrom=qi.zheng@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1685537575; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2ShbrEgfZy4By4UohTrcklSg54xQgs+3EWdpTAp00z8=; b=dw0p9yEqwoJ68IFZtmHffnZ4wp5USwQvnVqn94n4syCGENhdaRtT6IT3dXPhuhB7GeFZby EAm7yyWAoZ/WouPfjlyTwCg8ijHHlTofAXILbmW8dr+3eq6i1kiBqjx+Bf12QjXhBPbBb7 iUpHJKOu/PagvVxpglm0N+Kntq3mIHM= Date: Wed, 31 May 2023 20:52:46 +0800 MIME-Version: 1.0 Subject: Re: [PATCH 1/8] mm: vmscan: move shrinker_debugfs_remove() before synchronize_srcu() Content-Language: en-US To: Christian Brauner Cc: akpm@linux-foundation.org, tkhai@ya.ru, roman.gushchin@linux.dev, vbabka@suse.cz, viro@zeniv.linux.org.uk, djwong@kernel.org, hughd@google.com, paulmck@kernel.org, muchun.song@linux.dev, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org, Qi Zheng References: <20230531095742.2480623-1-qi.zheng@linux.dev> <20230531095742.2480623-2-qi.zheng@linux.dev> <20230531-notlage-ankommen-93022623b74b@brauner> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Qi Zheng In-Reply-To: <20230531-notlage-ankommen-93022623b74b@brauner> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 6536210001B X-Rspam-User: X-Stat-Signature: f1be1ekcpsq3afjjeami3wdgmjibo1bq X-Rspamd-Server: rspam03 X-HE-Tag: 1685537577-391045 X-HE-Meta: U2FsdGVkX1/FIy9f1aYZ3udb6Ryn67pTV4eLZKcfgMOVCSe+NgnZBj7RR7R9/DGEIgds4IHIHHw2wbcamOtkzMGvseW2hDYxxsNXkIeTPziPZpmtDWfwwLDGbxO34SVVkCnoEj+OYjTsayPKtSCYAU8is+wkivWFKbSnFzBDCISkm4mwOeqKZFfUVypvQn869w/KDkrh+VUFj/8rhr37d+j+Zbgvom+uhPzdQP5eOrVCHDXfBEuD1bSd+mis5TOzETwtG/VmDMmjvL9cZ0nCruHYvElibYLjh/W+gJFDLNd48/aNC6gQWchFEnlh80dcbRelpymnoUfCVgP+14dD82VDVwUeWw1NvQlOyFxoC4KOmJG9IrT5ZEJgDUnwrB5sOmswxY/8z6+7AsmrA1RmZRQdH2U+tlP2ynW0SncidReidCDcM2sGJkkdqK5r9slouqcA6EAtzuMGbbdWJwum4OrzocLviv0NkkSGpDEXDlCj20vZvKOM/HHuYEugCWM9efvNqQ0I3iNCyQl0cBtrDtXmvARCsFTOIxb/nrybggc2rrxuuL1YLV5ufEiB09Pd+RKiVV86+UkqWp3SaqhIerRjKW7ZHk0wpyQOA1qwuV7tN7h6n3/8PfxuAV4u5whTcIXkLEIiXf6tcii54YkdpRw5yvj66Sj9SJpb2tEZ8nvMlEqR6bDYVEt+ZVUTNoW4QQN9iqZuqI4UQ0wOEwt9/uydgn0bvXcWOxykmixTK+Y3KZ9OgyfQnyB6VzpSj8d1g7Xo/FP6OdBJr4XWamg/YUjHFXaguzWyPdGQ5Og/4tqd+xHZ0xKqIHMiGWQ7lbx+2TqLga+QCOvLMJVUDZDwA5eAh7Okuv4i18+ct5mmnzHa9HZEZq7KHJ2xG8zvNfi/zH9E1898sMKY3+KFCTSMopSWqqql+PGzCFEb7YrPuKcpOOThkJz8MJAlf5D31QH40FNQnEJAwa93xhwPBy5 W9KCtluH R53cP9UvLM9gy2ROEl12TkqGVFCxeWfmUgG6VN7K4Ui1jJKHJ/c6ig4+IOrzTM4Ua5IksflPcqhKCMO4Zfxks9Z9brMdueg7keD8YAwR3NBgvdBzkEOxF/vqSVkUoaXguKyupZ4O1H8cjsuh8U9yY/CTs2YPS7tcumxkkI1YGbBHKWP9tH5qQBnKn/yGgqnSdUORV X-Bogosity: Ham, tests=bogofilter, spamicity=0.000093, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/5/31 18:49, Christian Brauner wrote: > On Wed, May 31, 2023 at 09:57:35AM +0000, Qi Zheng wrote: >> From: Qi Zheng >> >> The debugfs_remove_recursive() will wait for debugfs_file_put() >> to return, so there is no need to put it after synchronize_srcu() >> to wait for the rcu read-side critical section to exit. >> >> Just move it before synchronize_srcu(), which is also convenient >> to put the heavy synchronize_srcu() in the delayed work later. >> >> Signed-off-by: Qi Zheng >> --- > > Afaict, should be a patch independent of this series. OK, will resend as an independent patch. Thanks, Qi