From: Khalid Aziz <khalid.aziz@oracle.com>
To: akpm@linux-foundation.org, willy@infradead.org,
longpeng2@huawei.com, arnd@arndb.de, dave.hansen@linux.intel.com,
david@redhat.com, rppt@kernel.org, surenb@google.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Cc: Khalid Aziz <khalid.aziz@oracle.com>
Subject: [RFC PATCH 5/6] mm: Add locking to msharefs syscalls
Date: Tue, 18 Jan 2022 14:19:17 -0700 [thread overview]
Message-ID: <a610631481f94b0bf3d2bf57523fe8dc80700290.1642526745.git.khalid.aziz@oracle.com> (raw)
In-Reply-To: <cover.1642526745.git.khalid.aziz@oracle.com>
Lock the root inode for msharefs when creating a new file or deleting
an existing one to avoid races. mshare syscalls are low frequency
operations, so locking the root inode is reasonable.
Signed-off-by: Khalid Aziz <khalid.aziz@oracle.com>
---
mm/mshare.c | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/mm/mshare.c b/mm/mshare.c
index 8273136363cc..adfd5a280e5b 100644
--- a/mm/mshare.c
+++ b/mm/mshare.c
@@ -194,11 +194,12 @@ SYSCALL_DEFINE5(mshare, const char __user *, name, unsigned long, addr,
err = msharefs_d_hash(msharefs_sb->s_root, &namestr);
if (err)
goto err_out;
+ inode_lock(d_inode(msharefs_sb->s_root));
dentry = d_lookup(msharefs_sb->s_root, &namestr);
if (dentry && (oflag & (O_EXCL|O_CREAT))) {
err = -EEXIST;
dput(dentry);
- goto err_out;
+ goto err_unlock_inode;
}
if (dentry) {
@@ -231,6 +232,7 @@ SYSCALL_DEFINE5(mshare, const char __user *, name, unsigned long, addr,
goto err_relinfo;
}
+ inode_unlock(d_inode(msharefs_sb->s_root));
putname(fname);
return 0;
@@ -238,6 +240,8 @@ SYSCALL_DEFINE5(mshare, const char __user *, name, unsigned long, addr,
kfree(info);
err_relmm:
mmput(mm);
+err_unlock_inode:
+ inode_unlock(d_inode(msharefs_sb->s_root));
err_out:
putname(fname);
return err;
@@ -263,10 +267,11 @@ SYSCALL_DEFINE1(mshare_unlink, const char *, name)
err = msharefs_d_hash(msharefs_sb->s_root, &namestr);
if (err)
goto err_out;
+ inode_lock(d_inode(msharefs_sb->s_root));
dentry = d_lookup(msharefs_sb->s_root, &namestr);
if (dentry == NULL) {
err = -EINVAL;
- goto err_out;
+ goto err_unlock_inode;
}
inode = d_inode(dentry);
@@ -289,11 +294,14 @@ SYSCALL_DEFINE1(mshare_unlink, const char *, name)
dput(dentry);
}
+ inode_unlock(d_inode(msharefs_sb->s_root));
putname(fname);
return 0;
err_dput:
dput(dentry);
+err_unlock_inode:
+ inode_unlock(d_inode(msharefs_sb->s_root));
err_out:
putname(fname);
return err;
--
2.32.0
next prev parent reply other threads:[~2022-01-18 21:20 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-18 21:19 [RFC PATCH 0/6] Add support for shared PTEs across processes Khalid Aziz
2022-01-18 21:19 ` [RFC PATCH 1/6] mm: Add new system calls mshare, mshare_unlink Khalid Aziz
2022-01-18 21:19 ` [RFC PATCH 2/6] mm: Add msharefs filesystem Khalid Aziz
2022-01-18 21:19 ` [RFC PATCH 3/6] mm: Add read for msharefs Khalid Aziz
2022-01-18 21:19 ` [RFC PATCH 4/6] mm: implement mshare_unlink syscall Khalid Aziz
2022-01-18 21:19 ` Khalid Aziz [this message]
2022-01-18 21:19 ` [RFC PATCH 6/6] mm: Add basic page table sharing using mshare Khalid Aziz
2022-01-18 21:41 ` [RFC PATCH 0/6] Add support for shared PTEs across processes Dave Hansen
2022-01-18 21:46 ` Matthew Wilcox
2022-01-18 22:47 ` Khalid Aziz
2022-01-18 22:06 ` Dave Hansen
2022-01-18 22:52 ` Khalid Aziz
2022-01-19 11:38 ` Mark Hemment
2022-01-19 17:02 ` Khalid Aziz
2022-01-20 12:49 ` Mark Hemment
2022-01-20 19:15 ` Khalid Aziz
2022-01-24 15:15 ` Mark Hemment
2022-01-24 15:27 ` Matthew Wilcox
2022-01-24 22:20 ` Khalid Aziz
2022-01-21 1:08 ` Barry Song
2022-01-21 2:13 ` Matthew Wilcox
2022-01-21 7:35 ` Barry Song
2022-01-21 14:47 ` Matthew Wilcox
2022-01-21 16:41 ` Khalid Aziz
2022-01-22 1:39 ` Longpeng (Mike, Cloud Infrastructure Service Product Dept.)
2022-01-22 1:41 ` Matthew Wilcox
2022-01-22 10:18 ` Thomas Schoebel-Theuer
2022-01-22 16:09 ` Matthew Wilcox
2022-01-22 11:31 ` Mike Rapoport
2022-01-22 18:29 ` Andy Lutomirski
2022-01-24 18:48 ` Khalid Aziz
2022-01-24 19:45 ` Andy Lutomirski
2022-01-24 22:30 ` Khalid Aziz
2022-01-24 23:16 ` Andy Lutomirski
2022-01-24 23:44 ` Khalid Aziz
2022-01-25 11:42 ` Kirill A. Shutemov
2022-01-25 12:09 ` William Kucharski
2022-01-25 13:18 ` David Hildenbrand
2022-01-25 14:01 ` Kirill A. Shutemov
2022-01-25 13:23 ` Matthew Wilcox
2022-01-25 13:59 ` Kirill A. Shutemov
2022-01-25 14:09 ` Matthew Wilcox
2022-01-25 18:57 ` Kirill A. Shutemov
2022-01-25 18:59 ` Matthew Wilcox
2022-01-26 4:04 ` Matthew Wilcox
2022-01-26 10:16 ` David Hildenbrand
2022-01-26 13:38 ` Matthew Wilcox
2022-01-26 13:55 ` David Hildenbrand
2022-01-26 14:12 ` Matthew Wilcox
2022-01-26 14:30 ` David Hildenbrand
2022-01-26 14:12 ` Mike Rapoport
2022-01-26 13:42 ` Kirill A. Shutemov
2022-01-26 14:18 ` Mike Rapoport
2022-01-26 17:33 ` Khalid Aziz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a610631481f94b0bf3d2bf57523fe8dc80700290.1642526745.git.khalid.aziz@oracle.com \
--to=khalid.aziz@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=dave.hansen@linux.intel.com \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=longpeng2@huawei.com \
--cc=rppt@kernel.org \
--cc=surenb@google.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox