From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0523CC433E0 for ; Tue, 9 Jun 2020 09:15:53 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C2744207ED for ; Tue, 9 Jun 2020 09:15:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C2744207ED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5542C6B0006; Tue, 9 Jun 2020 05:15:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 505286B0007; Tue, 9 Jun 2020 05:15:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 41B9D6B0008; Tue, 9 Jun 2020 05:15:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0200.hostedemail.com [216.40.44.200]) by kanga.kvack.org (Postfix) with ESMTP id 271AF6B0006 for ; Tue, 9 Jun 2020 05:15:52 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id CDCCA80134F1 for ; Tue, 9 Jun 2020 09:15:51 +0000 (UTC) X-FDA: 76909116102.12.boat62_1c134a526dc1 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin12.hostedemail.com (Postfix) with ESMTP id 9003B18017189 for ; Tue, 9 Jun 2020 09:15:51 +0000 (UTC) X-HE-Tag: boat62_1c134a526dc1 X-Filterd-Recvd-Size: 1842 Received: from out30-130.freemail.mail.aliyun.com (out30-130.freemail.mail.aliyun.com [115.124.30.130]) by imf30.hostedemail.com (Postfix) with ESMTP for ; Tue, 9 Jun 2020 09:15:49 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R171e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e07484;MF=alex.shi@linux.alibaba.com;NM=1;PH=DS;RN=10;SR=0;TI=SMTPD_---0U.3kARo_1591694145; Received: from IT-FVFX43SYHV2H.local(mailfrom:alex.shi@linux.alibaba.com fp:SMTPD_---0U.3kARo_1591694145) by smtp.aliyun-inc.com(127.0.0.1); Tue, 09 Jun 2020 17:15:45 +0800 Subject: Re: [patch 113/131] mm: balance LRU lists based on relative thrashing To: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, hannes@cmpxchg.org, iamjoonsoo.kim@lge.com, linux-mm@kvack.org, mhocko@suse.com, minchan@kernel.org, mm-commits@vger.kernel.org, riel@surriel.com, torvalds@linux-foundation.org References: <20200603230303.kSkT62Lb5%akpm@linux-foundation.org> From: Alex Shi Message-ID: Date: Tue, 9 Jun 2020 17:15:33 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200603230303.kSkT62Lb5%akpm@linux-foundation.org> Content-Type: text/plain; charset=gbk X-Rspamd-Queue-Id: 9003B18017189 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000548, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: =D4=DA 2020/6/4 =C9=CF=CE=E77:03, Andrew Morton =D0=B4=B5=C0: > =20 > + /* XXX: Move to lru_cache_add() when it supports new vs putback */ Hi Hannes, Sorry for a bit lost, would you like to explain a bit more of your idea h= ere? > + spin_lock_irq(&page_pgdat(page)->lru_lock); > + lru_note_cost(page); > + spin_unlock_irq(&page_pgdat(page)->lru_lock); > + What could we see here w/o the lru_lock? Thanks Alex