From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED582C4345F for ; Fri, 19 Apr 2024 12:58:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 27C116B0085; Fri, 19 Apr 2024 08:58:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 22C8F6B0087; Fri, 19 Apr 2024 08:58:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0CDE56B0088; Fri, 19 Apr 2024 08:58:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id E42C26B0085 for ; Fri, 19 Apr 2024 08:58:54 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 996DFA0101 for ; Fri, 19 Apr 2024 12:58:54 +0000 (UTC) X-FDA: 82026286188.06.03D89BB Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf01.hostedemail.com (Postfix) with ESMTP id 6A7E94000E for ; Fri, 19 Apr 2024 12:58:51 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FInnKAAT; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713531531; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Z2d3iqx05Gqxh4rph9K0FnqpHu231qlz9mgP4t0RVZk=; b=K7EXW/eOwgTfU24xtqtChGbT8NE1+2b1L5hsdLEViw3gVSVqSuJ3ZOEJ4+GrdS/I+VtjKT 8RZwZ/cIJT7ND3mWNDZMlFpaZUVYoxIFKS+COoPpZ4VuMpilDWus4Y39OrmupyguMB+LuT sk450IU83BhL22K5HnLqiO6i+poSqyM= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FInnKAAT; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713531531; a=rsa-sha256; cv=none; b=Jc3v0Syiy4CFXH9afgpU1pJ9QUf6QpDXZ4aYsfQC32Vt9NgOAYbarFzmrsVyDladYVEXc0 WpWlLnjOlCORN4ewJmVbn11TkKOmHQ46n6IjkA1mTHPhQyX4AvTV4VUXIGThWmB2JsnRqD hBf+JohzSG2jsBEbB+00LQu9v6cYau4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713531530; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Z2d3iqx05Gqxh4rph9K0FnqpHu231qlz9mgP4t0RVZk=; b=FInnKAATgrKeX3KnAhJ09x32spjY3WfHBvbUIqfuLIIFmeaEEZPZx6qKWQU8XwmSR7gF9L duc4HIA+DHllz4Aku5yJBddwOmIHobhI/rSulvq816iidsCcK9YLtlUxaLLJy4OX1fxm39 URp9l/chdqmCZ/meMbci/uv35HfXjRc= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-50-04CZh1zpMMS86zsJbQP5bA-1; Fri, 19 Apr 2024 08:58:47 -0400 X-MC-Unique: 04CZh1zpMMS86zsJbQP5bA-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4183d08093bso11641455e9.1 for ; Fri, 19 Apr 2024 05:58:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713531526; x=1714136326; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=Z2d3iqx05Gqxh4rph9K0FnqpHu231qlz9mgP4t0RVZk=; b=Ze0K4yMNTILmmFi78dtf0+qdbkEbPEif1Zg0UVoVuFVimZSFA2d6FjDVLSAxhKG5sh MrhkrtKrCpYVy54VmjKkFSJ1FhoPfThkFUae6brq9RigFkjo3SicP80H/iHMdCYPrzH4 xNByU31VSGPWtZsn9TxHXxezfQik/cCyvc0lpDAGMBrsj2NVKWzV5jyjUU9IsluKPv9p bsSgl2Y4wCYRVEYM0qnEgv1WDh+OGcTaE5YPF4PZpQn5v9ryyD8WcD3TJq7VUx7T4lVJ 9+mlAcKtpb2Awi6oJMWlmxWqKZA6FvvDB1L8DoSLp4T56KIMmnnVqlMtG7mIwbmK2YOS HQJA== X-Forwarded-Encrypted: i=1; AJvYcCUmUTxBugB6iixJvd3xSLX1Rohm7IxdisRLU2lKlu03L5vobviVOgaLRG3NMKGUmFB63k8ZYFsHeliFW/c9Lva9+Bc= X-Gm-Message-State: AOJu0YwaunUw/dt6lTAtgt0Zpop3YOYMrmhfzr5uVPsxLil+4MOUaps3 8S/ljQ8lkPOKbdx2fcljPq6ih8aN3HIWDHjmbEZu9zleIiwXp2megJc10DLaSf5fwz9C93pCGXT GpR8DrBbJKQ67rGV2aKwPyvqz5KbOmlXJqF+pFGJ6poXnzNqP X-Received: by 2002:a5d:6a46:0:b0:346:b581:ff57 with SMTP id t6-20020a5d6a46000000b00346b581ff57mr1650314wrw.68.1713531526322; Fri, 19 Apr 2024 05:58:46 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH7m8NTVqsbUldIBxMAx8E1NGImyAQjyh5UpwPAdGx0OoeBVIRTXxysKxRh8PdQ61Jjn+Ewpg== X-Received: by 2002:a5d:6a46:0:b0:346:b581:ff57 with SMTP id t6-20020a5d6a46000000b00346b581ff57mr1650273wrw.68.1713531525824; Fri, 19 Apr 2024 05:58:45 -0700 (PDT) Received: from ?IPV6:2003:cb:c716:f300:c9f0:f643:6aa2:16? (p200300cbc716f300c9f0f6436aa20016.dip0.t-ipconnect.de. [2003:cb:c716:f300:c9f0:f643:6aa2:16]) by smtp.gmail.com with ESMTPSA id w15-20020a5d544f000000b00349c63eb484sm4363099wrv.23.2024.04.19.05.58.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Apr 2024 05:58:45 -0700 (PDT) Message-ID: Date: Fri, 19 Apr 2024 14:58:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v13 04/26] KVM: guest_memfd: Fix PTR_ERR() handling in __kvm_gmem_get_pfn() To: Michael Roth , kvm@vger.kernel.org Cc: linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, dovmurik@linux.ibm.com, tobin@ibm.com, bp@alien8.de, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, jarkko@kernel.org, ashish.kalra@amd.com, nikunj.dadhania@amd.com, pankaj.gupta@amd.com, liam.merwick@oracle.com References: <20240418194133.1452059-1-michael.roth@amd.com> <20240418194133.1452059-5-michael.roth@amd.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240418194133.1452059-5-michael.roth@amd.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 6A7E94000E X-Stat-Signature: cqhfi4kktf1babkpthhpmuu4nyudfg8f X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1713531531-652258 X-HE-Meta: U2FsdGVkX1+3P7+TDFDcWyy7cI09bYfKOApM8TF0dKtcxua4zFZ0xpYlC7zQOrFu+AqUmeataALhPnLDXDPiIuM0xR65iGbBAJaus+kMSwP9oV/GNecejiYa4iz+1JscQrtX0hknu7i1ReW6pX3qDAFNyG22nA9Z0dvtPeHKWvgW+Xs2HBAurvWD4E4MBjlkRqqxcxdFEC93jygklbkTV1NdNu/Yt3z8BHFjdgknF4KlA42kXyfutD0plcW9Ip8z6lg6P1+KiarQRJI7AM4Hj7VUChUrv72fOgjB1AY8G+AUVJ0U4SwIijjRy15yeY2QC0gUwQ5tfU/ZvNaado3sttzIlPh+PjFYXidLTpF6lkzuGkmtDX6MkNo7DSJsRYzAdmZiDVD0/512Z3PWkxX3C3KnnAFCEKw7DXXtLi7P5tWp5vgkwvR6h1dn3oBtOd1O5KC9aOI6ue79PMvfHKjyiVIw9JJE77GPD/YNVhPk3dajw6JRqnCxiaBghLnTjLndNRZQAWcMHPRWGpONpQlRBWARLC5FUpqIws/fW+zxrkoBazqSMO6CMoqRSWbfcM+70lXmSiHMWBmtkH6D2t/8ui2jsUAdIInU7Rl6HtmQeF4d9yDHB8OqHFno3ERoVDMiM9/K8w4PHnjHkcuB5fPqDhrPYBY073H2Bp3kKleEPWuGN5LkhxLlVMrIjwM4IqmYNlkTOKfk9ybRw97DHIB+yE6hHvi2VHWaVypFs77b3RMjWpT/uLnC/bRfKIf/oyVURz75sEkiBs4ZPVWY9U7ADSBqpTUSizf5KsMBQHgYVaIaMZb5PZrNgNVInoDHe0GK/+7GvibryVoIs7QvewKFEXPfx1BuNqsplvdmI02RyiKdcJEyhNVYocZMjRznGrF7cAUj/zoG24wd5bShGUuTHmpW1z2L6uhwISfO38TibzOKArpC1+ojWt1unpNNk/GNQV35J0TdXhtle/EgH9x tFZtSfXK xiMtQ47Hv+f7fOzKgGtTBXJiTrEvm1jnvRHLjokFBYNAA+1H3jOcmFJPKcMj72OEISm3OOiib8qYHLy1XxP0FC5zHYiBL8iM8jyAgprnFacL9CLyMQTAdPWidEfCh6ZOwjyEfn9zhmLFotgjiiVZiiKSGqqEM2RF4/nsiCXyMKd+e8iZ5/9hKhEaRh9jS1V2sMq1NgTNGKrIvXlBjQIFF/nuqf1plL/KYaHdSX9pr9UVzAT8XhA90sm9u0YL3nRPy3Z4Mh7ai+J4rAomIyRQz12jxdSfzoBT8jcNRUuJLPKw+60lcIZcdlXMLBNfmLc//e/G08LIZD9c5SK14DfvGgCapLq4O7ZZPGPnd+1pn8qiLO5z87wXqAvXns76jrge6PVvEaHLqjX/ZsSNtwBDewrmjaDxiS+VuM/3RsVKNvPqlWCYLxrCjEqeFac8g+JRXyNVUyFsIyZStkongiuhwgy1grYvAOQwwDh9eTz/FGDBuak/QdF9P5cQnNA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 18.04.24 21:41, Michael Roth wrote: > kvm_gmem_get_folio() may return a PTR_ERR() rather than just NULL. In > particular, for cases where EEXISTS is returned when FGP_CREAT_ONLY > flag is used. Handle this properly in __kvm_gmem_get_pfn(). > > Signed-off-by: Michael Roth > --- > virt/kvm/guest_memfd.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/virt/kvm/guest_memfd.c b/virt/kvm/guest_memfd.c > index ccf22e44f387..9d7c6a70c547 100644 > --- a/virt/kvm/guest_memfd.c > +++ b/virt/kvm/guest_memfd.c > @@ -580,8 +580,8 @@ static int __kvm_gmem_get_pfn(struct file *file, struct kvm_memory_slot *slot, > } > > folio = kvm_gmem_get_folio(file_inode(file), index, prepare); > - if (!folio) > - return -ENOMEM; > + if (IS_ERR_OR_NULL(folio)) > + return folio ? PTR_ERR(folio) : -ENOMEM; Will it even return NULL? Staring at other filemap_grab_folio() users, they all check for IS_ERR(). > > if (folio_test_hwpoison(folio)) { > r = -EHWPOISON; Do we have a Fixes: tag? -- Cheers, David / dhildenb